Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-28 Thread Tobias Ellinghaus
Am Donnerstag, 26. Mai 2016, 09:00:00 schrieb Matthias Bodenbinder:
> Am 24.05.2016 um 07:18 schrieb Matthias Bodenbinder:
> > I will do more testing the next days.
> 
> After a few more tests it is clear that I can not change the basecurve
> preset "test" after it is created. This is true not only for the format
> value, but also for the filter when it should be applied. The preset is
> writeprotected.
> 
> This bevahour is different from any other module presets, like for the
> sharpen module for example. I can edit those presets just fine. Only
> basecurve presets are affected.

We have some ideas what might be going on. Please file a bug report, I will add 
my thoughts there. Fixing it won't be that easy, it's a limitation of how we 
handle presets internally. But that doesn't mean it's not a bug of course.

> Matthias

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-23 Thread Tobias Ellinghaus
Am Freitag, 20. Mai 2016, 18:14:30 schrieb Matthias Bodenbinder:
> Am 20.05.2016 um 12:10 schrieb Tobias Ellinghaus:
> > echo 'select name, format, autoapply from presets where
> > operation="basecurve";' | sqlite3 ~/.config/darktable/library.db

[presets]

That doesn't look suspicious.

Just to reiterate:
 - Which of those presets gets applied?

 - When editing that preset, is any change done to the auto-apply settings 
remembered? Maybe even try restarting darktable (that shouldn't matter, but 
who knows what edge cases there are). Note that we are talking about the 
settings for auto-apply, NOT for the images to show the preset for!

- What version of darktable is this exactly? Please show the output of
 darktable --version

Tobias

PS: Is anyone else having similar problems?

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-20 Thread Tobias Ellinghaus
Am Freitag, 20. Mai 2016, 07:32:41 schrieb Matthias Bodenbinder:
> Am 20.05.2016 um 07:14 schrieb Matthias Bodenbinder:
> > Am 19.05.2016 um 19:30 schrieb Matthias Bodenbinder:
> >> Am 19.05.2016 um 19:03 schrieb Tobias Ellinghaus:
> >>> and finally those where format is "7", i.e., every image:
> > meine Canon 6D|basecurve|7
> > Eizo FS2331|colorout|7
> > Fuji X100|colorin|7
> > Schärfen aus|sharpen|7
> > Sony DSC-RX100M3|lens|7
> > Reinhards Sony RX100M3|basecurve|7
> > Fuji X100|lens|7
> > stark|rawdenoise|7

Could you please show the output of

   echo 'select name, format, autoapply from presets where 
operation="basecurve";' | sqlite3 ~/.config/darktable/library.db

I was unable to reproduce your problem locally, maybe there is something else 
going on.

[...]

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-20 Thread Tobias Ellinghaus
Am Freitag, 20. Mai 2016, 07:32:41 schrieb Matthias Bodenbinder:
> Am 20.05.2016 um 07:14 schrieb Matthias Bodenbinder:
> > Am 19.05.2016 um 19:30 schrieb Matthias Bodenbinder:
> >> Am 19.05.2016 um 19:03 schrieb Tobias Ellinghaus:
> >>> and finally those where format is "7", i.e., every image:
> > meine Canon 6D|basecurve|7
> > Eizo FS2331|colorout|7
> > Fuji X100|colorin|7
> > Schärfen aus|sharpen|7
> > Sony DSC-RX100M3|lens|7
> > Reinhards Sony RX100M3|basecurve|7
> > Fuji X100|lens|7
> > stark|rawdenoise|7
> >>> 
> >>> You should go through the list of presets in the preferences and check
> >>> those.>> 
> >> Interesting. But how come? I am only using the GUI. No manipulation of
> >> the db with sqllite or such.
> >> 
> >> I tested with the basecurve preset "meine Canon 6D". Only "RAW" is
> >> checked as Format but still your sql command shows:
> >> 
> >> meine Canon 6D|basecurve|7
> >> 
> >> I can make any change to the Format checkboxes including unchecking
> >> everything the settings are not change. Next time I start DT only "RAW"
> >> is checked and your sql command gives the same result:
> >> 
> >> "|basecurve|7
> >> 
> >> What is happening here?
> >> 
> >> Matthias
> > 
> > I can not change the format value with the GUI. I did edit the "meine
> > Canon 6D" preset with sqlitebrowser to value "2". That helped to prevent
> > that the preset ist applied to PNG files. But then, when I change the
> > format checkboxes in the GUI, example: checking all three boxes "normale
> > Bilder", "RAW" and "HDR", the value stays at "2". That looks like a bug
> > to me.

Yes, seems so. We will investigate, thank you for reporting it. I fear that 
all those features us developers don't use ourselves have more bugs than the 
rest. :-(

> > Matthias

[...]

> When I check with , the
> preset "meine Canon 6D" is NOT listed.

Because your's is not writeprotected. Those are just the ones shipped by 
darktable. You can't edit them and they get re-created on every startup so we 
are easily able to change them in the future.

> Matthias

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-19 Thread Tobias Ellinghaus
Am Donnerstag, 19. Mai 2016, 17:41:15 schrieb Matthias Bodenbinder:
> Am 19.05.2016 um 11:02 schrieb Tobias Ellinghaus:
> > echo "select name, operation, format from presets where autoapply=1;" |
> > sqlite3 ~/.config/darktable/library.db

There we have it. The format column is ORed from these values:

1: ldr (for example JPEG or PNG)
2: raw
4: hdr

So you are forcing ldr images to be treated as sRGB:

> sRGB std. (PNG, TIF, JPG)|colorin|1

raw files get some treatment (potentially limited by other auto-apply filters):

> Entrauschen - 0,5 std|denoiseprofile|2
> Canon 20D|colorin|2
> Canon 6D|colorin|2
> Schärfen (mittel-3)|sharpen|2
> Canon 6D standard|sharpen|2
> Canon EOS-artig|basecurve|2
> Canon EOS-artig, Alternative|basecurve|2
> Nikon-artig|basecurve|2
> Nikon-artige Alternative|basecurve|2
> Sony Alpha-artig|basecurve|2
> Pentax-artig|basecurve|2
> Ricoh-artig|basecurve|2
> Olympus-artig|basecurve|2
> Olympus-artige Alternative|basecurve|2
> Panasonic-artig|basecurve|2
> Leica-artig|basecurve|2
> Kodak EasyShare-artig|basecurve|2
> Konica Minolta-artig|basecurve|2
> Samsung-artig|basecurve|2
> Fujifilm-artig|basecurve|2
> Nokia-artig|basecurve|2
> schärfen|sharpen|2

and finally those where format is "7", i.e., every image:

> meine Canon 6D|basecurve|7
> Eizo FS2331|colorout|7
> Fuji X100|colorin|7
> Schärfen aus|sharpen|7
> Sony DSC-RX100M3|lens|7
> Reinhards Sony RX100M3|basecurve|7
> Fuji X100|lens|7
> stark|rawdenoise|7

You should go through the list of presets in the preferences and check those.

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-19 Thread Tobias Ellinghaus
Am Mittwoch, 18. Mai 2016, 21:30:27 schrieb Matthias Bodenbinder:
> Am 18.05.2016 um 21:08 schrieb Tobias Ellinghaus:
> >>> Please open src/libs/metadata_view.c in a text editor and make sure that
> >>> SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and
> >>> check the image information of the PNG. There should be a line "Flags"
> >>> now. What does it say for the PNG?
> >> 
> >> It says: Flags 0..l...ap...
> >> The same flags are shown for the TIF.
> >> 
> >> Both, PNG and TIF, have been created by DT.
> > 
> > That means that darktable doesn't think those are raw files. So it must be
> > something else. Could you upload a sample image exported from darktable
> > that shows the wrong behaviour please?
> 
> Here is a small example PNG (800x534) :
> https://www.dropbox.com/s/b7t6pufeym70b3q/IMG_4339-800.png?dl=0

That image doesn't make darktable apply any unusual modules for me. So it must 
be something else. Please run the following command (it's one line):

echo "select name, operation, format from presets where autoapply=1;" | 
sqlite3 ~/.config/darktable/library.db

and show the output

> Matthias

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-18 Thread Tobias Ellinghaus
Am Mittwoch, 18. Mai 2016, 20:39:41 schrieb Matthias Bodenbinder:
> Am 18.05.2016 um 11:05 schrieb Tobias Ellinghaus:
> > Am Mittwoch, 18. Mai 2016, 08:05:35 schrieb Matthias Bodenbinder:
> >> Am 17.05.2016 um 22:44 schrieb Matthias Bodenbinder:
> >>> Am 17.05.2016 um 10:36 schrieb Tobias Ellinghaus:
>  Am Samstag, 14. Mai 2016, 15:34:41 schrieb Matthias Bodenbinder:
> > Hi,
> > 
> > I am struggling with my presets (DT 2.0.4). I have a basecurve preset
> > that
> > is applied to all my RAW (CR2). Unfortunately the same preset is also
> > applied to the exported PNG, JPG and TIF when I import them. How can I
> > prevent that?
> > 
> > I found this issue report https://redmine.darktable.org/issues/9540
> > which is describing exactly my problem. It is from 2013 and the last
> > comment is that it is fixed. But I can not find it.
> > 
> > My basecurve presets are always applied. The attached screenshot shows
> > the
> > preset dialog. I have only selected "Format: RAW" but that does not
> > help.
>  
>  It might be that the exported files look like a raw to darktable for
>  some
>  reason, maybe because of embedded metadata copied over from the
>  original
>  file.
>  
>  Do you have a way to compile darktable yourself? That would make it
>  easier to find out what is happening.
> >>> 
> >>> I do compile myself.
> >>> 
> >>> Matthias
> >> 
> >> What should I test?
> > 
> > Please open src/libs/metadata_view.c in a text editor and make sure that
> > SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and
> > check the image information of the PNG. There should be a line "Flags"
> > now. What does it say for the PNG?
> 
> It says: Flags 0..l...ap...
> The same flags are shown for the TIF.
> 
> Both, PNG and TIF, have been created by DT.

That means that darktable doesn't think those are raw files. So it must be 
something else. Could you upload a sample image exported from darktable that 
shows the wrong behaviour please?

> Matthias

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-18 Thread Tobias Ellinghaus
Am Mittwoch, 18. Mai 2016, 08:05:35 schrieb Matthias Bodenbinder:
> Am 17.05.2016 um 22:44 schrieb Matthias Bodenbinder:
> > Am 17.05.2016 um 10:36 schrieb Tobias Ellinghaus:
> >> Am Samstag, 14. Mai 2016, 15:34:41 schrieb Matthias Bodenbinder:
> >>> Hi,
> >>> 
> >>> I am struggling with my presets (DT 2.0.4). I have a basecurve preset
> >>> that
> >>> is applied to all my RAW (CR2). Unfortunately the same preset is also
> >>> applied to the exported PNG, JPG and TIF when I import them. How can I
> >>> prevent that?
> >>> 
> >>> I found this issue report https://redmine.darktable.org/issues/9540
> >>> which is describing exactly my problem. It is from 2013 and the last
> >>> comment is that it is fixed. But I can not find it.
> >>> 
> >>> My basecurve presets are always applied. The attached screenshot shows
> >>> the
> >>> preset dialog. I have only selected "Format: RAW" but that does not
> >>> help.
> >> 
> >> It might be that the exported files look like a raw to darktable for some
> >> reason, maybe because of embedded metadata copied over from the original
> >> file.
> >> 
> >> Do you have a way to compile darktable yourself? That would make it
> >> easier to find out what is happening.
> > 
> > I do compile myself.
> > 
> > Matthias
> 
> What should I test?

Please open src/libs/metadata_view.c in a text editor and make sure that 
SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and check 
the image information of the PNG. There should be a line "Flags" now. What 
does it say for the PNG?

> One more important info regarding this problem:
> 
> It is only the basecurve preset which is applied to PNG/TIF files. Presets
> like for denoise and sharpening are not applied automatically although they
> have a similar filter.
> 
> See the two screenshots. History stack was removed before opening the
> pictures in darkroom: (1) Modules applied to PNG file (2) Modules applied
> to CR2 files
> 
> 
> Matthias
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org


signature.asc
Description: This is a digitally signed message part.