[perl5-dbi/dbi] 6a5ada: Support multiple folders in DBD::File's f_dir attr...

2013-06-11 Thread H.Merijn Brand - Tux
  Branch: refs/heads/f_dir-ref
  Home:   https://github.com/perl5-dbi/dbi
  Commit: 6a5ada7b9e36edc32be5d34a39854660a4bf70b7
  
https://github.com/perl5-dbi/dbi/commit/6a5ada7b9e36edc32be5d34a39854660a4bf70b7
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-11 (Tue, 11 Jun 2013)

  Changed paths:
M Changes
M lib/DBD/File.pm

  Log Message:
  ---
  Support multiple folders in DBD::File's f_dir attribute

No tests yet and a few locations where things still will go wrong
when the catdir () is involved





[perl5-dbi/dbi] 6a5ada: Support multiple folders in DBD::File's f_dir attr...

2013-06-24 Thread Tim Bunce
  Branch: refs/heads/master
  Home:   https://github.com/perl5-dbi/dbi
  Commit: 6a5ada7b9e36edc32be5d34a39854660a4bf70b7
  
https://github.com/perl5-dbi/dbi/commit/6a5ada7b9e36edc32be5d34a39854660a4bf70b7
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-11 (Tue, 11 Jun 2013)

  Changed paths:
M Changes
M lib/DBD/File.pm

  Log Message:
  ---
  Support multiple folders in DBD::File's f_dir attribute

No tests yet and a few locations where things still will go wrong
when the catdir () is involved


  Commit: f69132e9fc2b732892906bd91e6a1697aaec0e7d
  
https://github.com/perl5-dbi/dbi/commit/f69132e9fc2b732892906bd91e6a1697aaec0e7d
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-11 (Tue, 11 Jun 2013)

  Changed paths:
M lib/DBD/File.pm

  Log Message:
  ---
  Use a new attribute: f_dir_ext

Extended dir search now more explicit. One of the reasons not to use
a ref in f_dir is that the current definition is (very) clear and we
should not break that. What e.g. would we use to write new files?

If a table is opened from folder 2, then deleted and recreated, does
that mean we should re-use folder 2? If f_dir working as before this
problem disappears


  Commit: be61af1533b582da2397cc33194bd43122717f83
  
https://github.com/perl5-dbi/dbi/commit/be61af1533b582da2397cc33194bd43122717f83
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-11 (Tue, 11 Jun 2013)

  Changed paths:
M Changes
M lib/DBD/File.pm

  Log Message:
  ---
  Jens really prefers f_dir_search over f_dir_ext


  Commit: 7b973933e1ed41866c9a85d0dbb970d0f2ad34b0
  
https://github.com/perl5-dbi/dbi/commit/7b973933e1ed41866c9a85d0dbb970d0f2ad34b0
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-11 (Tue, 11 Jun 2013)

  Changed paths:
M lib/DBD/File.pm

  Log Message:
  ---
  Make deep searches work.

Tested with DBD::CSV, now all we need is sanity checks and agreement on
this new feature


  Commit: dd4e5dc84fc8b6d168deff5d4bc7540a9bcb6f09
  
https://github.com/perl5-dbi/dbi/commit/dd4e5dc84fc8b6d168deff5d4bc7540a9bcb6f09
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M t/51dbm_file.t

  Log Message:
  ---
  Tests for f_dir_search


  Commit: b80a2f5c34f4e1befd53537bc6a0eeda4507fd97
  
https://github.com/perl5-dbi/dbi/commit/b80a2f5c34f4e1befd53537bc6a0eeda4507fd97
  Author: Jens Rehsack 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M t/51dbm_file.t

  Log Message:
  ---
  stop confusing duplicate defining @tbl ...


  Commit: b11f837cef600fe6206a1423439ff27b83bf4a35
  
https://github.com/perl5-dbi/dbi/commit/b11f837cef600fe6206a1423439ff27b83bf4a35
  Author: martin 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M Changes
M DBI.pm

  Log Message:
  ---
  Clarify bind_col TYPE attribute is sticky


  Commit: 07cf2f247bdbfd3d59627136e80b213016ab9117
  
https://github.com/perl5-dbi/dbi/commit/07cf2f247bdbfd3d59627136e80b213016ab9117
  Author: Ville Skyttä 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M Changes
M DBI.xs
M DBIXS.h
M INSTALL
M Old/TODO_gofer.txt
M dbiproxy.PL
M devel/README
M lib/DBD/DBM.pm
M lib/DBD/File.pm
M lib/DBD/Gofer.pm
M lib/DBD/Gofer/Transport/Base.pm
M lib/DBD/Multiplex.pm
M lib/DBD/NullP.pm
M lib/DBD/Proxy.pm
M lib/DBI/DBD.pm
M lib/DBI/DBD/SqlEngine.pm
M lib/DBI/FAQ.pm
M lib/DBI/Gofer/Execute.pm
M lib/DBI/ProxyServer.pm
M t/01basics.t
M t/03handle.t
M t/06attrs.t
M t/30subclass.t
M t/85gofer.t
M t/lib.pl

  Log Message:
  ---
  Spelling fixes.

Signed-off-by: H.Merijn Brand - Tux 


  Commit: 196df56912145879e791e7c10ca087ae788c7587
  
https://github.com/perl5-dbi/dbi/commit/196df56912145879e791e7c10ca087ae788c7587
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M Changes

  Log Message:
  ---
  Give Ville the credits for his patch

As I used git-am, I could not include this change in the previous
commit, unless I modified the patch to include this change :)


  Commit: 9bfd87b78a62d39165d3e1b7d7d8fa9115229156
  
https://github.com/perl5-dbi/dbi/commit/9bfd87b78a62d39165d3e1b7d7d8fa9115229156
  Author: H.Merijn Brand - Tux 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M DBI.pm

  Log Message:
  ---
  one more typo


  Commit: 481a197712ea22a76ec4060addc59849264fcf49
  
https://github.com/perl5-dbi/dbi/commit/481a197712ea22a76ec4060addc59849264fcf49
  Author: Jens Rehsack 
  Date:   2013-06-24 (Mon, 24 Jun 2013)

  Changed paths:
M Changes
M lib/DBI/SQL/Nano.pm

  Log Message:
  ---
  Fix handling "0" different from ""

Handle strings evaluating to a false value correct when simply expecting
data in DBI::SQL::Nano_::Statement part approval


  Commit: 98c69490d552bfb8c48fc323ca1c4c82082b5d9b
  
https://github.

Re: [perl5-dbi/dbi] 6a5ada: Support multiple folders in DBD::File's f_dir attr...

2013-06-11 Thread Tim Bunce
On Tue, Jun 11, 2013 at 04:09:13AM -0700, H.Merijn Brand - Tux wrote:
>   Branch: refs/heads/f_dir-ref
>   Home:   https://github.com/perl5-dbi/dbi
>   Commit: 6a5ada7b9e36edc32be5d34a39854660a4bf70b7
>   
> https://github.com/perl5-dbi/dbi/commit/6a5ada7b9e36edc32be5d34a39854660a4bf70b7
>   Author: H.Merijn Brand - Tux 
>   Date:   2013-06-11 (Tue, 11 Jun 2013)
> 
>   Changed paths:
> M Changes
> M lib/DBD/File.pm
> 
>   Log Message:
>   ---
>   Support multiple folders in DBD::File's f_dir attribute
> 
> No tests yet and a few locations where things still will go wrong
> when the catdir () is involved

I'd *really* like features to be developed on feature branches and only
to land on trunk, in a single merge, once they have reasonable test coverage.

Tim.


Re: [perl5-dbi/dbi] 6a5ada: Support multiple folders in DBD::File's f_dir attr...

2013-06-11 Thread H.Merijn Brand
On Tue, 11 Jun 2013 22:44:06 +0100, Tim Bunce 
wrote:

> On Tue, Jun 11, 2013 at 04:09:13AM -0700, H.Merijn Brand - Tux wrote:
> >   Branch: refs/heads/f_dir-ref
  

> >   Home:   https://github.com/perl5-dbi/dbi
> >   Commit: 6a5ada7b9e36edc32be5d34a39854660a4bf70b7
> >   
> > https://github.com/perl5-dbi/dbi/commit/6a5ada7b9e36edc32be5d34a39854660a4bf70b7
> >   Author: H.Merijn Brand - Tux 
> >   Date:   2013-06-11 (Tue, 11 Jun 2013)
> > 
> >   Changed paths:
> > M Changes
> > M lib/DBD/File.pm
> > 
> >   Log Message:
> >   ---
> >   Support multiple folders in DBD::File's f_dir attribute
> > 
> > No tests yet and a few locations where things still will go wrong
> > when the catdir () is involved
> 
> I'd *really* like features to be developed on feature branches and only
> to land on trunk, in a single merge, once they have reasonable test coverage.

Isn't that exactly what I am doing now?

FWIW, I finished some tests in DBD::CSV yesterday, and the basic
thought seems to work as intended. What is left to do is rework the
tests into tests that can be used in DBI itself, improve docs and
examples and merge back to master (there is no trunk anymore :)

In hindsight, the name I chose for the branch isn't that great. Do we
need a kind of standard, like feature_something?

> Tim.

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.19   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/


Re: [perl5-dbi/dbi] 6a5ada: Support multiple folders in DBD::File's f_dir attr...

2013-06-12 Thread Tim Bunce
On Wed, Jun 12, 2013 at 07:53:30AM +0200, H.Merijn Brand wrote:
> On Tue, 11 Jun 2013 22:44:06 +0100, Tim Bunce 
> wrote:
> 
> > On Tue, Jun 11, 2013 at 04:09:13AM -0700, H.Merijn Brand - Tux wrote:
> > >   Branch: refs/heads/f_dir-ref
>   
> 
> > I'd *really* like features to be developed on feature branches and only
> > to land on trunk, in a single merge, once they have reasonable test 
> > coverage.
> 
> Isn't that exactly what I am doing now?

Ooops! I'd *really* like to pay more attention to commit messages :)

> FWIW, I finished some tests in DBD::CSV yesterday, and the basic
> thought seems to work as intended. What is left to do is rework the
> tests into tests that can be used in DBI itself, improve docs and
> examples and merge back to master (there is no trunk anymore :)

:)

> In hindsight, the name I chose for the branch isn't that great. Do we
> need a kind of standard, like feature_something?

That by itself might not help much. The goal should be to communicate the
purpose and scope to someone who isn't familar with the branch.
Something like "dbd_file_multiple_dirs" expresses the scope and purpose
reasonably well.

Tim.