Re: DBI Bundle::DBD::Foo modules

2013-11-11 Thread Greg Sabino Mullane

-BEGIN PGP SIGNED MESSAGE-
Hash: RIPEMD160


> However the Bundle mechanism, which is described at
> https://metacpan.org/module/CPAN#Bundles - is deprecated; dependencies
> for DBD drivers can be correctly specified in Makefile.PL, Build.PL
> and/or dist.ini

Is this deprecation documented somewhere? I thought the link above 
would be a good place, but it doesn't mention it. I ask as I'd like 
to add a link about the deprecation inside the existing DBD::Pg bundle.

- -- 
Greg Sabino Mullane g...@turnstep.com
End Point Corporation http://www.endpoint.com/
PGP Key: 0x14964AC8 20132230
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-BEGIN PGP SIGNATURE-

iEYEAREDAAYFAlKBoTgACgkQvJuQZxSWSsgvbgCg1sVZYoTjVxh5E2G0iasiwwK3
4vwAoJgROewR71p1DLffVxS8eAc+K4wg
=4igF
-END PGP SIGNATURE-




Re: DBI Bundle::DBD::Foo modules

2013-10-10 Thread H.Merijn Brand
On Thu, 10 Oct 2013 10:47:02 +0200, Michiel Beijen
 wrote:

> Hi Merijn,
> 
> On Thu, Oct 10, 2013 at 10:40 AM, H.Merijn Brand  wrote:
> > On Thu, 10 Oct 2013 09:19:52 +0100, "Martin J. Evans"
> >  wrote:
> >> On 09/10/13 18:49, Michiel Beijen wrote:
> 
> >> > my proposal is:
> >> >
> >> >   - Remove the section from DBI documentation that states a DBD should
> >> > have a Bundle
> >> >   - Update the text in the existing Bundles, which now typically reads
> >> > someting along the lines of "This bundle includes all that is needed
> >> > to connect with a MySQL server using DBI." to "This file exists for
> >> > historical reasons."
> 
> 
> 
> > In which case removing the Bundle from the distribution (I keep the
> > required versions updated in the CSV bundle) should also imply an
> > action to remove the Bundle from CPAN, as otherwise people that still
> > install the bundle will get OLD versions installed.
> 
> Exactly, this is why my proposal is NOT to remove the bundles, but to
> drop the section in DBI documentation that says that ALL DBDs should
> have a Bundle. For Bundles that are already existing, we could change
> the text, explaining that the Bundle is really only there for legacy
> reasons.

I agree then. The doc change should note then that if a Bundle is
already defined (in history) the versions should be updated on every
release.

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.19   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/


Re: DBI Bundle::DBD::Foo modules

2013-10-10 Thread Michiel Beijen
Hi Merijn,

On Thu, Oct 10, 2013 at 10:40 AM, H.Merijn Brand  wrote:
> On Thu, 10 Oct 2013 09:19:52 +0100, "Martin J. Evans"
>  wrote:
>> On 09/10/13 18:49, Michiel Beijen wrote:

>> > my proposal is:
>> >
>> >   - Remove the section from DBI documentation that states a DBD should
>> > have a Bundle
>> >   - Update the text in the existing Bundles, which now typically reads
>> > someting along the lines of "This bundle includes all that is needed
>> > to connect with a MySQL server using DBI." to "This file exists for
>> > historical reasons."



> In which case removing the Bundle from the distribution (I keep the
> required versions updated in the CSV bundle) should also imply an
> action to remove the Bundle from CPAN, as otherwise people that still
> install the bundle will get OLD versions installed.

Exactly, this is why my proposal is NOT to remove the bundles, but to
drop the section in DBI documentation that says that ALL DBDs should
have a Bundle. For Bundles that are already existing, we could change
the text, explaining that the Bundle is really only there for legacy
reasons.
--
Mike


Re: DBI Bundle::DBD::Foo modules

2013-10-10 Thread H.Merijn Brand
On Thu, 10 Oct 2013 09:19:52 +0100, "Martin J. Evans"
 wrote:

> On 09/10/13 18:49, Michiel Beijen wrote:
> > DBI states that DBD drivers should provide a Bundle::DBD::Foo to
> > leverage the CPAN 'Bundle'  mechanism. (ref:
> > https://metacpan.org/module/DBI::DBD#lib-Bundle-DBD-Driver.pm)
> >
> > As a result many of the DBD driver distributions - such as DBD::Pg,
> > DBD::mysql, DBD::CSV - provide such a Bundle. Note that DBD::ODBC and
> > DBD::Oracle do not have a corresponding Bundle.
> >
> > However the Bundle mechanism, which is described at
> > https://metacpan.org/module/CPAN#Bundles - is deprecated; dependencies
> > for DBD drivers can be correctly specified in Makefile.PL, Build.PL
> > and/or dist.ini
> >
> > I brought this issue up on #dbi, was pointed to #toolchain , asked
> > there and they confirmed my assumption that the Bundle:: modules don't
> > serve any purpose; or at least not anymore, and probably for a *very*
> > long time already.
> >
> > It could be that people 'depend' on a Bundle module so I think we
> > should not remove existing bundles.
> >
> > my proposal is:
> >
> >   - Remove the section from DBI documentation that states a DBD should
> > have a Bundle
> >   - Update the text in the existing Bundles, which now typically reads
> > someting along the lines of "This bundle includes all that is needed
> > to connect with a MySQL server using DBI." to "This file exists for
> > historical reasons."
> >
> > Feedback very welcome!
> > --
> > Mike
> >
> 
> I've never used bundles myself and certainly never produced one for DBD::ODBC.
> 
> I never liked the text "This bundle includes all that is needed to connect 
> with a MySQL server using DBI" since it is not true, you need a mysql client 
> library too.
> 
> With dependencies in modules I don't see why they are necessary any more.
> 
> As such, your proposal sounds ok to me.

In which case removing the Bundle from the distribution (I keep the
required versions updated in the CSV bundle) should also imply an
action to remove the Bundle from CPAN, as otherwise people that still
install the bundle will get OLD versions installed.

I just have the Bundle in the DBD as it was there when I took over

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.19   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/


Re: DBI Bundle::DBD::Foo modules

2013-10-10 Thread Martin J. Evans

On 09/10/13 18:49, Michiel Beijen wrote:

DBI states that DBD drivers should provide a Bundle::DBD::Foo to
leverage the CPAN 'Bundle'  mechanism. (ref:
https://metacpan.org/module/DBI::DBD#lib-Bundle-DBD-Driver.pm)

As a result many of the DBD driver distributions - such as DBD::Pg,
DBD::mysql, DBD::CSV - provide such a Bundle. Note that DBD::ODBC and
DBD::Oracle do not have a corresponding Bundle.

However the Bundle mechanism, which is described at
https://metacpan.org/module/CPAN#Bundles - is deprecated; dependencies
for DBD drivers can be correctly specified in Makefile.PL, Build.PL
and/or dist.ini

I brought this issue up on #dbi, was pointed to #toolchain , asked
there and they confirmed my assumption that the Bundle:: modules don't
serve any purpose; or at least not anymore, and probably for a *very*
long time already.

It could be that people 'depend' on a Bundle module so I think we
should not remove existing bundles.

my proposal is:

  - Remove the section from DBI documentation that states a DBD should
have a Bundle
  - Update the text in the existing Bundles, which now typically reads
someting along the lines of "This bundle includes all that is needed
to connect with a MySQL server using DBI." to "This file exists for
historical reasons."

Feedback very welcome!
--
Mike



I've never used bundles myself and certainly never produced one for DBD::ODBC.

I never liked the text "This bundle includes all that is needed to connect with a 
MySQL server using DBI" since it is not true, you need a mysql client library too.

With dependencies in modules I don't see why they are necessary any more.

As such, your proposal sounds ok to me.

Martin

--
Martin J. Evans
Easysoft Limited
http://www.easysoft.com