[Dbmail-dev] Sieve status today

2006-02-20 Thread Aaron Stone
Implicit keep works.
Explicit keep works.
Fileinto works.
Discard works.
Redirect appears to work (not yet tested with a full mail stack).

Reject merely discards, but it should also return an appropriate
rejection exit code (smtp) or 5xx code (lmtp). I'm working on vacation
and subaddress this evening. More tonight.

Subaddress is broken in libSieve 2.1.8. I'll post a fixed 2.1.9 tomorrow.

Aaron




[Dbmail-dev] PostgreSQL error handling

2006-02-20 Thread Aaron Stone
I managed to forget to add the replycache table to my database, so the
query failed the first time. The second time, the query didn't just
fail, it was ignored. This continues even for queries to tables that
exist, until the end of the process.

So basically, we need to clear the error after handling it. *Goes
looking for the PostgreSQL manual...*

Aaron

dbpgsql.c, db_query: Error executing query [SELECT lastseen FROM
dbmail_replycache WHERE to_addr = '(null)' AND from_addr =
'[EMAIL PROTECTED]' AND handle = 'f8d79fc201c6332436d455d4dd99199c' AND
lastseen  (NOW() - INTERVAL '2 DAY')] : [ERROR:  relation
dbmail_replycache does not exist
]

db.c,db_replycache_validate: query failed
dbpgsql.c, db_query: Error executing query [SELECT lastseen FROM
dbmail_replycache WHERE to_addr = '(null)' AND from_addr =
'[EMAIL PROTECTED]' AND handle= 'f8d79fc201c6332436d455d4dd99199c' ] :
[ERROR:  current transaction is aborted, commands ignored until end of
transaction block
]




[Dbmail-dev] Re: PostgreSQL error handling

2006-02-20 Thread Thomas Mueller
Aaron Stone wrote:
 I managed to forget to add the replycache table to my database, so the
 query failed the first time. The second time, the query didn't just
 fail, it was ignored. This continues even for queries to tables that
 exist, until the end of the process.
 
[..]
 [ERROR:  current transaction is aborted, commands ignored until end of
 transaction block
 ]

Until the end of the transaction, that is until you do a 'rollback'.

To ignore everything makes sense: why put load on the database if
everything will be undone later?


Thomas



Re: [Dbmail-dev] Sieve status today

2006-02-20 Thread Aaron Stone
Progress!

Reject returns a failure code.

Subaddress works with the forthcoming libSieve 2.1.9.

Vacation works at the Sieve level, but isn't coded up in DBMail. I'm not
happy with the amount of code duplication in pipe.c, and would like to
have send_reply, send_notification and send_vacation share a common
codebase. More tomorrow.

Aaron

On Sun, 2006-02-19 at 22:36 -0800, Aaron Stone wrote:
 Implicit keep works.
 Explicit keep works.
 Fileinto works.
 Discard works.
 Redirect appears to work (not yet tested with a full mail stack).
 
 Reject merely discards, but it should also return an appropriate
 rejection exit code (smtp) or 5xx code (lmtp). I'm working on vacation
 and subaddress this evening. More tonight.
 
 Subaddress is broken in libSieve 2.1.8. I'll post a fixed 2.1.9 tomorrow.
 
 Aaron
 
 
 ___
 Dbmail-dev mailing list
 Dbmail-dev@dbmail.org
 http://twister.fastxs.net/mailman/listinfo/dbmail-dev



Re: [Dbmail-dev] Re: PostgreSQL error handling

2006-02-20 Thread Aaron Stone
On Mon, 2006-02-20 at 10:40 +0100, Thomas Mueller wrote:
 Aaron Stone wrote:
  I managed to forget to add the replycache table to my database, so the
  query failed the first time. The second time, the query didn't just
  fail, it was ignored. This continues even for queries to tables that
  exist, until the end of the process.
  
 [..]
  [ERROR:  current transaction is aborted, commands ignored until end of
  transaction block
  ]
 
 Until the end of the transaction, that is until you do a 'rollback'.
 
 To ignore everything makes sense: why put load on the database if
 everything will be undone later?

Of course -- the issue is that we're not handling the error elegantly,
but rather just throwing the rest of the queries at the server and
hoping that we've coded somewhat defensively against query errors.

It's actually kinda just fine as it is. The errors are logged, and a
temporary error code is returned, causing the message to remain queued
by the SMTP server.

Aaron



[Dbmail-dev] Re: Sieve status today

2006-02-20 Thread Oleg Lapshin

Hello!

 Progress!
 Reject returns a failure code.
 Subaddress works with the forthcoming libSieve 2.1.9.
 Vacation works at the Sieve level, but isn't coded up in DBMail. I'm not
 happy with the amount of code duplication in pipe.c, and would like to
 have send_reply, send_notification and send_vacation share a common
 codebase. More tomorrow.

 Aaron

Good news!

Can you commit both libSieve and dbmail?
Or where can I get them today?

(I need this functionality in nearly future - 3-4 days, and whant to do some 
tests)



-- 
Oleg Lapshin



Re: [Dbmail-dev] Re: Sieve status today

2006-02-20 Thread Aaron Stone
On Mon, 2006-02-20 at 13:26 +0300, Oleg Lapshin wrote:

 Can you commit both libSieve and dbmail?
 Or where can I get them today?

libSieve 2.1.9 is now posted and work on DBMail is in SVN.
Tomorrow I'll get the pipe.c stuff going so that vacation can work.

Aaron



[Dbmail-dev] Re: Sieve status today

2006-02-20 Thread Oleg Lapshin

 libSieve 2.1.9 is now posted and work on DBMail is in SVN.

I tried libsieve-2.1.9.tar.gz from 2 different mirrors, but:


$ tar xzf libsieve-2.1.9.tar.gz
tar: Skipping to next header
tar: Archive contains obsolescent base-64 headers

gzip: stdin: invalid compressed data--format violated
tar: Child returned status 1
tar: Error exit delayed from previous errors


$ md5sum libsieve-2.1.9.tar.gz
b8c3209a122912dbcd7a12df1148ef49  libsieve-2.1.9.tar.gz

Size: 765341 bytes

-- 
Oleg Lapshin



Re: [Dbmail-dev] Re: Sieve status today

2006-02-20 Thread Paul J Stevens
Yeah, definitely broken. Aaron, you getting enough sleep?

Oleg Lapshin wrote:
libSieve 2.1.9 is now posted and work on DBMail is in SVN.
 
 
 I tried libsieve-2.1.9.tar.gz from 2 different mirrors, but:
 
 
 $ tar xzf libsieve-2.1.9.tar.gz
 tar: Skipping to next header
 tar: Archive contains obsolescent base-64 headers
 
 gzip: stdin: invalid compressed data--format violated
 tar: Child returned status 1
 tar: Error exit delayed from previous errors
 
 
 $ md5sum libsieve-2.1.9.tar.gz
 b8c3209a122912dbcd7a12df1148ef49  libsieve-2.1.9.tar.gz
 
 Size: 765341 bytes
 


-- 
  
  Paul Stevens  mailto:[EMAIL PROTECTED]
  NET FACILITIES GROUP PGP: finger [EMAIL PROTECTED]
  The Netherlandshttp://www.nfg.nl


Re: [Dbmail-dev] Re: Sieve status today

2006-02-20 Thread Aaron Stone
The file I just downloaded was SF is 3k larger than the one I uploaded.
Very weird. New file posted. The size should be:

762488, rather than 765341. MD5 is 94743041a5718ce37b292af75b9a1199.

Aaron

On Mon, 2006-02-20 at 15:36 +0100, Paul J Stevens wrote:
 Yeah, definitely broken. Aaron, you getting enough sleep?
 
 Oleg Lapshin wrote:
 libSieve 2.1.9 is now posted and work on DBMail is in SVN.
  
  
  I tried libsieve-2.1.9.tar.gz from 2 different mirrors, but:
  
  
  $ tar xzf libsieve-2.1.9.tar.gz
  tar: Skipping to next header
  tar: Archive contains obsolescent base-64 headers
  
  gzip: stdin: invalid compressed data--format violated
  tar: Child returned status 1
  tar: Error exit delayed from previous errors
  
  
  $ md5sum libsieve-2.1.9.tar.gz
  b8c3209a122912dbcd7a12df1148ef49  libsieve-2.1.9.tar.gz
  
  Size: 765341 bytes
  
 
 



[Dbmail-dev] Re: Sieve status today

2006-02-20 Thread Oleg Lapshin

 libSieve 2.1.9 is now posted and work on DBMail is in SVN.
 Tomorrow I'll get the pipe.c stuff going so that vacation can work.

I downloaded new libsieve-2.1.9
Now it's ok.

I am happy!!! ;)

Excelent work! Thank you!

-- 
Oleg Lapshin



[Dbmail-dev] Undefined reference to crypt

2006-02-20 Thread Aaron Stone
I'm getting this on my shared builds:

./.libs/libdbmail.so: undefined reference to `crypt'

I guess we need to specify -lcrypt when linking. Sadly, I'm not up for
the necessary autoconf tomfoolery to get this working today...

Aaron