Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 10:45pm -07, Xiyue Deng wrote: > >> Ah I see. So for d/copyright we need to stick to the source >> information. Dropped Wilfred from the list of copyright holders for >> now. Also opened a PR upstream for tracking[1]. > > Cool. Just to note, in your commit message you wrote that he's not a > copyright holder yet, but we can't assert that -- in fact, he probably > is a copyright holder. You could have written that he's not > /documented/ as a copyright holder. > Ack. Yeah I should have said that in the commit message. I guess doing a reword and letting everyone having to do a force pull is a no-go so I think I'll have to leave it as-is. Will be more precise in future. >> As this is the first time I attempt of ITP/RFS, I'd like to go over the >> steps for packaging as much as possible if OK. But AIUI this package >> will need to go through the NEW queue, so I guess if you sponsor my >> upload to mentors.d.n it may require some extra steps, then I'm OK if >> what you propose can save some trouble. > > Okay, go ahead and let me know when you've done 'dch -r'. > > I will still work out of git, so please don't push a signed tag there. > See dgit-sponsorship(7) for more. Pushed the commit with 'dch -r' to salsa and also uploaded to mentors[1]. Please proceed as you see fit. Thanks for the sponsorship! [1] https://mentors.debian.net/package/bison-mode/ -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Mon 16 Oct 2023 at 03:51am -07, Xiyue Deng wrote: > >> Looks like I got confused about what you suggested as there was a "0.3" >> tag that was from the upstream repo which I assume "git deborig" can use >> so I thought an "upstream" may help more. >> >> I've now also pushed an "upstream/0.3" tag at the commit that matches >> the "0.3" tag, but not sure whether this is what you were referring to. >> If this works better I can remove the upstream branch to avoid further >> complications. Please advice. Thanks! > > What I meant was simply pushing the 0.3 tag to salsa. Ah got it, and done. Sorry for the confusion. I have also dropped the unnecessary tag "upstream/0.3" and the upstream branch, which is not actually used much in the dgit-maint-merge workflow AIUI. -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hello, On Mon 16 Oct 2023 at 03:51am -07, Xiyue Deng wrote: > Looks like I got confused about what you suggested as there was a "0.3" > tag that was from the upstream repo which I assume "git deborig" can use > so I thought an "upstream" may help more. > > I've now also pushed an "upstream/0.3" tag at the commit that matches > the "0.3" tag, but not sure whether this is what you were referring to. > If this works better I can remove the upstream branch to avoid further > complications. Please advice. Thanks! What I meant was simply pushing the 0.3 tag to salsa. -- Sean Whitton signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 10:46pm -07, Xiyue Deng wrote: > >> Sean Whitton writes: >> >>> Hello, >>> >>> On Sun 15 Oct 2023 at 03:10pm +01, Sean Whitton wrote: >>> Hello, On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have > also filed an RFS bug#1053987. Alright, pushed that to a team repo, let's work from there. >>> >>> It would be a good idea to push upstream's git tags to the repo, so that >>> I can just type 'git deborig'. >> >> Done. The `upstream' branch should be available now. > > I did mean the tags -- I myself prefer not to push an upstream branch. > The idea is that from our point of view the upstream source is > immutable, like tags, and unlike branches. But of course it's fine to > have one. Looks like I got confused about what you suggested as there was a "0.3" tag that was from the upstream repo which I assume "git deborig" can use so I thought an "upstream" may help more. I've now also pushed an "upstream/0.3" tag at the commit that matches the "0.3" tag, but not sure whether this is what you were referring to. If this works better I can remove the upstream branch to avoid further complications. Please advice. Thanks! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hello, On Sun 15 Oct 2023 at 10:45pm -07, Xiyue Deng wrote: > Ah I see. So for d/copyright we need to stick to the source > information. Dropped Wilfred from the list of copyright holders for > now. Also opened a PR upstream for tracking[1]. Cool. Just to note, in your commit message you wrote that he's not a copyright holder yet, but we can't assert that -- in fact, he probably is a copyright holder. You could have written that he's not /documented/ as a copyright holder. > As this is the first time I attempt of ITP/RFS, I'd like to go over the > steps for packaging as much as possible if OK. But AIUI this package > will need to go through the NEW queue, so I guess if you sponsor my > upload to mentors.d.n it may require some extra steps, then I'm OK if > what you propose can save some trouble. Okay, go ahead and let me know when you've done 'dch -r'. I will still work out of git, so please don't push a signed tag there. See dgit-sponsorship(7) for more. -- Sean Whitton signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hello, On Sun 15 Oct 2023 at 10:46pm -07, Xiyue Deng wrote: > Sean Whitton writes: > >> Hello, >> >> On Sun 15 Oct 2023 at 03:10pm +01, Sean Whitton wrote: >> >>> Hello, >>> >>> On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: >>> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have also filed an RFS bug#1053987. >>> >>> Alright, pushed that to a team repo, let's work from there. >> >> It would be a good idea to push upstream's git tags to the repo, so that >> I can just type 'git deborig'. > > Done. The `upstream' branch should be available now. I did mean the tags -- I myself prefer not to push an upstream branch. The idea is that from our point of view the upstream source is immutable, like tags, and unlike branches. But of course it's fine to have one. -- Sean Whitton signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 03:10pm +01, Sean Whitton wrote: > >> Hello, >> >> On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: >> >>> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >>> also filed an RFS bug#1053987. >> >> Alright, pushed that to a team repo, let's work from there. > > It would be a good idea to push upstream's git tags to the repo, so that > I can just type 'git deborig'. Done. The `upstream' branch should be available now. -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hi Sean, Thanks for your comments. Replies are inline below. Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > >> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >> also filed an RFS bug#1053987. > > Alright, pushed that to a team repo, let's work from there. > Thanks! Pushed the new changes with detailed below. > Review of 8123e6e09fa1591dc2182682661421d9be80c328: > > - d/copyright is required to say where upstream sources were obtained -- > see Debian Policy > Added in the `Source' field. Also added upstream maintainer to the `Upstream-Contact' field. > - It looks like you made up the copyright statement for Wilfred Hughes, > right? > > While he may indeed hold copyright, what the GPL requires is just that > we reproduce the copyright notices we actually find in the source. > So it's probably best to drop it for now, and consider offering a pull > request upstream. > Ah I see. So for d/copyright we need to stick to the source information. Dropped Wilfred from the list of copyright holders for now. Also opened a PR upstream for tracking[1]. > - I'd like to suggest dropping the .gitignore, because it interferes > with me uploading using dgit. Can explain more if you want. > Got it. Also dropped ".gitignore". > - description "electric support" is ambiguous. Support for doing what? > It should have been "electric indentation". Fixed now. > - in general, do you mind if when I upload I commit the 'dch -r' change > for you? I.e. the upload is signed off by me, but there'd be [ Xiyue > Deng ] in the changelog. This avoids an e-mail roundtrip. Totally up > to you. As this is the first time I attempt of ITP/RFS, I'd like to go over the steps for packaging as much as possible if OK. But AIUI this package will need to go through the NEW queue, so I guess if you sponsor my upload to mentors.d.n it may require some extra steps, then I'm OK if what you propose can save some trouble. Thanks! [1] https://github.com/Wilfred/bison-mode/issues/15 -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hello, On Sun 15 Oct 2023 at 03:10pm +01, Sean Whitton wrote: > Hello, > > On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > >> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >> also filed an RFS bug#1053987. > > Alright, pushed that to a team repo, let's work from there. It would be a good idea to push upstream's git tags to the repo, so that I can just type 'git deborig'. -- Sean Whitton signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hello, On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have > also filed an RFS bug#1053987. Alright, pushed that to a team repo, let's work from there. Review of 8123e6e09fa1591dc2182682661421d9be80c328: - d/copyright is required to say where upstream sources were obtained -- see Debian Policy - It looks like you made up the copyright statement for Wilfred Hughes, right? While he may indeed hold copyright, what the GPL requires is just that we reproduce the copyright notices we actually find in the source. So it's probably best to drop it for now, and consider offering a pull request upstream. - I'd like to suggest dropping the .gitignore, because it interferes with me uploading using dgit. Can explain more if you want. - description "electric support" is ambiguous. Support for doing what? - in general, do you mind if when I upload I commit the 'dch -r' change for you? I.e. the upload is signed off by me, but there'd be [ Xiyue Deng ] in the changelog. This avoids an e-mail roundtrip. Totally up to you. -- Sean Whitton signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Xiyue Deng writes: > Sean Whitton writes: > >> Hello Xiyue, >> >> On Sun 15 Oct 2023 at 04:32am -07, Xiyue Deng wrote: >> >>> Package: sponsorship-requests >>> Severity: wishlist >>> X-Debbugs-Cc: Xiyue Deng , >>> debian-emac...@lists.debian.org >>> >>> Dear mentors, >>> >>> I am looking for a sponsor for my package "bison-mode": >>> >>> * Package name : bison-mode >>>Version : 0.3-1 >>>Upstream contact : [fill in name and email of upstream] >>> * URL : https://github.com/Wilfred/bison-mode >>> * License : GPL-2+ >>> * Vcs : https://salsa.debian.org/emacsen-team/bison-mode >> >> Can you give me a git repo to clone, please? I'll create and push it to >> that team repo, then review and sponsor. > > Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have > also filed an RFS bug#1053987. > Apparently I meant the ITP bug#1053906 :P > Thanks in advance for taking a look! signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello Xiyue, > > On Sun 15 Oct 2023 at 04:32am -07, Xiyue Deng wrote: > >> Package: sponsorship-requests >> Severity: wishlist >> X-Debbugs-Cc: Xiyue Deng , debian-emac...@lists.debian.org >> >> Dear mentors, >> >> I am looking for a sponsor for my package "bison-mode": >> >> * Package name : bison-mode >>Version : 0.3-1 >>Upstream contact : [fill in name and email of upstream] >> * URL : https://github.com/Wilfred/bison-mode >> * License : GPL-2+ >> * Vcs : https://salsa.debian.org/emacsen-team/bison-mode > > Can you give me a git repo to clone, please? I'll create and push it to > that team repo, then review and sponsor. Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have also filed an RFS bug#1053987. Thanks in advance for taking a look! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hello Xiyue, On Sun 15 Oct 2023 at 04:32am -07, Xiyue Deng wrote: > Package: sponsorship-requests > Severity: wishlist > X-Debbugs-Cc: Xiyue Deng , debian-emac...@lists.debian.org > > Dear mentors, > > I am looking for a sponsor for my package "bison-mode": > > * Package name : bison-mode >Version : 0.3-1 >Upstream contact : [fill in name and email of upstream] > * URL : https://github.com/Wilfred/bison-mode > * License : GPL-2+ > * Vcs : https://salsa.debian.org/emacsen-team/bison-mode Can you give me a git repo to clone, please? I'll create and push it to that team repo, then review and sponsor. -- Sean Whitton signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Package: sponsorship-requests Severity: wishlist X-Debbugs-Cc: Xiyue Deng , debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "bison-mode": * Package name : bison-mode Version : 0.3-1 Upstream contact : [fill in name and email of upstream] * URL : https://github.com/Wilfred/bison-mode * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/bison-mode Section : editors The source builds the following binary packages: elpa-bison-mode - Emacs major mode for editing lex, yacc, and bison grammars To access further information about this package, please visit the following URL: https://mentors.debian.net/package/bison-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/b/bison-mode/bison-mode_0.3-1.dsc Changes for the initial release: bison-mode (0.3-1) UNRELEASED; urgency=medium . * Initial release. Closes: #1053906. Please note that I am currently intentionally leaving the distribution as "UNRELEASE" in case any changes is required. Will change this to "unstable" when uploading the final package. Regards, -- Xiyue Deng signature.asc Description: PGP signature
