Bug#299920: When Firefox is running, open links from commad line in an existing window

2005-03-18 Thread Cesar Martinez Izquierdo
El Viernes 18 Marzo 2005 08:37 escribiste:
 * [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote:
  Package: mozilla-firefox
  Version: 1.0.1-2
  Severity: normal
  Tags: patch
 
  Hi, last Firefox versions have reverted the previous way of open links
  from command line.
 
  In current version, if I try
  $ firefox file.html
  from command line while firefox is already running, file.html gets open
  in an existing window, replacing its previous content, insted of open a
  new window or tab.
 
  Bug #239323 submited a patch that allowed to open links in new windows or
  tabs, depending on a environment variable (FIREFOX_OPEN_IN=tab), which
  was already applied.
 
  It seems that you forgot to apply such patch for current version.
 
  Here is the patch again.

 This was done intentionally, it now follows the preference within
 firefox.

Sorry for the noise, I didn't realise about the new option.

Anyway, it would be nice to make the option [open in] a new window the 
default in Debian, as it was the default before. Otherwise, an entry in 
NEWS.Debian (or another *.Debian file) may be good.

Regards,

  César



Bug#299920: When Firefox is running, open links from commad line in an existing window

2005-03-17 Thread listas
Package: mozilla-firefox
Version: 1.0.1-2
Severity: normal
Tags: patch

Hi, last Firefox versions have reverted the previous way of open links from
command line.

In current version, if I try
$ firefox file.html
from command line while firefox is already running, file.html gets open in
an existing window, replacing its previous content, insted of open a new
window or tab.

Bug #239323 submited a patch that allowed to open links in new windows or
tabs, depending on a environment variable (FIREFOX_OPEN_IN=tab), which was
already applied.

It seems that you forgot to apply such patch for current version.

Here is the patch again.

Regards,

  Cesar Martinez Izquierdo


--- firefox.old 2005-03-06 02:50:17.0 +0200
+++ firefox 2005-03-17 13:12:23.940460200 +0200
@@ -366,11 +366,17 @@
 exec_verbose ${MOZ_PROGRAM} -remote xfeDoCommand(openBrowser)
 fi
 
+open_in=window
+ 
+if [ ${FIREFOX_OPEN_IN} = tab ] ; then
+open_in=tab
+fi
+
 # If we are trying to use existing instance, and it exists, and we're not 
having
 # a -remote command line argument, then open in window or tab accordingly.
 if [ ${REMOTE} -eq 0 ]  [ ${TRY_USE_EXIST} -eq 1 ]  [ ${PING_STATUS} 
-eq 0 ]; then
 # just pass it off if it looks like a url
-exec_verbose ${MOZ_PROGRAM} -remote openURL(${opt})
+exec_verbose ${MOZ_PROGRAM} -remote openURL(${opt},new-$open_in)
 fi
 
 if type ${FIREFOX_DSP}  /dev/null 21; then