Bug#302693: debian sig2dot package - improvements

[Thomas Huriaux]

I have opened new bugs to split this one.

 - removes the comments of the uid (usually they are quite boring, and
   do not mean anything since it is different for each uid)

#318751

 - there is some internationalization problems with the revoked text
   (in French, for example, it is r'evoqu'e)

#318740

The only thing remaining in this bug is the problem with the -a switch
if asking to show only a subset of your keyring.
A new simplified patch is attached.

-- 
Thomas Huriaux
--- sig2dot.orig2005-07-16 22:40:18.333859719 +0200
+++ sig2dot 2005-07-16 22:48:39.551092997 +0200
@@ -135,6 +135,9 @@
   {
 $id = (split('/',$id))[1];
 $owner = $id; 
+if ($all and not $name =~ /^\[revoked/) {
+ push (@idlist, $id, $owner);
+}
   } 
   
   $name{$id} = $name if $name; # gpg 1.4 fixup
@@ -258,6 +261,15 @@
   if (($sigcount{$id} eq ) and ($signedbycount{$id} eq ) and not $all) {
 next;
   }
+  if ($all) {
+$used_id = 0;
+for $owner (@idlist) {
+  if ($owner eq $id) {
+$used_id = 1;
+  }
+}
+  }
+  next if ($all and $used_id == 0);
   if ($color)
   {
 $red = $sigcount{$id} / $maxsigcount;


pgpgblrznJL62.pgp
Description: PGP signature

Bug#302693: debian sig2dot package - improvements

[Christoph Berg]

Package: sig2dot
Severity: wishlist

Christoph
-- 
[EMAIL PROTECTED] | http://www.df7cb.de/
---BeginMessage---
Hi,

I sent a patch for sig2dot to Kevin a few weeks ago, but I see that you
are the new maintainer of this package.
My patch fixed the problem with the new version of gpg (you already
fixed it) and proposed some improvements:
- removes the comments of the uid (usually they are quite boring, and
  do not mean anything since it is different for each uid)
- if using
$ gpg --list-sigs some_special_pattern | sigdot -a
  which is quite usefull to get a graph from special part of your
  keyring, it removes the uid from extern users (which is already done
  when you are not using the -a).
I attach to this mail the reduced patch, please check it and include it
if there is no problems.

Please note 2 things:
- the [user id not found] is never used with this patch, so you can
  remove everything linked to this from the script
- there is some internationalization problems with the revoked text
  (in French, for example, it is r'evoqu'e)

Regards,

-- 
Thomas Huriaux
--- /usr/bin/sig2dot2005-03-06 20:53:06.0 +0100
+++ sig2dot 2005-03-08 10:45:37.336302261 +0100
@@ -135,9 +135,12 @@
   {
 $id = (split('/',$id))[1];
 $owner = $id; 
+if ($all and not $name =~ /^\[revoked/) {
+ push (@idlist, $id, $owner);
+}
   } 
   
-  $name{$id} = $name if $name; # gpg 1.4 fixup
+  $name{$id} = (split('\(',$name))[0] if $name; # gpg 1.4 fixup
   
   # skip revoked keys 
   if ($name =~ /^\[revoked/) {
@@ -258,6 +261,15 @@
   if (($sigcount{$id} eq ) and ($signedbycount{$id} eq ) and not $all) {
 next;
   }
+  if ($all) {
+$used_id = 0;
+for $owner (@idlist) {
+  if ($owner eq $id) {
+$used_id = 1;
+  }
+}
+  }
+  next if ($all and $used_id == 0);
   if ($color)
   {
 $red = $sigcount{$id} / $maxsigcount;


signature.asc
Description: Digital signature
---End Message---


signature.asc
Description: Digital signature