Bug#338976: [Pbuilder-maint] Bug#338976: pbuilder and /etc/shadow
Hi, > with this, you are just preventing the respective lines from being > executed. I guess you have BUILDUSERNAME unset (default)? > Maybe we should also "cat >>" to etc/shadow etc. if it doesn't exist? Hmm.. I doubt we need to create etc/shadow if it doesn't already exist (i.e. shadow password is disabled). It should just conditionally error out. regards, junichi -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#338976: pbuilder and /etc/shadow
On Mit, 16 Nov 2005, Roland Stigge wrote: > etc/shadow et al. So your solution was even right, but for the wrong > problem... ;) Well, it solved the problem that I needed to build some packages urgently ;-) Best wishes Norbert --- Dr. Norbert Preining Università di Siena gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094 --- BROUGH SOWERBY One who has been working at that same desk in the same office for fifteen years and has very much his own ideas about why he is continually passed over for promotion. --- Douglas Adams, The Meaning of Liff -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#338976: pbuilder and /etc/shadow
Norbert Preining wrote: >>with this, you are just preventing the respective lines from being >>executed. I guess you have BUILDUSERNAME unset (default)? >> >>Maybe we should also "cat >>" to etc/shadow etc. if it doesn't exist? > > > Well, I didn't say that this is the right solution. But what is *TRUE* > is that the check for -n is *WRONG* in any case, so it is useless to > have this check! Why would there be a check for -n if the variable is > either "su " or "su username"? In any case it is -n! So there is for > sure a failure. I guess dancer intended it for checking if the variable was set to anything (assuming that the default case is "" instead of "su "). I.e. in the default case without a special user, we wouldn't manipulate etc/shadow et al. So your solution was even right, but for the wrong problem... ;) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#338976: pbuilder and /etc/shadow
On Die, 15 Nov 2005, Roland Stigge wrote: > with this, you are just preventing the respective lines from being > executed. I guess you have BUILDUSERNAME unset (default)? > > Maybe we should also "cat >>" to etc/shadow etc. if it doesn't exist? Well, I didn't say that this is the right solution. But what is *TRUE* is that the check for -n is *WRONG* in any case, so it is useless to have this check! Why would there be a check for -n if the variable is either "su " or "su username"? In any case it is -n! So there is for sure a failure. Best wishes Norbert --- Dr. Norbert Preining Università di Siena gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094 --- Arthur felt at a bit of a loss. There was a whole Galaxy of stuff out there for him, and he wondered if it was churlish of him to complain to himself that it lacked just two things: the world he was born on and the woman he loved. --- Douglas Adams, The Hitchhikers Guide to the Galaxy -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#338976: pbuilder and /etc/shadow
Norbert, with this, you are just preventing the respective lines from being executed. I guess you have BUILDUSERNAME unset (default)? Maybe we should also "cat >>" to etc/shadow etc. if it doesn't exist? bye, Roland -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#338976: pbuilder and /etc/shadow
Package: pbuilder
Version: 0.138
Followup-For: Bug #338976
The following fixed the problem for me:
--- pbuilder-buildpackage-funcs.orig2005-11-14 20:51:07.0 +0100
+++ pbuilder-buildpackage-funcs 2005-11-14 20:51:55.0 +0100
@@ -81,7 +81,7 @@
function createbuilduser () {
# create the build user
-if [ -n "$SUTOUSER" ]; then
+if [ ! "$SUTOUSER" = "su " ]; then
if ! grep -q ^$BUILDUSERNAME: $BUILDPLACE/etc/passwd; then
cowprotect $BUILDPLACE/etc/passwd
echo
"$BUILDUSERNAME:x:$BUILDUSERID:$BUILDUSERID:,,,:/tmp/buildd:/bin/sh" >>
$BUILDPLACE/etc/passwd
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-1-k7
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages pbuilder depends on:
ii cdebootstrap 0.3.9 Bootstrap a Debian system
ii coreutils 5.93-2 The GNU core utilities
ii debianutils 2.15.1 Miscellaneous utilities specific t
ii gcc 4:4.0.2-1 The GNU C compiler
ii wget 1.10.2-1 retrieves files from the web
Versions of packages pbuilder recommends:
ii devscripts2.9.8 Scripts to make the life of a Debi
ii fakeroot 1.5.5 Gives a fake root environment
ii sudo 1.6.8p9-3 Provide limited super user privile
-- no debconf information
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
