Bug#387894: [Pkg-sysvinit-devel] Bug#387894: sysv-rc: progress bar
[Jean-Damien Durand] > abour progress bar, here are few fixes and suggestions. > > - in debug mode, probably the call to usplash_write should just be echoed Sounds good. > - the count of number of scripts executed is approximate v.s. what happens > in reality (check if file exist, check of previous runlevel, etc.) > - the computation of what fraction of the bar to fill is not guaranteed to > reach 0 or 100, because of rouding issues (100/3, then multiplied again) Right. Sounds like a good idea too. > Please find attached a patch for all these issues, where I > factorized the call to kill and start script in order to avoid code > duplication. I let you check and/or reject it, no pb! The patch change a lot of indentation, making it hard to track what are real changes and what are just tabs converted to spaces. It would be better with a patch without these irrelevant whitespace changes. > Tested with splashutils, not tested with bootsplash. Is it tested with usplash too? -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#387894: [Pkg-sysvinit-devel] Bug#387894: sysv-rc: progress bar
Dear Petter, The patch change a lot of indentation, making it hard to track what are real changes and what are just tabs converted to spaces. It would be better with a patch without these irrelevant whitespace changes. That is true. The factorization of kill and start scripts in two dedicated functions (to not duplicate the code: one call to count the number of scripts, one call to execute them) will probably make diff show a lot of lines anyway - I understand your point and can do nothing else but agree. I'll have another look but if I do not post again a patch that's because I could not make it smaller. Tested with splashutils, not tested with bootsplash. Is it tested with usplash too? No, with splashutils only. The $debug in front of the usplash_write will show very well what happens, and I believe this must work with usplash as well. Can somebody in your team do this thest? Anyway you have a point; this must be tested. I'll see what I can do in here (I have to install usplash; why not! I'll be happy to test it). Cheers, JD. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
