Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
* Daniel Kahn Gillmor [EMAIL PROTECTED] [2007-03-14 17:58]: I think i've addressed all these concerns now. i've published 3.01-2 into my apt repository, for your examination. My powerpc build machine is down right now, so 3.01-2 is only published for arm and i386 at the moment. I checked the package and I think that 3.01-2 has release quality. If you agree, I will upload it to unstable. My comments below are quite minor and you could implement them in a future version of the package. On Wed 2007-03-14 12:49:35 -0400, Rafael Laboissiere wrote: * debian/menu: [snip] Good call. i've created tweak-wrapper as a variant of your recommendation. I also linked in tweak-wrapper.1.gz to tweak.1.gz, since i don't think it warrants its own man page. You might implement a full debhelper solution by using dh_install and dh_links in conjunction with debian/install and debian/links (files attached below). There is an advantage in doing this: if one day you decide to switch to CDBS, then you could use an almost trivial debian/rules file, like the one attached below. * Makefile: + [snip] In the meanwhile, you have two options: 1) Use a patch management system (such as dpatch, quilt, or CDBS' simple-patchsys; I prefer the later because I am a CDBS adept). 2) Call make with the appropriate PREFIX and MANDIR settings in the command line i've gone with option 2, since it seems like the simplest approach for a tool that doesn't need patching otherwise. The variable DESTDIR is set in the command line, but does not appear in Makefile. You might drop this. + Most of the *.c files, as well as the *.but and *.h files are lacking copyright notice and licensing terms. We can assume that they are the same as in LICENCE, but the Debian standards require that every file must have those. Your package may be rejected due to that. Please, ask the upstream author to fix this. I spoke with Simon about this via e-mail, and he's understandably reluctant to make changes to 13 files in a relatively small package to satisfy a potentially theoretical concern, especially when LICENCE seems pretty clear-cut. I tend to agree with the author and I hope that the ftp-master admin will not see a problem. We could assume here a principle of least effort (or whatever), meaning that if a file is lacking the licensing terms, then the ones in LICENCE apply to it. Can you give me a reference to policy which states that *every* file must include a copyright notice and licensing information? Look, for instance, at the text of the GPL, around this excerpt: How to Apply These Terms to Your New Programs [snip] To do so, attach the following notices to the program. It is safest to attach them to the start of each source file to most effectively convey the exclusion of warranty; and each file should have at least the copyright line and a pointer to where the full notice is found. I made one other change: i included Simon's generated btree.html in docs/, since it seems relevant, small, and unobtrusive. Good idea. A debian/doc-base entry for it would be useful (see file attached below). I did this, but the .changes file doesn't get published to the apt repository via reprepro, afaict. Do you want me to send it on separately? Or is it published in some obscure way by reprepro that i'm missing? AFAICT, *.changes files do no appear in APT repositories. They are only used when uploading package and appear in debian-devel-changes. Anyway, I do not need your .changes file, since I always build sponsoree packages before uploading. One last thing: I was confused when I asked you to add my name to the Uploaders list. I am just sponsoring the package and am not co-maintaining it. Please, remove that in a future release of the package. -- Rafael debian/tweak-wrapper usr/bin tweak.1 usr/share/man/man1/tweak-wrapper.1 #!/usr/bin/make -f # -*- makefile -*- include /usr/share/cdbs/1/rules/debhelper.mk include /usr/share/cdbs/1/class/makefile.mk CFLAGS = -c -g -Wall -O2 DEB_MAKE_INSTALL_TARGET = PREFIX=$(CURDIR)/debian/tweak/usr MANDIR=$(CURDIR)/debian/tweak/usr/share/man/man1 install Document: tweak-btree Title: An Efficient Data Structure For A Hex Editor Author: Simon Tatham Abstract: FIXME Section: technical Format: html Index: /usr/share/doc/tweak/btree.html Files: /usr/share/doc/tweak/btree.html
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
* Rafael Laboissiere [EMAIL PROTECTED] [2007-03-15 08:57]: * Daniel Kahn Gillmor [EMAIL PROTECTED] [2007-03-14 17:58]: I made one other change: i included Simon's generated btree.html in docs/, since it seems relevant, small, and unobtrusive. Good idea. A debian/doc-base entry for it would be useful (see file attached below). Sorry, the Section field in this file must be Apps/Technical. -- Rafael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu 2007-03-15 03:57:19 -0400, Rafael Laboissiere wrote: I checked the package and I think that 3.01-2 has release quality. If you agree, I will upload it to unstable. My comments below are quite minor and you could implement them in a future version of the package. i've just uploaded 3.01-3 that addresses most of these issues, actually, since they're good ones. If you wouldn't mind looking over it, i'd prefer that one to be uploaded. You might implement a full debhelper solution by using dh_install and dh_links in conjunction with debian/install and debian/links (files attached below). There is an advantage in doing this: if one day you decide to switch to CDBS, then you could use an almost trivial debian/rules file, like the one attached below. This is a good suggestion. i've done it, without going whole hog CDBS. i'm inclined to trust you that it's a good idea, but i'd prefer to read up more on it before i make any changes. D'you have any preferred reading material other than what ships with the cdbs package? The alioth cdbs page [0] seems to have a bunch of broken links. :/ btw, the debian/links turned out to need usr/share/man/man1/tweak.1 usr/share/man/man1/tweak-wrapper.1 instead of tweak.1 usr/share/man/man1/tweak-wrapper.1 the latter gives a broken link to /tweak.1, apparently. from man dh_link: dh_link will generate symlinks that comply with debian policy - absolute when policy says they should be absolute, and relative links with as short a path as possible. It will also create any subdirectories it needs to to put the symlinks in. so it did a proper job of stripping the leading path elements. nice when a tool does the right thing! The variable DESTDIR is set in the command line, but does not appear in Makefile. You might drop this. ok, i've done that. i wasn't sure if DESTDIR was a commonly expected variable that we should be providing to any Makefile on principle. I tend to agree with the author and I hope that the ftp-master admin will not see a problem. We could assume here a principle of least effort (or whatever), meaning that if a file is lacking the licensing terms, then the ones in LICENCE apply to it. yeah. i think the direct statement from Simon is a pretty clear message as well. Thanks again for your prompt help with this. I learn a lot from these exchanges. --dkg [0] http://build-common.alioth.debian.org/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Processed by Mailcrypt 3.5.8+ http://mailcrypt.sourceforge.net/ iD8DBQFF+aRTiXTlFKVLY2URAmCNAJ43H43SH6OhMbEDxzzEwAt6FK95CACgqUul iXogBDg8qBA3Vb6iihZ+NKc= =up/h -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 2007-03-14 11:23:35 -0400, Rafael Laboissiere wrote: Okay, since I already sponsored a package from you, I am ready to do it again for this one. I will give you a feedback on the tweak package soon. Great! Thank you, Rafael. BTW, the ttf-fifthhorseman-dkg-handwriting package is still roting at the NEW queue, although it should be out soon, since it is at the top of the list. Thanks for the update. i've been keeping an eye on it here: http://ftp-master.debian.org/new.html Is that the best way to do this? --dkg -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Processed by Mailcrypt 3.5.8+ http://mailcrypt.sourceforge.net/ iD8DBQFF+BTPiXTlFKVLY2URAlGfAJ0dtg1qymkYIN09E5Ttusb8Eiie1gCgk0X4 4BSyt8PvO/O380ykiksyEkc= =e0ji -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
* Daniel Kahn Gillmor [EMAIL PROTECTED] [2007-03-14 00:17]: OK, i've packaged tweak version 3.01 now. I've published binary packages for i386, arm, and powerpc (and of course the source as well). They work for me on both etch and sid. The packages are in an apt repository located at: http://lair.fifthhorseman.net/~dkg/src/tweak/apt The repositories are signed by my GPG key, which is on the pgp.mit.edu and subkeys.pgp.net keyservers: ID: A54B6365 fingerprint: B599 41F7 41EA EAF8 726F 45D8 8974 E514 A54B 6365 As i'm not a debian developer, i'm going to need a sponsor for these packages. I welcome feedback on the packaging from anyone, whether you're willing to consider sponsoring or not. Okay, since I already sponsored a package from you, I am ready to do it again for this one. I will give you a feedback on the tweak package soon. BTW, the ttf-fifthhorseman-dkg-handwriting package is still roting at the NEW queue, although it should be out soon, since it is at the top of the list. Cheers, -- Rafael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
Daniel,
The package builds fine and is in a good shape. Thanks for your work. Here
are some (mostly minor) comments/suggestions:
* debian/rules:
+ Remove commented lines with dh_* commands
+ Add proper header with copyright notice and license terms
* debian/control:
+ Put my name and email address in the Uploaders field
+ Drop ${misc:Depends} from Depends
+ Reference the upstream website according to the guidelines in section
6.2.4 of the Debian Developer's Reference [1]. Also, although it is
nice to put the name of the upstream author in the Description, this is
not a common practice in Debian.
* debian/menu:
+ This file is useless without a call to dh_installmenu in debian/rules
+ At any rate, the menu entry does not work, because tweak needs a file
name as argument. You might add a tweak-wrapper script to the package
(example attached below) and update the debian/menu file accordingly.
* debian/dirs:
+ This file seems to be useless. Remove it.
* Makefile:
+ You seem to have patched the upstream Makefile and the differences
appear in the diff.gz file. Doing this is highly discouraged, because
updating to a subsequent version is error prone. You should try to get
your patch (or a variant of it) applied upstream. In the meanwhile, you
have two options:
1) Use a patch management system (such as dpatch, quilt, or CDBS'
simple-patchsys; I prefer the later because I am a CDBS adept).
2) Call make with the appropriate PREFIX and MANDIR settings in the
command line
* LICENCE:
+ Are the contents of this file some standard boilerplate? The licensing
conditions look DFSG-compliant, but you might ask in debian-legal, just
to be sure.
+ Most of the *.c files, as well as the *.but and *.h files are lacking
copyright notice and licensing terms. We can assume that they are the
same as in LICENCE, but the Debian standards require that every file
must have those. Your package may be rejected due to that. Please, ask
the upstream author to fix this.
If you generate a new version of the package, you could give it the version
number 3.01-2 and run debuild -sa -v3.01-0, such that both the orig.tar.gz
file name and the appropriate Closes: header appear in the *.changes file.
--
Rafael
#!/bin/sh
echo -n Edit file:
read file
/usr/bin/tweak $file
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
* Rafael Laboissiere [EMAIL PROTECTED] [2007-03-14 17:49]: * debian/control: [snip] + Reference the upstream website according to the guidelines in section 6.2.4 of the Debian Developer's Reference [1]. [snip] I forgot the link: [1] http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-bpp-upstream-info -- Rafael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks once again for the good feedback, Rafael. I'm working on these changes now. On Wed 2007-03-14 12:49:35 -0400, Rafael Laboissiere wrote: * LICENCE: + Are the contents of this file some standard boilerplate? The licensing conditions look DFSG-compliant, but you might ask in debian-legal, just to be sure. the license appears to be identical (save for linebreaks and identification of author/copyright holder) as the SPI/debian section in /usr/share/doc/xorg/copyright. I think it's the MIT license [0], no? --dkg [0] http://www.opensource.org/licenses/mit-license.php -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Processed by Mailcrypt 3.5.8+ http://mailcrypt.sourceforge.net/ iD8DBQFF+C9BiXTlFKVLY2URAtYEAKCQtGuJcfrsXb+8OtEudZx3EafklQCgx4sY U6Pz7Q5qLvm6GEGWIQLHg/g= =MUu2 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
* Daniel Kahn Gillmor [EMAIL PROTECTED] [2007-03-14 13:22]: On Wed 2007-03-14 12:49:35 -0400, Rafael Laboissiere wrote: * LICENCE: + Are the contents of this file some standard boilerplate? The licensing conditions look DFSG-compliant, but you might ask in debian-legal, just to be sure. the license appears to be identical (save for linebreaks and identification of author/copyright holder) as the SPI/debian section in /usr/share/doc/xorg/copyright. I think it's the MIT license [0], no? Yes, it is. Thanks for looking at this. I could have googled it before bugging you. I am so lazy... :-) -- Rafael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Rafael--
I think i've addressed all these concerns now. i've published 3.01-2
into my apt repository, for your examination. My powerpc build
machine is down right now, so 3.01-2 is only published for arm and
i386 at the moment.
On Wed 2007-03-14 12:49:35 -0400, Rafael Laboissiere wrote:
* debian/rules:
+ Remove commented lines with dh_* commands
+ Add proper header with copyright notice and license terms
this is done. i tend to get confused with the header requirements for
mostly-auto-generated files. If you think what i've got there is
inappropriate, i'm open to further suggestions.
* debian/control:
+ Put my name and email address in the Uploaders field
+ Drop ${misc:Depends} from Depends
+ Reference the upstream website according to the guidelines in section
6.2.4 of the Debian Developer's Reference [1]. Also, although it is
nice to put the name of the upstream author in the Description, this is
not a common practice in Debian.
Done. i think you taught me the upstream website reference on the
ttf-fifthhorseman-dkg-handwriting package. Sorry to have not retained
it properly.
I've also added a paragraph about the keybindings, since that's one of
the salient features of tweak. It also helps tweak show up if
someone does apt-cache search emacs hex :)
* debian/menu:
+ This file is useless without a call to dh_installmenu in debian/rules
+ At any rate, the menu entry does not work, because tweak needs a file
name as argument. You might add a tweak-wrapper script to the package
(example attached below) and update the debian/menu file accordingly.
Good call. i've created tweak-wrapper as a variant of your
recommendation. I also linked in tweak-wrapper.1.gz to tweak.1.gz,
since i don't think it warrants its own man page.
* debian/dirs:
+ This file seems to be useless. Remove it.
whoops! done.
* Makefile:
+ You seem to have patched the upstream Makefile and the differences
appear in the diff.gz file. Doing this is highly discouraged, because
updating to a subsequent version is error prone. You should try to get
your patch (or a variant of it) applied upstream. In the meanwhile, you
have two options:
1) Use a patch management system (such as dpatch, quilt, or CDBS'
simple-patchsys; I prefer the later because I am a CDBS adept).
2) Call make with the appropriate PREFIX and MANDIR settings in the
command line
i've gone with option 2, since it seems like the simplest approach for
a tool that doesn't need patching otherwise. unintrusive packaging is
a good thing.
+ Most of the *.c files, as well as the *.but and *.h files are lacking
copyright notice and licensing terms. We can assume that they are the
same as in LICENCE, but the Debian standards require that every file
must have those. Your package may be rejected due to that. Please, ask
the upstream author to fix this.
I spoke with Simon about this via e-mail, and he's understandably
reluctant to make changes to 13 files in a relatively small package to
satisfy a potentially theoretical concern, especially when LICENCE
seems pretty clear-cut. Can you give me a reference to policy which
states that *every* file must include a copyright notice and licensing
information? If the requirement is only that all the files must be
properly licensed, i think it's clear that they are, despite not
including any internal notice.
in [EMAIL PROTECTED] at
Wed, 14 Mar 2007 20:56:52 +, Simon Tatham wrote:
Daniel Kahn Gillmor [EMAIL PROTECTED] wrote:
snip
(it's pretty clear that LICENCE is intended to cover everything in
the package)
Just in case there's any lingering doubt: you and your sponsor are,
of course, both correct in this assumption.
I think i have Simon's permission to forward the full e-mail, so i can
send it on to you or to this bug if you'd prefer.
I made one other change: i included Simon's generated btree.html in
docs/, since it seems relevant, small, and unobtrusive.
On Wed 2007-03-14 12:49:35 -0400, Rafael Laboissiere wrote:
If you generate a new version of the package, you could give it the version
number 3.01-2 and run debuild -sa -v3.01-0, such that both the orig.tar.gz
file name and the appropriate Closes: header appear in the *.changes file.
I did this, but the .changes file doesn't get published to the apt
repository via reprepro, afaict. Do you want me to send it on
separately? Or is it published in some obscure way by reprepro that
i'm missing?
Thanks again for your prompt help with this package, Rafael.
--dkg
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ http://mailcrypt.sourceforge.net/
iD8DBQFF+HAKiXTlFKVLY2URAnAiAKCl4VfjYxCPdK7snLUVKscQnqVMJACgpMKJ
cyFCH9ausnELgu55g1q3M0g=
=66fr
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
Bug#414844: Acknowledgement (ITP: tweak -- an efficient hex editor)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 OK, i've packaged tweak version 3.01 now. I've published binary packages for i386, arm, and powerpc (and of course the source as well). They work for me on both etch and sid. The packages are in an apt repository located at: http://lair.fifthhorseman.net/~dkg/src/tweak/apt The repositories are signed by my GPG key, which is on the pgp.mit.edu and subkeys.pgp.net keyservers: ID: A54B6365 fingerprint: B599 41F7 41EA EAF8 726F 45D8 8974 E514 A54B 6365 As i'm not a debian developer, i'm going to need a sponsor for these packages. I welcome feedback on the packaging from anyone, whether you're willing to consider sponsoring or not. --dkg -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Processed by Mailcrypt 3.5.8+ http://mailcrypt.sourceforge.net/ iD8DBQFF93cqiXTlFKVLY2URAlZsAJ46mhm9tKsgVm2u4JiSg/FUnVWkEACeKWi9 ZDZBLgoLOI4PVY3bw9KXt0A= =uiMr -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
