Bug#448979: usplash: starts too late in the shutdown sequence

2008-05-24 Thread Petter Reinholdtsen 
[Maximilian Attems]
 no i meant that usplash is *enabled* unless you pass nosplash
 bootarg.  the change was made several revisions ago, an installed
 usplash is default enabled. so you have to grep for nosplash if
 you don't want unsplash to be shown on shutdown.

Right.  Here is an updated patch.  With this patch and the patch in
#482015, usplash should work properly at shutdown again.

diff -u usplash-0.5.19/debian/usplash.init usplash-0.5.19/debian/usplash.init
--- usplash-0.5.19/debian/usplash.init
+++ usplash-0.5.19/debian/usplash.init
@@ -32,6 +32,8 @@
 
 test -x $DAEMON || exit 0
 
+. /lib/init/splash-functions
+
 set -e
 
 usplash_quit() {
@@ -85,8 +87,20 @@
usplash_quit
;;
   stop)
-   if grep -q splash /proc/cmdline; then
-   usplash_write TIMEOUT 15
+   SPLASH=true
+   if [ -f /proc/cmdline ] ; then
+   for x in $(cat /proc/cmdline); do
+   case $x in
+   nosplash*)
+   SPLASH=false
+   ;;
+   esac
+   done
+   fi
+
+   if [ $SPLASH = true ] ; then
+   splash_start
+   splash_stop_indefinite
fi
;;
   *)



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#448979: usplash: starts too late in the shutdown sequence

2008-05-18 Thread Petter Reinholdtsen 

tags 448979 + patch
thanks

[David Härdeman]
 Would it perhaps be an idea to move the usplash startup to the
 usplash init.d script as it's stop action? Then the usplash init.d
 link could be moved from /etc/rc[06].d/K01usplash to
 /etc/rc[06].d/K02usplash (since gdm is at prio K01)?

I believe this is the correct approach to get usplash started on
systems without gdm and kdm installed.  Here is a patch to make sure
usplash is started during shutdown when the init.d script is executed.
With dependency based boot sequencing usplash is started very early in
the shutdown sequence, and this is sufficient to solve the issue.

This patch uses the new splash API presented to sysvinit, and rewrites
how the kernel arguments are parsed to make sure it is handled the
same way as in sendsigs.

diff -ur usplash-0.5.19/debian/usplash.init 
usplash-0.5.19-pere/debian/usplash.init
--- usplash-0.5.19/debian/usplash.init  2008-05-18 11:02:39.0 +0200
+++ usplash-0.5.19-pere/debian/usplash.init 2008-05-18 11:08:40.0 
+0200
@@ -32,6 +32,8 @@
 
 test -x $DAEMON || exit 0
 
+. /lib/init/splash-functions
+
 set -e
 
 usplash_quit() {
@@ -85,8 +87,20 @@
usplash_quit
;;
   stop)
-   if grep -q splash /proc/cmdline; then
-   usplash_write TIMEOUT 15
+   SPLASH=false
+   if [ -f /proc/cmdline ] ; then
+   for x in $(cat /proc/cmdline); do
+   case $x in
+   splash*)
+   SPLASH=true
+   ;;
+   esac
+   done
+   fi
+
+   if [ $SPLASH = true ] ; then
+   splash_start
+   splash_stop_indefinite
fi
;;
   *)

Please test this patch and let me know if it work.

Happy hacking,
-- 
Petter Reinholdtsen



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#448979: usplash: starts too late in the shutdown sequence

2008-05-18 Thread Petter Reinholdtsen 
[maximilian attems]
 aboves is wrong we assume usplash is running unless nosplash is
 given (yes the script is currently wrong too, there is another bug
 report on that).

I'm not sure I parse this correctly.  Do you mean that usplash should
be enabled when its package is installed, unless 'nosplash' is used as
a kernel argument?  I did not try to do that in my patch, as I was not
aware that this was the intended behaviour. :)

I hope a fix for this issue will make it to Lenny, as it make the
shutdown sequence in Debian Edu a lot better. :)

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#448979: usplash: starts too late in the shutdown sequence

2008-05-18 Thread maximilian attems 
On Sun, 18 May 2008, Petter Reinholdtsen wrote:

 
 tags 448979 + patch
 thanks
 
 [David Härdeman]
  Would it perhaps be an idea to move the usplash startup to the
  usplash init.d script as it's stop action? Then the usplash init.d
  link could be moved from /etc/rc[06].d/K01usplash to
  /etc/rc[06].d/K02usplash (since gdm is at prio K01)?
 
 I believe this is the correct approach to get usplash started on
 systems without gdm and kdm installed.  Here is a patch to make sure
 usplash is started during shutdown when the init.d script is executed.
 With dependency based boot sequencing usplash is started very early in
 the shutdown sequence, and this is sufficient to solve the issue.
 
 This patch uses the new splash API presented to sysvinit, and rewrites
 how the kernel arguments are parsed to make sure it is handled the
 same way as in sendsigs.

thanks just a quick review.
 
 diff -ur usplash-0.5.19/debian/usplash.init 
 usplash-0.5.19-pere/debian/usplash.init
 --- usplash-0.5.19/debian/usplash.init2008-05-18 11:02:39.0 
 +0200
 +++ usplash-0.5.19-pere/debian/usplash.init   2008-05-18 11:08:40.0 
 +0200
 @@ -32,6 +32,8 @@
  
  test -x $DAEMON || exit 0
  
 +. /lib/init/splash-functions
 +
  set -e
  
  usplash_quit() {
 @@ -85,8 +87,20 @@
   usplash_quit
   ;;
stop)
 - if grep -q splash /proc/cmdline; then
 - usplash_write TIMEOUT 15
 + SPLASH=false
 + if [ -f /proc/cmdline ] ; then
 + for x in $(cat /proc/cmdline); do
 + case $x in
 + splash*)
 + SPLASH=true
 + ;;
 + esac
 + done
 + fi
 +
 + if [ $SPLASH = true ] ; then
 + splash_start
 + splash_stop_indefinite
   fi
   ;;
*)

aboves is wrong we assume usplash is running unless nosplash is
given (yes the script is currently wrong too, there is another
bug report on that).
 
happy weekend

-- 
maks



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#448979: usplash: starts too late in the shutdown sequence

2008-05-18 Thread maximilian attems 
On Sun, 18 May 2008, Petter Reinholdtsen wrote:

 [maximilian attems]
  aboves is wrong we assume usplash is running unless nosplash is
  given (yes the script is currently wrong too, there is another bug
  report on that).
 
 I'm not sure I parse this correctly.  Do you mean that usplash should
 be enabled when its package is installed, unless 'nosplash' is used as
 a kernel argument?  I did not try to do that in my patch, as I was not
 aware that this was the intended behaviour. :)

no i meant that usplash is *enabled* unless you pass nosplash bootarg.
the change was made several revisions ago, an installed usplash
is default enabled. so you have to grep for nosplash if you don't want
unsplash to be shown on shutdown.
 
 I hope a fix for this issue will make it to Lenny, as it make the
 shutdown sequence in Debian Edu a lot better. :)

cool.

-- 
maks



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#448979: usplash: starts too late in the shutdown sequence

2007-11-01 Thread David Härdeman 

Package: usplash
Version: 0.5.2-3
Severity: normal

Currently usplash is started again on shutdown by S20sendsigs in 
/etc/rc[06].d which is quite late as all the K* scripts will already 
have been executed by then (giving a long period of text to look at 
first).


Would it perhaps be an idea to move the usplash startup to the usplash 
init.d script as it's stop action? Then the usplash init.d link could be 
moved from /etc/rc[06].d/K01usplash to /etc/rc[06].d/K02usplash (since 
gdm is at prio K01)?


--
David Härdeman