Bug#492329: asterisk: Move chan_vpb.so dependencies to 'Suggests'

2013-10-01 Thread Tzafrir Cohen
On Fri, Jul 25, 2008 at 11:33:57AM +0100, Tim Retout wrote:

 Not everyone uses VoiceTronix hardware; I have been told that the vpb channel
 is still unstable, and would prefer not to install libvpb.

Upstream set the module chan_vpb as disabled by default somewhere
between versions 1.8 and 11. I forgot about it and thus the current
package does not build the module. This should be fixed in the next
upload (which should be soon, the package FTBFS). But I'll use this
excuse to ask the following question:

I wonder if moving it to a subpackage makes more sense now.
* Now that dahdi is on a separate sub-package, libvpb is the only one
  pulling, by recommendation, module-assistant.
* libvpb0 has a high-priority debconf question. Having it with such a
  high priority does not make sense if most of the users installing it
  install it just for Asterisk.

So, a separate subpackagee?

-- 
   Tzafrir Cohen
icq#16849755  jabber:tzafrir.co...@xorcom.com
+972-50-7952406   mailto:tzafrir.co...@xorcom.com
http://www.xorcom.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#492329: asterisk: Move chan_vpb.so dependencies to 'Suggests'

2012-04-24 Thread Tzafrir Cohen
Revisiting an old wishlist bug,

On Fri, Jul 25, 2008 at 06:34:49PM +0300, Faidon Liambotis wrote:
 Tim Retout wrote:
  Not everyone uses VoiceTronix hardware; I have been told that the vpb 
  channel
  is still unstable, and would prefer not to install libvpb.
  
  The attached patch sets some dh_shlibdeps options, to move the dependencies
  of this one channel into 'Suggests'. Splitting it out into a separate 
  package
  seemed like overkill (c.f. #459244). It would be possible to bring it back
  into 'Depends' or 'Recommends' when the module is stable.
  
  The same method could be used to move more non-core asterisk dependencies 
  into
  'Recommends'. These would still be installed by default, but could be
  removed by the administrator.
 There is no way we're going to do that; I believe it is the wrong way 
 and my gut tells me that it may also be a policy violation, but I 
 haven't checked.
 
 Splitting chan_vpb to a different package is something we can discuss 
 though. We've done this before for chan_h323, it's only fair to consider 
 it for chan_vpb.
 
 Besides the obvious bloat of having libvpb installed, do you have any 
 other issues with it?

One minor issue: libvpb has a high-priority debconf question, and most
people don't really care about it. I suppose most of the people who
install libvpb0 installed it as it is a dependency of Asterisk and don't
really need it as a high-priority debconf question.

-- 
   Tzafrir Cohen
icq#16849755  jabber:tzafrir.co...@xorcom.com
+972-50-7952406   mailto:tzafrir.co...@xorcom.com
http://www.xorcom.com  iax:gu...@local.xorcom.com/tzafrir



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#492329: asterisk: Move chan_vpb.so dependencies to 'Suggests'

2008-07-25 Thread Tim Retout
Package: asterisk
Version: 1:1.4.20~dfsg-1
Severity: wishlist
Tags: patch

Not everyone uses VoiceTronix hardware; I have been told that the vpb channel
is still unstable, and would prefer not to install libvpb.

The attached patch sets some dh_shlibdeps options, to move the dependencies
of this one channel into 'Suggests'. Splitting it out into a separate package
seemed like overkill (c.f. #459244). It would be possible to bring it back
into 'Depends' or 'Recommends' when the module is stable.

The same method could be used to move more non-core asterisk dependencies into
'Recommends'. These would still be installed by default, but could be
removed by the administrator.

(I did have one issue where symbol versioning caused libstdc++6 to be
repeated in Suggests, but that does not seem to happen with asterisk from
pkg-voip svn.)

--
Tim Retout [EMAIL PROTECTED]
commit ffe5319c612cb4c49ec4f1a53ffca8e6b43d87bc
Author: Tim Retout [EMAIL PROTECTED]
Date:   Fri Jul 25 10:06:32 2008 +0100

Move chan_vpb.so dependencies into 'Suggests'.

diff --git a/debian/control b/debian/control
index e0d7f11..985387e 100644
--- a/debian/control
+++ b/debian/control
@@ -16,7 +16,7 @@ Depends: ${shlibs:Depends}, asterisk-config (= 
${source:Version}) | asterisk-con
 Conflicts: asterisk-classic, asterisk-bristuff, asterisk-chan-capi ( 
1.1.1-1~)
 Replaces: asterisk-classic, asterisk-bristuff
 Provides: asterisk-1.4
-Suggests: ekiga, ohphone, twinkle, kphone, asterisk-doc, asterisk-dev, 
asterisk-h323
+Suggests: ${shlibs:Suggests}, ekiga, ohphone, twinkle, kphone, asterisk-doc, 
asterisk-dev, asterisk-h323
 Description: Open Source Private Branch Exchange (PBX)
  Asterisk is an Open Source PBX and telephony toolkit.  It is, in a
  sense, middleware between Internet and telephony channels on the bottom,
diff --git a/debian/rules b/debian/rules
index 19c62e0..99d4032 100755
--- a/debian/rules
+++ b/debian/rules
@@ -209,7 +209,9 @@ binary-arch: install-arch
dh_installdeb -a
rm -f debian/asterisk/usr/lib/asterisk/modules/chan_h323.so
dh_makeshlibs -a 
-   dh_shlibdeps -a
+   dh_shlibdeps -a -X/usr/lib/asterisk/modules/chan_vpb.so -- \
+   -dSuggests debian/asterisk/usr/lib/asterisk/modules/chan_vpb.so \
+   -dDepends
dh_gencontrol -a
dh_md5sums -a
dh_builddeb -a


Bug#492329: asterisk: Move chan_vpb.so dependencies to 'Suggests'

2008-07-25 Thread Ron
On Fri, Jul 25, 2008 at 11:33:57AM +0100, Tim Retout wrote:
 Not everyone uses VoiceTronix hardware; I have been told that the vpb channel
 is still unstable, and would prefer not to install libvpb.

Interesting.  Have you talked to VoiceTronix about this?  Have you
experienced problems personally that you wish to report?

Dare I ask, do you believe everything you hear about asterisk?

 The attached patch sets some dh_shlibdeps options, to move the dependencies
 of this one channel into 'Suggests'. Splitting it out into a separate package
 seemed like overkill (c.f. #459244). It would be possible to bring it back
 into 'Depends' or 'Recommends' when the module is stable.

And how do you plan to gauge that?

 The same method could be used to move more non-core asterisk dependencies into
 'Recommends'. These would still be installed by default, but could be
 removed by the administrator.

I'd be all for making most of the hard dependencies this package has
accrued more loose, but lying about the package dependencies in a way
that _will_ make chan_vpb break for people doesn't quite seem like the
best way to do that.

You should probably talk to upstream about making their dependencies
more modular or something if you dislike the number of things it
requires that you personally don't need or want.

HTH,
Ron





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#492329: asterisk: Move chan_vpb.so dependencies to 'Suggests'

2008-07-25 Thread Faidon Liambotis

Tim Retout wrote:

Not everyone uses VoiceTronix hardware; I have been told that the vpb channel
is still unstable, and would prefer not to install libvpb.

The attached patch sets some dh_shlibdeps options, to move the dependencies
of this one channel into 'Suggests'. Splitting it out into a separate package
seemed like overkill (c.f. #459244). It would be possible to bring it back
into 'Depends' or 'Recommends' when the module is stable.

The same method could be used to move more non-core asterisk dependencies into
'Recommends'. These would still be installed by default, but could be
removed by the administrator.
There is no way we're going to do that; I believe it is the wrong way 
and my gut tells me that it may also be a policy violation, but I 
haven't checked.


Splitting chan_vpb to a different package is something we can discuss 
though. We've done this before for chan_h323, it's only fair to consider 
it for chan_vpb.


Besides the obvious bloat of having libvpb installed, do you have any 
other issues with it?


Thanks,
Faidon



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#492329: asterisk: Move chan_vpb.so dependencies to 'Suggests'

2008-07-25 Thread Tim Retout
On Fri, 2008-07-25 at 18:34 +0300, Faidon Liambotis wrote:
 Tim Retout wrote:
  The same method could be used to move more non-core asterisk dependencies 
  into
  'Recommends'. These would still be installed by default, but could be
  removed by the administrator.
 There is no way we're going to do that; I believe it is the wrong way 
 and my gut tells me that it may also be a policy violation, but I 
 haven't checked.

Well, policy 7.2 says that 'Recommends' is a strong but not absolute
dependency, and 'Depends' are the absolute ones.  I think that many of
the asterisk 'Depends' fall into the former rather than the latter; not
every asterisk installation requires every asterisk dependency.

For instance, I can see asterisk dependencies on libpq5, libsqlite0,
unixodbc, libpri1.0, libsnmp15... if someone is just using SIP, they may
well not want to have all these other dependencies installed.

Recommended packages are still installed by default with both apt-get
and aptitude, so this should not break anyone's installation.

 Splitting chan_vpb to a different package is something we can discuss 
 though. We've done this before for chan_h323, it's only fair to consider 
 it for chan_vpb.

Or that would work. :) So long as we can avoid splitting asterisk into
dozens of packages, as discussed on #459244.

 Besides the obvious bloat of having libvpb installed, do you have any 
 other issues with it?

I've chatted to Ron on IRC, and suspect the crashes our customer
experienced were a corner case not caught by the patch to #466729 in the
version of asterisk that I backported to etch. They may well be fixed in
Debian by now.

-- 
Tim Retout [EMAIL PROTECTED]




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]