Bug#521027: (no subject)

2009-04-09 Thread Thomas Lange
Just for the record.
This bug is only valid for squeeze and later, not for lenny.
-- 
regards Thomas



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#521027: (no subject)

2009-04-09 Thread Holger Levsen
Hi,

On Donnerstag, 9. April 2009, Thomas Lange wrote:
> This bug is only valid for squeeze and later, not for lenny.

huh? how is missing depends not relevant for lenny?

also you could use tags to express that information ;-)


regards,
Holger



signature.asc
Description: This is a digitally signed message part.


Bug#521027: (no subject)

2009-04-09 Thread Thomas Lange
One part of the patch in experimental (which replaces ifconfig with ip
calls) removes the variable $mask, so that now the NFSROOT is only
exported to the IP address of the server. I'm pretty sure this will
break things. Or did I overlooked something?

-- 
regards Thomas



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#521027: (no subject)

2009-04-09 Thread Michael Tautschnig
> One part of the patch in experimental (which replaces ifconfig with ip
> calls) removes the variable $mask, so that now the NFSROOT is only
> exported to the IP address of the server. I'm pretty sure this will
> break things. Or did I overlooked something?
> 

ip addr includes the mask in the output, so it would be there rightaway, like
this:

mole:~# ip addr show dev eth0
2: eth0:  mtu 1500 qdisc pfifo_fast qlen 1000
link/ether 00:14:4f:9e:af:b0 brd ff:ff:ff:ff:ff:ff
inet 130.83.161.196/27 brd 130.83.161.223 scope global eth0
inet6 fe80::214:4fff:fe9e:afb0/64 scope link 
   valid_lft forever preferred_lft forever

The patch, however, indeed seems to be broken because of the cut -d / -f 1,
which drops the mask. Luk (BCC'ed), could you comment on that?

Best,
Michael



pgpWEoAkzOGZh.pgp
Description: PGP signature


Bug#521027: (no subject)

2009-04-09 Thread Thomas Lange
> On Thu, 9 Apr 2009 19:30:53 +0200, Michael Tautschnig  
> said:

> ip addr includes the mask in the output, so it would be there rightaway, 
like
> this:

Yep, if if also contains the mask it will work. Seems fine to me, but 
I have to check some other things before including the patch.

-- 
regards Thomas



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#521027: (no subject)

2009-04-09 Thread Michael Tautschnig
> > On Thu, 9 Apr 2009 19:30:53 +0200, Michael Tautschnig  
> > said:
> 
> > ip addr includes the mask in the output, so it would be there 
> rightaway, like
> > this:
> 
> Yep, if if also contains the mask it will work. Seems fine to me, but 
> I have to check some other things before including the patch.
> 

But you also noticed the part if wrote after the ip addr output, didn't you?
(that is, the current patch is broken with respect to the mask.)

Best,
Michael



pgpa7rjIDQFR4.pgp
Description: PGP signature


Bug#521027: (no subject)

2009-04-09 Thread Luk Claes
Michael Tautschnig wrote:
>> One part of the patch in experimental (which replaces ifconfig with ip
>> calls) removes the variable $mask, so that now the NFSROOT is only
>> exported to the IP address of the server. I'm pretty sure this will
>> break things. Or did I overlooked something?
>>
> 
> ip addr includes the mask in the output, so it would be there rightaway, like
> this:
> 
> mole:~# ip addr show dev eth0
> 2: eth0:  mtu 1500 qdisc pfifo_fast qlen 1000
> link/ether 00:14:4f:9e:af:b0 brd ff:ff:ff:ff:ff:ff
> inet 130.83.161.196/27 brd 130.83.161.223 scope global eth0
> inet6 fe80::214:4fff:fe9e:afb0/64 scope link 
>valid_lft forever preferred_lft forever
> 
> The patch, however, indeed seems to be broken because of the cut -d / -f 1,
> which drops the mask. Luk (BCC'ed), could you comment on that?

Well, it was only being used for single IPs anyway, so the netmask
doesn't make any difference AFAICS. Though feel free to adjust to also
use the netmask if you like it better.

Cheers

Luk



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org