Bug#529515: emacs22-common: mml-secure-message-sign does not sign entire message

[Sven Joachim]

On 2010-04-11 16:57 +0200, Ansgar Burchardt wrote:

> package emacs22-common
> notforwarded 529515
> thanks
>
> Hi,
>
> I think something went wrong when forwarding this message: I cannot find
> it in Gmane's archive.

Yes, looks like it did not arrive. :-(

> Also, is d...@gnus.org the correct upstream?

Yes, although it might be better to use the Emacs bug tracker these days.

> I noticed that their CVS [1] does not include mml-sec.el.

Strange, it is definitely present in my up-to-date checkout:

,
| /usr/local/src/gnus% cvs status lisp/mml-sec.el
| ===
| File: mml-sec.elStatus: Up-to-date
| 
|Working revision:7.27
|Repository revision: 7.27/usr/local/cvsroot/gnus/lisp/mml-sec.el,v
|Sticky Tag:  (none)
|Sticky Date: (none)
|Sticky Options:  (none)
| 
`

> In a related note, this bug is still present in emacs23 (23.1+1-5).

It might be best to send it to bug-gnu-em...@gnu.org.  You can reuse
your original report, just edit the "Package" pseudo-header to say
"emacs,gnus" and remove the "Version" pseudo-header.

Regards,
Sven



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#529515: emacs22-common: mml-secure-message-sign does not sign entire message

[Ansgar Burchardt]

package emacs22-common
notforwarded 529515
thanks

Hi,

I think something went wrong when forwarding this message: I cannot find
it in Gmane's archive.  Also, is d...@gnus.org the correct upstream?  I
noticed that their CVS [1] does not include mml-sec.el.

In a related note, this bug is still present in emacs23 (23.1+1-5).

Regards,
Ansgar

[1] 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#529515: emacs22-common: mml-secure-message-sign does not sign entire message

[Ansgar Burchardt]

Package: emacs22-common
Version: 22.3+1-1
Severity: normal
Tags: patch

Hi,

the `mml-secure-message-sign' function only signs the current part, as
does the `mml-secure-sign' function.  It is supposed to sign the entire
message instead (see the other `mml-secure-message-*' functions).

Please consider applying the attached patch.

Regards,
Ansgar

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.29-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages emacs22-common depends on:
ii  dpkg  1.14.26Debian package management system
ii  emacsen-common1.4.17 Common facilities for all emacsen

emacs22-common recommends no packages.

Versions of packages emacs22-common suggests:
ii  emacs22-common-non-dfsg   22.3+1-1   GNU Emacs shared, architecture ind
ii  emacs22-el22.3+1-1   GNU Emacs LISP (.el) files

-- no debconf information
>From 3c3d05460a87a95130f6de1995bc7b7e69ae4446 Mon Sep 17 00:00:00 2001
From: Ansgar Burchardt 
Date: Tue, 19 May 2009 21:16:41 +0200
Subject: [PATCH] mml-secure-message-sign: sign entire message

The function `mml-secure-message-sign' did only sign the current part
instead of the entire message.

Signed-off-by: Ansgar Burchardt 
---
 lisp/gnus/mml-sec.el |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 7845cfd..a8ec9c7 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -274,11 +274,11 @@ Use METHOD if given.  Else use `mml-secure-method' or
 
 
 (defun mml-secure-message-sign (&optional method)
-  "Add MML tags to sign this MML part.
+  "Add MML tags to sign the entire message.
 Use METHOD if given. Else use `mml-secure-method' or
 `mml-default-sign-method'."
   (interactive)
-  (mml-secure-part
+  (mml-secure-message
(or method mml-secure-method mml-default-sign-method)
'sign))
 
-- 
1.6.2.4