Bug#548681: videolink: Transition to xulrunner 1.9.1
On Sun, 2009-10-04 at 08:31 +0200, Mike Hommey wrote: On Sat, Oct 03, 2009 at 09:55:20PM +0100, Ben Hutchings wrote: Any HTML file will do. If I remember correctly, this interface lookup in conversion_window::process() now fails: nsCOMPtrnsIDocShell doc_shell(do_GetInterface(browser)); Did you really build against xulrunner-dev 1.9.1, then ? Because it seems to work for me (with --preview, without, I only get a complain that RANDR is missing on :10.0) Works for me, too. It seemt shtat nsIDocShell changed, along with its UUID, between 1.9 and 1.9.1. In that case, I should set the version requirement depending on the version of the build environment. Remind me what the purpose of these GRE version specifications is again? ;-) Ben. -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure. signature.asc Description: This is a digitally signed message part
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Tue, Oct 06, 2009 at 04:42:39AM +0100, Ben Hutchings wrote: On Sun, 2009-10-04 at 08:31 +0200, Mike Hommey wrote: On Sat, Oct 03, 2009 at 09:55:20PM +0100, Ben Hutchings wrote: Any HTML file will do. If I remember correctly, this interface lookup in conversion_window::process() now fails: nsCOMPtrnsIDocShell doc_shell(do_GetInterface(browser)); Did you really build against xulrunner-dev 1.9.1, then ? Because it seems to work for me (with --preview, without, I only get a complain that RANDR is missing on :10.0) Works for me, too. It seemt shtat nsIDocShell changed, along with its UUID, between 1.9 and 1.9.1. In that case, I should set the version requirement depending on the version of the build environment. Remind me what the purpose of these GRE version specifications is again? ;-) For the theorical case where you build a special version that is able to use both versions of the ABI. I think anybody trying to do that will lose his mind first. ;) Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Sat, Oct 03, 2009 at 09:55:20PM +0100, Ben Hutchings wrote: Any HTML file will do. If I remember correctly, this interface lookup in conversion_window::process() now fails: nsCOMPtrnsIDocShell doc_shell(do_GetInterface(browser)); Did you really build against xulrunner-dev 1.9.1, then ? Because it seems to work for me (with --preview, without, I only get a complain that RANDR is missing on :10.0) Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Mon, Sep 28, 2009 at 04:51:57AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 13:10 +0200, Mike Hommey wrote: On Mon, Sep 28, 2009 at 03:46:20AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 08:16 +0200, Mike Hommey wrote: Package: videolink Severity: important Tags: patch Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime soonish, so videolink should switch to using it. As a matter of being future-proof, a dh_xulrunner program has been added to xulrunner-dev, that will add the proper dependency to shlibs:Depends. Please note that the package supporting this command is not yet in the archive and should reach experimental some time today. The attached patch implements the necessary changes[1], [...] No it does not. Some substantial source changes appear to be needed as well. :-( Mmmm that's surprising, as standard browsers such as galeon and epiphany only need a rebuild. Does it totally fail to build or is it a runtime problem? It's a run-time problem - VideoLink depends on some interfaces which are no longer implemented by the same objects. Do you have a set of example files so that I can test a locally built package? Cheers, Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Sat, 2009-10-03 at 21:04 +0200, Mike Hommey wrote: On Mon, Sep 28, 2009 at 04:51:57AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 13:10 +0200, Mike Hommey wrote: On Mon, Sep 28, 2009 at 03:46:20AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 08:16 +0200, Mike Hommey wrote: Package: videolink Severity: important Tags: patch Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime soonish, so videolink should switch to using it. As a matter of being future-proof, a dh_xulrunner program has been added to xulrunner-dev, that will add the proper dependency to shlibs:Depends. Please note that the package supporting this command is not yet in the archive and should reach experimental some time today. The attached patch implements the necessary changes[1], [...] No it does not. Some substantial source changes appear to be needed as well. :-( Mmmm that's surprising, as standard browsers such as galeon and epiphany only need a rebuild. Does it totally fail to build or is it a runtime problem? It's a run-time problem - VideoLink depends on some interfaces which are no longer implemented by the same objects. Do you have a set of example files so that I can test a locally built package? Any HTML file will do. If I remember correctly, this interface lookup in conversion_window::process() now fails: nsCOMPtrnsIDocShell doc_shell(do_GetInterface(browser)); Ben. -- Ben Hutchings Always try to do things in chronological order; it's less confusing that way. signature.asc Description: This is a digitally signed message part
Bug#548681: videolink: Transition to xulrunner 1.9.1
Package: videolink
Severity: important
Tags: patch
Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime
soonish, so videolink should switch to using it.
As a matter of being future-proof, a dh_xulrunner program has been added
to xulrunner-dev, that will add the proper dependency to shlibs:Depends.
Please note that the package supporting this command is not yet in the
archive and should reach experimental some time today.
The attached patch implements the necessary changes[1], please upload to
unstable as soon as possible. The package will then be dep-wait, and will
get built as soon as xulrunner 1.9.1 reaches unstable, which will happen
when all the changes required on other packages will be ready.
Cheers,
Mike
1. Please note that this patch still hardcodes the GREVersionRange, which
is not really future-proof. Something similar to what exists in chmsee would
be required for that.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -ruN videolink-1.2.8/browser_widget.cpp videolink-1.2.8.new/browser_widget.cpp
--- videolink-1.2.8/browser_widget.cpp
+++ videolink-1.2.8.new/browser_widget.cpp
@@ -532,8 +532,8 @@
{
#if MOZ_VERSION_MAJOR == 1 MOZ_VERSION_MINOR == 9
static const GREVersionRange gre_versions = {
- 1.9a, PR_TRUE,
- 1.9.1, PR_FALSE
+ 1.9.1, PR_TRUE,
+ 1.9.2, PR_FALSE
};
char path[PATH_MAX];
check(GRE_GetGREPathWithProperties(gre_versions, 1, 0, 0,
diff -ruN videolink-1.2.8/debian/control videolink-1.2.8.new/debian/control
--- videolink-1.2.8/debian/control
+++ videolink-1.2.8.new/debian/control
@@ -2,14 +2,14 @@
Maintainer: Ben Hutchings b...@decadent.org.uk
Section: contrib/video
Priority: extra
-Build-Depends: debhelper (=4), libgtkmm-2.4-dev, xulrunner-dev, libexpat1-dev
+Build-Depends: debhelper (=4), libgtkmm-2.4-dev, xulrunner-dev (= 1.9.1.3-2), libexpat1-dev
Standards-Version: 3.8.0
Vcs-Browser: http://git.decadent.org.uk/gitweb?p=videolink.git
Vcs-Git: http://git.decadent.org.uk/git/videolink.git
Package: videolink
Architecture: any
-Depends: xvfb, dvdauthor, ffmpeg | mjpegtools, ffmpeg | netpbm, xulrunner-1.9, ${shlibs:Depends}
+Depends: xvfb, dvdauthor, ffmpeg | mjpegtools, ffmpeg | netpbm, ${shlibs:Depends}
Recommends: genisoimage, xfonts-base
Description: assembles a DVD video filesystem from HTML pages and video files
VideoLink is intended to provide a simple way of producing DVDs with
diff -ruN videolink-1.2.8/debian/rules videolink-1.2.8.new/debian/rules
--- videolink-1.2.8/debian/rules
+++ videolink-1.2.8.new/debian/rules
@@ -10,6 +10,7 @@
$(MAKE) DESTDIR=debian/videolink prefix=/usr install
dh_strip
dh_shlibdeps
+ dh_xulrunner
mkdir -p -m755 debian/videolink/usr/share/doc/videolink
install -m644 debian/copyright debian/videolink/usr/share/doc/videolink/copyright
mv debian/videolink/usr/share/doc/videolink/ChangeLog.gz \
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Mon, 2009-09-28 at 08:16 +0200, Mike Hommey wrote: Package: videolink Severity: important Tags: patch Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime soonish, so videolink should switch to using it. As a matter of being future-proof, a dh_xulrunner program has been added to xulrunner-dev, that will add the proper dependency to shlibs:Depends. Please note that the package supporting this command is not yet in the archive and should reach experimental some time today. The attached patch implements the necessary changes[1], [...] No it does not. Some substantial source changes appear to be needed as well. :-( Ben. -- Ben Hutchings Any sufficiently advanced bug is indistinguishable from a feature. signature.asc Description: This is a digitally signed message part
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Mon, Sep 28, 2009 at 03:46:20AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 08:16 +0200, Mike Hommey wrote: Package: videolink Severity: important Tags: patch Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime soonish, so videolink should switch to using it. As a matter of being future-proof, a dh_xulrunner program has been added to xulrunner-dev, that will add the proper dependency to shlibs:Depends. Please note that the package supporting this command is not yet in the archive and should reach experimental some time today. The attached patch implements the necessary changes[1], [...] No it does not. Some substantial source changes appear to be needed as well. :-( Mmmm that's surprising, as standard browsers such as galeon and epiphany only need a rebuild. Does it totally fail to build or is it a runtime problem? Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Mon, Sep 28, 2009 at 04:51:57AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 13:10 +0200, Mike Hommey wrote: On Mon, Sep 28, 2009 at 03:46:20AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 08:16 +0200, Mike Hommey wrote: Package: videolink Severity: important Tags: patch Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime soonish, so videolink should switch to using it. As a matter of being future-proof, a dh_xulrunner program has been added to xulrunner-dev, that will add the proper dependency to shlibs:Depends. Please note that the package supporting this command is not yet in the archive and should reach experimental some time today. The attached patch implements the necessary changes[1], [...] No it does not. Some substantial source changes appear to be needed as well. :-( Mmmm that's surprising, as standard browsers such as galeon and epiphany only need a rebuild. Does it totally fail to build or is it a runtime problem? It's a run-time problem - VideoLink depends on some interfaces which are no longer implemented by the same objects. Dammit :( Do you have specifics ? Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#548681: videolink: Transition to xulrunner 1.9.1
On Mon, 2009-09-28 at 13:10 +0200, Mike Hommey wrote: On Mon, Sep 28, 2009 at 03:46:20AM -0700, Ben Hutchings wrote: On Mon, 2009-09-28 at 08:16 +0200, Mike Hommey wrote: Package: videolink Severity: important Tags: patch Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime soonish, so videolink should switch to using it. As a matter of being future-proof, a dh_xulrunner program has been added to xulrunner-dev, that will add the proper dependency to shlibs:Depends. Please note that the package supporting this command is not yet in the archive and should reach experimental some time today. The attached patch implements the necessary changes[1], [...] No it does not. Some substantial source changes appear to be needed as well. :-( Mmmm that's surprising, as standard browsers such as galeon and epiphany only need a rebuild. Does it totally fail to build or is it a runtime problem? It's a run-time problem - VideoLink depends on some interfaces which are no longer implemented by the same objects. Ben. -- Ben Hutchings Any sufficiently advanced bug is indistinguishable from a feature. signature.asc Description: This is a digitally signed message part
