Bug#568477: Bug#581511: also needed for cups-pk-helper support
Le samedi 31 juillet 2010 à 13:53 +0200, Michael Biebl a écrit : # These come from system-config-printer import config import cupshelpers, options from optionwidgets import OptionWidget from smburi import SMBURI from debug import * An alternative solution to splitting s-c-p could be, to move the necessary classes into python-cupshelpers. TBH I dunno which solution is better/cleaner. IMO the clean solution is to let s-c-p-kde only rely on public interfaces and to put all these interfaces in the public cupshelpers namespace and in the python-cupshelpers package. -- .''`. Josselin Mouette : :' : `. `' “If you behave this way because you are blackmailed by someone, `-[…] I will see what I can do for you.” -- Jörg Schilling signature.asc Description: This is a digitally signed message part
Bug#568477: Bug#581511: also needed for cups-pk-helper support
Hi Michael,
On Fri, Jul 30, 2010 at 08:13:51PM +0200, Michael Biebl wrote:
On 30.07.2010 19:26, Guido Günther wrote:
On Thu, Jul 29, 2010 at 11:18:14AM +0200, Guido Günther wrote:
On Wed, Jul 28, 2010 at 04:08:17PM +0200, Guido Günther wrote:
[..snip..]
- I'm not a python packager, but the python bits are installed as
/usr/lib/python2.6/site-packages/cupshelpers/*.
Shouldn't the python-cupsutils package be renamed to python-cupshelpers?
Think so. But we can make the renaming with system-config-printer -
sytem-config-printer-gnome in one go.
I've renamed python-cupsutils to python-cupshelpers so I think we're
good for an upload to experimental.
I've Uploaded a version to delayed/3.
Thanks for your work on this.
Just wanted to add, that I successfully tested your packages. I was able to
add/delete/modify printers and a hotplugged printes was automatically setup
correctly.
Great! Thanks a lot for your testing.
Uploading 1.2.3-1 makes system-config-printer-kde uninstallable though.
So I guess we need to file an RC bug to get system-config-printer-kde updated
and determine how (and if) we are proceeding with the
system-config-printer-{common,gnome} split.
I've contacted the submitter of #525714 but didn't get a reply so far.
Since the upload is targeted at experimental we can sort that out before
uploading to unstable. I'll file a bug against system-config-printer-kde
once the upload hit experimental.
As already said, I don't have any experience with python (packaging), but I
find
it a bit strange that system-config-printer-kde uses API from
/usr/share/system-config-printer/. Isn't that internal to s-c-p?
Looking at the system-config-printer-kde source it seems the only parts
that are needed are from cusphelpers so this might turn out as a non
issue after all.
Cheers,
-- Guido
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On 31.07.2010 13:34, Guido Günther wrote: On Fri, Jul 30, 2010 at 08:13:51PM +0200, Michael Biebl wrote: As already said, I don't have any experience with python (packaging), but I find it a bit strange that system-config-printer-kde uses API from /usr/share/system-config-printer/. Isn't that internal to s-c-p? Looking at the system-config-printer-kde source it seems the only parts that are needed are from cusphelpers so this might turn out as a non issue after all. Are you sure you are not looking at the patched sources of kdeadmin (see 01_system_config_printer_kde_cupsutils.diff)? I found the following in system-config-printer-kde.py: #load modules from system-config-printer-common (debug, smburi), change path here if you have it installed elsewhere SYSTEM_CONFIG_PRINTER_DIR = /usr/share/system-config-printer if os.path.exists(SYSTEM_CONFIG_PRINTER_DIR + /debug.py): sys.path.append(SYSTEM_CONFIG_PRINTER_DIR) ... # These come from system-config-printer import config import cupshelpers, options from optionwidgets import OptionWidget from smburi import SMBURI from debug import * An alternative solution to splitting s-c-p could be, to move the necessary classes into python-cupshelpers. TBH I dunno which solution is better/cleaner. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On Thu, Jul 29, 2010 at 11:18:14AM +0200, Guido Günther wrote: On Wed, Jul 28, 2010 at 04:08:17PM +0200, Guido Günther wrote: [..snip..] - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer - sytem-config-printer-gnome in one go. I've renamed python-cupsutils to python-cupshelpers so I think we're good for an upload to experimental. I've Uploaded a version to delayed/3. -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On 30.07.2010 19:26, Guido Günther wrote:
On Thu, Jul 29, 2010 at 11:18:14AM +0200, Guido Günther wrote:
On Wed, Jul 28, 2010 at 04:08:17PM +0200, Guido Günther wrote:
[..snip..]
- I'm not a python packager, but the python bits are installed as
/usr/lib/python2.6/site-packages/cupshelpers/*.
Shouldn't the python-cupsutils package be renamed to python-cupshelpers?
Think so. But we can make the renaming with system-config-printer -
sytem-config-printer-gnome in one go.
I've renamed python-cupsutils to python-cupshelpers so I think we're
good for an upload to experimental.
I've Uploaded a version to delayed/3.
Thanks for your work on this.
Just wanted to add, that I successfully tested your packages. I was able to
add/delete/modify printers and a hotplugged printes was automatically setup
correctly.
Uploading 1.2.3-1 makes system-config-printer-kde uninstallable though.
So I guess we need to file an RC bug to get system-config-printer-kde updated
and determine how (and if) we are proceeding with the
system-config-printer-{common,gnome} split.
As already said, I don't have any experience with python (packaging), but I find
it a bit strange that system-config-printer-kde uses API from
/usr/share/system-config-printer/. Isn't that internal to s-c-p?
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On Wed, Jul 28, 2010 at 04:08:17PM +0200, Guido Günther wrote: [..snip..] - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer - sytem-config-printer-gnome in one go. I've renamed python-cupsutils to python-cupshelpers so I think we're good for an upload to experimental. Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#568477: Bug#581511: also needed for cups-pk-helper support
Le jeudi 29 juillet 2010 à 11:18 +0200, Guido Günther a écrit : On Wed, Jul 28, 2010 at 04:08:17PM +0200, Guido Günther wrote: [..snip..] - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer - sytem-config-printer-gnome in one go. I've renamed python-cupsutils to python-cupshelpers so I think we're good for an upload to experimental. You should remove python-cupsutils entirely, unless you have made sure that the same API is provided. The same can be said about hal-cups-utils. Just add the conflict, and we’ll replace it in the meta-gnome2 dependencies. Cheers, -- .''`. : :' : “Fuck you sir, don’t be suprised when you die if `. `' you burn in Hell, because I am a solid Christian `-and I am praying for you.” -- Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On Thu, Jul 29, 2010 at 12:02:17PM +0200, Josselin Mouette wrote: Le jeudi 29 juillet 2010 à 11:18 +0200, Guido Günther a écrit : On Wed, Jul 28, 2010 at 04:08:17PM +0200, Guido Günther wrote: [..snip..] - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer - sytem-config-printer-gnome in one go. I've renamed python-cupsutils to python-cupshelpers so I think we're good for an upload to experimental. You should remove python-cupsutils entirely, unless you have made sure that the same API is provided. The same can be said about hal-cups-utils. Just add the conflict, and we’ll replace it in the meta-gnome2 dependencies. O.k. done. -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#568477: Bug#581511: also needed for cups-pk-helper support
Hi Guido, thanks for working on this. On 28.07.2010 12:32, Guido Günther wrote: Hi Joss, On Fri, Jul 23, 2010 at 03:19:08PM +0200, Josselin Mouette wrote: Le vendredi 23 juillet 2010 à 14:57 +0200, Guido Günther a écrit : A new upstream version is also needed to support cups-pk-helper. This makes is possible to have finer grained actions using policy kit. I don’t have a printer anymore so I will probably not work on system-config-printer before the squeeze release. Help is welcome. I've updated the package at: http://git.debian.org/?p=users/agx/system-config-printer.git;a=summary and it works here. A few comments/suggestions: - Build-Depends on quilt can/should be dropped. - libudev-dev Build-Depends is linux only [linux-any]. - system-config-printer-udev should be Architecture: linux-any - hal-cups-utils should probably depend on system-config-printer-udev [linux-any]. Does system-config-printer have a fallback for non-udev systems? What happens to the original hal-cups-utils source package? Does it make sense to keep it around for non-linux systems? The general question here is, how to handle kbsd/hurd - seems debian/control and debian/control.in are out-of-sync - long package description of hal-cups-utils: the . should be indented with one white space, not two. - changelog: Conflict on hal-cups-utils since system-config-printer- udev provides should probably be Conflict with hal-cups-utils since system-config-printer-udev provides - Should the package be split in GUI + core, i.e. move the GNOME bits in a system-config-printer-gnome package? Is system-config-printer-kde actually usable without system-config-printer installed? If not, it would need a dependency on GNOME bits. - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On Wed, Jul 28, 2010 at 01:33:23PM +0200, Michael Biebl wrote: Hi Guido, A few comments/suggestions: - Build-Depends on quilt can/should be dropped. Done. - libudev-dev Build-Depends is linux only [linux-any]. - system-config-printer-udev should be Architecture: linux-any - hal-cups-utils should probably depend on system-config-printer-udev [linux-any]. Does system-config-printer have a fallback for non-udev systems? What happens to the original hal-cups-utils source package? Does it make sense to keep it around for non-linux systems? The general question here is, how to handle kbsd/hurd We could make the transitional hal-cups-utils package [linux-any] too so kfreebsd/hurd can keep the real implementation, if wanted. - seems debian/control and debian/control.in are out-of-sync I keep on editing debian/control directly. Fixed now. - long package description of hal-cups-utils: the . should be indented with one white space, not two. Copy paste error, fixed. - changelog: Conflict on hal-cups-utils since system-config-printer- udev provides should probably be Conflict with hal-cups-utils since system-config-printer-udev provides Fixed. - Should the package be split in GUI + core, i.e. move the GNOME bits in a system-config-printer-gnome package? Is system-config-printer-kde actually usable without system-config-printer installed? If not, it would need a dependency on GNOME bits. It'd like to see this happen but I figure having the current version in experimental will make it easier for the KDE team to figure out which parts they need. We can make the split afterwards. - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer - sytem-config-printer-gnome in one go. Thanks a lot for your feedback, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#568477: Bug#581511: also needed for cups-pk-helper support
On 28.07.2010 16:08, Guido Günther wrote: On Wed, Jul 28, 2010 at 01:33:23PM +0200, Michael Biebl wrote: - Should the package be split in GUI + core, i.e. move the GNOME bits in a system-config-printer-gnome package? Is system-config-printer-kde actually usable without system-config-printer installed? If not, it would need a dependency on GNOME bits. It'd like to see this happen but I figure having the current version in experimental will make it easier for the KDE team to figure out which parts they need. We can make the split afterwards. - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer - sytem-config-printer-gnome in one go. See Jonathan's comment at [1] what is required by system-config-printer-kde, so I'd say we can/should do the split and the renaming in one go. As for the split, I created a wiki page [2] which contains all files installed by s-c-p. Will add Jonathans comments there. Feel free to add any comments yourself. Joss, I'm particular interested in your comment on this matter. Cheers, Michael [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=581511#40 [2] http://wiki.debian.org/system-config-printer -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
