Bug#576573: live-helper: config: bogus architecture checking

2010-04-05 Thread Geert Stappers 
Package: live-helper
Version:  2.0~a9-1

Hello,

Live-helper config does bogus checking on architecture.

To me it seems it only checks during "create" of the config tree

Please check architecture also during "update"


Demostration:

|stapp...@inertia:/tmp
|$ mkdir qed
|stapp...@inertia:/tmp
|$ cd qed
|stapp...@inertia:/tmp/qed
|$ sudo lh config --architecture i486
|P: Considering defaults defined in /etc/default/live-helper
|E: Architecture i486 not yet supported (FIXME)
|stapp...@inertia:/tmp/qed
|$ ls
|stapp...@inertia:/tmp/qed
|$ sudo lh config --architecture i386
|P: Considering defaults defined in /etc/default/live-helper
|P: Creating config tree
|stapp...@inertia:/tmp/qed
|$ ls
|auto  config
|stapp...@inertia:/tmp/qed
|$ grep -ri architecture *
|config/bootstrap:# $LH_ARCHITECTURE: select chroot architecture
|config/bootstrap:LH_ARCHITECTURE="i386"
|stapp...@inertia:/tmp/qed
|$ sudo lh config --architecture i486
|P: Considering defaults defined in /etc/default/live-helper
|P: Updating config tree
|stapp...@inertia:/tmp/qed
|$ grep -ri architecture *
|config/bootstrap:# $LH_ARCHITECTURE: select chroot architecture
|config/bootstrap:LH_ARCHITECTURE="i486"
|stapp...@inertia:/tmp/qed
|$ 


Regards
Geert Stappers



signature.asc
Description: Digital signature

Bug#576573: live-helper: config: bogus architecture checking

2010-04-05 Thread Daniel Baumann 

retitle 576573 check config tree also on updates
severity 576573 minor
tag 576573 pending

On 04/05/2010 09:02 PM, Geert Stappers wrote:

To me it seems it only checks during "create" of the config tree

Please check architecture also during "update"


there are two things here:

first, lh_config should call Check_defaults(); twice, once when reading 
in the config, once when writing. this is now done in git.


second, this is what you have reported, is about the user setting a 
wrong architecture. this is not really fixable without having to 
hardcode a fixed list of possible architectures, so there's nothing i 
can do about it (and hardcoding the architecture list is kind of bad).


Regards,
Daniel

--
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:  daniel.baum...@panthera-systems.net
Internet:   http://people.panthera-systems.net/~daniel-baumann/



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org