Bug#601259: FTBFS if only built with Python =2.6
On 10/24/2010 06:40 PM, Jakub Wilk wrote: armel, hppa, mips, powerpc, maybe s390, plus all non-Linux ones. Use something like: $(shell python -c 'import distutils.util as d; print d.get_platform()') Okay, I've committed the above. Is this solution acceptable to everyone? -- ╒═╕ │Luke Faraone ╭Debian / Ubuntu Developer╮│ │http://luke.faraone.cc╰Sugar Labs, Systems Admin╯│ │PGP: 5189 2A7D 16D0 49BB 046B DC77 9732 5DD8 F9FD D506 │ ╘═╛ signature.asc Description: OpenPGP digital signature
Bug#601259: FTBFS if only built with Python =2.6
On 10/25/2010 06:15 PM, Luke Faraone wrote: On 10/24/2010 06:40 PM, Jakub Wilk wrote: armel, hppa, mips, powerpc, maybe s390, plus all non-Linux ones. Use something like: $(shell python -c 'import distutils.util as d; print d.get_platform()') Okay, I've committed the above. Is this solution acceptable to everyone? No major objections on my part, I just consider my patch simpler. This is a module, not an extension, so the build result is identical -- which is why dh_pysupport grabs only one version. An elaborate construction to run the tests using the build from the corresponding Python version appears overly complex to me. Again, this is just a comment. I'm fine either way as long as it fixes the bug. Christian signature.asc Description: OpenPGP digital signature
Bug#601259: FTBFS if only built with Python =2.6
Package: python-keyczar Version: 0.6~b.061709-2 Severity: serious Justification: fails to build from source (but built successfully in the past) When attempting to build this package with pyversions of 2.6-, the package FTBFS because it expects there to be a build/lib directory. Versions of Python after 2.5.x do not create this directory. I'll prepare an upload that fixes this and other problems shortly. -- System Information: Debian Release: squeeze/sid APT prefers maverick APT policy: (500, 'maverick') Architecture: amd64 (x86_64) Kernel: Linux 2.6.35-22-generic (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#601259: FTBFS if only built with Python =2.6
On 10/24/2010 03:22 PM, Jakub Wilk wrote: * Luke Faraone lfara...@debian.org, 2010-10-24, 13:55: When attempting to build this package with pyversions of 2.6-, the package FTBFS because it expects there to be a build/lib directory. Versions of Python after 2.5.x do not create this directory. AFAIK we haven't removed Python 2.5 from the set of supported versions yet. Right, I was unclear whether this would merit does-not-build or not. My apologies. The patch you committed is incorrect: the package will FTBFS on some architectures or if DEB_* variables were not exported into environment. I've added the following: DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS) DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU) What architectures would it FTBFS on? -- ╒═╕ │Luke Faraone ╭Debian / Ubuntu Developer╮│ │http://luke.faraone.cc╰Sugar Labs, Systems Admin╯│ │PGP: 5189 2A7D 16D0 49BB 046B DC77 9732 5DD8 F9FD D506 │ ╘═╛ signature.asc Description: OpenPGP digital signature
Bug#601259: FTBFS if only built with Python =2.6
user debian-pyt...@lists.debian.org usertags 601259 + python2.5-removal severity 601259 important tags 601259 - pending thanks * Luke Faraone lfara...@debian.org, 2010-10-24, 13:55: When attempting to build this package with pyversions of 2.6-, the package FTBFS because it expects there to be a build/lib directory. Versions of Python after 2.5.x do not create this directory. AFAIK we haven't removed Python 2.5 from the set of supported versions yet. The patch you committed is incorrect: the package will FTBFS on some architectures or if DEB_* variables were not exported into environment. -- Jakub Wilk signature.asc Description: Digital signature
Bug#601259: FTBFS if only built with Python =2.6
On Sun, Oct 24, 2010 at 15:59:43 -0400, Luke Faraone wrote: I've added the following: DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS) DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU) The usual way to do this is with ?= so that the environment takes precedence (also the build architecture usually doesn't matter, so you may want to double check that you didn't really want DEB_HOST_ARCH_OS here). Cheers, Julien signature.asc Description: Digital signature
Bug#601259: FTBFS if only built with Python =2.6
On 10/24/2010 09:59 PM, Luke Faraone wrote: On 10/24/2010 03:22 PM, Jakub Wilk wrote: * Luke Faraone lfara...@debian.org, 2010-10-24, 13:55: When attempting to build this package with pyversions of 2.6-, the package FTBFS because it expects there to be a build/lib directory. Versions of Python after 2.5.x do not create this directory. AFAIK we haven't removed Python 2.5 from the set of supported versions yet. Right, I was unclear whether this would merit does-not-build or not. My apologies. The patch you committed is incorrect: the package will FTBFS on some architectures or if DEB_* variables were not exported into environment. I've added the following: DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS) DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU) Why use the DEB_* stuff at all? The way I see it, the following should change to PYTHONPATH should sufficed: PYTHONPATH=$(shell ls -d $(CURDIR)/build/lib* | head -n 1) ie, pick the first lib directory found instead of hard-coding the 2.5 lib directory. Christian Index: trunk/debian/rules === --- trunk/debian/rules (revision 14743) +++ trunk/debian/rules (working copy) @@ -9,18 +9,11 @@ %: dh $@ -DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS) -DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU) - override_dh_auto_test: ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS))) set -e ; \ cd tests/keyczar/; \ for py in $(PYVERS); do \ - if [ $$py \ 2.6 ]; then \ - PYTHONPATH=$(CURDIR)/build/lib python$$py alltests.py; \ - else \ - PYTHONPATH=$(CURDIR)/build/lib.$(DEB_BUILD_ARCH_OS)-$(DEB_HOST_GNU_CPU)-$$py python$$py alltests.py; \ - fi; \ + PYTHONPATH=$(shell ls -d $(CURDIR)/build/lib* | head -n 1) python$$py alltests.py; \ done endif signature.asc Description: OpenPGP digital signature
Bug#601259: FTBFS if only built with Python =2.6
* Luke Faraone lfara...@debian.org, 2010-10-24, 15:59: The patch you committed is incorrect: the package will FTBFS on some architectures or if DEB_* variables were not exported into environment. I've added the following: DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS) DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU) What architectures would it FTBFS on? armel, hppa, mips, powerpc, maybe s390, plus all non-Linux ones. Use something like: $(shell python -c 'import distutils.util as d; print d.get_platform()') or, better, use wildcards. -- Jakub Wilk signature.asc Description: Digital signature
