Bug#621122: viewvc: "as text" links in log displayed for binaries instead of text files.
> Package: viewvc > Version: 1.1.5-1.1 > Severity: normal > > > The "as text" links are displayed in the ViewVC log pages in wrong > circumstances. They ARE displayed for binary files and are NOT displayed > for plain text files. That is exactly the other way around as it should > be. > > I just did a quick view in /usr/lib/viewvc/lib/viewvc.py and found out > there's a negation error on line 1049: > > if not is_plain_text(mime_type): > download_text_href = request.get_url(view_func=view_checkout, > > The "not" should not be there. Hello, Durk. I have been trying to understand your bug report and I think I finally understand what's going on here. The logic is totally fine, what is probably wrong is the label. It should read "see as raw file", not "as text", as it's very misleading. That is why it's on for binary files and off for the others, because it doesn't make sense as it's already a text file. If you see a PNG on the normal markup interface, it'll show up as "broken", and the only way of displaying it properly is through the checkout view (which is accessed with the "as test" link) Please tell me if this satisfies you or you prefer to contact upstream to see if we can change this. I'm on your side with this and I think it could be worded better. Thanks for your report, Ender. signature.asc Description: OpenPGP digital signature
Bug#621122: viewvc: "as text" links in log displayed for binaries instead of text files
Package: viewvc Version: 1.1.5-1.1 Severity: normal The "as text" links are displayed in the ViewVC log pages in wrong circumstances. They ARE displayed for binary files and are NOT displayed for plain text files. That is exactly the other way around as it should be. I just did a quick view in /usr/lib/viewvc/lib/viewvc.py and found out there's a negation error on line 1049: if not is_plain_text(mime_type): download_text_href = request.get_url(view_func=view_checkout, The "not" should not be there. -- System Information: Debian Release: 6.0 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages viewvc depends on: ii python 2.6.6-3+squeeze5 interactive high-level object-orie ii python-subversion 1.6.12dfsg-5 Python bindings for Subversion ii python-support 1.0.10 automated rebuilding support for P ii rcs 5.7-25 The GNU Revision Control System ii subversion 1.6.12dfsg-5 Advanced version control system Versions of packages viewvc recommends: ii apache2 2.2.16-6 Apache HTTP Server metapackage ii apache2-mpm-worker [httpd-cgi 2.2.16-6 Apache HTTP Server - high speed th pn python-pygments(no description available) Versions of packages viewvc suggests: pn cvsgraph (no description available) pn libapache2-mod-python (no description available) ii mime-support 3.48-1 MIME files 'mime.types' & 'mailcap pn python-tk (no description available) pn viewvc-query (no description available) -- Configuration Files: /etc/viewvc/viewvc.conf changed [not included] -- debconf-show failed -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
