Bug#648124: therion: FTBFS with libpng 1.5

2011-11-29 Thread Wookey
+++ Olly Betts [2011-11-29 13:33 +]:
> On Tue, Nov 29, 2011 at 11:34:05AM +, Wookey wrote:
> > But what is the correct thing to do in the control file for this
> > transition? set Build-Depends: to 
> > libpng15-dev | libpng12-dev
> > libpng12-dev | libpng15-dev
> > libpng-dev
> > libpng-dev | libpng12-dev
> > 
> > I assume the last one is best: libpng-dev is presumably generic and
> > will avoid this issue in the future, but is only in experimental
> > currently so we should fallback to the existing libpng12-dev in the
> > meantime. right?
> 
> The buildds will only ever take the *first* alternative to any build
> dependency (and fail if that's not available), so practically speaking
> you want to stick with libpng12-dev until the newer libpng hits
> unstable.

OK, I had forgotten that. That's a bit dull. It'd have been nice to do
a pre-emptive upload so this didn't break when libpng15 gets uploaded.

Wookey
-- 
Principal hats:  Linaro, Emdebian, Wookware, Balloonboard, ARM
http://wookware.org/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#648124: therion: FTBFS with libpng 1.5

2011-11-29 Thread Olly Betts
On Tue, Nov 29, 2011 at 11:34:05AM +, Wookey wrote:
> But what is the correct thing to do in the control file for this
> transition? set Build-Depends: to 
> libpng15-dev | libpng12-dev
> libpng12-dev | libpng15-dev
> libpng-dev
> libpng-dev | libpng12-dev
> 
> I assume the last one is best: libpng-dev is presumably generic and
> will avoid this issue in the future, but is only in experimental
> currently so we should fallback to the existing libpng12-dev in the
> meantime. right?

The buildds will only ever take the *first* alternative to any build
dependency (and fail if that's not available), so practically speaking
you want to stick with libpng12-dev until the newer libpng hits
unstable.

After that, I guess the libpng maintainers have a plan that people
move to libpng-dev (presumably akin to libjpeg-dev).

> Eventually Build-depends could be changed to just 'libpng-dev' (The '|
> libpng12-dev' will remain useful for backports for a while after the
> wheezy release).

For autobuilt backports, the person doing the backport will need to edit
the control file to say libpng12-dev as the first (or only) alternative
anyway.

Cheers,
Olly



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#648124: therion: FTBFS with libpng 1.5

2011-11-29 Thread Wookey
+++ Olly Betts [2011-11-25 21:41 +1300]:
> On Wed, Nov 09, 2011 at 12:20:40PM +0900, Nobuhiro Iwamatsu wrote:
> > I uploaded libpng 1.5 to experimental.
> > libpng maintainers plan to transition from libpng 1.2 to 1.5.
> > I am checking build it the package depend to libpng.
> > 
> > I noticed your package FTBFS by libpng 1.5. I attached build log.
> > Could you check your package ?
> 
> The issue is just that a debian patch hard-codes -lpng12 - in
> debian/patches/25debianize-loch-makefile.patch there's:
> 
> -PLIBS = $(shell wx-config --libs --gl-libs) -L$(VTKLIBPATH) $(VTKLIBS) -lGLU 
> -l
> pthread -lz 
> +PLIBS = $(shell wx-config --libs --gl-libs) $(VTKLIBS) -lGLU -lpthread -lz 
> -lpn
> g12 -ljpeg -lX11 -lGL
> 
> It would probably be better to replace -lpng12 there with:
> 
> `pkg-config --libs libpng`

OK, that's easy and sensible. I've use pkg-config for libgs GL and GLU
too as it improves portability/crossability.

But what is the correct thing to do in the control file for this
transition? set Build-Depends: to 
libpng15-dev | libpng12-dev
libpng12-dev | libpng15-dev
libpng-dev
libpng-dev | libpng12-dev

I assume the last one is best: libpng-dev is presumably generic and
will avoid this issue in the future, but is only in experimental
currently so we should fallback to the existing libpng12-dev in the
meantime. right?

Eventually Build-depends could be changed to just 'libpng-dev' (The '|
libpng12-dev' will remain useful for backports for a while after the
wheezy release).

Wookey
-- 
Principal hats:  Linaro, Emdebian, Wookware, Balloonboard, ARM
http://wookware.org/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#648124: therion: FTBFS with libpng 1.5

2011-11-25 Thread Olly Betts
On Wed, Nov 09, 2011 at 12:20:40PM +0900, Nobuhiro Iwamatsu wrote:
> I uploaded libpng 1.5 to experimental.
> libpng maintainers plan to transition from libpng 1.2 to 1.5.
> I am checking build it the package depend to libpng.
> 
> I noticed your package FTBFS by libpng 1.5. I attached build log.
> Could you check your package ?

The issue is just that a debian patch hard-codes -lpng12 - in
debian/patches/25debianize-loch-makefile.patch there's:

-PLIBS = $(shell wx-config --libs --gl-libs) -L$(VTKLIBPATH) $(VTKLIBS) -lGLU -l
pthread -lz 
+PLIBS = $(shell wx-config --libs --gl-libs) $(VTKLIBS) -lGLU -lpthread -lz -lpn
g12 -ljpeg -lX11 -lGL

It would probably be better to replace -lpng12 there with:

`pkg-config --libs libpng`

Cheers,
Olly



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#648124: therion: FTBFS with libpng 1.5

2011-11-08 Thread Nobuhiro Iwamatsu
Source: therion
Version: 5.3.8-2
Severity: wishlist
User: lib...@packages.debian.org
Usertags: libpng15-transition

Hi,

I uploaded libpng 1.5 to experimental.
libpng maintainers plan to transition from libpng 1.2 to 1.5.
I am checking build it the package depend to libpng.

I noticed your package FTBFS by libpng 1.5. I attached build log.
Could you check your package ?

Best regards,
  Nobuhiro
-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6


therion_5.3.8-2_amd64.build.gz
Description: GNU Zip compressed data