Bug#659745: mocp: Assertion fails when lyrics file ends with a dot and mocp crashes
tags 659745 patch thanks * Mark Caglienzi [120213 15:44 +0100]: Package: moc Version: 1:2.5.0~alpha4+svn20111012-1 Severity: normal Hello, when I enter a directory containing a lyrics file (that must have the same name of the song, but without extension) ending with a dot, mocp crashes with the following message: mocp: decoder.c:128: find_extn_decoder: Assertion `extn extn[0]' failed. Aborted For example, if the song filename is f.o.o..mp3 and the lyrics filename is f.o.o. mocp crashes. Obviously, if I name the lyrics file f.o.o moc doesn't crash, but doesn't recognize the lyrics. I got a patch from John Fitgerald, upstream, which solves that behaviour. I'll upload the new version in a few days together with some other fixes. Elimar -- Obviously the human brain works like a computer. Since there are no stupid computers humans can't be stupid. There are just a few running with Windows or even CE ;-) From: John Fitzgerald Debian-Bug: #659745 Index: decoder.c === --- decoder.c(revision 2382) +++ decoder.c(working copy) @@ -175,7 +175,7 @@ static int find_decoder (const char *extn, const char *file, char **mime) result = -1; if (mime *mime) result = find_mime_decoder (default_decoder_list, plugins_num, *mime); - if (result == -1 extn) + if (result == -1 extn *extn) result = find_extn_decoder (default_decoder_list, plugins_num, extn); return result;
Bug#659745: mocp: Assertion fails when lyrics file ends with a dot and mocp crashes
Package: moc Version: 1:2.5.0~alpha4+svn20111012-1 Severity: normal Hello, when I enter a directory containing a lyrics file (that must have the same name of the song, but without extension) ending with a dot, mocp crashes with the following message: mocp: decoder.c:128: find_extn_decoder: Assertion `extn extn[0]' failed. Aborted For example, if the song filename is f.o.o..mp3 and the lyrics filename is f.o.o. mocp crashes. Obviously, if I name the lyrics file f.o.o moc doesn't crash, but doesn't recognize the lyrics. Regards, Mark -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 3.2.0-1-686-pae (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages moc depends on: ii libasound21.0.24.1-4 ii libc6 2.13-26 ii libcurl3-gnutls 7.24.0-1 ii libdb5.1 5.1.29-1 ii libfaad2 2.7-7 ii libflac8 1.2.1-6 ii libgcc1 1:4.6.2-12 ii libid3tag00.15.1b-10 ii libjack0 [libjack-0.116] 1:0.121.0+svn4538-3 ii libltdl7 2.4.2-1 ii libmad0 0.15.1b-7 ii libmagic1 5.09-2 ii libmodplug1 1:0.8.8.4-1 ii libmpcdec62:0.1~r459-1 ii libncursesw5 5.9-4 ii libogg0 1.2.2~dfsg-1 ii librcc0 0.2.9-3 ii libresid-builder0c2a 2.1.1-8 ii libsamplerate00.1.8-2 ii libsidplay2 2.1.1-8 ii libsidutils0 2.1.1-8 ii libsndfile1 1.0.25-4 ii libspeex1 1.2~rc1-3 ii libstdc++64.6.2-12 ii libtagc0 1.7-1 ii libtinfo5 5.9-4 ii libvorbis0a 1.3.2-1.1 ii libvorbisfile31.3.2-1.1 ii libwavpack1 4.60.1-2 ii zlib1g1:1.2.3.4.dfsg-3 moc recommends no packages. Versions of packages moc suggests: ii moc-ffmpeg-plugin 1:2.5.0~alpha4+svn20111012-1 -- no debconf information -- . ''`. | GPG Public Key : 0xCD542422 - Download it from http://is.gd/fOa7Vm : :' : | GPG Fingerprint : 0823 A40D F31B 67A8 5621 AD32 E293 A2EB CD54 2422 `. `'` | Powered by Debian GNU/Linux, http://www.debian.org `-| Try not. Do, or do not. There is no try. - Master Yoda, TESB. signature.asc Description: Digital signature
Bug#659745: mocp: Assertion fails when lyrics file ends with a dot and mocp crashes
* Mark Caglienzi [120213 15:44 +0100]: Package: moc Version: 1:2.5.0~alpha4+svn20111012-1 Severity: normal Hello, when I enter a directory containing a lyrics file (that must have the same name of the song, but without extension) ending with a dot, mocp crashes with the following message: mocp: decoder.c:128: find_extn_decoder: Assertion `extn extn[0]' failed. Aborted For example, if the song filename is f.o.o..mp3 and the lyrics filename is f.o.o. mocp crashes. Obviously, if I name the lyrics file f.o.o moc doesn't crash, but doesn't recognize the lyrics. What happens if you rename f.o.o..mp3 to f.o.o.mp3 and f.o.o. to f.o.o ? Elimar -- Numeric stability is probably not all that important when you're guessing;-) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#659745: mocp: Assertion fails when lyrics file ends with a dot and mocp crashes
On 13 Feb 19:44, Elimar Riesebieter wrote: * Mark Caglienzi [120213 15:44 +0100]: Package: moc Version: 1:2.5.0~alpha4+svn20111012-1 Severity: normal Hello, when I enter a directory containing a lyrics file (that must have the same name of the song, but without extension) ending with a dot, mocp crashes with the following message: mocp: decoder.c:128: find_extn_decoder: Assertion `extn extn[0]' failed. Aborted For example, if the song filename is f.o.o..mp3 and the lyrics filename is f.o.o. mocp crashes. Obviously, if I name the lyrics file f.o.o moc doesn't crash, but doesn't recognize the lyrics. What happens if you rename f.o.o..mp3 to f.o.o.mp3 and f.o.o. to f.o.o ? Thanks for the very quick reply! I tried to rename the files like you said, and in this way there's no problem, mocp doesn't crash and the lyrics are correctly shown when I press L. Elimar Mark -- . ''`. | GPG Public Key : 0xCD542422 - Download it from http://is.gd/fOa7Vm : :' : | GPG Fingerprint : 0823 A40D F31B 67A8 5621 AD32 E293 A2EB CD54 2422 `. `'` | Powered by Debian GNU/Linux, http://www.debian.org `-| Try not. Do, or do not. There is no try. - Master Yoda, TESB. signature.asc Description: Digital signature
