Bug#688321: unblock: quota/4.01-1
Hi Jonathan On Sun, Mar 17, 2013 at 03:19:37PM +, Jonathan Wiltshire wrote: > Control: tag -1 + pending > > On Sat, Mar 09, 2013 at 04:45:06PM +0100, Salvatore Bonaccorso wrote: > > Hi all > > > > I have updated the proposed debdiff with also the patch for reporting > > problem with NFS mounts. Julien is this acceptable for a t-p-u upload? > > > > Regards, > > Salvatore > > Please go ahead. Thank you, just uploaded. Regards, Salvatore -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#688321: unblock: quota/4.01-1
Control: tag -1 + pending On Sat, Mar 09, 2013 at 04:45:06PM +0100, Salvatore Bonaccorso wrote: > Hi all > > I have updated the proposed debdiff with also the patch for reporting > problem with NFS mounts. Julien is this acceptable for a t-p-u upload? > > Regards, > Salvatore Please go ahead. Thanks, -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 i have six years of solaris sysadmin experience, from 8->10. i am well qualified to say it is made from bonghits layered on top of bonghits signature.asc Description: Digital signature
Bug#688321: unblock: quota/4.01-1
Hi all
I have updated the proposed debdiff with also the patch for reporting
problem with NFS mounts. Julien is this acceptable for a t-p-u upload?
Regards,
Salvatore
diff -u quota-4.00/debian/changelog quota-4.00/debian/changelog
--- quota-4.00/debian/changelog
+++ quota-4.00/debian/changelog
@@ -1,3 +1,15 @@
+quota (4.00-4+deb7u1) testing-proposed-updates; urgency=low
+
+ * Non-maintainer upload.
+ * Add 685356-Fix-reporting-for-XFS.patch patch.
+Fixes quota reporting on XFS filesystems. Cherry-pick commit from
+upstream git repository. (Closes: #685356)
+ * Add 698864-Fix-reporting-of-NFS-mountpoints.patch patch.
+Fixes quota reporting on NFS mountpoints. Cherry-pick commit from
+upstream git repository. (Closes: #698864)
+
+ -- Salvatore Bonaccorso Sat, 09 Mar 2013 16:37:03 +0100
+
quota (4.00-4) unstable; urgency=low
* Added upstream patch to fix problem with editing of several users.
diff -u quota-4.00/debian/patches/series quota-4.00/debian/patches/series
--- quota-4.00/debian/patches/series
+++ quota-4.00/debian/patches/series
@@ -4,0 +5,2 @@
+685356-Fix-reporting-for-XFS.patch
+698864-Fix-reporting-of-NFS-mountpoints.patch
only in patch2:
unchanged:
--- quota-4.00.orig/debian/patches/685356-Fix-reporting-for-XFS.patch
+++ quota-4.00/debian/patches/685356-Fix-reporting-for-XFS.patch
@@ -0,0 +1,35 @@
+From 6ba6546dd167297cb9ed69d0257ee245b0faea47 Mon Sep 17 00:00:00 2001
+From: Jan Kara
+Date: Fri, 8 Jun 2012 11:11:20 +0200
+Subject: [PATCH] repquota: Fix reporting for XFS
+
+Conversion to generic quota scanning introduced a bug for XFS where we
+stopped scanning after quotactl reported first error. quotactl for XFS
+however reports ENOENT when it has nothing to report for a particular user
+/ group and we shouldn't stop scanning after that. We tried to test for this
+but the test was wrong. Fix it.
+
+Signed-off-by: Jan Kara
+---
+ quotaio_xfs.c |4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/quotaio_xfs.c b/quotaio_xfs.c
+index 2e879e6..903c03e 100644
+--- a/quotaio_xfs.c
b/quotaio_xfs.c
+@@ -183,9 +183,9 @@ static int xfs_get_dquot(struct dquot *dq)
+ memset(&d, 0, sizeof(d));
+ ret = quotactl(qcmd, dq->dq_h->qh_quotadev, dq->dq_id, (void *)&d);
+ if (ret < 0) {
+- if (ret == -ENOENT)
++ if (errno == ENOENT)
+ return 0;
+- return ret;
++ return -1;
+ }
+ xfs_kern2utildqblk(&dq->dq_dqb, &d);
+ return 0;
+--
+1.7.4.1
+
only in patch2:
unchanged:
--- quota-4.00.orig/debian/patches/698864-Fix-reporting-of-NFS-mountpoints.patch
+++ quota-4.00/debian/patches/698864-Fix-reporting-of-NFS-mountpoints.patch
@@ -0,0 +1,30 @@
+From 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d Mon Sep 17 00:00:00 2001
+From: Jan Kara
+Date: Mon, 20 Aug 2012 19:16:05 +0200
+Subject: [PATCH] quota: Fix reporting of NFS mountpoints
+
+Commit b8ab76ad19e3c284ac14bd0450662bfc41719e03 creating split_nfs_mount()
+forgot to remove zeroing of pathname character. That lead to broken reporting
+quotas for NFSv3 mount points.
+
+Thanks to anonymous reporter for spotting this.
+
+Signed-off-by: Jan Kara
+---
+ rquota_client.c |1 -
+ 1 files changed, 0 insertions(+), 1 deletions(-)
+
+diff --git a/rquota_client.c b/rquota_client.c
+index 54a8921..e26e066 100644
+--- a/rquota_client.c
b/rquota_client.c
+@@ -162,7 +162,6 @@
+ return -ENOENT;
+ }
+
+- *pathname++ = '\0';
+ /* For NFSv4, we send the filesystem path without initial /. Server
prepends proper
+* NFS pseudoroot automatically and uses this for detection of NFSv4
mounts. */
+ if ((dquot->dq_h->qh_io_flags & IOFL_NFS_MIXED_PATHS) &&
+--
+1.7.4.1
Bug#688321: unblock: quota/4.01-1
Hi, On Sun, Mar 03, 2013 at 01:58:32PM -0800, Christoph Egger wrote: > intrigeri writes: > > Michael Meskes wrote (27 Dec 2012 11:21:56 GMT) : > >>> > Would it be possible to get *only* the xfs fix in testing instead of the > >>> > whole new release? > > > >> Where does fixing the XFS problem differ from fixing the other bugs > >> in 4.01? > > > > As I understand it (and not being a member of the release team), it > > differs because that one has been reported in Debian as the #685356 > > important bug, while the others have not. At this time of the freeze, > > including a new upstream release because it fixes a lot of more or > > less important bugs (and adds a few features..) is probably not an > > option. I guess that's exactly why Salvatore prepared a minimal > > t-p-u debdiff. > > > > But well, if you feel like every change in 4.01 satisfies the current > > freeze policy and should be fixed in Wheezy, then please feel free to > > explain why :) > > > >> Anyway, we can surely do a Wheezy version of 4.00 that fixes XFS. > > > > OK. Do you ACK Salvatore's proposed t-p-u debdiff? > > Hm could we maybe add 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d (upstream > git) as well? > Seems to be the one addressing (at least the second half of) > #698864. Cc-ed the folks there to check the fixed quota 4.00 binary they > deployed is actually using this patch. Yes, that's exactly the patch we're using. It fixes our problems described in #698864. Regards Simon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#688321: unblock: quota/4.01-1
Hi! intrigeri writes: > Michael Meskes wrote (27 Dec 2012 11:21:56 GMT) : >>> > Would it be possible to get *only* the xfs fix in testing instead of the >>> > whole new release? > >> Where does fixing the XFS problem differ from fixing the other bugs >> in 4.01? > > As I understand it (and not being a member of the release team), it > differs because that one has been reported in Debian as the #685356 > important bug, while the others have not. At this time of the freeze, > including a new upstream release because it fixes a lot of more or > less important bugs (and adds a few features..) is probably not an > option. I guess that's exactly why Salvatore prepared a minimal > t-p-u debdiff. > > But well, if you feel like every change in 4.01 satisfies the current > freeze policy and should be fixed in Wheezy, then please feel free to > explain why :) > >> Anyway, we can surely do a Wheezy version of 4.00 that fixes XFS. > > OK. Do you ACK Salvatore's proposed t-p-u debdiff? Hm could we maybe add 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d (upstream git) as well? Seems to be the one addressing (at least the second half of) #698864. Cc-ed the folks there to check the fixed quota 4.00 binary they deployed is actually using this patch. Christoph 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d >>> >From 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Mon, 20 Aug 2012 19:16:05 +0200 Subject: [PATCH] quota: Fix reporting of NFS mountpoints Commit b8ab76ad19e3c284ac14bd0450662bfc41719e03 creating split_nfs_mount() forgot to remove zeroing of pathname character. That lead to broken reporting quotas for NFSv3 mount points. Thanks to anonymous reporter for spotting this. Signed-off-by: Jan Kara --- rquota_client.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/rquota_client.c b/rquota_client.c index 54a8921..e26e066 100644 --- a/rquota_client.c +++ b/rquota_client.c @@ -162,7 +162,6 @@ int rpc_rquota_get(struct dquot *dquot) return -ENOENT; } - *pathname++ = '\0'; /* For NFSv4, we send the filesystem path without initial /. Server prepends proper * NFS pseudoroot automatically and uses this for detection of NFSv4 mounts. */ if ((dquot->dq_h->qh_io_flags & IOFL_NFS_MIXED_PATHS) && -- 1.7.4.1 <<< -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#688321: unblock: quota/4.01-1
Hi, Michael Meskes wrote (27 Dec 2012 11:21:56 GMT) : >> > Would it be possible to get *only* the xfs fix in testing instead of the >> > whole new release? > Where does fixing the XFS problem differ from fixing the other bugs > in 4.01? As I understand it (and not being a member of the release team), it differs because that one has been reported in Debian as the #685356 important bug, while the others have not. At this time of the freeze, including a new upstream release because it fixes a lot of more or less important bugs (and adds a few features..) is probably not an option. I guess that's exactly why Salvatore prepared a minimal t-p-u debdiff. But well, if you feel like every change in 4.01 satisfies the current freeze policy and should be fixed in Wheezy, then please feel free to explain why :) > Anyway, we can surely do a Wheezy version of 4.00 that fixes XFS. OK. Do you ACK Salvatore's proposed t-p-u debdiff? Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#688321: unblock: quota/4.01-1
> Cc'ing Michael (maintainer of quota). Thanks, I didn't know a freeze exception for quota was asked for. > > Would it be possible to get *only* the xfs fix in testing instead of the > > whole new release? Where does fixing the XFS problem differ from fixing the other bugs in 4.01? There are not a whole lot of changes from 4.00 to 4.01, at least not functional ones. Anyway, we can surely do a Wheezy version of 4.00 that fixes XFS. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#688321: unblock: quota/4.01-1
Hi Julien On Sat, Dec 01, 2012 at 01:05:29PM +0100, Julien Cristau wrote: > The changelog diff is weird: > > --- quota-4.00/debian/changelog 2012-12-01 12:01:05.0 + > +++ quota-4.01/debian/changelog 2012-12-01 12:01:06.0 + > @@ -1,11 +1,11 @@ > -quota (4.00-4) unstable; urgency=low > +quota (4.01-1) unstable; urgency=low > > - * Added upstream patch to fix problem with editing of several users. > -(Closes: #670641) > - * Updated packages description which was pretty outdated. > -Thanks to Justin B Rye (Closes: #673396) > + * Imported Upstream version 4.01 (Closes: #685356) > + * Adjusted patch for new upstream version. > + * Bumped Standards-Version to 3.9.3, no changes needed. > + * Use Debian build flags. > > - -- Michael Meskes Wed, 23 May 2012 18:35:45 +0200 > + -- Michael Meskes Mon, 10 Sep 2012 12:51:40 +0200 > > quota (4.00-3) unstable; urgency=low > > What's up with that? Have reported it as http://bugs.debian.org/696788 . Regards, Salvatore signature.asc Description: Digital signature
Bug#688321: unblock: quota/4.01-1
Hi Julien
Cc'ing Michael (maintainer of quota).
On Sat, Dec 01, 2012 at 01:05:29PM +0100, Julien Cristau wrote:
[...]
> Would it be possible to get *only* the xfs fix in testing instead of the
> whole new release?
I was looking at the bugs for release.debian.org for the wheezy
release and noticed #688321. I cherry picked the mentioned patch and
rebuilded the package. repquota now reports the quotas even on
Fileystems are files owned by users without quota.
Attached is the proposed debdiff. Would that be acceptable Julien?
(strictly speaking if the bug is not RC, then it does not meet the
criterias mentioned in freeze policy as it cannot go trough unstable).
Michael, would you like to follow-up on this yourself?
Regards,
Salvatore
diff -u quota-4.00/debian/changelog quota-4.00/debian/changelog
--- quota-4.00/debian/changelog
+++ quota-4.00/debian/changelog
@@ -1,3 +1,12 @@
+quota (4.00-4+deb7u1) testing-proposed-updates; urgency=low
+
+ * Non-maintainer upload.
+ * Add 685356-Fix-reporting-for-XFS.patch patch.
+Fixes quota reporting on XFS filesystems. Cherry-pick commit from
+upstream git repository. (Closes: #685356)
+
+ -- Salvatore Bonaccorso Thu, 27 Dec 2012 07:03:36 +0100
+
quota (4.00-4) unstable; urgency=low
* Added upstream patch to fix problem with editing of several users.
diff -u quota-4.00/debian/patches/series quota-4.00/debian/patches/series
--- quota-4.00/debian/patches/series
+++ quota-4.00/debian/patches/series
@@ -4,0 +5 @@
+685356-Fix-reporting-for-XFS.patch
only in patch2:
unchanged:
--- quota-4.00.orig/debian/patches/685356-Fix-reporting-for-XFS.patch
+++ quota-4.00/debian/patches/685356-Fix-reporting-for-XFS.patch
@@ -0,0 +1,35 @@
+From 6ba6546dd167297cb9ed69d0257ee245b0faea47 Mon Sep 17 00:00:00 2001
+From: Jan Kara
+Date: Fri, 8 Jun 2012 11:11:20 +0200
+Subject: [PATCH] repquota: Fix reporting for XFS
+
+Conversion to generic quota scanning introduced a bug for XFS where we
+stopped scanning after quotactl reported first error. quotactl for XFS
+however reports ENOENT when it has nothing to report for a particular user
+/ group and we shouldn't stop scanning after that. We tried to test for this
+but the test was wrong. Fix it.
+
+Signed-off-by: Jan Kara
+---
+ quotaio_xfs.c |4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/quotaio_xfs.c b/quotaio_xfs.c
+index 2e879e6..903c03e 100644
+--- a/quotaio_xfs.c
b/quotaio_xfs.c
+@@ -183,9 +183,9 @@ static int xfs_get_dquot(struct dquot *dq)
+ memset(&d, 0, sizeof(d));
+ ret = quotactl(qcmd, dq->dq_h->qh_quotadev, dq->dq_id, (void *)&d);
+ if (ret < 0) {
+- if (ret == -ENOENT)
++ if (errno == ENOENT)
+ return 0;
+- return ret;
++ return -1;
+ }
+ xfs_kern2utildqblk(&dq->dq_dqb, &d);
+ return 0;
+--
+1.7.4.1
+
signature.asc
Description: Digital signature
Bug#688321: unblock: quota/4.01-1
On Fri, Sep 21, 2012 at 17:21:32 +0200, Tobias Burnus wrote: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > > Please unblock package quota > http://packages.qa.debian.org/q/quota.html > > The new version fixes Debian bug #685356, namely: > > repquota: Fix reporting for XFS > > Conversion to generic quota scanning introduced a bug for XFS where we > stopped scanning after quotactl reported first error. quotactl for XFS > however reports ENOENT when it has nothing to report for a particular user > / group and we shouldn't stop scanning after that. We tried to test for > this but the test was wrong. Fix it. > The changelog diff is weird: --- quota-4.00/debian/changelog 2012-12-01 12:01:05.0 + +++ quota-4.01/debian/changelog 2012-12-01 12:01:06.0 + @@ -1,11 +1,11 @@ -quota (4.00-4) unstable; urgency=low +quota (4.01-1) unstable; urgency=low - * Added upstream patch to fix problem with editing of several users. -(Closes: #670641) - * Updated packages description which was pretty outdated. -Thanks to Justin B Rye (Closes: #673396) + * Imported Upstream version 4.01 (Closes: #685356) + * Adjusted patch for new upstream version. + * Bumped Standards-Version to 3.9.3, no changes needed. + * Use Debian build flags. - -- Michael Meskes Wed, 23 May 2012 18:35:45 +0200 + -- Michael Meskes Mon, 10 Sep 2012 12:51:40 +0200 quota (4.00-3) unstable; urgency=low What's up with that? Would it be possible to get *only* the xfs fix in testing instead of the whole new release? Cheers, Julien signature.asc Description: Digital signature
Bug#688321: unblock: quota/4.01-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package quota http://packages.qa.debian.org/q/quota.html The new version fixes Debian bug #685356, namely: repquota: Fix reporting for XFS Conversion to generic quota scanning introduced a bug for XFS where we stopped scanning after quotactl reported first error. quotactl for XFS however reports ENOENT when it has nothing to report for a particular user / group and we shouldn't stop scanning after that. We tried to test for this but the test was wrong. Fix it. Changelog from Debian: quota (4.01-1) unstable; urgency=low * Imported Upstream version 4.01 (Closes: #685356) * Adjusted patch for new upstream version. * Bumped Standards-Version to 3.9.3, no changes needed. * Use Debian build flags. Upstream Changelog: Changes in quota-tools from 4.00 to 4.01 * fix compilation failure with --enable-bsd_behaviour=no (Jan Kara) * fix quota(1) for NFS mountpoints (Jan Kara) * fix reporting of huge quota limits over rpc (Jan Kara) * fix repquota to report all users on XFS (Jan Kara) * fixed edquota(8) for more users (Jan Kara) * remove fixed limit on number of autofs mount points (Jan Kara) * add quota type names to message catalogue (Jan Kara) * typo fixes, message changes for easier i18n (Jan Kara) * created Czech translation (Petr Pisar) * store PID of quota_nld into lock file (Petr Pisar) * warnquota: Fix manpage formatting (Jan Kara) * warnquota: Allow specifying of filesystems to check (Jan Kara) * add support for quotas on ext4 in system files (Jan Kara) * quotaon: Remove duplicated check for hasquota() (Jan Kara) * quotacheck: Fix warning about journaled quota for 3.0 and newer kernels (Jan Kara) * edquota: Fix localication of time units (Jan Kara) * rip out ALTFORMAT config option (Jan Kara) * add support for dynamic RPC block to support larger quotas (Petr Pisar) * check set limits fit into the range supported by RPC transport (Petr Pisar) * do not report missing utmp record to syslog (Petr Pisar) unblock quota/4.01-1 -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
