Bug#694452: unblock: gjs/1.32.0-3
Le mardi 18 décembre 2012 à 22:25 +0100, Josselin Mouette a écrit : > Yes it is, but I checked rdeps and they don’t use the function except > for gjs itself. Actually gjs itself doesn’t use this function directly either; it’s meant to be called from JS code. And no gjs rdeps in the archive seem to actually use it in wheezy. Cheers, -- .''`. Josselin Mouette : :' : `. `' `- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#694452: unblock: gjs/1.32.0-3
Le mardi 18 décembre 2012 à 21:39 +0100, Julien Cristau a écrit : > On Mon, Nov 26, 2012 at 15:31:52 +0100, Josselin Mouette wrote: > > > +diff --git a/gjs/context.h b/gjs/context.h > > +index 4e01cc7..d19d8a5 100644 > > +--- a/gjs/context.h > > b/gjs/context.h > > +@@ -68,7 +68,11 @@ gbooleangjs_context_define_string_array > > (GjsContext *js_context, > > + GList* gjs_context_get_all (void); > > + void* gjs_context_get_native_context (GjsContext *js_context); > > + > > ++/* initial_frame is a JSStackFrame, but cannot be exposed as such in the > > ++ public API. Pass NULL to get the topmost frame. > > ++*/ > > + voidgjs_context_print_stack_to_buffer (GjsContext *js_context, > > ++ void > > *initial_frame, > > +GString*buf); > > + > > + voidgjs_context_print_stack_stderr(GjsContext > > *js_context); > > gjs/context.h seems to be a public header, and > gjs_context_print_stack_to_buffer is exported. This looks like ABI > breakage to me? Yes it is, but I checked rdeps and they don’t use the function except for gjs itself. Maybe I need to add a Breaks, though. (As you may have noticed, upstream is not very careful with gjs’ ABI versioning, grrr) -- .''`. Josselin Mouette : :' : `. `' `- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#694452: unblock: gjs/1.32.0-3
On Mon, Nov 26, 2012 at 15:31:52 +0100, Josselin Mouette wrote: > +diff --git a/gjs/context.h b/gjs/context.h > +index 4e01cc7..d19d8a5 100644 > +--- a/gjs/context.h > b/gjs/context.h > +@@ -68,7 +68,11 @@ gbooleangjs_context_define_string_array > (GjsContext *js_context, > + GList* gjs_context_get_all (void); > + void* gjs_context_get_native_context (GjsContext *js_context); > + > ++/* initial_frame is a JSStackFrame, but cannot be exposed as such in the > ++ public API. Pass NULL to get the topmost frame. > ++*/ > + voidgjs_context_print_stack_to_buffer (GjsContext *js_context, > ++ void > *initial_frame, > +GString*buf); > + > + voidgjs_context_print_stack_stderr(GjsContext *js_context); gjs/context.h seems to be a public header, and gjs_context_print_stack_to_buffer is exported. This looks like ABI breakage to me? Cheers, Julien signature.asc Description: Digital signature
Bug#694452: unblock: gjs/1.32.0-3
Control: retitle -1 unblock: gjs/1.32.0-4 Le mardi 11 décembre 2012 à 23:04 +0100, Niels Thykier a écrit : > > I’ll reupload with that additional patch. > > http://git.gnome.org/browse/gjs/commit/?id=5c90e776ce3c > Please go ahead. Done as 1.32.0-4 (it’s the only change). Cheers, -- .''`. Josselin Mouette : :' : `. `' `- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#694452: unblock: gjs/1.32.0-3
Control: tags -1 confirmed On 2012-12-10 09:48, Josselin Mouette wrote: > Le dimanche 09 décembre 2012 à 12:41 +0100, Niels Thykier a écrit : > [...] > > I’ll reupload with that additional patch. > http://git.gnome.org/browse/gjs/commit/?id=5c90e776ce3c > > Cheers, Please go ahead. ~Niels -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#694452: unblock: gjs/1.32.0-3
Le dimanche 09 décembre 2012 à 12:41 +0100, Niels Thykier a écrit :
>
> +-gjs_context_print_stack_to_buffer(GjsContext* context, GString *buf)
> ++gjs_context_print_stack_to_buffer(GjsContext* context, void
> *initial, GString *buf)
> + {
> + JSContext *js_context =
> (JSContext*)gjs_context_get_native_context(context);
> +-JSStackFrame* fp;
> +-JSStackFrame* iter = NULL;
> ++JSStackFrame* fp = initial;
>
> Seems to me that gjs_context_print_stack_to_buffer is (more or less) a
> NO-OP if intial is NULL. (/me read "topmost" as the
> "deepest/innermost" frame, so I was expecting it to dump the "entire"
> stack. If "topmost" has a different meaning here or I missed
> something in the diff, please do correct me)
Awesome review, thanks for noticing.
I’ll reupload with that additional patch.
http://git.gnome.org/browse/gjs/commit/?id=5c90e776ce3c
Cheers,
--
.''`. Josselin Mouette
: :' :
`. `'
`-
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#694452: unblock: gjs/1.32.0-3
Control: tags -1 moreinfo
On 2012-11-26 15:31, Josselin Mouette wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
>
> Please unblock package gjs for an API extension that is necessary for a
> RC bugfix in gnome-documents.
>
> gjs (1.32.0-3) unstable; urgency=low
>
> * 02_gerror_class.patch, 03_gerror_details.patch: patches from
> upstream git. Introduce a class to manage GError correctly.
> Closes: #691551.
> * Bump shblibs version since this extends the API.
>
> Please require 15 days before testing migration since there is a small
> but existing possiblity of impact on gnome-shell and gnome-sushi.
>
> unblock gjs/1.32.0-3
>
> Thanks,
Hi,
I do have a concern or two about the actual diff (see gjs-diff.review,
attached to avoid line-mangling).
~Niels
+--- /dev/null 1970-01-01 00:00:00.0 +
gjs-1.32.0/gi/gerror.c 2012-11-26 10:59:33.538183526 +0100
+@@ -0,0 +1,589 @@
++/* -*- mode: C; c-basic-offset: 4; indent-tabs-mode: nil; -*- */
++/*
++ * Copyright (c) 2008 litl, LLC
Copy-waste? Similar coment for the .h file (in case it is)
I am a bit concerned about:
"""
+--- a/gjs/context.h
b/gjs/context.h
+@@ -68,7 +68,11 @@ gbooleangjs_context_define_string_array
(GjsContext *js_context,
+ GList* gjs_context_get_all (void);
+ void* gjs_context_get_native_context (GjsContext *js_context);
+
++/* initial_frame is a JSStackFrame, but cannot be exposed as such in the
++ public API. Pass NULL to get the topmost frame.
++*/
+ voidgjs_context_print_stack_to_buffer (GjsContext *js_context,
++ void *initial_frame,
+GString*buf);
"""
combined with
"""
+ void
+-gjs_context_print_stack_to_buffer(GjsContext* context, GString *buf)
++gjs_context_print_stack_to_buffer(GjsContext* context, void *initial, GString
*buf)
+ {
+ JSContext *js_context =
(JSContext*)gjs_context_get_native_context(context);
+-JSStackFrame* fp;
+-JSStackFrame* iter = NULL;
++JSStackFrame* fp = initial;
+ int num = 0;
+
+-g_string_append_printf(buf, "== Stack trace for context %p ==\n",
context);
+-while ((fp = JS_FrameIterator(js_context, &iter)) != NULL) {
++while (fp) {
^^
+ format_frame(js_context, fp, buf, num);
+ num++;
+-}
+
+-if(!num)
+-g_string_append_printf(buf, "(JavaScript stack is empty)\n");
+-g_string_append(buf, "\n");
++ JS_FrameIterator(js_context, &fp);
++}
+ }
"""
Seems to me that gjs_context_print_stack_to_buffer is (more or less) a
NO-OP if intial is NULL. (/me read "topmost" as the
"deepest/innermost" frame, so I was expecting it to dump the "entire"
stack. If "topmost" has a different meaning here or I missed
something in the diff, please do correct me)
