I'm not planning to sponsor this but here is a review:
I wonder if the low-level nvram reading code should be replaced with a
Linux driver?
Please run tagpending from devscripts before uploading to mentors.
Please mention why debian/tpb.devfs is being dropped in the changelog.
fix-spelling-error-in-manpage.patch contains an invalid Bug URL.
Please send the patches upstream or mark them as forwarded using DEP-3:
http://dep.debian.net/deps/dep3/
The watch file doesn't account for the possibility of upstream
changing tarball formats. There is at least one other mistake in the
watch file:
https://wiki.debian.org/debian/watch#Common_mistakes
You may want to switch to debhelper compat 9 and dh instead of manual
dh_* sequencing for debian/rules.
You may want to use dh-autoreconf instead of autotools-dev.
The package fails to build twice in a row.
Various files have the incorrect FSF address, please to ask upstream
to fix them.
intl/plural.c is a generated file, please ensure that it is
regenerated at build time.
You might want to help review other packages:
http://mentors.debian.net/intro-reviewers
If you contact upstream, please mention our upstream guide:
http://wiki.debian.org/UpstreamGuide
Automatic checks:
https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
gcc:
cfg.c: In function 'override_cfg':
cfg.c:965:21: warning: comparison between 'xosd_pos' and 'enum state'
[-Wenum-compare]
cfg.c:971:23: warning: comparison between 'xosd_align' and 'enum
state' [-Wenum-compare]
cfg.c: At top level:
cfg.c:45:29: warning: 'RCSid' defined but not used [-Wunused-variable]
tpb.c:55:29: warning: 'RCSid' defined but not used [-Wunused-variable]
tpb.c: In function 'fork_app':
tpb.c:1260:12: warning: ignoring return value of 'chdir', declared
with attribute warn_unused_result [-Wunused-result]
tpb.c: In function 'daemonize':
tpb.c:779:8: warning: ignoring return value of 'chdir', declared with
attribute warn_unused_result [-Wunused-result]
tpb.c:790:6: warning: ignoring return value of 'dup', declared with
attribute warn_unused_result [-Wunused-result]
tpb.c:793:6: warning: ignoring return value of 'dup', declared with
attribute warn_unused_result [-Wunused-result]
dpkg-shlibdeps:
warning: package could avoid a useless dependency if
debian/tpb/usr/bin/tpb was not linked against libXinerama.so.1 (it
uses none of the library's symbols)
warning: package could avoid a useless dependency if
debian/tpb/usr/bin/tpb was not linked against libSM.so.6 (it uses none
of the library's symbols)
warning: package could avoid a useless dependency if
debian/tpb/usr/bin/tpb was not linked against libICE.so.6 (it uses
none of the library's symbols)
warning: package could avoid a useless dependency if
debian/tpb/usr/bin/tpb was not linked against libXext.so.6 (it uses
none of the library's symbols)
cppcheck:
[intl/localcharset.c:153]: (error) Common realloc mistake: 'res_ptr'
nulled but not freed upon failure
msgfmt:
lots of fuzzy/empty things ignored.
POFileChecker:
po-file-checker
file name=./debian/po/id.po allow=0
error line=46 message=5missing ./error
/file
file name=./debian/po/de.po allow=0
error line=53 message=5missing ./error
/file
file name=./debian/po/nl.po allow=0
error line=46 message=5missing ./error
/file
file name=./debian/po/ja.po allow=0
error line=54 message=5missing ./error
/file
file name=./po/fr.po allow=0
error line=577 message=122extra amp; acelerator/error
error line=582 message=123extra amp; acelerator/error
error line=587 message=124extra amp; acelerator/error
error line=592 message=125extra amp; acelerator/error
/file
file name=./po/da.po allow=0
error line=18 message=2missing :/error
/file
file name=./po/de.po allow=0
error line=216 message=49missing :/error
/file
/po-file-checker
isutf8:
./debian/po/fr.po: line 38, char 1, byte offset 18: invalid UTF-8 code
./debian/po/de.po: line 31, char 1, byte offset 46: invalid UTF-8 code
./debian/po/sv.po: line 30, char 1, byte offset 18: invalid UTF-8 code
./debian/po/ja.po: line 32, char 1, byte offset 13: invalid UTF-8 code
./debian/po/cs.po: line 31, char 1, byte offset 22: invalid UTF-8 code
./debian/patches/add-french-traslation.patch: line 35, char 1, byte
offset 6: invalid UTF-8 code
./debian/patches/fix-spelling-error-in-binary.patch: line 18, char 1,
byte offset 44: invalid UTF-8 code
./po/fr.po: line 3, char 1, byte offset 5: invalid UTF-8 code
./po/da.po: line 19, char 1, byte offset 48: invalid UTF-8 code
./po/de.po: line 19, char 1, byte offset 10: invalid UTF-8 code
./po/ru.po: line 18, char 1, byte offset 9: invalid UTF-8 code
./intl/locale.alias: line 33, char 1, byte offset 5: invalid UTF-8 code
--
bye,
pabs
http://wiki.debian.org/PaulWise
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
