Bug#706170: xosview: platform detection improvement/fix in debian/rules
Alle venerdì 26 aprile 2013, Kartik Mistry ha scritto: On Fri, Apr 26, 2013 at 2:05 AM, Pino Toscano p...@debian.org wrote: the changes in the experimental version still make xosview compiled as linux even in non-Linux OSes, and never uses the right platform string on kFreeBSD. The attached patch factorizes the detection of the platform string to use when invoking make, - making it use the right one on kFreeBSD (which though won't compile yet, and that will need proper fixes) - bailing out when the OS is not recognized, and it is easy (just add the two proper lines in that if chain, e.g. starting from the kfreebsd ones) to add cases for new OSes Thanks a lot. I was about to commit my fix in git repo (and also realized that kfreebsd build is not yet ready!), but your patch is way much better. Committed to git repo. I'll disable kfreebsd-* build and upload in a day or two. Thanks, but why leaving it commented and removing the kfreebsd build? After all, xosview on kfreebsd has not been compiled before, so having it fail is not a regression wrt previous versions (thus it won't stop xosview migrating to testing, when uploaded to unstable). Just leave the platform selection as it is and readd kfreebsd-any as architecture for xosview, so kfreebsd porters can notice the build failure and possibly provide patches for it. -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Bug#706170: xosview: platform detection improvement/fix in debian/rules
On Fri, Apr 26, 2013 at 1:13 PM, Pino Toscano p...@debian.org wrote:
Thanks, but why leaving it commented and removing the kfreebsd build?
After all, xosview on kfreebsd has not been compiled before, so having
it fail is not a regression wrt previous versions (thus it won't stop
xosview migrating to testing, when uploaded to unstable).
Just leave the platform selection as it is and readd kfreebsd-any as
architecture for xosview, so kfreebsd porters can notice the build
failure and possibly provide patches for it.
Great. Done.
--
Kartik Mistry | IRC: kart_
{0x1f1f, kartikm}.wordpress.com
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#706170: xosview: platform detection improvement/fix in debian/rules
Alle venerdì 26 aprile 2013, Kartik Mistry ha scritto: On Fri, Apr 26, 2013 at 1:13 PM, Pino Toscano p...@debian.org wrote: Thanks, but why leaving it commented and removing the kfreebsd build? After all, xosview on kfreebsd has not been compiled before, so having it fail is not a regression wrt previous versions (thus it won't stop xosview migrating to testing, when uploaded to unstable). Just leave the platform selection as it is and readd kfreebsd-any as architecture for xosview, so kfreebsd porters can notice the build failure and possibly provide patches for it. Great. Done. Thanks. Just one niptick more: you can replace «kfreebsd-amd64 kfreebsd-i386» with just «kfreebsd-any» in both the libkvm-dev build dependency and in the Architecture control field. There's nothing potentially specific to amd64 or i386, so (once fixed) it will work fine with any other kfreebsd arch. -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Bug#706170: xosview: platform detection improvement/fix in debian/rules
On Fri, Apr 26, 2013 at 1:31 PM, Pino Toscano p...@debian.org wrote:
Just one niptick more: you can replace «kfreebsd-amd64 kfreebsd-i386»
with just «kfreebsd-any» in both the libkvm-dev build dependency and in
the Architecture control field. There's nothing potentially specific to
amd64 or i386, so (once fixed) it will work fine with any other kfreebsd
arch.
Look like I'm doing some silly mistakes :)
Thanks. Done.
--
Kartik Mistry | IRC: kart_
{0x1f1f, kartikm}.wordpress.com
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#706170: xosview: platform detection improvement/fix in debian/rules
Source: xosview Version: 1.14-1 Severity: wishlist Tags: patch Hi, the changes in the experimental version still make xosview compiled as linux even in non-Linux OSes, and never uses the right platform string on kFreeBSD. The attached patch factorizes the detection of the platform string to use when invoking make, - making it use the right one on kFreeBSD (which though won't compile yet, and that will need proper fixes) - bailing out when the OS is not recognized, and it is easy (just add the two proper lines in that if chain, e.g. starting from the kfreebsd ones) to add cases for new OSes Thanks, -- Pino --- a/debian/rules +++ b/debian/rules @@ -9,23 +9,20 @@ CXX=g++ DEB_BUILD_ARCH_OS ?=$(shell dpkg-architecture -qDEB_BUILD_ARCH_OS) +ifeq ($(DEB_BUILD_ARCH_OS),linux) + PLATFORM=linux +else ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd) + PLATFORM=bsd +else + $(error Missing implementation for $(DEB_BUILD_ARCH_OS)) +endif build: build-arch build-indep build-arch: build-stamp build-indep: build-stamp build-stamp: dh_testdir - -#experimental kfreebsd-* support -ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd-i386) - $(MAKE) PLATFORM=bsd -else -ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd-amd64) - $(MAKE) PLATFORM=bsd -endif -endif - - $(MAKE) PLATFORM=linux + $(MAKE) PLATFORM=$(PLATFORM) touch $@ clean:
Bug#706170: xosview: platform detection improvement/fix in debian/rules
On Fri, Apr 26, 2013 at 2:05 AM, Pino Toscano p...@debian.org wrote:
the changes in the experimental version still make xosview compiled as
linux even in non-Linux OSes, and never uses the right platform
string on kFreeBSD.
The attached patch factorizes the detection of the platform string
to use when invoking make,
- making it use the right one on kFreeBSD (which though won't compile
yet, and that will need proper fixes)
- bailing out when the OS is not recognized, and it is easy (just add
the two proper lines in that if chain, e.g. starting from the
kfreebsd ones) to add cases for new OSes
Thanks a lot. I was about to commit my fix in git repo (and also
realized that kfreebsd build is not yet ready!), but your patch is way
much better. Committed to git repo. I'll disable kfreebsd-* build and
upload in a day or two.
--
Kartik Mistry | IRC: kart_
{0x1f1f, kartikm}.wordpress.com
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
