Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On Mon, Jan 27, 2014 at 4:20 PM, Kai Storbeck k...@xs4all.nl wrote: On 27/01/2014 04:25, Andrew Starr-Bochicchio wrote: Hi Kai, I came across your package on mentors, and I am interested in sponsoring it. Though, I ran into a few issues that need to be fixed first. Hello Andrew, Thanks for your response. I've marked the package as no need for a sponsor, but your feedback is very welcome. Perhaps my discussions with Sebastian should've been Cc'ed to this bug. No worries. Less work for me! 1) You seem to maintain the packaging in a VCS: Since I'm joining the python application packaging team, I'll be moving to SVN. I'm probably going to import the last uploaded version (1.20-1 or 1.1?) to svn.debian.org with this command: $ svn import -m New import roundup \ svn+ssh://svn.debian.org/svn/python-apps/packages/roundup/trunk Would that do the right thing? I presume I now have access to svn.debian.org, being in the team listing on Alioth? Would you know that? If you don't know, I'll ask on the debian-python listing. You can use svn-inject. It will take care of creating the needed directories and such. Take a look here: https://wiki.debian.org/Teams/PythonAppsPackagingTeam/HowTo 2) There are minified version of JQuery and Bootstrap located in: share/roundup/templates/jinja2/static Thanks. I'm aware of that; Sebastian pointed this out too. I've already posted upstream to ask them to include a non-minified version. For 1.5.0 I'm a bit in the dark on how to proceed. Can I remove those files, and ship a symlink to jquery and bootstrap packages? Or should I make a full-fledged _dfsg.tgz file, and build from that? IMHO, I'd go ahead and create a DFSG tarball removing them. This can now be automated with the latest version of uscan. See here: https://wiki.debian.org/UscanEnhancements As you already remove other copies of JQuery in other templates, you probably already know that you should use the system copies. Additionally, minified JavaScript objects that are installed with the binary package must be built from source. Same goes for the minified Bootstrap css files in that directory. Ah. css too. Sometimes I think its less work to let upstream build a package, and let it drop from debian. I know the feeling, but I'd encourage you not to give up! Also, as long as these files are shipped in the tarball, their license information needs to be documented in debian/copyright. Ouch. They are using bootstrap 2.2.2. That tarfile is not downloadable from getbootstrap.com anymore, so I can only guess that this was licenced under Apache 2.0. Would that be enough? Sure. The file header reads: * Bootstrap v2.2.2 * * Copyright 2012 Twitter, Inc * Licensed under the Apache License v2.0 * http://www.apache.org/licenses/LICENSE-2.0 Also it seems to still be available on their github: https://github.com/twbs/bootstrap/releases/tag/v2.2.2 -- Andrew Starr-Bochicchio Ubuntu Developer https://launchpad.net/~andrewsomething Debian Developer http://qa.debian.org/developer.php?login=asb PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
Le 27 janv. 2014 17:45, Andrew Starr-Bochicchio a...@debian.org a écrit : On Mon, Jan 27, 2014 at 2:04 AM, Bastien ROUCARIES roucaries.bast...@gmail.com wrote: Le 27 janv. 2014 04:27, Andrew Starr-Bochicchio a...@debian.org a écrit : On Thu, Oct 17, 2013 at 5:20 PM, Kai Storbeck k...@xs4all.nl wrote: I have updated roundup_1.5.0-1 per the 17th of October with a few changes after getting feedback by Sebastian Ramacher. Hi Kai, I came across your package on mentors, and I am interested in sponsoring it. Though, I ran into a few issues that need to be fixed first. I have just filled two rc severity bug against your package. Please close it. This isn't a particularly useful message. What are the issues you are filing bugs about? I see no RC bugs against roundup right now, did you really file these bugs? What are their numbers? Src:roundup #736782 The minified js files I pointed out only exist on mentors, not in the version in the archive. That's the only thing I can guess this is about. -- Andrew Starr-Bochicchio Ubuntu Developer https://launchpad.net/~andrewsomething Debian Developer http://qa.debian.org/developer.php?login=asb PGP/GPG Key ID: D53FDCB1
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On Mon, Jan 27, 2014 at 2:10 PM, Bastien ROUCARIES roucaries.bast...@gmail.com wrote: I have just filled two rc severity bug against your package. Please close it. This isn't a particularly useful message. What are the issues you are filing bugs about? I see no RC bugs against roundup right now, did you really file these bugs? What are their numbers? Src:roundup #736782 That bug seems to be about Src:roundcube. This thread is about Src:roundup. Similar names, different packages. Thanks, -- Andrew Starr-Bochicchio Ubuntu Developer https://launchpad.net/~andrewsomething Debian Developer http://qa.debian.org/developer.php?login=asb PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On 27/01/2014 04:25, Andrew Starr-Bochicchio wrote:
On Thu, Oct 17, 2013 at 5:20 PM, Kai Storbeck k...@xs4all.nl wrote:
I have updated roundup_1.5.0-1 per the 17th of October with a few
changes after getting feedback by Sebastian Ramacher.
Hi Kai,
I came across your package on mentors, and I am interested in
sponsoring it. Though, I ran into a few issues that need to be fixed
first.
Hello Andrew,
Thanks for your response. I've marked the package as no need for a
sponsor, but your feedback is very welcome.
Perhaps my discussions with Sebastian should've been Cc'ed to this bug.
1) You seem to maintain the packaging in a VCS:
* Move to git-dpm packaging
In that case, it is very useful to include Vcs-{Git, Svn, Bzr} and
Vcs-Browser fields in debian/control:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-VCS-fields
Perhaps you can help me with this.
Since I'm joining the python application packaging team, I'll be moving
to SVN. I'm probably going to import the last uploaded version (1.20-1
or 1.1?) to svn.debian.org with this command:
$ svn import -m New import roundup \
svn+ssh://svn.debian.org/svn/python-apps/packages/roundup/trunk
Would that do the right thing? I presume I now have access to
svn.debian.org, being in the team listing on Alioth? Would you know that?
If you don't know, I'll ask on the debian-python listing.
2) There are minified version of JQuery and Bootstrap located in:
share/roundup/templates/jinja2/static
Thanks. I'm aware of that; Sebastian pointed this out too. I've already
posted upstream to ask them to include a non-minified version.
For 1.5.0 I'm a bit in the dark on how to proceed. Can I remove those
files, and ship a symlink to jquery and bootstrap packages? Or should I
make a full-fledged _dfsg.tgz file, and build from that?
As you already remove other copies of JQuery in other templates, you
probably already know that you should use the system copies.
Additionally, minified JavaScript objects that are installed with the
binary package must be built from source. Same goes for the minified
Bootstrap css files in that directory.
Ah. css too. Sometimes I think its less work to let upstream build a
package, and let it drop from debian.
Also, as long as these files are shipped in the tarball, their license
information needs to be documented in debian/copyright.
Ouch. They are using bootstrap 2.2.2. That tarfile is not downloadable
from getbootstrap.com anymore, so I can only guess that this was
licenced under Apache 2.0. Would that be enough?
So, what should I do: remove the not working template from 1.5.0, or
ship with a broken template? We're talking 1.5.0, since 1.5.1 is not
released yet, and I haven't heard words about estimates.
3) You seemed to remove some necessary bits from your postrm to clean
up when purging the package. From piuparts:
3m20.5s ERROR: FAIL: Package purging left files on system:
/etc/roundup/ owned by: roundup
/etc/roundup/service/ not owned
/etc/roundup/service/log/ not owned
3m20.5s ERROR: FAIL: Installation, upgrade and purging tests.
I'm aware of that too. I hadn't started working on both issues, pending
my move to subversion.
There maybe further issues. This is just as far as I got. I'd be happy
to do a closer review and hopefully sponsor the package once these
problems are fixed.
Thanks for your work on Debian!
Cheers. I find it quite a lot of work for a niche leave-package, and its
not an easy package to start out with. Sadly.
Regards,
Kai
signature.asc
Description: OpenPGP digital signature
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On Mon, Jan 27, 2014 at 2:04 AM, Bastien ROUCARIES roucaries.bast...@gmail.com wrote: Le 27 janv. 2014 04:27, Andrew Starr-Bochicchio a...@debian.org a écrit : On Thu, Oct 17, 2013 at 5:20 PM, Kai Storbeck k...@xs4all.nl wrote: I have updated roundup_1.5.0-1 per the 17th of October with a few changes after getting feedback by Sebastian Ramacher. Hi Kai, I came across your package on mentors, and I am interested in sponsoring it. Though, I ran into a few issues that need to be fixed first. I have just filled two rc severity bug against your package. Please close it. This isn't a particularly useful message. What are the issues you are filing bugs about? I see no RC bugs against roundup right now, did you really file these bugs? What are their numbers? The minified js files I pointed out only exist on mentors, not in the version in the archive. That's the only thing I can guess this is about. -- Andrew Starr-Bochicchio Ubuntu Developer https://launchpad.net/~andrewsomething Debian Developer http://qa.debian.org/developer.php?login=asb PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On Thu, Oct 17, 2013 at 5:20 PM, Kai Storbeck k...@xs4all.nl wrote:
I have updated roundup_1.5.0-1 per the 17th of October with a few
changes after getting feedback by Sebastian Ramacher.
Hi Kai,
I came across your package on mentors, and I am interested in
sponsoring it. Though, I ran into a few issues that need to be fixed
first.
1) You seem to maintain the packaging in a VCS:
* Move to git-dpm packaging
In that case, it is very useful to include Vcs-{Git, Svn, Bzr} and
Vcs-Browser fields in debian/control:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-VCS-fields
2) There are minified version of JQuery and Bootstrap located in:
share/roundup/templates/jinja2/static
As you already remove other copies of JQuery in other templates, you
probably already know that you should use the system copies.
Additionally, minified JavaScript objects that are installed with the
binary package must be built from source. Same goes for the minified
Bootstrap css files in that directory.
Also, as long as these files are shipped in the tarball, their license
information needs to be documented in debian/copyright.
3) You seemed to remove some necessary bits from your postrm to clean
up when purging the package. From piuparts:
3m20.5s ERROR: FAIL: Package purging left files on system:
/etc/roundup/ owned by: roundup
/etc/roundup/service/ not owned
/etc/roundup/service/log/ not owned
3m20.5s ERROR: FAIL: Installation, upgrade and purging tests.
There maybe further issues. This is just as far as I got. I'd be happy
to do a closer review and hopefully sponsor the package once these
problems are fixed.
Thanks for your work on Debian!
-- Andrew Starr-Bochicchio
Ubuntu Developer https://launchpad.net/~andrewsomething
Debian Developer http://qa.debian.org/developer.php?login=asb
PGP/GPG Key ID: D53FDCB1
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
Le 27 janv. 2014 04:27, Andrew Starr-Bochicchio a...@debian.org a écrit :
On Thu, Oct 17, 2013 at 5:20 PM, Kai Storbeck k...@xs4all.nl wrote:
I have updated roundup_1.5.0-1 per the 17th of October with a few
changes after getting feedback by Sebastian Ramacher.
Hi Kai,
I came across your package on mentors, and I am interested in
sponsoring it. Though, I ran into a few issues that need to be fixed
first.
I have just filled two rc severity bug against your package. Please close
it.
Bastien
1) You seem to maintain the packaging in a VCS:
* Move to git-dpm packaging
In that case, it is very useful to include Vcs-{Git, Svn, Bzr} and
Vcs-Browser fields in debian/control:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-VCS-fields
2) There are minified version of JQuery and Bootstrap located in:
share/roundup/templates/jinja2/static
As you already remove other copies of JQuery in other templates, you
probably already know that you should use the system copies.
Additionally, minified JavaScript objects that are installed with the
binary package must be built from source. Same goes for the minified
Bootstrap css files in that directory.
Also, as long as these files are shipped in the tarball, their license
information needs to be documented in debian/copyright.
3) You seemed to remove some necessary bits from your postrm to clean
up when purging the package. From piuparts:
3m20.5s ERROR: FAIL: Package purging left files on system:
/etc/roundup/ owned by: roundup
/etc/roundup/service/ not owned
/etc/roundup/service/log/ not owned
3m20.5s ERROR: FAIL: Installation, upgrade and purging tests.
There maybe further issues. This is just as far as I got. I'd be happy
to do a closer review and hopefully sponsor the package once these
problems are fixed.
Thanks for your work on Debian!
-- Andrew Starr-Bochicchio
Ubuntu Developer https://launchpad.net/~andrewsomething
Debian Developer http://qa.debian.org/developer.php?login=asb
PGP/GPG Key ID: D53FDCB1
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact
listmas...@lists.debian.org
Archive:
http://lists.debian.org/CAL6k_Ayk1wykGHTKh7-D9vs-xq=ur+27x_taocr76qxm_ha...@mail.gmail.com
Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On 8/15/13 3:21 PM, Debian Bug Tracking System wrote: Thank you for filing a new Bug report with Debian. I have updated roundup_1.5.0-1 per the 17th of October with a few changes after getting feedback by Sebastian Ramacher. - I removed runit support; - added a NEWS.Debian section about this - Added in a WSGI example application and libapache2-mod-wsgi examples (And Suggests) - Rewrote large parts of the README.Debian to be consistent with the above changes. This should close an extra bug: #604074 - Made a debhelper Build dependency on 8.2 instead of 8. - Changed the debian/compat from 7 to 8. - removed an old occurrence of dh_installoverrides (unused) - /etc/defaults/roundup contains a $RUN variable defaulting to 'no'. - Added more NEWS about this. - Rebuild the documentation using sphinx, fix an upstream sphinx layout issue. This removed some lintian4py warnings. - #DEBHELPER# tags are now present in all the *.(pre|post)(inst|rm) scripts where they are needed. Removed lintian overrides. Lots of work done I think. Regards, Kai signature.asc Description: OpenPGP digital signature
