Bug#566901: Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-17 Thread Markus Koschany
Hi Vincent,

On 17.10.2013 19:12, Vincent Fourmond wrote:
[...]
>   Good job for checking all that !

You're welcome.

> 
>> As you said verifying that everything works as intended is time
>> consuming. Therefore I have targeted the new revision for experimental.
>> I suggest to ask the maintainers/uploaders of these rdeps to confirm
>> that their packages still work fine with the new version as soon as it
>> enters experimental. Hopefully this will speed things up a little.
> 
>   That's definitely the way to go. I can review/sponsor this upload
> this week-end if you wish.

Alright, thank you! I forgot to close #566901 in debian/changelog.
Updated debdiff is attached.

Cheers,

Markus




diff -Nru batik-1.7+dfsg/debian/batik.manpages 
batik-1.7+dfsg/debian/batik.manpages
--- batik-1.7+dfsg/debian/batik.manpages1970-01-01 01:00:00.0 
+0100
+++ batik-1.7+dfsg/debian/batik.manpages2013-10-17 21:43:10.0 
+0200
@@ -0,0 +1,4 @@
+debian/manpages/rasterizer.1
+debian/manpages/svgpp.1
+debian/manpages/squiggle.1
+debian/manpages/ttf2svg.1
diff -Nru batik-1.7+dfsg/debian/changelog batik-1.7+dfsg/debian/changelog
--- batik-1.7+dfsg/debian/changelog 2013-10-17 06:59:23.0 +0200
+++ batik-1.7+dfsg/debian/changelog 2013-10-17 21:45:09.0 +0200
@@ -1,3 +1,16 @@
+batik (1.7+dfsg-5) experimental; urgency=low
+
+  * Team upload.
+  * Split the package in libbatik-java and batik. (Closes: #566901)
+- Rename manifest to libbatik-java.manifest.
+- Install man pages with batik.manpages.
+- Set Breaks and Replaces relation accordingly.
+- debian/rules: Install wrapper scripts to batik package.
+- debian/control: Add new binary package batik.
+  * Drop libbatik-java.dirs. Not needed.
+
+ -- Markus Koschany   Thu, 17 Oct 2013 17:46:02 +0200
+
 batik (1.7+dfsg-4) unstable; urgency=low
 
   * Team upload.
@@ -13,7 +26,7 @@
   * Bump compat level to 9 and require debhelper >= 9.
   * Use canonical VCS-URI.
   * Remove Michael Koch from Uploaders. (Closes: #653996)
-  * libatik-java: Drop all jre/jdk dependencies. Recommend default-jre instead.
+  * libbatik-java: Drop all jre/jdk dependencies. Recommend default-jre 
instead.
   * Run wrap-and-sort -sa
   * Add DEP-3 header to all patches.
 
diff -Nru batik-1.7+dfsg/debian/control batik-1.7+dfsg/debian/control
--- batik-1.7+dfsg/debian/control   2013-10-17 06:59:23.0 +0200
+++ batik-1.7+dfsg/debian/control   2013-10-17 21:43:10.0 +0200
@@ -14,7 +14,7 @@
  ant,
  default-jdk,
  javahelper,
- libavalon-framework-java (>= 4.2.0),
+ libavalon-framework-java,
  libbsf-java,
  libcommons-io-java,
  libcommons-logging-java,
@@ -29,18 +29,13 @@
 Package: libbatik-java
 Architecture: all
 Depends:
- java-wrappers (>= 0.1.12),
- libavalon-framework-java (>= 4.2.0),
+ libavalon-framework-java,
  libbsf-java,
  libcommons-io-java,
  libcommons-logging-java,
  libxalan2-java,
  libxml-commons-external-java,
  ${misc:Depends}
-Recommends:
- fop (>= 1:0.94),
- rhino,
- default-jre
 Description: xml.apache.org SVG Library
  Batik is a toolkit for applications or applets that want to use images
  in the Scalable Vector Graphics (SVG) format for various purposes, such
@@ -52,8 +47,34 @@
   * A module to convert SVG to various formats, such as raster images
 (JPEG, PNG or Tiff) and PS, PDF.
  .
+ For detailed information, go to http://xml.apache.org/batik/
+
+Package: batik
+Architecture: all
+Depends:
+ java-wrappers,
+ libbatik-java (>= ${source:Version}),
+ ${misc:Depends},
+ default-jre | java7-runtime
+Recommends:
+ fop,
+ rhino
+Breaks: libbatik-java (<< 1.7+dfsg-5)
+Replaces: libbatik-java (<< 1.7+dfsg-5)
+Description: xml.apache.org SVG Library -- wrapper scripts
+ This package provides the wrapper scripts for rasterizer, squiggle, ttf2svg
+ and svgpp.
+ .
+ Batik is a toolkit for applications or applets that want to use images
+ in the Scalable Vector Graphics (SVG) format for various purposes, such
+ as viewing, generation or manipulation.
+ .
+ Batik provides several modules to be used in applications:
+  * A SVG generator module, usable to export graphics into the SVG format.
+  * A SVG processor and SVG Viewing component for integrating SVG viewing.
+  * A module to convert SVG to various formats, such as raster images
+(JPEG, PNG or Tiff) and PS, PDF.
+ .
  fop is necessary for PDF output of rasterizer.
  .
  rhino is necessary for using the SVG browser, squiggle.
- .
- For detailed information, go to http://xml.apache.org/batik/
diff -Nru batik-1.7+dfsg/debian/libbatik-java.dirs 
batik-1.7+dfsg/debian/libbatik-java.dirs
--- batik-1.7+dfsg/debian/libbatik-java.dirs2010-11-25 01:18:24.0 
+0100
+++ batik-1.7+dfsg/debian/libbatik-java.dirs1970-01-01 01:00:00.0 
+0100
@@ -1 +0,0 @@
-usr/share/java
diff -Nru batik-1.7+dfsg/debian/libbatik-java.manifest 
batik-1.7+dfsg/debian/libbatik-java.manifest
--- batik-1.7+dfsg/debian/libbatik-java.manifest1970-01-01 

Bug#566901: Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-17 Thread Vincent Fourmond
  Hi Markus,

On Thu, Oct 17, 2013 at 6:15 PM, Markus Koschany  wrote:
> Control: tags 566901 patch
>
> Hi Vincent,
>
> On 17.10.2013 15:07, Vincent Fourmond wrote:
> [...]
>>   I don't have the time to review the patch right now. I can have a
>> look this week-end, if you want more eyes, but if you feel confident
>> about the current state, I don't mind an upload as-is.
>
> No worries. Tony Mancill has uploaded the bug fixes for #725461 already.
> Now I'm attaching the debdiff with all the changes to split the package
> into libbatik-java and batik.
>
> I can confirm that these rdeps still build fine with those changes:
>
> scilab-full-bin
> umlet
> sweethome3d-furniture-editor
> sweethome3d
> scilab-full-bin
> osmosis (FTBFS because of a another bug)
> libjeuclid-core-java
> libjcharts-java
> libjaxe-java
> libjasperreports3.7-java
> libjasperreports-java
> freeplane
> freemind-plugins-svg
> libfop-java
> libflamingo-java
> ditaa

  Good job for checking all that !

> As you said verifying that everything works as intended is time
> consuming. Therefore I have targeted the new revision for experimental.
> I suggest to ask the maintainers/uploaders of these rdeps to confirm
> that their packages still work fine with the new version as soon as it
> enters experimental. Hopefully this will speed things up a little.

  That's definitely the way to go. I can review/sponsor this upload
this week-end if you wish.

  Cheers,

  Vincent


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#566901: Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-17 Thread Markus Koschany
Control: tags 566901 patch

Hi Vincent,

On 17.10.2013 15:07, Vincent Fourmond wrote:
[...]
>   I don't have the time to review the patch right now. I can have a
> look this week-end, if you want more eyes, but if you feel confident
> about the current state, I don't mind an upload as-is.

No worries. Tony Mancill has uploaded the bug fixes for #725461 already.
Now I'm attaching the debdiff with all the changes to split the package
into libbatik-java and batik.

I can confirm that these rdeps still build fine with those changes:

scilab-full-bin
umlet
sweethome3d-furniture-editor
sweethome3d
scilab-full-bin
osmosis (FTBFS because of a another bug)
libjeuclid-core-java
libjcharts-java
libjaxe-java
libjasperreports3.7-java
libjasperreports-java
freeplane
freemind-plugins-svg
libfop-java
libflamingo-java
ditaa

As you said verifying that everything works as intended is time
consuming. Therefore I have targeted the new revision for experimental.
I suggest to ask the maintainers/uploaders of these rdeps to confirm
that their packages still work fine with the new version as soon as it
enters experimental. Hopefully this will speed things up a little.

Regards,

Markus
diff -Nru batik-1.7+dfsg/debian/batik.manpages 
batik-1.7+dfsg/debian/batik.manpages
--- batik-1.7+dfsg/debian/batik.manpages1970-01-01 01:00:00.0 
+0100
+++ batik-1.7+dfsg/debian/batik.manpages2013-10-17 17:52:28.0 
+0200
@@ -0,0 +1,4 @@
+debian/manpages/rasterizer.1
+debian/manpages/svgpp.1
+debian/manpages/squiggle.1
+debian/manpages/ttf2svg.1
diff -Nru batik-1.7+dfsg/debian/changelog batik-1.7+dfsg/debian/changelog
--- batik-1.7+dfsg/debian/changelog 2013-10-17 06:59:23.0 +0200
+++ batik-1.7+dfsg/debian/changelog 2013-10-17 17:52:28.0 +0200
@@ -1,3 +1,16 @@
+batik (1.7+dfsg-5) experimental; urgency=low
+
+  * Team upload.
+  * Split the package in libbatik-java and batik.
+- Rename manifest to libbatik-java.manifest.
+- Install man pages with batik.manpages.
+- Set Breaks and Replaces relation accordingly.
+- debian/rules: Install wrapper scripts to batik package.
+- debian/control: Add new binary package batik.
+  * Drop libbatik-java.dirs. Not needed.
+
+ -- Markus Koschany   Thu, 17 Oct 2013 17:46:02 +0200
+
 batik (1.7+dfsg-4) unstable; urgency=low
 
   * Team upload.
diff -Nru batik-1.7+dfsg/debian/control batik-1.7+dfsg/debian/control
--- batik-1.7+dfsg/debian/control   2013-10-17 06:59:23.0 +0200
+++ batik-1.7+dfsg/debian/control   2013-10-17 17:52:28.0 +0200
@@ -14,7 +14,7 @@
  ant,
  default-jdk,
  javahelper,
- libavalon-framework-java (>= 4.2.0),
+ libavalon-framework-java,
  libbsf-java,
  libcommons-io-java,
  libcommons-logging-java,
@@ -29,18 +29,13 @@
 Package: libbatik-java
 Architecture: all
 Depends:
- java-wrappers (>= 0.1.12),
- libavalon-framework-java (>= 4.2.0),
+ libavalon-framework-java,
  libbsf-java,
  libcommons-io-java,
  libcommons-logging-java,
  libxalan2-java,
  libxml-commons-external-java,
  ${misc:Depends}
-Recommends:
- fop (>= 1:0.94),
- rhino,
- default-jre
 Description: xml.apache.org SVG Library
  Batik is a toolkit for applications or applets that want to use images
  in the Scalable Vector Graphics (SVG) format for various purposes, such
@@ -52,8 +47,34 @@
   * A module to convert SVG to various formats, such as raster images
 (JPEG, PNG or Tiff) and PS, PDF.
  .
+ For detailed information, go to http://xml.apache.org/batik/
+
+Package: batik
+Architecture: all
+Depends:
+ java-wrappers,
+ libbatik-java (>= ${source:Version}),
+ ${misc:Depends},
+ default-jre | java7-runtime
+Recommends:
+ fop,
+ rhino
+Breaks: libbatik-java (<< 1.7+dfsg-5)
+Replaces: libbatik-java (<< 1.7+dfsg-5)
+Description: xml.apache.org SVG Library -- wrapper scripts
+ This package provides the wrapper scripts for rasterizer, squiggle, ttf2svg
+ and svgpp.
+ .
+ Batik is a toolkit for applications or applets that want to use images
+ in the Scalable Vector Graphics (SVG) format for various purposes, such
+ as viewing, generation or manipulation.
+ .
+ Batik provides several modules to be used in applications:
+  * A SVG generator module, usable to export graphics into the SVG format.
+  * A SVG processor and SVG Viewing component for integrating SVG viewing.
+  * A module to convert SVG to various formats, such as raster images
+(JPEG, PNG or Tiff) and PS, PDF.
+ .
  fop is necessary for PDF output of rasterizer.
  .
  rhino is necessary for using the SVG browser, squiggle.
- .
- For detailed information, go to http://xml.apache.org/batik/
diff -Nru batik-1.7+dfsg/debian/libbatik-java.dirs 
batik-1.7+dfsg/debian/libbatik-java.dirs
--- batik-1.7+dfsg/debian/libbatik-java.dirs2010-11-25 01:18:24.0 
+0100
+++ batik-1.7+dfsg/debian/libbatik-java.dirs1970-01-01 01:00:00.0 
+0100
@@ -1 +0,0 @@
-usr/share/java
diff -Nru batik-1.7+dfsg/debian/libbatik-java.manifest 
batik-1.7+dfsg/debian/libbatik-java.manif

Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-17 Thread Vincent Fourmond
  Hi,

  [currently at a congress, hence not very on top of Debian things]

On Wed, Oct 16, 2013 at 8:28 PM, Markus Koschany  wrote:
> The current svn revision still recommends default-jre because of the
> included wrapper scripts squiggle, rasterizer, ttf2svg and svgpp. The
> recommendation for default-jre is the only thing that bothers me. The
> current dependencies on jre-headless go against the current java policy
> but the current package also needs a working JRE to run the
> aforementioned wrapper scripts. I think recommending default-jre is a
> kind of compromise here.

  Excatly...

> I agree with Emmanuel Bourg's comment from the list that it is more
> reasonable to split the package in libbatik-java and batik. I have done
> this locally and all reverse dependencies (except osmosis that FTBFS
> because of another bug) still build fine. Though I'm not 100% sure if
> one of those r-deps expects one of the wrapper scripts to be included in
> libbatik-java, otherwise it would be simple.

  This is the sensible thing to do, and one I should have done ages
ago, but evaluating the impact on rdeps/build-rdeps is far from
trivial, so this is not a change to be acted too lightly -- and one of
the reasons why I refrained from doing so, mostly because I didn't
have the time to look.

> Hence I think uploading the current changes would be a good idea and I
> will attach a patch for #566901 soon.

  I don't have the time to review the patch right now. I can have a
look this week-end, if you want more eyes, but if you feel confident
about the current state, I don't mind an upload as-is.

  Cheers, and sorry for the lack of timely feedback.

  Vincent


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-16 Thread tony mancill
On 10/16/2013 11:28 AM, Markus Koschany wrote:
> Hi,
> 
> On 16.10.2013 07:21, tony mancill wrote:
>> On 10/14/2013 06:23 AM, Markus Koschany wrote:
> [...]
>>> I have prepared a new revision for batik and committed everything to the
>>> svn repository of the package. I believe the changes will fix this bug.
>>
>> Hi,
>>
>> Any concerns with an upload of Markus's changes?
>>
> 
> [...]
> 
> Splitting the package is a rather big change and I still hesitate to
> implement it without getting feedback from one of batik's past uploaders
> and I don't intend to become an uploader for batik myself.
> 
> Hence I think uploading the current changes would be a good idea and I
> will attach a patch for #566901 soon.

Agreed.  Thank you for taking care of the FTBFS.
tony



signature.asc
Description: OpenPGP digital signature


Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-16 Thread Markus Koschany
Hi,

On 16.10.2013 07:21, tony mancill wrote:
> On 10/14/2013 06:23 AM, Markus Koschany wrote:
[...]
>> I have prepared a new revision for batik and committed everything to the
>> svn repository of the package. I believe the changes will fix this bug.
> 
> Hi,
> 
> Any concerns with an upload of Markus's changes?
> 

The current svn revision still recommends default-jre because of the
included wrapper scripts squiggle, rasterizer, ttf2svg and svgpp. The
recommendation for default-jre is the only thing that bothers me. The
current dependencies on jre-headless go against the current java policy
but the current package also needs a working JRE to run the
aforementioned wrapper scripts. I think recommending default-jre is a
kind of compromise here.

I agree with Emmanuel Bourg's comment from the list that it is more
reasonable to split the package in libbatik-java and batik. I have done
this locally and all reverse dependencies (except osmosis that FTBFS
because of another bug) still build fine. Though I'm not 100% sure if
one of those r-deps expects one of the wrapper scripts to be included in
libbatik-java, otherwise it would be simple.

Splitting the package is a rather big change and I still hesitate to
implement it without getting feedback from one of batik's past uploaders
and I don't intend to become an uploader for batik myself.

Hence I think uploading the current changes would be a good idea and I
will attach a patch for #566901 soon.

Regards,

Markus




signature.asc
Description: OpenPGP digital signature


Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-15 Thread tony mancill
On 10/14/2013 06:23 AM, Markus Koschany wrote:
> On 14.10.2013 12:00, Daniel Schepler wrote:
> [...]
>> The point is, this installs openjdk-6-jdk by preference because it's first in
>> the Build-Depends; and the only parts of openjdk-7 that get pulled in by 
>> other
>> packages are -jre-headless and -jre-lib.
> 
> Indeed. The alternative build-dependency on openjdk-6-jdk is obsolete
> and this conflicts with the settings in debian/rules for JAVA_HOME_DIRS.
> The JAVA_HOME environment variable points to openjdk-7 whereas openjdk-6
> gets installed by default. It seems the default pbuilder behavior is
> somehow smarter than the classic one.
> 
> I have prepared a new revision for batik and committed everything to the
> svn repository of the package. I believe the changes will fix this bug.

Hi,

Any concerns with an upload of Markus's changes?

Thanks,
tony



signature.asc
Description: OpenPGP digital signature


Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-14 Thread Markus Koschany
On 14.10.2013 12:00, Daniel Schepler wrote:
[...]
> The point is, this installs openjdk-6-jdk by preference because it's first in
> the Build-Depends; and the only parts of openjdk-7 that get pulled in by other
> packages are -jre-headless and -jre-lib.

Indeed. The alternative build-dependency on openjdk-6-jdk is obsolete
and this conflicts with the settings in debian/rules for JAVA_HOME_DIRS.
The JAVA_HOME environment variable points to openjdk-7 whereas openjdk-6
gets installed by default. It seems the default pbuilder behavior is
somehow smarter than the classic one.

I have prepared a new revision for batik and committed everything to the
svn repository of the package. I believe the changes will fix this bug.

Regards,

Markus




signature.asc
Description: OpenPGP digital signature


Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-14 Thread Daniel Schepler
On Monday, October 14, 2013 10:20:25 AM Markus Koschany wrote:
> Control: severity 725461 normal
> Control: tags 725461 moreinfo
> 
> Hello,
> 
> I have also tried to reproduce your issue but without success. Batik
> builds without problems in a clean cowbuilder chroot on sid amd64.
> 
> I'm lowering the severity to normal and tagging the bug "moreinfo" until
> more information are available that justify RC severity.

OK, it turns out I couldn't reproduce it either with the default pbuilder
setup.  But with this, I can reproduce the build failure:

echo 
'PBUILDERSATISFYDEPENDSCMD="/usr/lib/pbuilder/pbuilder-satisfydepends-classic"' 
> /tmp/pbuilderrc-classic
pbuilder build --configfile /tmp/pbuilderrc-classic 
fail/b/batik/batik_1.7+dfsg-3.dsc

The point is, this installs openjdk-6-jdk by preference because it's first in
the Build-Depends; and the only parts of openjdk-7 that get pulled in by other
packages are -jre-headless and -jre-lib.
-- 
Daniel Schepler


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-14 Thread Markus Koschany
Control: severity 725461 normal
Control: tags 725461 moreinfo

Hello,

I have also tried to reproduce your issue but without success. Batik
builds without problems in a clean cowbuilder chroot on sid amd64.

I'm lowering the severity to normal and tagging the bug "moreinfo" until
more information are available that justify RC severity.

Regards,

Markus



signature.asc
Description: OpenPGP digital signature


Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-06 Thread tony mancill
tag 725461 + unreproducible
thanks

On 10/05/2013 09:02 PM, Daniel Schepler wrote:
> Source: batik
> Version: 1.7+dfsg-3
> Severity: serious
(snip)
> BUILD FAILED
> /tmp/buildd/batik-1.7+dfsg/build.xml:1008: Unable to find a javac
compiler;
> com.sun.tools.javac.Main is not on the classpath.
> Perhaps JAVA_HOME does not point to the JDK.
> It is currently set to "/usr/lib/jvm/java-7-openjdk-amd64/jre"

Hi Daniel,

I'm not able to reproduce this on my system building in sid, jessie, or
wheezy.  Perhaps JAVA_HOME is getting passed into your pbuilder?  Can
you try again without JAVA_HOME being set?

Thank you,
tony



signature.asc
Description: OpenPGP digital signature


Bug#725461: batik: FTBFS: Unable to find a javac compiler

2013-10-05 Thread Daniel Schepler
Source: batik
Version: 1.7+dfsg-3
Severity: serious

>From my pbuilder build log:

...
 debian/rules build
test -x debian/rules
mkdir -p "."
cd . && /usr/lib/jvm/java-7-openjdk-amd64/bin/java -classpath 
/usr/share/ant/lib/ant.jar:/usr/share/ant/lib/ant-launcher.jar:/usr/share/ant/lib/ant-launcher.jar:/usr/share/java/js.jar:/usr/share/java/xalan2.jar:/usr/share/java/xml-apis-ext.jar:
 -Xms256m -Xmx256m -Dbuild.sysclasspath=only -Dant.home=/usr/share/ant 
org.apache.tools.ant.Main -Dcompile.debug=true -Dcompile.optimize=true  
-Dbuild.compiler=modern -buildfile build.xml  all-jar libs-jar ext-jar 
transcoder-jar
Buildfile: /tmp/buildd/batik-1.7+dfsg/build.xml

init:
 [echo]  == Apache Batik 1.7 build file 
 [echo] 
 [echo] JAVA_HOME: ${env.JAVA_HOME}
 [echo] VM:23.7-b01, Oracle Corporation

compile-prepare:
[mkdir] Created dir: /tmp/buildd/batik-1.7+dfsg/classes
 [echo] debug off, optimize on, deprecation on

compile:

BUILD FAILED
/tmp/buildd/batik-1.7+dfsg/build.xml:1008: Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "/usr/lib/jvm/java-7-openjdk-amd64/jre"

Total time: 0 seconds
make: *** [debian/stamp-ant-build] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
-- 
Daniel Schepler


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org