Bug#784959: blhc: possible false positive about missing CPPFLAGS in a linker call

2015-09-25 Thread Simon Ruderich
On Mon, May 11, 2015 at 10:35:45AM +0200, Raphaël Hertzog wrote:
> Package: blhc
> Version: 0.04+20140813+gitac2b8ce-1
> Severity: normal
>
> For cpputest I get two reports (out of 80 calls scanned) of CPPFLAGS
> missing:
>
> [snip]
>
> If you look at those calls, they boil down to "g++ [noise] -o foo foo.o bar.o
> [more object files] -lpthread" and as such I believe that they need neither
> CFLAGS nor CPPFLAGS. However CFLAGS appear to be injected and possibly due to
> this, blhc complains about the missing CPPFLAGS.
>
> It would be nice to not get those false positives.

Hello,

Sorry for the late reply. The problem is the "-include
./include/CppUTest/MemoryLeakDetectorNewMacros.h" part. Due to
the .h-extension the line is classified as requiring CPPFLAGS.

I don't know how to fix this in the general case, but for
"libtool: link" lines, this is easy. It's fixed in commit 5dd19b
[1].

Regards
Simon

[1]: 
http://ruderich.org/simon/gitweb/?p=blhc/blhc.git;a=commit;h=5dd19bb96effb0b40c26bb669dd0f8ef176ebf40
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9


signature.asc
Description: PGP signature


Bug#784959: blhc: possible false positive about missing CPPFLAGS in a linker call

2015-05-11 Thread Raphaël Hertzog
Package: blhc
Version: 0.04+20140813+gitac2b8ce-1
Severity: normal

For cpputest I get two reports (out of 80 calls scanned) of CPPFLAGS
missing:

$ blhc deb/pkg/build-area/cpputest_3.7.2-1_amd64.build 
CPPFLAGS missing (-D_FORTIFY_SOURCE=2): libtool: link: g++ -include 
./include/CppUTest/MemoryLeakDetectorNewMacros.h -Wall -Wextra -Wshadow 
-Wswitch-default -Wswitch-enum -Wconversion -pedantic -Wsign-conversion 
-Woverloaded-virtual -Wno-disabled-macro-expansion -Wno-padded 
-Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables 
-Wno-old-style-cast -g -O2 -fstack-protector-strong -Wformat 
-Werror=format-security -Wl,-z -Wl,relro -o CppUTestTests 
CppUTestTests-AllocationInCFile.o CppUTestTests-AllocationInCppFile.o 
CppUTestTests-AllocLetTestFree.o CppUTestTests-AllocLetTestFreeTest.o 
CppUTestTests-AllTests.o CppUTestTests-CheatSheetTest.o 
CppUTestTests-CommandLineArgumentsTest.o 
CppUTestTests-CommandLineTestRunnerTest.o CppUTestTests-JUnitOutputTest.o 
CppUTestTests-MemoryLeakDetectorTest.o 
CppUTestTests-MemoryLeakOperatorOverloadsTest.o 
CppUTestTests-MemoryLeakWarningTest.o CppUTestTests-PluginTest.o 
CppUTestTests-PreprocessorTest.o CppUTestTests-SetPluginTest.o CppUTest
 Tests-SimpleStringTest.o CppUTestTests-SimpleMutexTest.o 
CppUTestTests-TestFailureNaNTest.o CppUTestTests-TestFailureTest.o 
CppUTestTests-TestFilterTest.o CppUTestTests-TestHarness_cTest.o 
CppUTestTests-TestHarness_cTestCFile.o CppUTestTests-TestInstallerTest.o 
CppUTestTests-TestMemoryAllocatorTest.o CppUTestTests-TestOutputTest.o 
CppUTestTests-TestRegistryTest.o CppUTestTests-TestResultTest.o 
CppUTestTests-TestUTestMacro.o CppUTestTests-UtestTest.o 
CppUTestTests-UtestPlatformTest.o  lib/libCppUTest.a -lpthread
CPPFLAGS missing (-D_FORTIFY_SOURCE=2): libtool: link: g++ -include 
./include/CppUTest/MemoryLeakDetectorNewMacros.h -Wall -Wextra -Wshadow 
-Wswitch-default -Wswitch-enum -Wconversion -pedantic -Wsign-conversion 
-Woverloaded-virtual -Wno-disabled-macro-expansion -Wno-padded 
-Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables 
-Wno-old-style-cast -g -O2 -fstack-protector-strong -Wformat 
-Werror=format-security -Wl,-z -Wl,relro -o CppUTestExtTests 
CppUTestExtTests-AllTests.o CppUTestExtTests-CodeMemoryReportFormatterTest.o 
CppUTestExtTests-GMockTest.o CppUTestExtTests-GTest1Test.o 
CppUTestExtTests-GTest2ConvertorTest.o 
CppUTestExtTests-MemoryReportAllocatorTest.o 
CppUTestExtTests-MemoryReporterPluginTest.o 
CppUTestExtTests-MemoryReportFormatterTest.o 
CppUTestExtTests-MockActualCallTest.o CppUTestExtTests-MockCheatSheetTest.o 
CppUTestExtTests-MockExpectedCallTest.o 
CppUTestExtTests-MockExpectedFunctionsListTest.o 
CppUTestExtTests-MockFailureTest.o CppUTestExtTests-MockP
 luginTest.o CppUTestExtTests-MockSupportTest.o 
CppUTestExtTests-MockSupport_cTest.o CppUTestExtTests-MockSupport_cTestCFile.o 
CppUTestExtTests-OrderedTestTest.o  lib/libCppUTestExt.a lib/libCppUTest.a 
-lpthread

If you look at those calls, they boil down to g++ [noise] -o foo foo.o bar.o
[more object files] -lpthread and as such I believe that they need neither
CFLAGS nor CPPFLAGS. However CFLAGS appear to be injected and possibly due to
this, blhc complains about the missing CPPFLAGS.

It would be nice to not get those false positives.

-- System Information:
Debian Release: stretch/sid
  APT prefers squeeze-lts
  APT policy: (500, 'squeeze-lts'), (500, 'oldoldstable'), (500, 'unstable'), 
(500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages blhc depends on:
ii  libdpkg-perl  1.17.25

blhc recommends no packages.

blhc suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org