Bug#807442: patch

2016-02-04 Thread dann frazier 
On Thu, Feb 04, 2016 at 09:35:13AM +0100, Hendrik Brueckner wrote:
> Hi Dann,
> 
> I have CC'ed Wolfgang who takes care of it from customer service perspective.
> Within our team, we received some feedback for your patches that I want to
> share with you.
> 
> On Fri, Jan 29, 2016 at 04:17:32PM -0700, dann frazier wrote:
> > On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> > > On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > > > diff -Nru s390-tools-1.32.0/debian/changelog 
> > > > s390-tools-1.32.0/debian/changelog
> > > > --- s390-tools-1.32.0/debian/changelog  2015-10-25 17:12:02.0 
> > > > +0100
> > > > +++ s390-tools-1.32.0/debian/changelog  2015-12-08 23:14:52.0 
> > > > +0100
> > > > @@ -1,3 +1,9 @@
> > > > +s390-tools (1.32.0-2) UNRELEASED; urgency=medium
> > > > +
> > > > +  * Add dbginfo.sh. (Closes: #807442)
> > > > +
> > > > + -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
> > > > +
> > > >  s390-tools (1.32.0-1) unstable; urgency=medium
> > > >  
> > > >* New upstream release
> > > > diff -Nru s390-tools-1.32.0/debian/s390-tools.install 
> > > > s390-tools-1.32.0/debian/s390-tools.install
> > > > --- s390-tools-1.32.0/debian/s390-tools.install 2014-07-26 
> > > > 23:59:18.0 +0200
> > > > +++ s390-tools-1.32.0/debian/s390-tools.install 2015-12-08 
> > > > 23:08:30.0 +0100
> > > > @@ -10,6 +10,10 @@
> > > >  /sbin/dasdview
> > > >  /usr/share/man/man8/dasdview.8
> > > >  
> > > > +# dbginfo.sh
> > > > +/sbin/dbginfo.sh
> > > > +/usr/share/man/man1/dbginfo.sh.1
> > > > +
> > > >  # fdasd
> > > >  /sbin/fdasd
> > > >  /usr/share/man/man8/fdasd.8
> > > 
> > > Three comments:
> > > 
> > >  * dbginfo.sh should tell the user that the information in the tarball
> > >is sensitive.
> > >  * The resulting tarball should be 0600 by default. (The script needs
> > >to run as root anyway, but placing the result world-readable in
> > >/tmp does not seem smart.)
> > >  * Unless this is expected to be in /sbin, given that it's user
> > >invoked and not usually scripted, should this be in /usr/sbin
> > >instead?
> > 
> > Good feedback, thanks Philipp! I've addressed all 3 issues in the
> > attached updated patch.
> 
> > diff -Nru s390-tools-1.32.0/debian/changelog 
> > s390-tools-1.32.0/debian/changelog
> > --- s390-tools-1.32.0/debian/changelog  2015-12-13 09:50:48.0 
> > -0500
> > +++ s390-tools-1.32.0/debian/changelog  2016-01-29 12:56:29.0 
> > -0500
> > @@ -1,3 +1,12 @@
> > +s390-tools (1.32.0-3) UNRELEASED; urgency=medium
> > +
> > +  * Add dbginfo.sh. (Closes: #807442, LP: #1539719)
> > +- dbginfo.sh-umask.patch: Avoid leaking content to unprivileged users.
> > +- dbginfo.sh-warn.patch: Warn users about the sensitivity of the data
> > +  this tool collects.
> > +
> > + -- dann frazier   Fri, 29 Jan 2016 12:49:16 -0500
> > +
> >  s390-tools (1.32.0-2) unstable; urgency=medium
> > 
> >[ Hendrik Brueckner ]
> > diff -Nru s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch 
> > s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch
> > --- s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch 1969-12-31 
> > 19:00:00.0 -0500
> > +++ s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch 2016-01-29 
> > 12:21:06.0 -0500
> > @@ -0,0 +1,16 @@
> > +Description: dbginfo.sh: set umask to prevent local leaks of sensitive data
> > +Author: dann frazier 
> > +Last-Update: 2016-01-29
> > +
> > +Index: s390-tools-1.32.0/scripts/dbginfo.sh
> > +===
> > +--- s390-tools-1.32.0.orig/scripts/dbginfo.sh
> >  s390-tools-1.32.0/scripts/dbginfo.sh
> > +@@ -12,6 +12,7 @@ export LC_ALL
> > + # The general name of this script
> > + readonly SCRIPTNAME="${0##*/}"
> > + 
> > ++umask 0077
> 
> This is tricky and probaly leads to changed permissions that might be useful
> to detect permissions problem.  Wolfgang and team worked on this topic and
> a problem fix will be provided with the next s390-tools version.  The idea
> here is to change the permission of the directory which will be created to
> contain all service data.

OK.

> > + 
> > + 
> > + # print version info
> > diff -Nru s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch 
> > s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch
> > --- s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch  1969-12-31 
> > 19:00:00.0 -0500
> > +++ s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch  2016-01-29 
> > 12:32:51.0 -0500
> > @@ -0,0 +1,38 @@
> > +Description: dbginfo.sh: Sensitivity training
> > + Warn users that the archive this tool generates contains sensitive data,
> > + and give them an opportunity to exit.
> > +Author: dann frazier 
> > +Last-Update: 2016-01-29
> > +
> > +Index: s390-tools-1.32.0/scripts/dbginfo.sh
> >

Bug#807442: patch

2016-02-04 Thread Hendrik Brueckner 
Hi Dann,

I have CC'ed Wolfgang who takes care of it from customer service perspective.
Within our team, we received some feedback for your patches that I want to
share with you.

On Fri, Jan 29, 2016 at 04:17:32PM -0700, dann frazier wrote:
> On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> > On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > > diff -Nru s390-tools-1.32.0/debian/changelog 
> > > s390-tools-1.32.0/debian/changelog
> > > --- s390-tools-1.32.0/debian/changelog2015-10-25 17:12:02.0 
> > > +0100
> > > +++ s390-tools-1.32.0/debian/changelog2015-12-08 23:14:52.0 
> > > +0100
> > > @@ -1,3 +1,9 @@
> > > +s390-tools (1.32.0-2) UNRELEASED; urgency=medium
> > > +
> > > +  * Add dbginfo.sh. (Closes: #807442)
> > > +
> > > + -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
> > > +
> > >  s390-tools (1.32.0-1) unstable; urgency=medium
> > >  
> > >* New upstream release
> > > diff -Nru s390-tools-1.32.0/debian/s390-tools.install 
> > > s390-tools-1.32.0/debian/s390-tools.install
> > > --- s390-tools-1.32.0/debian/s390-tools.install   2014-07-26 
> > > 23:59:18.0 +0200
> > > +++ s390-tools-1.32.0/debian/s390-tools.install   2015-12-08 
> > > 23:08:30.0 +0100
> > > @@ -10,6 +10,10 @@
> > >  /sbin/dasdview
> > >  /usr/share/man/man8/dasdview.8
> > >  
> > > +# dbginfo.sh
> > > +/sbin/dbginfo.sh
> > > +/usr/share/man/man1/dbginfo.sh.1
> > > +
> > >  # fdasd
> > >  /sbin/fdasd
> > >  /usr/share/man/man8/fdasd.8
> > 
> > Three comments:
> > 
> >  * dbginfo.sh should tell the user that the information in the tarball
> >is sensitive.
> >  * The resulting tarball should be 0600 by default. (The script needs
> >to run as root anyway, but placing the result world-readable in
> >/tmp does not seem smart.)
> >  * Unless this is expected to be in /sbin, given that it's user
> >invoked and not usually scripted, should this be in /usr/sbin
> >instead?
> 
> Good feedback, thanks Philipp! I've addressed all 3 issues in the
> attached updated patch.

> diff -Nru s390-tools-1.32.0/debian/changelog 
> s390-tools-1.32.0/debian/changelog
> --- s390-tools-1.32.0/debian/changelog2015-12-13 09:50:48.0 
> -0500
> +++ s390-tools-1.32.0/debian/changelog2016-01-29 12:56:29.0 
> -0500
> @@ -1,3 +1,12 @@
> +s390-tools (1.32.0-3) UNRELEASED; urgency=medium
> +
> +  * Add dbginfo.sh. (Closes: #807442, LP: #1539719)
> +- dbginfo.sh-umask.patch: Avoid leaking content to unprivileged users.
> +- dbginfo.sh-warn.patch: Warn users about the sensitivity of the data
> +  this tool collects.
> +
> + -- dann frazier   Fri, 29 Jan 2016 12:49:16 -0500
> +
>  s390-tools (1.32.0-2) unstable; urgency=medium
> 
>[ Hendrik Brueckner ]
> diff -Nru s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch 
> s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch
> --- s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch   1969-12-31 
> 19:00:00.0 -0500
> +++ s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch   2016-01-29 
> 12:21:06.0 -0500
> @@ -0,0 +1,16 @@
> +Description: dbginfo.sh: set umask to prevent local leaks of sensitive data
> +Author: dann frazier 
> +Last-Update: 2016-01-29
> +
> +Index: s390-tools-1.32.0/scripts/dbginfo.sh
> +===
> +--- s390-tools-1.32.0.orig/scripts/dbginfo.sh
>  s390-tools-1.32.0/scripts/dbginfo.sh
> +@@ -12,6 +12,7 @@ export LC_ALL
> + # The general name of this script
> + readonly SCRIPTNAME="${0##*/}"
> + 
> ++umask 0077

This is tricky and probaly leads to changed permissions that might be useful
to detect permissions problem.  Wolfgang and team worked on this topic and
a problem fix will be provided with the next s390-tools version.  The idea
here is to change the permission of the directory which will be created to
contain all service data.

> + 
> + 
> + # print version info
> diff -Nru s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch 
> s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch
> --- s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch1969-12-31 
> 19:00:00.0 -0500
> +++ s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch2016-01-29 
> 12:32:51.0 -0500
> @@ -0,0 +1,38 @@
> +Description: dbginfo.sh: Sensitivity training
> + Warn users that the archive this tool generates contains sensitive data,
> + and give them an opportunity to exit.
> +Author: dann frazier 
> +Last-Update: 2016-01-29
> +
> +Index: s390-tools-1.32.0/scripts/dbginfo.sh
> +===
> +--- s390-tools-1.32.0.orig/scripts/dbginfo.sh
>  s390-tools-1.32.0/scripts/dbginfo.sh
> +@@ -71,6 +71,27 @@ if test "$(/usr/bin/id -u 2>/dev/null)"
> + exit 1
> + fi
> + 
> ++echo 
>

Bug#807442: patch

2016-01-29 Thread dann frazier 
On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > diff -Nru s390-tools-1.32.0/debian/changelog 
> > s390-tools-1.32.0/debian/changelog
> > --- s390-tools-1.32.0/debian/changelog  2015-10-25 17:12:02.0 
> > +0100
> > +++ s390-tools-1.32.0/debian/changelog  2015-12-08 23:14:52.0 
> > +0100
> > @@ -1,3 +1,9 @@
> > +s390-tools (1.32.0-2) UNRELEASED; urgency=medium
> > +
> > +  * Add dbginfo.sh. (Closes: #807442)
> > +
> > + -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
> > +
> >  s390-tools (1.32.0-1) unstable; urgency=medium
> >  
> >* New upstream release
> > diff -Nru s390-tools-1.32.0/debian/s390-tools.install 
> > s390-tools-1.32.0/debian/s390-tools.install
> > --- s390-tools-1.32.0/debian/s390-tools.install 2014-07-26 
> > 23:59:18.0 +0200
> > +++ s390-tools-1.32.0/debian/s390-tools.install 2015-12-08 
> > 23:08:30.0 +0100
> > @@ -10,6 +10,10 @@
> >  /sbin/dasdview
> >  /usr/share/man/man8/dasdview.8
> >  
> > +# dbginfo.sh
> > +/sbin/dbginfo.sh
> > +/usr/share/man/man1/dbginfo.sh.1
> > +
> >  # fdasd
> >  /sbin/fdasd
> >  /usr/share/man/man8/fdasd.8
> 
> Three comments:
> 
>  * dbginfo.sh should tell the user that the information in the tarball
>is sensitive.
>  * The resulting tarball should be 0600 by default. (The script needs
>to run as root anyway, but placing the result world-readable in
>/tmp does not seem smart.)
>  * Unless this is expected to be in /sbin, given that it's user
>invoked and not usually scripted, should this be in /usr/sbin
>instead?

Good feedback, thanks Philipp! I've addressed all 3 issues in the
attached updated patch.
diff -Nru s390-tools-1.32.0/debian/changelog s390-tools-1.32.0/debian/changelog
--- s390-tools-1.32.0/debian/changelog	2015-12-13 09:50:48.0 -0500
+++ s390-tools-1.32.0/debian/changelog	2016-01-29 12:56:29.0 -0500
@@ -1,3 +1,12 @@
+s390-tools (1.32.0-3) UNRELEASED; urgency=medium
+
+  * Add dbginfo.sh. (Closes: #807442, LP: #1539719)
+- dbginfo.sh-umask.patch: Avoid leaking content to unprivileged users.
+- dbginfo.sh-warn.patch: Warn users about the sensitivity of the data
+  this tool collects.
+
+ -- dann frazier   Fri, 29 Jan 2016 12:49:16 -0500
+
 s390-tools (1.32.0-2) unstable; urgency=medium
 
   [ Hendrik Brueckner ]
diff -Nru s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch
--- s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch	1969-12-31 19:00:00.0 -0500
+++ s390-tools-1.32.0/debian/patches/dbginfo.sh-umask.patch	2016-01-29 12:21:06.0 -0500
@@ -0,0 +1,16 @@
+Description: dbginfo.sh: set umask to prevent local leaks of sensitive data
+Author: dann frazier 
+Last-Update: 2016-01-29
+
+Index: s390-tools-1.32.0/scripts/dbginfo.sh
+===
+--- s390-tools-1.32.0.orig/scripts/dbginfo.sh
 s390-tools-1.32.0/scripts/dbginfo.sh
+@@ -12,6 +12,7 @@ export LC_ALL
+ # The general name of this script
+ readonly SCRIPTNAME="${0##*/}"
+ 
++umask 0077
+ 
+ 
+ # print version info
diff -Nru s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch
--- s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch	1969-12-31 19:00:00.0 -0500
+++ s390-tools-1.32.0/debian/patches/dbginfo.sh-warn.patch	2016-01-29 12:32:51.0 -0500
@@ -0,0 +1,38 @@
+Description: dbginfo.sh: Sensitivity training
+ Warn users that the archive this tool generates contains sensitive data,
+ and give them an opportunity to exit.
+Author: dann frazier 
+Last-Update: 2016-01-29
+
+Index: s390-tools-1.32.0/scripts/dbginfo.sh
+===
+--- s390-tools-1.32.0.orig/scripts/dbginfo.sh
 s390-tools-1.32.0/scripts/dbginfo.sh
+@@ -71,6 +71,27 @@ if test "$(/usr/bin/id -u 2>/dev/null)"
+ exit 1
+ fi
+ 
++echo "!!"
++echo " Warning: The archive created by this utility will contain sensitive"
++echo " information including, but not limited to:"
++echo "  - configuration files"
++echo "  - log files"
++echo "  - hardware state information"
++echo "  - running process state and command line arguments"
++echo "!!"
++echo ""
++echo -n " Do you wish to continue? [y/N]> "
++read resp
++case "$resp" in
++y|Y)
++	:
++	;;
++*)
++	echo "OK, exiting."
++	exit 0
++esac
++		
++
+ ###
+ # Parsing the command line
+ #
diff -Nru s390-tools-1.32.0/debian/patches/series s390-tools-1.32.0/debian/patches/series
--- s390-tools-1.32.0/debian/patches/series	2015-12-13

Bug#807442: patch

2016-01-29 Thread dann frazier 
On Mon, Dec 14, 2015 at 11:31:26AM +0100, Hendrik Brueckner wrote:
> On Mon, Dec 14, 2015 at 09:28:08AM +0100, Hendrik Brueckner wrote:
> > On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> > > On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > > > --- s390-tools-1.32.0/debian/s390-tools.install 2014-07-26 
> > > > 23:59:18.0 +0200
> > > > +++ s390-tools-1.32.0/debian/s390-tools.install 2015-12-08 
> > > > 23:08:30.0 +0100
> > > > @@ -10,6 +10,10 @@
> > > >  /sbin/dasdview
> > > >  /usr/share/man/man8/dasdview.8
> > > >  
> > > > +# dbginfo.sh
> > > > +/sbin/dbginfo.sh
> > > > +/usr/share/man/man1/dbginfo.sh.1
> > > > +
> > >
> > >  * Unless this is expected to be in /sbin, given that it's user
> > >invoked and not usually scripted, should this be in /usr/sbin
> > >instead?
> 
> I am not sure what you exactly mean with "user" invoked.

I believe that note means that this utility appears to be something
that a user would execute in an interactive terminal vs. e.g. a script
in early boot.

> Anyhow, /sbin/ makes sense because the intention of the dbginfo.sh
> script is to collect system and debugging information.  So it is
> important to have it available early (even before /usr becomes
> mounted).

While this maybe a theoretical use case, I don't think the script has
been designed to run in this environment. As one example, it
calls "/usr/bin/id" to check if it is running as root. It also uses the
"find" command in a number of places which, at least on Debian
systems, is installed in /usr/bin.

> I would also go further and would suggest to included it in the
> s390-tools udeb package to be available in the debian installer
> too.  But I would have to check if it runs in the debian installer
> environment.  I could also imagine to integrate it into the
> installation-report module.

I'd suggest opening separate bugs for those.

Bug#807442: patch

2015-12-14 Thread Hendrik Brueckner 
On Mon, Dec 14, 2015 at 09:28:08AM +0100, Hendrik Brueckner wrote:
> On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> > On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > > --- s390-tools-1.32.0/debian/s390-tools.install   2014-07-26 
> > > 23:59:18.0 +0200
> > > +++ s390-tools-1.32.0/debian/s390-tools.install   2015-12-08 
> > > 23:08:30.0 +0100
> > > @@ -10,6 +10,10 @@
> > >  /sbin/dasdview
> > >  /usr/share/man/man8/dasdview.8
> > >  
> > > +# dbginfo.sh
> > > +/sbin/dbginfo.sh
> > > +/usr/share/man/man1/dbginfo.sh.1
> > > +
> >
> >  * Unless this is expected to be in /sbin, given that it's user
> >invoked and not usually scripted, should this be in /usr/sbin
> >instead?

I am not sure what you exactly mean with "user" invoked.
Anyhow, /sbin/ makes sense because the intention of the dbginfo.sh
script is to collect system and debugging information.  So it is
important to have it available early (even before /usr becomes
mounted).

I would also go further and would suggest to included it in the
s390-tools udeb package to be available in the debian installer
too.  But I would have to check if it runs in the debian installer
environment.  I could also imagine to integrate it into the
installation-report module.

Thanks and kind regards,
  Hendrik


pgp4VFlwRTv1O.pgp
Description: PGP signature

Bug#807442: patch

2015-12-14 Thread Hendrik Brueckner 
Hi Philipp,

On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > diff -Nru s390-tools-1.32.0/debian/changelog 
> > s390-tools-1.32.0/debian/changelog
> > --- s390-tools-1.32.0/debian/changelog  2015-10-25 17:12:02.0 
> > +0100
> > +++ s390-tools-1.32.0/debian/changelog  2015-12-08 23:14:52.0 
> > +0100
> > @@ -1,3 +1,9 @@
> > +s390-tools (1.32.0-2) UNRELEASED; urgency=medium
> > +
> > +  * Add dbginfo.sh. (Closes: #807442)
> > +
> > + -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
> > +
> >  s390-tools (1.32.0-1) unstable; urgency=medium
> >  
> >* New upstream release
> > diff -Nru s390-tools-1.32.0/debian/s390-tools.install 
> > s390-tools-1.32.0/debian/s390-tools.install
> > --- s390-tools-1.32.0/debian/s390-tools.install 2014-07-26 
> > 23:59:18.0 +0200
> > +++ s390-tools-1.32.0/debian/s390-tools.install 2015-12-08 
> > 23:08:30.0 +0100
> > @@ -10,6 +10,10 @@
> >  /sbin/dasdview
> >  /usr/share/man/man8/dasdview.8
> >  
> > +# dbginfo.sh
> > +/sbin/dbginfo.sh
> > +/usr/share/man/man1/dbginfo.sh.1
> > +
> >  # fdasd
> >  /sbin/fdasd
> >  /usr/share/man/man8/fdasd.8
> 
> Three comments:
> 
>  * dbginfo.sh should tell the user that the information in the tarball
>is sensitive.
>  * The resulting tarball should be 0600 by default. (The script needs
>to run as root anyway, but placing the result world-readable in
>/tmp does not seem smart.)

Thanks for the feedback.  I think that sounds good.  I put the s390-tools
owners for their feedback on CC.

>  * Unless this is expected to be in /sbin, given that it's user
>invoked and not usually scripted, should this be in /usr/sbin
>instead?
> 

Kind regards,
  Hendrik


pgpc0EN1oVlag.pgp
Description: PGP signature

Bug#807442: patch

2015-12-13 Thread Philipp Kern 
On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> diff -Nru s390-tools-1.32.0/debian/changelog 
> s390-tools-1.32.0/debian/changelog
> --- s390-tools-1.32.0/debian/changelog2015-10-25 17:12:02.0 
> +0100
> +++ s390-tools-1.32.0/debian/changelog2015-12-08 23:14:52.0 
> +0100
> @@ -1,3 +1,9 @@
> +s390-tools (1.32.0-2) UNRELEASED; urgency=medium
> +
> +  * Add dbginfo.sh. (Closes: #807442)
> +
> + -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
> +
>  s390-tools (1.32.0-1) unstable; urgency=medium
>  
>* New upstream release
> diff -Nru s390-tools-1.32.0/debian/s390-tools.install 
> s390-tools-1.32.0/debian/s390-tools.install
> --- s390-tools-1.32.0/debian/s390-tools.install   2014-07-26 
> 23:59:18.0 +0200
> +++ s390-tools-1.32.0/debian/s390-tools.install   2015-12-08 
> 23:08:30.0 +0100
> @@ -10,6 +10,10 @@
>  /sbin/dasdview
>  /usr/share/man/man8/dasdview.8
>  
> +# dbginfo.sh
> +/sbin/dbginfo.sh
> +/usr/share/man/man1/dbginfo.sh.1
> +
>  # fdasd
>  /sbin/fdasd
>  /usr/share/man/man8/fdasd.8

Three comments:

 * dbginfo.sh should tell the user that the information in the tarball
   is sensitive.
 * The resulting tarball should be 0600 by default. (The script needs
   to run as root anyway, but placing the result world-readable in
   /tmp does not seem smart.)
 * Unless this is expected to be in /sbin, given that it's user
   invoked and not usually scripted, should this be in /usr/sbin
   instead?

Kind regards and thanks
Philipp Kern


signature.asc
Description: Digital signature

Bug#807442: patch

2015-12-09 Thread Hendrik Brueckner 
Hi Dann,

On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> Attached.

> diff -Nru s390-tools-1.32.0/debian/changelog 
> s390-tools-1.32.0/debian/changelog
> --- s390-tools-1.32.0/debian/changelog2015-10-25 17:12:02.0 
> +0100
> +++ s390-tools-1.32.0/debian/changelog2015-12-08 23:14:52.0 
> +0100
> @@ -1,3 +1,9 @@
> +s390-tools (1.32.0-2) UNRELEASED; urgency=medium
> +
> +  * Add dbginfo.sh. (Closes: #807442)
> +
> + -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
> +
>  s390-tools (1.32.0-1) unstable; urgency=medium
> 
>* New upstream release
> diff -Nru s390-tools-1.32.0/debian/s390-tools.install 
> s390-tools-1.32.0/debian/s390-tools.install
> --- s390-tools-1.32.0/debian/s390-tools.install   2014-07-26 
> 23:59:18.0 +0200
> +++ s390-tools-1.32.0/debian/s390-tools.install   2015-12-08 
> 23:08:30.0 +0100
> @@ -10,6 +10,10 @@
>  /sbin/dasdview
>  /usr/share/man/man8/dasdview.8
> 
> +# dbginfo.sh
> +/sbin/dbginfo.sh
> +/usr/share/man/man1/dbginfo.sh.1
> +
>  # fdasd
>  /sbin/fdasd
>  /usr/share/man/man8/fdasd.8

Thanks for submitting this patch and the lsluns patch as well.  I am about to
open another bug to include the device-mapper helper for zipl and chreipl as
well.  They are required for booting from device-mapper devices, for example,
LVM, multipath.

Thanks and kind regards,
  Hendrik

-- 
Hendrik Brueckner
brueck...@linux.vnet.ibm.com  | IBM Deutschland Research & Development GmbH
Linux on z Systems Development| Schoenaicher Str. 220, 71032 Boeblingen


IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Bug#807442: patch

2015-12-08 Thread dann frazier 
Attached.
diff -Nru s390-tools-1.32.0/debian/changelog s390-tools-1.32.0/debian/changelog
--- s390-tools-1.32.0/debian/changelog	2015-10-25 17:12:02.0 +0100
+++ s390-tools-1.32.0/debian/changelog	2015-12-08 23:14:52.0 +0100
@@ -1,3 +1,9 @@
+s390-tools (1.32.0-2) UNRELEASED; urgency=medium
+
+  * Add dbginfo.sh. (Closes: #807442)
+
+ -- dann frazier   Tue, 08 Dec 2015 22:33:52 +0100
+
 s390-tools (1.32.0-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru s390-tools-1.32.0/debian/s390-tools.install s390-tools-1.32.0/debian/s390-tools.install
--- s390-tools-1.32.0/debian/s390-tools.install	2014-07-26 23:59:18.0 +0200
+++ s390-tools-1.32.0/debian/s390-tools.install	2015-12-08 23:08:30.0 +0100
@@ -10,6 +10,10 @@
 /sbin/dasdview
 /usr/share/man/man8/dasdview.8
 
+# dbginfo.sh
+/sbin/dbginfo.sh
+/usr/share/man/man1/dbginfo.sh.1
+
 # fdasd
 /sbin/fdasd
 /usr/share/man/man8/fdasd.8