Bug#809678: unicode-screensaver: "Something is wrong" is not a character name
Hi, Am Montag, den 04.01.2016, 03:24 + schrieb Daniel Shahaf: > Joachim Breitner wrote on Sat, Jan 02, 2016 at 20:12:10 +0100: > > Hi, > > > > yes, this “something is wrong” is annoying. Unless I am mistaken, it > > happens if the unicode character has no entry in the table? Maybe it > > should simply print "U+ABCD" then. > > Yes, I agree, printing just "U+ABCD" with neither a name nor an error > message afterwards is another option. heh, looks like I accidentally fixed this with a recent change: http://git.nomeata.de/?p=unicode-screensaver.git;a=commitdiff;h=71d2cb9bc2c5845e51975390ed116b369597d640 sorry for that. Guess I should upload that :-) Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: This is a digitally signed message part
Bug#809678: unicode-screensaver: "Something is wrong" is not a character name
Joachim Breitner wrote on Sat, Jan 02, 2016 at 20:12:10 +0100: > Hi, > > yes, this “something is wrong” is annoying. Unless I am mistaken, it > happens if the unicode character has no entry in the table? Maybe it > should simply print "U+ABCD" then. Yes, I agree, printing just "U+ABCD" with neither a name nor an error message afterwards is another option. > (Or was it the case that there is simply a bug in the code when that > happens? In that case, maybe it’s easier to fix the bug :-)) > I don't know whether it's a "character not in the table" or a bug, but Occam's razor suggests it is probably the former. I'll try to confirm this the next time I see the "something is wrong" error. Cheers, Daniel > Greetings, > Joachim
Bug#809678: unicode-screensaver: "Something is wrong" is not a character name
Package: unicode-screensaver Version: 0.4-2 Severity: normal Tags: upstream patch Dear Maintainer, unicode-screensaver sometimes shows "U+ABCD: something is wrong" in the footer, in place of "U+ABCD: ". This make it hard to distinguish the error message from actual content (character names). Would it be possible to increase the differentiation between error messages and from character names? I propose this: diff --git a/unicode.c b/unicode.c index 3c19244..b424351 100644 --- a/unicode.c +++ b/unicode.c @@ -107,5 +107,5 @@ get_unicode_data_name (FcChar32 uc) return unicode_name_get_name(_names[mid]); } - return "something is wrong"; + return "�"; } (To be clear, that's a literal U+FFFD in the patch.) Thank you for making unicode-screensaver! ☺ Daniel P.S. I didn't try to build with this patch, but I applied it directly to the packaged binary and it worked as expected. -- System Information: Debian Release: 8.1 APT prefers stable APT policy: (990, 'stable'), (500, 'testing-updates'), (500, 'stable-updates'), (250, 'testing'), (200, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages unicode-screensaver depends on: ii libc6 2.19-18+deb8u1 ii libfontconfig1 2.11.0-6.3 ii libfreetype62.5.2-3+deb8u1 ii libx11-62:1.6.2-3 ii libxft2 2.3.2-1 ii libxmu6 2:1.1.2-1 ii libxt6 1:1.1.4-1+b1 Versions of packages unicode-screensaver recommends: ii xscreensaver 5.30-1+b1 unicode-screensaver suggests no packages. -- no debconf information
Bug#809678: unicode-screensaver: "Something is wrong" is not a character name
Hi, yes, this “something is wrong” is annoying. Unless I am mistaken, it happens if the unicode character has no entry in the table? Maybe it should simply print "U+ABCD" then. (Or was it the case that there is simply a bug in the code when that happens? In that case, maybe it’s easier to fix the bug :-)) Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: This is a digitally signed message part
