Bug#833125: : debirf: fails to build rescue on sid/stretch: insserv not found

[Tzafrir Cohen]

Control: -1 tag + patch

On Wed, Mar 01, 2017 at 09:09:02PM +0100, jhcha54008 wrote:
> Hi,
> 
> What about the more conservative patch below ? 

Thanks. WorksForMe. Attached in a slightly different format.

-- 
Tzafrir Cohen | tzaf...@jabber.org | VIM is
http://tzafrir.org.il || a Mutt's
tzaf...@cohens.org.il ||  best
tzaf...@debian.org|| friend
>From f88f462f9bf3a2a245f04246583e404b33c547e3 Mon Sep 17 00:00:00 2001
From: jhcha54008 
Date: Wed, 1 Mar 2017 21:09:02 +0100
Subject: [PATCH 1/2] a0_prep-root: run insserv if installed (Closes: #833125)

Module a0_prep-root runs insserv to fix issues in a sysv system. This
workaround is not required in a systemd system. It is not included in
a minimal systemd-based system.
---
 src/modules/a0_prep-root | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/modules/a0_prep-root b/src/modules/a0_prep-root
index 21138a1..ea5d1cb 100755
--- a/src/modules/a0_prep-root
+++ b/src/modules/a0_prep-root
@@ -67,4 +67,4 @@ debirf_exec apt-get --yes --force-yes update
 debirf_exec apt-get --yes --force-yes upgrade
 
 # work around http://bugs.debian.org/686965
-debirf_exec sh -c 'cd /etc/init.d && insserv $(ls | grep -vFx -e rc -e rcS -e skeleton -e README)'
+debirf_exec sh -c 'if `which insserv > /dev/null`; then cd /etc/init.d && insserv $(ls | grep -vFx -e rc -e rcS -e skeleton -e README); fi'
-- 
2.11.0

Bug#833125: : debirf: fails to build rescue on sid/stretch: insserv not found

[jhcha54008]

Hi,

What about the more conservative patch below ? 
This last line of a0_prep_root is still useful in case one replaces
systemd-sysv with sysvinit-core :

$ echo '+sysvinit-core' > minimal/packages
$ debirf make minimal

I hope it will help !

Regards,
JH Chatenet

--- a/usr/share/debirf/modules/a0_prep-root
+++ b/usr/share/debirf/modules/a0_prep-root
@@ -67,4 +67,4 @@
 debirf_exec apt-get --yes --force-yes upgrade
 
 # work around http://bugs.debian.org/686965
-debirf_exec sh -c 'cd /etc/init.d && insserv $(ls | grep -vFx -e rc -e rcS -e 
skeleton -e README)'
+debirf_exec sh -c 'if `which insserv > /dev/null`; then cd /etc/init.d && 
insserv $(ls | grep -vFx -e rc -e rcS -e skeleton -e README); fi'

Bug#833125: debirf: fails to build rescue on sid/stretch: insserv not found

[Tzafrir Cohen]

Package: debirf
Version: 0.36
Severity: important

Dear Maintainer,

I tried building a debirf image on my Stretch system. It failed building
with an error regarding 'insserv not found' (IIRC). The error persisted
when I set the DISTRO to stretch.

My workaround: rem-out the last line in rescue/modules/a0_prep-root:

  # work around http://bugs.debian.org/686965
  debirf_exec sh -c 'cd /etc/init.d && insserv $(ls | grep -vFx -e rc -e rcS -e 
skeleton -e README)'

>From what I see, insserv is no longer pulled into a systemd-based
system. Should this line become optional or should insserv be pulled
explicitly?

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf

Kernel: Linux 4.6.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=he_IL.UTF-8, LC_CTYPE=he_IL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages debirf depends on:
ii  apt  1.3~pre2
ii  cpio 2.11+dfsg-5
ii  debootstrap  1.0.81
ii  fakechroot   2.18-1
ii  fakeroot 1.21-1
ii  klibc-utils  2.0.4-9

Versions of packages debirf recommends:
ii  grub-common  2.02~beta2-36
ii  lsb-release  9.20160629
ii  xorriso  1.4.4-1

Versions of packages debirf suggests:
ii  syslinux-common  3:6.03+dfsg-14

-- no debconf information