Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Shlomi Fish]

Hi Gergely,

thanks for your message.

On Tue, 24 Jan 2017 17:45:25 +0100
Gergely Risko  wrote:

> Hey Guys,
> 
> Sorry, don't have the time to followup on the whole discussion again.
> 
> As many times I told Shlomi Fish, I'm happy to help with this package,
> but yes, I have a very busy life nowadays and if I miss things, I
> asked to be emailed privately either on ri...@debian.org or
> gerg...@risko.hu.
> 

ah, I didn't recall it. I'll try to keep it in mind from now on.

> If someone tells me what's the current state and if you just need a
> version update ASAP, then I can do this over the weekend.
> 

Thanks!

> Any other bugs to handle that makes this complicated?
> 

None that I am aware of.

-- Shlomi Fish

> Cheers,
> Gergely
> 
> On 2017-01-23 16:12 (Monday), Gianfranco Costamagna
>  writes:
> > Hello
> >  
> >>This makes me angry and disappointed. I reported  
> >  
> >>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841445 many months ago and
> >>posted "ping replies" and nothing was done to resolve it - either by the
> >>maintainer, who was missing-in-action and not for the first time - or by a
> >>different Debian contributor. And now you tell me that the new release of
> >>Debian will ship an old version of freecell-solver with some documented
> >>crashes and freezes and other bugs.  
> >
> > for sure you should have opened an NMU request months ago, posting your
> > willingness to upload and a deadline to the maintainer.
> >
> > However, the maintainer had already a MIA process, is inactive since 9
> > months, and upstream is asking us to update because of bugs/crashes.
> > Since we can't ignore upstream, I think in this case we should just upload
> > it.
> >
> > (the changes looks fine, but something needs adjustememnt)
> > 1) the library is public, and maybe the ABI changed but there are no
> > reverse-deps, so I don't care too much
> > 2) there is an useless "debhelper," dependency in control file
> >
> > 3) kaz_tree.c and +kaz_tree.h are not reflected in debian/copyright
> >
> > the packaging looks complicate, but we can't fix this in an NMU :)
> >
> > I'm going to open a MIA process right now
> >
> > Andrey, do you agree with me? you started the review, I don't want to steal
> > your package or break rules too much :)
> >
> > Gianfranco  

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Gianfranco Costamagna]

Hello Shlomi, you need to make the package build against sid in less than one 
day.:q
vi


I did the changes and I'm attaching them here, lots of conflicts between 


fcs_enums.h and patsolve-shlomif/patsolve/fcs_enums.h
fcs_dllexport.h and patsolve-shlomif/patsolve/fcs_dllexport.h

(I'm removing them in clean target)

and a bad include guard on cmd_line_enum.h

http://debomatic-amd64.debian.net/distribution#unstable/freecell-solver/4.8.0-0.1/buildlog

please make it  build, or I won't be able to sponsor it in time for the freeze

G.


>I didn't look into the packaging, only into the diff between versions,
>feel free to continue reviewing it.


(thanks!)G.

freecell-solver_4.8.0-0.1.debian.tar.bz2
Description: application/bzip

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Andrey Rahmatullin]

On Mon, Jan 23, 2017 at 04:12:01PM +, Gianfranco Costamagna wrote:
> Andrey, do you agree with me? you started the review, I don't want to steal 
> your package
> or break rules too much :)
I didn't look into the packaging, only into the diff between versions,
feel free to continue reviewing it.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Gianfranco Costamagna]

Hello

>This makes me angry and disappointed. I reported

>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841445 many months ago and
>posted "ping replies" and nothing was done to resolve it - either by the
>maintainer, who was missing-in-action and not for the first time - or by a
>different Debian contributor. And now you tell me that the new release of
>Debian will ship an old version of freecell-solver with some documented crashes
>and freezes and other bugs.


for sure you should have opened an NMU request months ago, posting your 
willingness
to upload and a deadline to the maintainer.

However, the maintainer had already a MIA process, is inactive since 9 months,
and upstream is asking us to update because of bugs/crashes.
Since we can't ignore upstream, I think in this case we should just upload it.

(the changes looks fine, but something needs adjustememnt)
1) the library is public, and maybe the ABI changed but there are no 
reverse-deps, so I don't
care too much
2) there is an useless "debhelper," dependency in control file

3) kaz_tree.c and +kaz_tree.h are not reflected in debian/copyright

the packaging looks complicate, but we can't fix this in an NMU :)

I'm going to open a MIA process right now

Andrey, do you agree with me? you started the review, I don't want to steal 
your package
or break rules too much :)


Gianfranco

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Shlomi Fish]

On Mon, 23 Jan 2017 19:56:37 +0500
Andrey Rahmatullin  wrote:

> Oh, and as this NMU doesn't deserve a short delay, it will miss stretch
> and so should be uploaded to experimental until the freeze is over, unless
> I'm miscalculating.
> 

This makes me angry and disappointed. I reported
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841445 many months ago and
posted "ping replies" and nothing was done to resolve it - either by the
maintainer, who was missing-in-action and not for the first time - or by a
different Debian contributor. And now you tell me that the new release of
Debian will ship an old version of freecell-solver with some documented crashes
and freezes and other bugs.

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Shlomi Fish]

Control: retitle -1 RFS: freecell-solver/4.8.0-0.1 NMU

On Mon, 23 Jan 2017 19:52:06 +0500
Andrey Rahmatullin  wrote:

> On Mon, Jan 23, 2017 at 04:44:03PM +0200, Shlomi Fish wrote:
> > should I send a new NMU request based on that or can this ticket be reused
> > for it  as well?  
> You can reuse this RFS ticket for the package you just uploaded, you
> should retitle it though. 

Hopefully done.

> And you still need to follow the NMU procedure,
> including sending the nmudiff to the bug(s) you are closing.
> 

OK, I must have missed that when reading your link about the NMU procedure.
There's too much verbiage there.

Regards,

-- Shlomi

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Andrey Rahmatullin]

On Mon, Jan 23, 2017 at 04:44:03PM +0200, Shlomi Fish wrote:
> should I send a new NMU request based on that or can this ticket be reused for
> it  as well?
You can reuse this RFS ticket for the package you just uploaded, you
should retitle it though. And you still need to follow the NMU procedure,
including sending the nmudiff to the bug(s) you are closing.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Andrey Rahmatullin]

Oh, and as this NMU doesn't deserve a short delay, it will miss stretch
and so should be uploaded to experimental until the freeze is over, unless
I'm miscalculating.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Shlomi Fish]

Hi Andrey,

On Mon, 23 Jan 2017 17:25:11 +0500
Andrey Rahmatullin  wrote:

> Control: tags -1 + moreinfo
> 
> Please read and follow
> https://www.debian.org/doc/manuals/developers-reference/ch05.en.html#nmu
> 
> Your debian/patches/debian-changes is full of conflict markers, this is
> unacceptable and also means you did something wrong.
> 
> B-D changes are not reflected in d/changelog.
> 

thanks for the commentary. I uploaded a 4.8.0-0.1 package with your
recommendations applied there. mentors.debian.net is now giving me this:

<
Hi.

Your upload of the package 'freecell-solver' to mentors.debian.net was
successful. Others can now see it. The URL of your package is:
https://mentors.debian.net/package/freecell-solver

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/main/f/freecell-solver/freecell-solver_4.8.0-0.1.dsc

If you do not yet have a sponsor for your package you may want to go to
https://mentors.debian.net/sponsors/rfs-howto/freecell-solver
and set the "Seeking a sponsor" option to highlight your package on the
welcome page.

You can also send an RFS (request for sponsorship) to the debian-mentors
mailing list. Your package page will give your suggestions on how to
send that mail.

Good luck in finding a sponsor!

Thanks,
>>

should I send a new NMU request based on that or can this ticket be reused for
it  as well?

-- Shlomi

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Andrey Rahmatullin]

Control: tags -1 + moreinfo

Please read and follow
https://www.debian.org/doc/manuals/developers-reference/ch05.en.html#nmu

Your debian/patches/debian-changes is full of conflict markers, this is
unacceptable and also means you did something wrong.

B-D changes are not reflected in d/changelog.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#852295: RFS: freecell-solver/4.8.0-1 NMU

[Shlomi Fish]

Package: sponsorship-requests
  Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "freecell-solver"

 * Package name: freecell-solver
   Version : 4.8.0-1
   Upstream Author : Shlomi Fish 
 * URL : http://fc-solve.shlomifish.org/
 * License : Expat
   Section : devel

  It builds those binary packages:

freecell-solver-bin - Library for solving Freecell games
 libfreecell-solver-dev - Library for solving Freecell games (Development files)
 libfreecell-solver0 - Library for solving Freecell games

  To access further information about this package, please visit the following
URL:

  https://mentors.debian.net/package/freecell-solver


  Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/f/freecell-solver/freecell-solver_4.8.0-1.dsc

  More information about freecell-solver can be obtained from
 http://fc-solve.shlomifish.org/ .

  Changes since the last upload:

  Updated to the new upstream version with several fixes and improvements - see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841445


  Regards,
   Shlomi Fish