Bug#853929: Please upstream modifications to Thunderbird/Icedove AppArmor profile
Hi Douglas, >> it's great that you provided modifications to the AppArmor profile in >> Debian! May I kindly ask you to send these upstream too? >> If you think that's too much work, please just tag your bug using a >> usertag. The corresponding tag would be "merge-to-upstream" and then the >> AppArmor team can take care of this. See >> https://wiki.debian.org/AppArmor/Reportbug#Usertags for how to do that. > > Thanks. I am taking this last option because trying to work out where > that commit with the dots-for-spaces came from has baffled me, and in > dealing with upstream I lack the historical context of the two teams > interactions to know whether they would prefer the broken patch and > its fix merged into one or both in series or some other thing. People > are particular about how they like to manage mistakes in their git > trees, so it is best in this case that you/they do it. I've just updated the documentation: https://wiki.debian.org/AppArmor/Contribute/Upstream#Quick_howto_contribute_to_upstream_AppArmor_profiles_using_Git because I realized that some parts were missing. Basically the idea would always be to get patches upstreamed and then to tell Debian (Thunderbird + AppArmor) maintainers about it once it's been merged. For this particular case, I think Simon said he would take care of it. Have a nice day, ulrike
Bug#853929: Please upstream modifications to Thunderbird/Icedove AppArmor profile
hi Ulrike, On 18/03/17 03:56, Ulrike Uhlig wrote: > Hi Douglas, > > it's great that you provided modifications to the AppArmor profile in > Debian [1]! May I kindly ask you to send these upstream too? That way, > they will get reviewed first and then all other distributions using > AppArmor can profit from your improvements. > > Debian has some documentation on how to do so: > https://wiki.debian.org/AppArmor/Contribute/Upstream > > Basically, their Git repo lives here: > https://code.launchpad.net/~apparmor-dev/apparmor-profiles/+git/apparmor-profiles > (The particular file lives here: > https://git.launchpad.net/apparmor-profiles/tree/ubuntu/17.04/usr.bin.thunderbird) > When done, you can ask for a merge using Launchpad or the mailinglist: > appar...@lists.ubuntu.com > > If you think that's too much work, please just tag your bug using a > usertag. The corresponding tag would be "merge-to-upstream" and then the > AppArmor team can take care of this. See > https://wiki.debian.org/AppArmor/Reportbug#Usertags for how to do that. Thanks. I am taking this last option because trying to work out where that commit with the dots-for-spaces came from has baffled me, and in dealing with upstream I lack the historical context of the two teams interactions to know whether they would prefer the broken patch and its fix merged into one or both in series or some other thing. People are particular about how they like to manage mistakes in their git trees, so it is best in this case that you/they do it. cheers, Douglas > [1] > https://anonscm.debian.org/cgit/pkg-mozilla/icedove.git/commit/?h=debian/experimental=e2c8a2391c7b6d422f5df40682b8b19f08b88dcf >
Bug#853929: Please upstream modifications to Thunderbird/Icedove AppArmor profile
Hello Simon, On Fri, Mar 17, 2017 at 11:21:38AM -0400, Simon Deziel wrote: > On 03/17/2017 10:56 AM, Ulrike Uhlig wrote: > > it's great that you provided modifications to the AppArmor profile in > > Debian [1]! May I kindly ask you to send these upstream too? That way, > > they will get reviewed first and then all other distributions using > > AppArmor can profit from your improvements. > > Yes, thanks for adding useful bits to the profile. The commit [1] > unfortunately has some formatting issues were the spaces are replaced > with a special dot character. Aside from that, the diff looks good to me. > > > [1] > > https://anonscm.debian.org/cgit/pkg-mozilla/icedove.git/commit/?h=debian/experimental=e2c8a2391c7b6d422f5df40682b8b19f08b88dcf yes, while adding the changes accidentally dots were added were spaces should be. This was fixed some commits later in the branch debian/sid. https://anonscm.debian.org/cgit/pkg-mozilla/icedove.git/commit/?h=debian/sid=36a922f30da08591bbe3bb38b3401434191ec6eb Regards Carsten
Bug#853929: Please upstream modifications to Thunderbird/Icedove AppArmor profile
On 03/17/2017 10:56 AM, Ulrike Uhlig wrote: > it's great that you provided modifications to the AppArmor profile in > Debian [1]! May I kindly ask you to send these upstream too? That way, > they will get reviewed first and then all other distributions using > AppArmor can profit from your improvements. Yes, thanks for adding useful bits to the profile. The commit [1] unfortunately has some formatting issues were the spaces are replaced with a special dot character. Aside from that, the diff looks good to me. > [1] > https://anonscm.debian.org/cgit/pkg-mozilla/icedove.git/commit/?h=debian/experimental=e2c8a2391c7b6d422f5df40682b8b19f08b88dcf Regards, Simon
Bug#853929: Please upstream modifications to Thunderbird/Icedove AppArmor profile
Hi Douglas, it's great that you provided modifications to the AppArmor profile in Debian [1]! May I kindly ask you to send these upstream too? That way, they will get reviewed first and then all other distributions using AppArmor can profit from your improvements. Debian has some documentation on how to do so: https://wiki.debian.org/AppArmor/Contribute/Upstream Basically, their Git repo lives here: https://code.launchpad.net/~apparmor-dev/apparmor-profiles/+git/apparmor-profiles (The particular file lives here: https://git.launchpad.net/apparmor-profiles/tree/ubuntu/17.04/usr.bin.thunderbird) When done, you can ask for a merge using Launchpad or the mailinglist: appar...@lists.ubuntu.com If you think that's too much work, please just tag your bug using a usertag. The corresponding tag would be "merge-to-upstream" and then the AppArmor team can take care of this. See https://wiki.debian.org/AppArmor/Reportbug#Usertags for how to do that. Thank you! ulrike [1] https://anonscm.debian.org/cgit/pkg-mozilla/icedove.git/commit/?h=debian/experimental=e2c8a2391c7b6d422f5df40682b8b19f08b88dcf
