Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-07 Thread Otto Kekäläinen
Hello!

su 6. tammik. 2019 klo 23.52 Nikolay Dimitrov
(nikolay.dimit...@retrohub.org) kirjoitti:
>
> Hi Otto, Helmut,
>
> Thanks for fixing the bug and sharing the progress with me.
>
> To be honest, I could have sent a patch for this issue even back then,
> but I'm not familiar with Debian's contributors' policy and procedures,
> and decided to not experiment with it (if it takes months for
> experienced Debian developers to push patches through the system, there
> aren't any high hopes for external contributors like me).

It is actually very easy nowadays to contribute. Just fork the
packaging repo, do your changes, test and submit a merge request. Once
the change is approved, it will be part of the next upload, usually
within a few weeks.

If you do some improvements to the mariadb-10.3 packaging this week, I
can promise it will be in Debian unstable next week.



Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-06 Thread Nikolay Dimitrov

Hi Otto, Helmut,

Thanks for fixing the bug and sharing the progress with me.

To be honest, I could have sent a patch for this issue even back then,
but I'm not familiar with Debian's contributors' policy and procedures,
and decided to not experiment with it (if it takes months for
experienced Debian developers to push patches through the system, there
aren't any high hopes for external contributors like me).

Thank you for making Debian a great distibution. Happy New Year!

Kind regards,
Nikolay Dimitrov
(A happy Debian user since 2003)


On 1/6/19 8:01 PM, Otto Kekäläinen wrote:

Hello Nikolay!

Thanks for submitting the bug report below in late 2017. Sorry that I
did not respond to it this year and apparently nobody else responded
to it last year either.
It should be fixed now in
https://salsa.debian.org/mariadb-team/mariadb-10.3/commits/bugfix/878340-mysqlclient.pc-path

One problem we have with the MariaDB package in Debian (and also in
upstream mariadb.org repos) is that there hasn't been any automated or
complete testing system for compiling software using the MariaDB libs.
I have now built something simple in
https://salsa.debian.org/mariadb-team/mariadb-10.3/blob/master/debian/gitlab-ci.yml#L200-234

I would appreciate very much if you would like to contribute to
MariaDB in Debian and extend that test code so that it would actually
build/compile a small sample program first using the libmysqlclient
libs and then re-doing it with the MariaDB equivalent installed.

I prefer contributions as merge requests on Debian's new Gitlab
instance called Salsa:
https://wiki.debian.org/Teams/MySQL/patches

Maintaining MariaDB in Debian is a very big task and I appreciate all
help I get that decreases my workload. Thanks for your previous
contributions and hopefully you can continue contributing!





pe 13. lokak. 2017 klo 1.48 Nikolay Dimitrov
(nikolay.dimit...@retrohub.org) kirjoitti:


Package: libmariadbclient-dev-compat
Version: 10.1.26-0+deb9u1
Severity: important

Dear Maintainer,

I'm trying to compile a software that requires a mysql client library. CMake
is unable to detect that libmariadbclient-dev-compat package is installed on my
system, and running pkg-config against the package shows an error:

$ pkg-config --cflags mysqlclient
Package mysqlclient was not found in the pkg-config search path.
Perhaps you should add the directory containing `mysqlclient.pc'
to the PKG_CONFIG_PATH environment variable
No package 'mysqlclient' found

It seems to me that libmariadbclient-dev-compat package installs mysqlclient.pc
at /usr/lib/x86_64-linux-gnu/, while pkg-config looks for .pc files at /usr/lib/
x86_64-linux-gnu/pkgconfig.

When I create a symlink mysqlclient.pc -> mariadb.pc located in /usr/lib/
x86_64-linux-gnu/pkgconfig, pkg-config is now able to detect the package:

$ pkg-config --cflags mysqlclient
-I/usr/include/mysql -I/usr/include/mysql/..

Can you please double-check whether mysqlclient.pc is installed at the proper 
path?

Kind regards,
Nikolay Dimitrov


-- System Information:
Debian Release: 9.2
   APT prefers stable-updates
   APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libmariadbclient-dev-compat depends on:
ii  libmariadbclient-dev  10.1.26-0+deb9u1

libmariadbclient-dev-compat recommends no packages.

libmariadbclient-dev-compat suggests no packages.

-- no debconf information




--
Otto Kekäläinen
CEO
Seravo
+358 44 566 2204

Follow me at @ottokekalainen





Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-06 Thread Otto Kekäläinen
Hello Nikolay!

Thanks for submitting the bug report below in late 2017. Sorry that I
did not respond to it this year and apparently nobody else responded
to it last year either.
It should be fixed now in
https://salsa.debian.org/mariadb-team/mariadb-10.3/commits/bugfix/878340-mysqlclient.pc-path

One problem we have with the MariaDB package in Debian (and also in
upstream mariadb.org repos) is that there hasn't been any automated or
complete testing system for compiling software using the MariaDB libs.
I have now built something simple in
https://salsa.debian.org/mariadb-team/mariadb-10.3/blob/master/debian/gitlab-ci.yml#L200-234

I would appreciate very much if you would like to contribute to
MariaDB in Debian and extend that test code so that it would actually
build/compile a small sample program first using the libmysqlclient
libs and then re-doing it with the MariaDB equivalent installed.

I prefer contributions as merge requests on Debian's new Gitlab
instance called Salsa:
https://wiki.debian.org/Teams/MySQL/patches

Maintaining MariaDB in Debian is a very big task and I appreciate all
help I get that decreases my workload. Thanks for your previous
contributions and hopefully you can continue contributing!





pe 13. lokak. 2017 klo 1.48 Nikolay Dimitrov
(nikolay.dimit...@retrohub.org) kirjoitti:
>
> Package: libmariadbclient-dev-compat
> Version: 10.1.26-0+deb9u1
> Severity: important
>
> Dear Maintainer,
>
> I'm trying to compile a software that requires a mysql client library. CMake
> is unable to detect that libmariadbclient-dev-compat package is installed on 
> my
> system, and running pkg-config against the package shows an error:
>
> $ pkg-config --cflags mysqlclient
> Package mysqlclient was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mysqlclient.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'mysqlclient' found
>
> It seems to me that libmariadbclient-dev-compat package installs 
> mysqlclient.pc
> at /usr/lib/x86_64-linux-gnu/, while pkg-config looks for .pc files at 
> /usr/lib/
> x86_64-linux-gnu/pkgconfig.
>
> When I create a symlink mysqlclient.pc -> mariadb.pc located in /usr/lib/
> x86_64-linux-gnu/pkgconfig, pkg-config is now able to detect the package:
>
> $ pkg-config --cflags mysqlclient
> -I/usr/include/mysql -I/usr/include/mysql/..
>
> Can you please double-check whether mysqlclient.pc is installed at the proper 
> path?
>
> Kind regards,
> Nikolay Dimitrov
>
>
> -- System Information:
> Debian Release: 9.2
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 4.9.0-4-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: 
> LC_ALL set to en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: 
> LC_ALL set to en_US.UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
> Versions of packages libmariadbclient-dev-compat depends on:
> ii  libmariadbclient-dev  10.1.26-0+deb9u1
>
> libmariadbclient-dev-compat recommends no packages.
>
> libmariadbclient-dev-compat suggests no packages.
>
> -- no debconf information
>


--
Otto Kekäläinen
CEO
Seravo
+358 44 566 2204

Follow me at @ottokekalainen



Bug#878340: [debian-mysql] Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-06 Thread Otto Kekäläinen
Hello!

su 6. tammik. 2019 klo 12.54 Helmut Grohne (hel...@subdivi.de) kirjoitti:
>
> Hi Otto,
>
> On Sun, Jan 06, 2019 at 12:19:50PM +0200, Otto Kekäläinen wrote:
> > Currenlty in Debian unstable we have mariadb-10.3. Would you be kind
> > and rebase, test and submit your patch on mariadb-10.3?
>
> If "apt-get source libmariadbclient-dev-compat" yields a non-default
> version in unstable, then you have cruft in unstable. Would you be kind
> and clean up that cruft to make standard workflows work?

I think I have been doing Debian packaging almost every day, even on
weekends, for the past 5 weeks. Currently we are in the middle of
having mariadb-10.1 in testing and mariadb-10.3 in unstable (along
with an updated mysql-defaults in unstable). There are a multitude of
issues and due to the complexity of having to adopt to upstream
changes that sometimes conflict with Debian needs there is a lot of
work. Also, as some areas are regression prone, I have been forced to
spend time to develop on CI tooling to ensure we don't get old
regressions back again.

So all help and encouragement is welcome. Thanks for your patch!

In mariadb-10.3 the package libmariadbclient-dev-compat has been
replaced by libmariadb-dev-compat (which was previously alreadi in
Debian as well as part of
https://tracker.debian.org/pkg/mariadb-connector-c but upstream merged
the connector into the server source so we need to adapt now.

> In particular, please don't let important bugs linger for extended
> periods of time without any response. Much less ones that are as trivial
> to fix as this one is.

Sorry, I wasn't active with the packaging in the fall 2017 due to
other priorities and the person active at the time overlooked this,
and I seem to have overlooked it as well when i in DebConf 2018
triaged and updated all bugs (but apparently not this one, sorry).



Bug#878340: [debian-mysql] Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-06 Thread Helmut Grohne
Hi Otto,

On Sun, Jan 06, 2019 at 12:19:50PM +0200, Otto Kekäläinen wrote:
> Currenlty in Debian unstable we have mariadb-10.3. Would you be kind
> and rebase, test and submit your patch on mariadb-10.3?

If "apt-get source libmariadbclient-dev-compat" yields a non-default
version in unstable, then you have cruft in unstable. Would you be kind
and clean up that cruft to make standard workflows work?

> Preferred way to get patches if as Salsa merge requests. See easy
> instructions at https://wiki.debian.org/Teams/MySQL/patches

The preferred way to interact with contributors is the bug tracking
system. See easy instruction at
https://www.debian.org/doc/manuals/developers-reference/ch05.en.html#bug-handling
for how to use that interface.

In particular, please don't let important bugs linger for extended
periods of time without any response. Much less ones that are as trivial
to fix as this one is.

Helmut



Bug#878340: [debian-mysql] Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-06 Thread Otto Kekäläinen
Hello Helmut!

su 6. tammik. 2019 klo 12.09 Helmut Grohne (hel...@subdivi.de) kirjoitti:
>
> Control: tags -1 + patch
>
> On Fri, Oct 13, 2017 at 01:47:19AM +0300, Nikolay Dimitrov wrote:
> > Can you please double-check whether mysqlclient.pc is installed at the 
> > proper path?
>
> It isn't. Please use the attached patch.

Thanks for the patch!

Currenlty in Debian unstable we have mariadb-10.3. Would you be kind
and rebase, test and submit your patch on mariadb-10.3?
Preferred way to get patches if as Salsa merge requests. See easy
instructions at https://wiki.debian.org/Teams/MySQL/patches



Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2019-01-06 Thread Helmut Grohne
Control: tags -1 + patch

On Fri, Oct 13, 2017 at 01:47:19AM +0300, Nikolay Dimitrov wrote:
> Can you please double-check whether mysqlclient.pc is installed at the proper 
> path?

It isn't. Please use the attached patch.

Helmut
diff --minimal -Nru mariadb-10.1-10.1.37/debian/changelog 
mariadb-10.1-10.1.37/debian/changelog
--- mariadb-10.1-10.1.37/debian/changelog   2018-12-08 17:50:43.0 
+0100
+++ mariadb-10.1-10.1.37/debian/changelog   2019-01-06 11:03:04.0 
+0100
@@ -1,3 +1,10 @@
+mariadb-10.1 (1:10.1.37-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix path of mysqlclient.pc. (Closes: #878340)
+
+ -- Helmut Grohne   Sun, 06 Jan 2019 11:03:04 +0100
+
 mariadb-10.1 (1:10.1.37-3) unstable; urgency=low
 
   [ Otto Kekäläinen ]
diff --minimal -Nru 
mariadb-10.1-10.1.37/debian/libmariadbclient-dev-compat.links 
mariadb-10.1-10.1.37/debian/libmariadbclient-dev-compat.links
--- mariadb-10.1-10.1.37/debian/libmariadbclient-dev-compat.links   
2018-11-29 16:34:32.0 +0100
+++ mariadb-10.1-10.1.37/debian/libmariadbclient-dev-compat.links   
2019-01-06 11:02:47.0 +0100
@@ -1,4 +1,4 @@
 #!/usr/bin/dh-exec
 usr/lib/${DEB_HOST_MULTIARCH}/libmariadbclient.so 
usr/lib/${DEB_HOST_MULTIARCH}/libmysqlclient.so
 usr/lib/${DEB_HOST_MULTIARCH}/libmariadbclient_r.so 
usr/lib/${DEB_HOST_MULTIARCH}/libmysqlclient_r.so
-usr/lib/${DEB_HOST_MULTIARCH}/pkgconfig/mariadb.pc 
usr/lib/${DEB_HOST_MULTIARCH}/mysqlclient.pc
+usr/lib/${DEB_HOST_MULTIARCH}/pkgconfig/mariadb.pc 
usr/lib/${DEB_HOST_MULTIARCH}/pkgconfig/mysqlclient.pc


Bug#878340: libmariadbclient-dev-compat: mysqlclient.pc is not visible to pkg-config

2017-10-12 Thread Nikolay Dimitrov
Package: libmariadbclient-dev-compat
Version: 10.1.26-0+deb9u1
Severity: important

Dear Maintainer,

I'm trying to compile a software that requires a mysql client library. CMake
is unable to detect that libmariadbclient-dev-compat package is installed on my
system, and running pkg-config against the package shows an error:

$ pkg-config --cflags mysqlclient
Package mysqlclient was not found in the pkg-config search path.
Perhaps you should add the directory containing `mysqlclient.pc'
to the PKG_CONFIG_PATH environment variable
No package 'mysqlclient' found

It seems to me that libmariadbclient-dev-compat package installs mysqlclient.pc
at /usr/lib/x86_64-linux-gnu/, while pkg-config looks for .pc files at /usr/lib/
x86_64-linux-gnu/pkgconfig.

When I create a symlink mysqlclient.pc -> mariadb.pc located in /usr/lib/
x86_64-linux-gnu/pkgconfig, pkg-config is now able to detect the package:

$ pkg-config --cflags mysqlclient
-I/usr/include/mysql -I/usr/include/mysql/..

Can you please double-check whether mysqlclient.pc is installed at the proper 
path?

Kind regards,
Nikolay Dimitrov


-- System Information:
Debian Release: 9.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libmariadbclient-dev-compat depends on:
ii  libmariadbclient-dev  10.1.26-0+deb9u1

libmariadbclient-dev-compat recommends no packages.

libmariadbclient-dev-compat suggests no packages.

-- no debconf information