Bug#917203: FTBFS on at least two architectures: test failure in the enigma algorithm
tags 917203 + pending
thanks
I've uploaded libmcrypt 2.5.8-3.4 to DELAYED/5:
libmcrypt (2.5.8-3.4) unstable; urgency=medium
* Non-maintainer upload.
* Fix FTBFS on at least two architectures due to test failures in the
"enigma". Thanks to Göran Weinholt (weinholt) for the patch.
(Closes: #917203)
* Update Vcs-{Git,Browser} to point to salsa.debian.org.
The full debdiff is attached.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
diffstat for libmcrypt_2.5.8-3.3 libmcrypt_2.5.8-3.4
libmcrypt-2.5.8/debian/changelog | 10 ++
libmcrypt-2.5.8/debian/control |4 ++--
modules/algorithms/enigma.h | 10 +-
3 files changed, 17 insertions(+), 7 deletions(-)
diff -u libmcrypt-2.5.8/debian/changelog libmcrypt-2.5.8/debian/changelog
--- libmcrypt-2.5.8/debian/changelog
+++ libmcrypt-2.5.8/debian/changelog
@@ -1,3 +1,13 @@
+libmcrypt (2.5.8-3.4) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTBFS on at least two architectures due to test failures in the
+"enigma". Thanks to Göran Weinholt (weinholt) for the patch.
+(Closes: #917203)
+ * Update Vcs-{Git,Browser} to point to salsa.debian.org.
+
+ -- Chris Lamb Sun, 07 Apr 2019 14:38:10 +0200
+
libmcrypt (2.5.8-3.3) unstable; urgency=low
* Non-maintainer upload.
diff -u libmcrypt-2.5.8/debian/control libmcrypt-2.5.8/debian/control
--- libmcrypt-2.5.8/debian/control
+++ libmcrypt-2.5.8/debian/control
@@ -3,8 +3,8 @@
Priority: optional
Maintainer: RISKO Gergely
Build-Depends: debhelper (>= 7.0.50), dh-autoreconf, libltdl-dev
-Vcs-Browser: http://git.debian.org/?p=collab-maint/libmcrypt.git;a=summary
-Vcs-Git: git://git.debian.org/collab-maint/libmcrypt.git
+Vcs-Browser: http://salsa.debian.org/debian/libmcrypt
+Vcs-Git: http://salsa.debian.org/debian/libmcrypt.git
Homepage: http://mcrypt.sourceforge.net/
Standards-Version: 3.8.1
--- libmcrypt-2.5.8.orig/modules/algorithms/enigma.h
+++ libmcrypt-2.5.8/modules/algorithms/enigma.h
@@ -3,11 +3,11 @@
#define MASK 0377
typedef struct crypt_key {
- char t1[ROTORSZ];
- char t2[ROTORSZ];
- char t3[ROTORSZ];
- char deck[ROTORSZ];
- char cbuf[13];
+ signed char t1[ROTORSZ];
+ signed char t2[ROTORSZ];
+ signed char t3[ROTORSZ];
+ signed char deck[ROTORSZ];
+ signed char cbuf[13];
int n1, n2, nr1, nr2;
} CRYPT_KEY;
Bug#917203: FTBFS on at least two architectures: test failure in the enigma algorithm
On Mon, Dec 24, 2018 at 12:20:05AM +, Steve McIntyre wrote: >Package: src:libmcrypt >Version: 2.5.8-3.3 >Severity: serious >Tags: ftbfs >Justification: fails to build from source (but built successfully in the past) > >Hi! > >I've been doing a full rebuild of the Debian archive, building all >source packages targeting armel and armhf using arm64 hardware. We are >planning in future to move all of our 32-bit armel/armhf builds to >using arm64 machines, so this rebuild is to identify packages that >might have problems with this configuration. > >While doing this, I found that libmcrypt failed its test suite for >armel running on arm64: > >... >Algorithm: enigma... failed compatibility >Expected: f3edda7da20f8975884600f014d32c7a08e59d7b >Got: 216540d5d71ec2d57f626a5609a3ebedbb9b32e4 >... > >I've tested on amd64 and things look fine, but building for arm64 on >arm64 also fails with exactly the same test failure as armel-on-arm64. Just retested again today at a BSP. The failing test (the enigma self-test) works OK on amd64, but fails reliably and repeatedly on at least arm64, armhf and ppc64el with the same failing result. I can only assume that something has changed in compiler setup here - these tests all passed when last uploaded over 4 years ago. Last "maintainer" upload in 2009. Arg. :-( -- Steve McIntyre, Cambridge, UK.st...@einval.com "I've only once written 'SQL is my bitch' in a comment. But that code is in use on a military site..." -- Simon Booth
Bug#917203: FTBFS on at least two architectures: test failure in the enigma algorithm
Package: src:libmcrypt Version: 2.5.8-3.3 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) Hi! I've been doing a full rebuild of the Debian archive, building all source packages targeting armel and armhf using arm64 hardware. We are planning in future to move all of our 32-bit armel/armhf builds to using arm64 machines, so this rebuild is to identify packages that might have problems with this configuration. While doing this, I found that libmcrypt failed its test suite for armel running on arm64: ... Algorithm: enigma... failed compatibility Expected: f3edda7da20f8975884600f014d32c7a08e59d7b Got: 216540d5d71ec2d57f626a5609a3ebedbb9b32e4 ... I've tested on amd64 and things look fine, but building for arm64 on arm64 also fails with exactly the same test failure as armel-on-arm64. Full log at https://www.einval.com/debian/arm/rebuild-logs/armel/FAIL/libmcrypt_2.5.8-3.3_armel.log -- System Information: Debian Release: 9.6 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
