Bug#932474: [pkg-gnupg-maint] Bug#932474: scdaemon: Additional udev rules for librem key

2019-08-08 Thread Daniel Kahn Gillmor
Control: tags 932474 - moreinfo
Control: tags 932474 + pending

On Tue 2019-07-30 16:53:34 -0400, Jeremiah C. Foster wrote:
> The document you point to shows our assignment of 0x316d as "Purism
> SPC". Of course our patch has to be updated accordingly -- please find
> attached an updated patch.

thanks!  i've applied this patch in git, and it will be in the next
upload of the gnupg2 source package.

--dkg


signature.asc
Description: PGP signature


Bug#932474: [pkg-gnupg-maint] Bug#932474: scdaemon: Additional udev rules for librem key

2019-07-30 Thread Jeremiah C. Foster
On Sat, 2019-07-20 at 14:57 -0400, Daniel Kahn Gillmor wrote:
> Control: tags 932474 + moreinfo
> 
> Hi Jeremiah--

Hello Daniel!

> On Fri 2019-07-19 17:24:34 -0400, Jeremiah C. Foster wrote:
> > I would like to add a USB VID:PID pair to the scdaemon package,
> > please find a diff attached.
> 
> I'm really happy to see Librem getting this stuff working, and I'd be
> happy to try to get this merged shortly.

Thank you in advance.

> > +## Librem Key
> > +SUBSYSTEM=="usb", ATTR{idVendor}=="4c4b", ATTR{idProduct}=="4c05",
> > ENV{ID_SMARTCARD_READER}="1",
> > ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
> 
> I'm sure you understand that we don't want to misattribute either
> vendorIDs or vendors.

I do understand that and am grateful for the attention to detail.

>   I tried to look up 0x4c4b (19531 decimal) in the
> "Valid USB Vendor ID Numbers" list distributed by the USB
> implementers
> forum here:
> 
> https://www.usb.org/developers
> 
> It says it's update quarterly, but the version i looked at is from
> late
> May:
> 
> https://usb.org/sites/default/files/vendor_ids052019.pdf
> 
> Was this a recently-assigned vendor ID? 

Yes, but I must apologize for providing you incorrect infomation.
Purism's vendor ID is actually 12653 or 0x316d.

>  Can you provide some evidence
> of the assignment?

The document you point to shows our assignment of 0x316d as "Purism
SPC". Of course our patch has to be updated accordingly -- please find
attached an updated patch.

Many thanks,

Jeremiah
--- /lib/udev/rules.d/60-scdaemon.rules-o	2019-07-19 13:48:34.591954821 -0700
+++ /lib/udev/rules.d/60-scdaemon.rules	2019-07-19 13:49:50.319551666 -0700
@@ -36,6 +36,8 @@
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4108", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4109", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4211", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
+## Librem Key
+SUBSYSTEM=="usb", ATTR{idVendor}=="316d", ATTR{idProduct}=="4c4b", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 ## Gnuk Token
 SUBSYSTEM=="usb", ATTR{idVendor}=="234b", ATTR{idProduct}=="", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 ## Alcor Micro Corp cardreader (in ThinkPad X250)


signature.asc
Description: This is a digitally signed message part


Bug#932474: [pkg-gnupg-maint] Bug#932474: scdaemon: Additional udev rules for librem key

2019-07-20 Thread Daniel Kahn Gillmor
Control: tags 932474 + moreinfo

Hi Jeremiah--

On Fri 2019-07-19 17:24:34 -0400, Jeremiah C. Foster wrote:
> I would like to add a USB VID:PID pair to the scdaemon package, please find a 
> diff attached.

I'm really happy to see Librem getting this stuff working, and I'd be
happy to try to get this merged shortly.

> +## Librem Key
> +SUBSYSTEM=="usb", ATTR{idVendor}=="4c4b", ATTR{idProduct}=="4c05", 
> ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"

I'm sure you understand that we don't want to misattribute either
vendorIDs or vendors.  I tried to look up 0x4c4b (19531 decimal) in the
"Valid USB Vendor ID Numbers" list distributed by the USB implementers
forum here:

https://www.usb.org/developers

It says it's update quarterly, but the version i looked at is from late
May:

https://usb.org/sites/default/files/vendor_ids052019.pdf

Was this a recently-assigned vendor ID?  Can you provide some evidence
of the assignment?

--dkg


signature.asc
Description: PGP signature


Bug#932474: scdaemon: Additional udev rules for librem key

2019-07-19 Thread Jeremiah C. Foster
Package: scdaemon
Version: 2.2.12-1
Severity: wishlist
Tags: patch

Dear Maintainer,

I would like to add a USB VID:PID pair to the scdaemon package, please find a 
diff attached.

-- System Information:
Distributor ID: PureOS
Description:PureOS
Release:8
Codename:   green
Architecture: x86_64

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages scdaemon depends on:
ii  gpg-agent  2.2.12-1
ii  libassuan0 2.5.2-1
ii  libc6  2.28-10
ii  libgcrypt201.8.4-5
ii  libgpg-error0  1.35-1
ii  libksba8   1.3.5-2
ii  libnpth0   1.6-1
ii  libusb-1.0-0   2:1.0.22-2

scdaemon recommends no packages.

scdaemon suggests no packages.

-- no debconf information
--- /lib/udev/rules.d/60-scdaemon.rules-o   2019-07-19 13:48:34.591954821 
-0700
+++ /lib/udev/rules.d/60-scdaemon.rules 2019-07-19 13:49:50.319551666 -0700
@@ -36,6 +36,8 @@
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4108", 
ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4109", 
ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4211", 
ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
+## Librem Key
+SUBSYSTEM=="usb", ATTR{idVendor}=="4c4b", ATTR{idProduct}=="4c05", 
ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 ## Gnuk Token
 SUBSYSTEM=="usb", ATTR{idVendor}=="234b", ATTR{idProduct}=="", 
ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 ## Alcor Micro Corp cardreader (in ThinkPad X250)