Bug#952759: Fwd: Bug#952759: libsass-python 0.18.0 FTBFS with libsass 3.6.3, please upgrade to 0.19.4

2020-03-10 Thread Anthony Fok
(Oops, forgot to send to the bug report too, forwarding...)

-- Forwarded message -
From: Anthony Fok 
Date: Mon, Mar 9, 2020 at 7:28 PM
Subject: Re: Bug#952759: libsass-python 0.18.0 FTBFS with libsass
3.6.3, please upgrade to 0.19.4
To: Frédéric Bonnard 


Hi Fred,

On Mon, Mar 9, 2020 at 3:16 AM Frédéric Bonnard  wrote:
> March 9, 2020 8:30 AM, "Anthony Fok"  wrote:
> > [testing errors] which all go away with libsass-python 0.19.4.
> expected at some point :)
> I remember having checked in January the status of libsass which latest
> version was still in experimental.

Indeed.  It seems that Jonas (libsass's original maintainer) is quite
conservative with upgrading libsass, probably wary of breakage, though
it is understandable as it seems to be the time of Debian buster's
freeze and imminent release.  I am glad that Jonas did package 3.6.1
in experimental, as it does help my preparation of libsass 3.6.3 much
smoother.

And indeed, to this day, node-node-sass (node-sass upstream) is still
not compatible with libsass 3.6.3, and the upstream authors cite "it
is a volunteer project" as the reason for having no time line for the
upgrade... Thankfully, node-node-sass can be built with its embedded
copy of libsass 3.5.5 for the time being.

My impetus is to get the latest Hugo, which requires libsass 3.6.3,
into Debian (and Ubuntu).  And everyone seems to be saying that
libsass 3.6.3 solves some significant security issues, and we are in
relatively early stages of bullseye cycle, so I'd say, let's be bold
and upgrade and break things!  (and fix them)...

> > So, it would be great if you could upload libsass-python 0.19.4-1. :-)
> >
> > In case you are busy, since I have been fixing the ruby-sassc and
> > node-node-sass packages which also FTBFS due to the libsass 3.6.3
> > upgrade, I would be very happy to make an NMU upload of libsass-python
> > 0.19.4-0.1, which I have prepared at my fork at
> > https://salsa.debian.org/foka/libsass-python, and which I am happy to
> > upload any time, with your permission of course.
>
> It would be a shame to lose the work you've done already and that I didn't
> do, so feel free to NMU libsass-python.

You are very kind, thank you for your generosity!  I have done a "gbp
push" to your repository, and I will do a dput upload soon, like now.
:-)

> > Please let me know soon, especially because I would like to solve all
> > remaining libsass 3.6.3 upgrade issues, hopefully in time for Ubuntu
> > 20.04 LTS release.
>
> No worries, thanks a bunch for all the work and kind mail.

Thank you so much for your kind words and for maintaining the Python
binding for libsass!

Cheers,
Anthony



Bug#952759: libsass-python 0.18.0 FTBFS with libsass 3.6.3, please upgrade to 0.19.4

2020-03-09 Thread Frédéric Bonnard
Hi Anthony

March 9, 2020 8:30 AM, "Anthony Fok"  wrote:

> Control: severity -1 serious
> Control: tags -1 + ftbfs sid
> Control: found -1 0.18.0-1
> 
> On Fri, 28 Feb 2020 17:38:13 +0100 Michael Fladischer  
> wrote:
> 
>> Source: libsass-python
>> Severity: wishlist
>> 
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA512
>> 
>> Dear Maintainer,
>> 
>> right now there is 0.19.4 available from upstream. Would you consider 
>> uploading
>> an updated package to the archive?
>> 
>> Cheers,
>> Michael
> 
> Dear Frédéric,
> 
> I understand that the reason you uploaded libsass-python 0.18.0-1 in
> January 2020, even though 0.19.4 was already released November 2019,
> was to match the existing libsass 3.5.5-4 in Debian.

true

> That changed about 10 days ago on 2020-02-28 when I uploaded libsass
> 3.6.3-1 to Debian sid, and indeed, libsass-python 0.18.0-1 FTBFS with
> libsass 3.6.3-1 with the following errors:
> 
> FAIL: test_importer_returns_wrong_tuple_size_too_big
> (sasstests.CompileTestCase)
> FAIL: test_importer_returns_wrong_tuple_size_zero (sasstests.CompileTestCase)
> FAIL: test_importers_raises_exception (sasstests.CompileTestCase)
> FAIL: test_error (sasstests.CustomFunctionsTest)
> FAIL: test_raises (sasstests.CustomFunctionsTest)
> FAIL: test_returns_unknown_object (sasstests.CustomFunctionsTest)
> FAIL: test_warning (sasstests.CustomFunctionsTest)
> 
> which all go away with libsass-python 0.19.4.

expected at some point :)
I remember having checked in January the status of libsass which latest
version was still in experimental.

> So, it would be great if you could upload libsass-python 0.19.4-1. :-)
> 
> In case you are busy, since I have been fixing the ruby-sassc and
> node-node-sass packages which also FTBFS due to the libsass 3.6.3
> upgrade, I would be very happy to make an NMU upload of libsass-python
> 0.19.4-0.1, which I have prepared at my fork at
> https://salsa.debian.org/foka/libsass-python, and which I am happy to
> upload any time, with your permission of course.

It would be a shame to lose the work you've done already and that I didn't
do, so feel free to NMU libsass-python.

> Please let me know soon, especially because I would like to solve all
> remaining libsass 3.6.3 upgrade issues, hopefully in time for Ubuntu
> 20.04 LTS release.

No worries, thanks a bunch for all the work and kind mail.

Fred

> Many thanks!
> 
> Yours truly,
> 
> Anthony Fok



Bug#952759: libsass-python 0.18.0 FTBFS with libsass 3.6.3, please upgrade to 0.19.4

2020-03-09 Thread Anthony Fok
Control: severity -1 serious
Control: tags -1 + ftbfs sid
Control: found -1 0.18.0-1

On Fri, 28 Feb 2020 17:38:13 +0100 Michael Fladischer  wrote:
> Source: libsass-python
> Severity: wishlist
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Dear Maintainer,
>
> right now there is 0.19.4 available from upstream. Would you consider 
> uploading
> an updated package to the archive?
>
> Cheers,
> Michael

Dear Frédéric,

I understand that the reason you uploaded libsass-python 0.18.0-1 in
January 2020, even though 0.19.4 was already released November 2019,
was to match the existing libsass 3.5.5-4 in Debian.

That changed about 10 days ago on 2020-02-28 when I uploaded libsass
3.6.3-1 to Debian sid, and indeed, libsass-python 0.18.0-1 FTBFS with
libsass 3.6.3-1 with the following errors:

  FAIL: test_importer_returns_wrong_tuple_size_too_big
(sasstests.CompileTestCase)
  FAIL: test_importer_returns_wrong_tuple_size_zero (sasstests.CompileTestCase)
  FAIL: test_importers_raises_exception (sasstests.CompileTestCase)
  FAIL: test_error (sasstests.CustomFunctionsTest)
  FAIL: test_raises (sasstests.CustomFunctionsTest)
  FAIL: test_returns_unknown_object (sasstests.CustomFunctionsTest)
  FAIL: test_warning (sasstests.CustomFunctionsTest)

which all go away with libsass-python 0.19.4.

So, it would be great if you could upload libsass-python 0.19.4-1.  :-)

In case you are busy, since I have been fixing the ruby-sassc and
node-node-sass packages which also FTBFS due to the libsass 3.6.3
upgrade, I would be very happy to make an NMU upload of libsass-python
0.19.4-0.1, which I have prepared at my fork at
https://salsa.debian.org/foka/libsass-python, and which I am happy to
upload any time, with your permission of course.

Please let me know soon, especially because I would like to solve all
remaining libsass 3.6.3 upgrade issues, hopefully in time for Ubuntu
20.04 LTS release.

Many thanks!

Yours truly,

Anthony Fok