Bug#968485: vagrant-libvirt: Please re-introduce the create_box.sh example script

[intrigeri]

Control: tag -1 + wontfix

Hi,

Antonio Terceiro (2020-08-17):
> That script was shipped as an example in /usr/share/docs/, and that is
> not a published interface.
>
> We can even re-introduce it at some point, but IMO if you want to rely
> on it for any kind of automation, you should copy it into your own
> system.

Fair enough :)

I'm thus tagging this bug wontfix, assuming nobody else cares and has
more a stronger need for shipping this script in Debian: as long as we
(Tails) don't use the copy shipped by the package, the main burden is
keeping our own copy up-to-date, and then doing this from upstream Git
is not much more costly than relying on a packaged version.

Thank you for having taken the time to consider my request!

Bug#968485: vagrant-libvirt: Please re-introduce the create_box.sh example script

[Antonio Terceiro]

Hi,

On Sun, Aug 16, 2020 at 09:35:11AM +0200, intrig...@debian.org wrote:
> Package: vagrant-libvirt
> Version: 0.1.2-1
> Severity: wishlist
> Tags: patch
> User: tails-...@boum.org
> Usertags: build-system
> 
> Hi,
> 
> a few years back, in #823317 we added the create_box.sh example script
> to the Debian package: the Tails build system needs it.
> 
> But 0.1.2-1 stopped including this script¹, presumably because the
> upstream tarball does not include that script anymore, which I believe
> is in turn caused by a change Hans-Christoph did upstream².
> 
> How about we do this:
> 
> 1. Bring back create_box.sh into the upstream tarball.
>I suppose the untested attached patch, generated against current
>upstream master branch, could suffice.
> 
> 2. Bring back create_box.sh into the Debian package.
>I suppose it boils down to reverting 
> e767deba89c8cabb26c2706e1d4f0b6475fd1070.
> 
> ?
> 
> [1] 
> https://salsa.debian.org/ruby-team/vagrant-libvirt/-/commit/e767deba89c8cabb26c2706e1d4f0b6475fd1070
> [2] 
> https://github.com/vagrant-libvirt/vagrant-libvirt/commit/2ca5603ad2e4e7cd90951d2064226de7eec1214b

That script was shipped as an example in /usr/share/docs/, and that is
not a published interface.

We can even re-introduce it at some point, but IMO if you want to rely
on it for any kind of automation, you should copy it into your own
system.


signature.asc
Description: PGP signature

Bug#968485: vagrant-libvirt: Please re-introduce the create_box.sh example script

[intrigeri]

Package: vagrant-libvirt
Version: 0.1.2-1
Severity: wishlist
Tags: patch
User: tails-...@boum.org
Usertags: build-system

Hi,

a few years back, in #823317 we added the create_box.sh example script
to the Debian package: the Tails build system needs it.

But 0.1.2-1 stopped including this script¹, presumably because the
upstream tarball does not include that script anymore, which I believe
is in turn caused by a change Hans-Christoph did upstream².

How about we do this:

1. Bring back create_box.sh into the upstream tarball.
   I suppose the untested attached patch, generated against current
   upstream master branch, could suffice.

2. Bring back create_box.sh into the Debian package.
   I suppose it boils down to reverting 
e767deba89c8cabb26c2706e1d4f0b6475fd1070.

?

[1] 
https://salsa.debian.org/ruby-team/vagrant-libvirt/-/commit/e767deba89c8cabb26c2706e1d4f0b6475fd1070
[2] 
https://github.com/vagrant-libvirt/vagrant-libvirt/commit/2ca5603ad2e4e7cd90951d2064226de7eec1214b

Cheers!

diff --git a/vagrant-libvirt.gemspec b/vagrant-libvirt.gemspec
index df906d6..6451956 100644
--- a/vagrant-libvirt.gemspec
+++ b/vagrant-libvirt.gemspec
@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.summary   = %q{libvirt provider for Vagrant.}
   s.homepage  = 'https://github.com/vagrant-libvirt/vagrant-libvirt'
 
-  s.files = Dir.glob("{lib,locales}/**/*.*") + %w(LICENSE README.md)
+  s.files = Dir.glob("{lib,locales,tools}/**/*.*") + %w(LICENSE README.md)
   s.executables   = Dir.glob("bin/*.*").map{ |f| File.basename(f) }
   s.test_files= Dir.glob("{test,spec,features}/**/*.*")
   s.name  = 'vagrant-libvirt'