Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
Em 24/08/2020 04:14, Adam Borowski escreveu:
> On Sun, Aug 23, 2020 at 04:00:07PM -0300, Fabio Augusto De Muzio Tobich wrote:
>> Em 23/08/2020 10:19, Adam Borowski escreveu:
>>> On Fri, Aug 21, 2020 at 02:48:16PM -0300, Fabio Augusto De Muzio Tobich
>>> wrote:
Em 21/08/2020 05:54, Adam Borowski escreveu:
> On Mon, Aug 17, 2020 at 09:12:51PM -0300, Fabio Augusto De Muzio Tobich
> wrote:
>> * Package name: eqonomize
>> Version : 1.5.0-1
>>>
> Hi, it fails autopkgtest:
>
>> Got the fail with sbuild + schroot and I believe your bet is correct.
>> I've modified the test to fix this and get it running right, no matter
>> the tool, and I believe it's good now.
>
> It does pass now, but...
>
> .--[ debian/tests/openfile ]
> export XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp
> cp debian/examples/housekeeping_book.eqz $AUTOPKGTEST_TMP
> xvfb-run -a eqonomize $AUTOPKGTEST_TMP/housekeeping_book.eqz &
> EQOPID=`ps ax | grep -e 'eqonomize.*housekeeping_book.eqz' | grep -v grep |
> awk '{print
>
> if [ -z $EQOPID ]; then
> exit 1
> else
> kill -9 $EQOPID
> fi
>
> exit 0
> `
>
> It's racey: will fail if "ps" runs before xvfb-run progresses past the point
> of spawning the child process.
>
> And then, what is this test even supposed to check? The only thing is does
> is checking that eqonomize doesn't exit immediately -- which, for a GUI
> program with a ton of library dependencies, probably means it won't even
> enter main() by the time "ps" does its thing, still being in the process of
> loading libraries.
>
> So this test is pointless even if it passes, and I'd recommend either:
> * adding a few seconds of sleep between xvfb-run and ps (so it at least has
> a chance to pop up a window / crash), or
> * dropping this test altogether
>
The intention of the test was to avoid what was happening when I first came
across
this package, when I tried to use it and it's crashed everytime before even
open the
main window.
But I understand your point and I need to come up with a better way to test
this, so,
for now, I accepted your recommendation and dropped this last test. Thanks a
lot for
your help on this.
Mentors[1] and salsa[2] updated.
[1]
https://mentors.debian.net/debian/pool/main/e/eqonomize/eqonomize_1.5.0-1.dsc
[2] https://salsa.debian.org/debian/eqonomize
Cheers!
Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
On Sun, Aug 23, 2020 at 04:00:07PM -0300, Fabio Augusto De Muzio Tobich wrote:
> Em 23/08/2020 10:19, Adam Borowski escreveu:
> > On Fri, Aug 21, 2020 at 02:48:16PM -0300, Fabio Augusto De Muzio Tobich
> > wrote:
> >> Em 21/08/2020 05:54, Adam Borowski escreveu:
> >>> On Mon, Aug 17, 2020 at 09:12:51PM -0300, Fabio Augusto De Muzio Tobich
> >>> wrote:
> * Package name: eqonomize
> Version : 1.5.0-1
> >
> >>> Hi, it fails autopkgtest:
> Got the fail with sbuild + schroot and I believe your bet is correct.
> I've modified the test to fix this and get it running right, no matter
> the tool, and I believe it's good now.
It does pass now, but...
.--[ debian/tests/openfile ]
export XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp
cp debian/examples/housekeeping_book.eqz $AUTOPKGTEST_TMP
xvfb-run -a eqonomize $AUTOPKGTEST_TMP/housekeeping_book.eqz &
EQOPID=`ps ax | grep -e 'eqonomize.*housekeeping_book.eqz' | grep -v grep | awk
'{print
if [ -z $EQOPID ]; then
exit 1
else
kill -9 $EQOPID
fi
exit 0
`
It's racey: will fail if "ps" runs before xvfb-run progresses past the point
of spawning the child process.
And then, what is this test even supposed to check? The only thing is does
is checking that eqonomize doesn't exit immediately -- which, for a GUI
program with a ton of library dependencies, probably means it won't even
enter main() by the time "ps" does its thing, still being in the process of
loading libraries.
So this test is pointless even if it passes, and I'd recommend either:
* adding a few seconds of sleep between xvfb-run and ps (so it at least has
a chance to pop up a window / crash), or
* dropping this test altogether
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ It's time to migrate your Imaginary Protocol from version 4i to 6i.
⠈⠳⣄
Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
Em 23/08/2020 10:19, Adam Borowski escreveu: > On Fri, Aug 21, 2020 at 02:48:16PM -0300, Fabio Augusto De Muzio Tobich wrote: >> Em 21/08/2020 05:54, Adam Borowski escreveu: >>> On Mon, Aug 17, 2020 at 09:12:51PM -0300, Fabio Augusto De Muzio Tobich >>> wrote: * Package name: eqonomize Version : 1.5.0-1 > >>> Hi, it fails autopkgtest: >>> >>> autopkgtest [10:48:32]: test command3: export >>> XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & >>> autopkgtest [10:48:32]: test command3: [--- >>> "Couldn't open file for writing" >>> autopkgtest [10:48:32]: test command3: ---] >>> autopkgtest [10:48:32]: test command3: - - - - - - - - - - results - - - - >>> - - - - - - >>> command3 FAIL stderr: "Couldn't open file for writing" >>> autopkgtest [10:48:32]: test command3: - - - - - - - - - - stderr - - - - >>> - - - - - - >>> "Couldn't open file for writing" >> Hello, >> >> Thanks for the feedback. >> I'm trying to reproduce the error but I'm not succeding. >> I built the package in several clean environments (chroot, docker...) and >> autopkgtest ran successfully every time. > > I'm running on sbuild, which is the build tool used for official packages > (thus, even if some other tool is better, it's sbuild which matters the > most). For autopkgtest, that's schroot invoked from within sbuild. > > The fail reproduces for me on multiple machines; on the big one out of > 26 attempts 24 failed 2 passed -- but even those passed ones had > "Couldn't open file for writing" -- just apparently too late to cause > failure. > > I have no experience using xvfb-run, but my bet is on invoking the run > in the background, and not even waiting for it to complete: > Got the fail with sbuild + schroot and I believe your bet is correct. I've modified the test to fix this and get it running right, no matter the tool, and I believe it's good now. >> autopkgtest [17:46:50]: test command3: preparing testbed >> autopkgtest [17:46:50]: test command3: export >> XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & >> autopkgtest [17:46:50]: test command3: [--- >> autopkgtest [17:46:50]: test command3: ---] >> autopkgtest [17:46:51]: test command3: - - - - - - - - - - results - - - - >> - - - - - - >> command3 PASS > >> Can you give me some details on how you set up your environment so I can try >> to reproduce it here? > > sbuild + schroot > I re-uploaded the package on mentors[1] and updated on salsa[2]. Can you please test it again, when you have a spare time, to confirm it's working now? [1] https://mentors.debian.net/debian/pool/main/e/eqonomize/eqonomize_1.5.0-1.dsc [2] https://salsa.debian.org/debian/eqonomize > > Meow! > Cheers!
Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
On Fri, Aug 21, 2020 at 02:48:16PM -0300, Fabio Augusto De Muzio Tobich wrote: > Em 21/08/2020 05:54, Adam Borowski escreveu: > > On Mon, Aug 17, 2020 at 09:12:51PM -0300, Fabio Augusto De Muzio Tobich > > wrote: > > > * Package name: eqonomize > > > Version : 1.5.0-1 > > Hi, it fails autopkgtest: > > > > autopkgtest [10:48:32]: test command3: export > > XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & > > autopkgtest [10:48:32]: test command3: [--- > > "Couldn't open file for writing" > > autopkgtest [10:48:32]: test command3: ---] > > autopkgtest [10:48:32]: test command3: - - - - - - - - - - results - - - - > > - - - - - - > > command3 FAIL stderr: "Couldn't open file for writing" > > autopkgtest [10:48:32]: test command3: - - - - - - - - - - stderr - - - - > > - - - - - - > > "Couldn't open file for writing" > Hello, > > Thanks for the feedback. > I'm trying to reproduce the error but I'm not succeding. > I built the package in several clean environments (chroot, docker...) and > autopkgtest ran successfully every time. I'm running on sbuild, which is the build tool used for official packages (thus, even if some other tool is better, it's sbuild which matters the most). For autopkgtest, that's schroot invoked from within sbuild. The fail reproduces for me on multiple machines; on the big one out of 26 attempts 24 failed 2 passed -- but even those passed ones had "Couldn't open file for writing" -- just apparently too late to cause failure. I have no experience using xvfb-run, but my bet is on invoking the run in the background, and not even waiting for it to complete: > autopkgtest [17:46:50]: test command3: preparing testbed > autopkgtest [17:46:50]: test command3: export > XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & > autopkgtest [17:46:50]: test command3: [--- > autopkgtest [17:46:50]: test command3: ---] > autopkgtest [17:46:51]: test command3: - - - - - - - - - - results - - - - > - - - - - - > command3 PASS > Can you give me some details on how you set up your environment so I can try > to reproduce it here? sbuild + schroot Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ It's time to migrate your Imaginary Protocol from version 4i to 6i. ⠈⠳⣄
Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
Em 21/08/2020 05:54, Adam Borowski escreveu: On Mon, Aug 17, 2020 at 09:12:51PM -0300, Fabio Augusto De Muzio Tobich wrote: * Package name: eqonomize Version : 1.5.0-1 eqonomize (1.5.0-1) unstable; urgency=medium . * New upstream release. * debian/control: rearranged Build-Depends field. * debian/copyright: - Removed BSD-3-Clause license text. - Removed create-man.sh block. * debian/eqonomize-doc.install: rearranged. * debian/eqonomize.manpages: updated manpage path. * debian/manpages/: removed, upstream provide a manpage now. * debian/patches/: - 020-add-desktop-entry-keywords.patch: removed, incorporated upstream. - 030-enable-pt-br-translation.patch: removed, incorporated upstream. - 040-update-pt-br-translation.patch: removed, incorporated upstream. * debian/source/lintian-overrides: removed, not needed anymore. Hi, it fails autopkgtest: autopkgtest [10:48:32]: test command3: export XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & autopkgtest [10:48:32]: test command3: [--- "Couldn't open file for writing" autopkgtest [10:48:32]: test command3: ---] autopkgtest [10:48:32]: test command3: - - - - - - - - - - results - - - - - - - - - - command3 FAIL stderr: "Couldn't open file for writing" autopkgtest [10:48:32]: test command3: - - - - - - - - - - stderr - - - - - - - - - - "Couldn't open file for writing" Hello, Thanks for the feedback. I'm trying to reproduce the error but I'm not succeding. I built the package in several clean environments (chroot, docker...) and autopkgtest ran successfully every time. autopkgtest [17:46:50]: test command3: preparing testbed autopkgtest [17:46:50]: test command3: export XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & autopkgtest [17:46:50]: test command3: [--- autopkgtest [17:46:50]: test command3: ---] autopkgtest [17:46:51]: test command3: - - - - - - - - - - results - - - - - - - - - - command3 PASS The autopkgtest on salsa[1] also runs successfully. Can you give me some details on how you set up your environment so I can try to reproduce it here? [1] https://salsa.debian.org/debian/eqonomize/-/jobs/947551 Cheers, Fabio Tobich Meow!
Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
On Mon, Aug 17, 2020 at 09:12:51PM -0300, Fabio Augusto De Muzio Tobich wrote: > * Package name: eqonomize >Version : 1.5.0-1 > eqonomize (1.5.0-1) unstable; urgency=medium > . >* New upstream release. >* debian/control: rearranged Build-Depends field. >* debian/copyright: >- Removed BSD-3-Clause license text. >- Removed create-man.sh block. >* debian/eqonomize-doc.install: rearranged. >* debian/eqonomize.manpages: updated manpage path. >* debian/manpages/: removed, upstream provide a manpage now. >* debian/patches/: >- 020-add-desktop-entry-keywords.patch: removed, incorporated upstream. >- 030-enable-pt-br-translation.patch: removed, incorporated upstream. >- 040-update-pt-br-translation.patch: removed, incorporated upstream. >* debian/source/lintian-overrides: removed, not needed anymore. Hi, it fails autopkgtest: autopkgtest [10:48:32]: test command3: export XDG_RUNTIME_DIR=$AUTOPKGTEST_TMP/tmp && xvfb-run -a eqonomize & autopkgtest [10:48:32]: test command3: [--- "Couldn't open file for writing" autopkgtest [10:48:32]: test command3: ---] autopkgtest [10:48:32]: test command3: - - - - - - - - - - results - - - - - - - - - - command3 FAIL stderr: "Couldn't open file for writing" autopkgtest [10:48:32]: test command3: - - - - - - - - - - stderr - - - - - - - - - - "Couldn't open file for writing" Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ It's time to migrate your Imaginary Protocol from version 4i to 6i. ⠈⠳⣄
Bug#968582: RFS: eqonomize/1.5.0-1 -- personal accounting software for the small household economy
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "eqonomize": * Package name: eqonomize Version : 1.5.0-1 Upstream Author : Hanna Knutsson * URL : https://eqonomize.github.io/ * License : GPL-3+, MIT, GFDL-1.2+ * Vcs : https://salsa.debian.org/debian/eqonomize Section : kde It builds those binary packages: eqonomize-doc - documentation for the Eqonomize! accounting software eqonomize - personal accounting software for the small household economy To access further information about this package, please visit the following URL: https://mentors.debian.net/package/eqonomize/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/e/eqonomize/eqonomize_1.5.0-1.dsc Changes since the last upload: eqonomize (1.5.0-1) unstable; urgency=medium . * New upstream release. * debian/control: rearranged Build-Depends field. * debian/copyright: - Removed BSD-3-Clause license text. - Removed create-man.sh block. * debian/eqonomize-doc.install: rearranged. * debian/eqonomize.manpages: updated manpage path. * debian/manpages/: removed, upstream provide a manpage now. * debian/patches/: - 020-add-desktop-entry-keywords.patch: removed, incorporated upstream. - 030-enable-pt-br-translation.patch: removed, incorporated upstream. - 040-update-pt-br-translation.patch: removed, incorporated upstream. * debian/source/lintian-overrides: removed, not needed anymore. Regards, -- ⢀⣴⠾⠻⢶⣦⠀ Fabio A. De Muzio Tobich ⣾⠁⢰⠒⠀⣿⡁ 9730 4066 E5AE FAC2 2683 ⢿⡄⠘⠷⠚⠋⠀ D03D 4FB3 B4D3 7EF6 3B2E ⠈⠳⣄ GPG:rsa4096/7EF63B2E
