Bug#973570: fzf: keybinding files should be installed under /etc
Hi,
On Fri, Jun 18, 2021 at 02:30:03PM +1000, Jai Flack wrote:
On Sun, 21 Feb 2021 17:11:28 +0100 Jonas Smedegaard wrote:
Debian Policy §12.6 says that /usr/share/doc/*/examples/ is "for the
benefit of the system administrator and users as documentation only."
Notice the final part of "documentation only".
That is a good point; as they are intended for use I'll move them out of
doc/. This is also good opportinity to install the bash completions by
default and maybe the Vim plugin if it's not too intrusive.
It's worth noting that completion of command-line arguments of fzf
itself is only a secondary purpose of
/usr/share/bash-completion/completions/fzf, the primary purpose being
augmenting completion of other commands to use fzf, as described here:
https://github.com/junegunn/fzf#fuzzy-completion-for-bash-and-zsh
This primary purpose, however, isn't active via the bash-completion
autoloading. As things currently stand, it only becomes active after one
types fzf a presses Tab, which is probably not a good experience. So I
believe the note in /usr/share/doc/fzf/README.Debian about the
completion being installed by default is incorrect, and should be
reverted and the path corrected to
/usr/share/bash-completion/completions/fzf (rather than
/usr/share/doc/fzf/examples/completion.bash, which is still in
README.Debian).
Alternatively, the file can be installed into /etc/bash_completion.d,
which is the compat (no autoload) dir for old-style bash-completion
modules, so it will indeed get loaded unconditionally. I'd personally
prefer the former solution, though.
--
Tomáš "liskin" ("Pivník") Janoušek, https://lisk.in/
Bug#973570: fzf: keybinding files should be installed under /etc
On Sun, 21 Feb 2021 17:11:28 +0100 Jonas Smedegaard wrote: > Debian Policy §12.6 says that /usr/share/doc/*/examples/ is "for the > benefit of the system administrator and users as documentation only." > > Notice the final part of "documentation only". That is a good point; as they are intended for use I'll move them out of doc/. This is also good opportinity to install the bash completions by default and maybe the Vim plugin if it's not too intrusive. -- Thanks, Jai
Bug#973570: fzf: keybinding files should be installed under /etc
Package: fzf Version: 0.24.3-1+b1 Followup-For: Bug #973570 -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Debian Policy §12.6 says that /usr/share/doc/*/examples/ is "for the benefit of the system administrator and users as documentation only." Notice the final part of "documentation only". As I also commented today at the fine blog entry at https://linuxnatives.net/2021/save-time-command-line-fuzzy-finder users should not rely on files at that location for code execution. - Jonas -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAmAyhi0ACgkQLHwxRsGg ASEIHBAAkaaPfE/gJkNVPHZ2ucrjiWlNMHgk8KKfwhh03VBSpxs4pwDJPdxb4DsQ cNL02F+FvvtYUDftydBzWs6reUzciOz8QMBTSrdWYvGYs0wJgGsUyOfeA9p22b3l YGn9a57a4OJwMDb9mTyPONWBHz/9X2bRnVXUVqeoD0TtLL96VfIlCskTs4+oWx8F WyqjVBKVKbHjXBPs70m/X+jAGSNoJEZY8a8/FCGW8h6diONeuy3L4iOSR+1Cdxjp wEJQyYIZoS4QxSFaIptFEb8b2/YT+Kl5F9HeGTbo18y/gLi9m8WfHCrNp09IJML5 Nbylq057XJ54dF//6NjJ+OJqUrVM8fHYkF0pk9K7f+eth2iNJR2i6t5VbHSo6+tb 8qcZshNoTwRiycJ2PjJ7G+RBb0n8BcevESDrbYDEtqWNGoNFgLjQREnDqPLe2Y/R YXOyTldCb6IG7nnIKs2SY0p+iE1OSUhxlGi8L5fW5VtnB08I14O/kHDS7rx82nFk Kxz8e4asmHrtYhuWj8FLjCsJ5z5oC+mDD1HqigIo/OXI4zIa0TYY804uCfqgwwl3 blopD+ET8bs+y7X6rdTnK4BKK+U/hP6u/0J2RM672WDHjeG4cqWEnhRKWiz/MtPI h5cmw7jyZQ9YvXSWn8VGO/wbVyJLE0N1SGZwpgNuDtbQZls2pj0= =vh0w -END PGP SIGNATURE-
Bug#973570: fzf: keybinding files should be installed under /etc
On Sun, 01 Nov 2020 23:56:28 + yacoob wrote: > Right now the example keybindings for different shells > (/usr/share/doc/fzf/examples/key-bindings.*) are placed under > /usr/share/doc. This is all fine and good, except for cases where you're using > a slimed down file (eg. debian-slim image from docker) which doesn't have > /usr/share/doc. Please consider placing those keybindings somewhere under > /etc. /usr/share/doc is the standard location for these in Debian. What would be the use-case for having these in a docker (or other) image designed to not include unnecessary files? -- Thanks, Jai
Bug#973570: fzf: keybinding files should be installed under /etc
Package: fzf Version: 0.17.5-2+b10 Severity: normal Right now the example keybindings for different shells (/usr/share/doc/fzf/examples/key-bindings.*) are placed under /usr/share/doc. This is all fine and good, except for cases where you're using a slimed down file (eg. debian-slim image from docker) which doesn't have /usr/share/doc. Please consider placing those keybindings somewhere under /etc. -- System Information: Debian Release: 10.6 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.104-microsoft-standard (SMP w/12 CPU cores) Locale: LANG=en_IE.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8), LANGUAGE=en_IE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: unable to detect Versions of packages fzf depends on: ii libc6 2.28-10 fzf recommends no packages. fzf suggests no packages. -- no debconf information
