Bug#998231:
A git bisect seems to suggest that https://github.com/go-ping/ping/commit/30a8f08ad2a9d0b88ca9c1978114d253f63748c3 is the commit which resulted in the regression in go-ping. Sadly that made it into the package that shipped with bullseye. I can update the go-ping package to a newer version that resolves this bug, and bump a new build of smokeping_prober. Perhaps somebody with more free time can backport it to bullseye.
Bug#998231:
I tested some upstream tags, i.e. "go run ..." to build with the exact module versions specified by their go.mod: v0.3.1 - OK v0.4.0 - counters latch at 65536 v0.4.1 - counters latch at 65534 v0.4.2 - OK master (as of writing) - OK Between v0.4.1 and v0.4.2, the go-ping version specified by go.mod changed from v0.0.0-20210201192233-b6486c6f1f2d to v0.0.0-20210417180633-a50937ef0888. Theoretically, an updated golang-github-go-ping-ping package, built from v0.0.0-20210417180633-a50937ef0888 or later, should resolve this bug. The go-ping commit responsible for fixing this bug is https://github.com/go-ping/ping/commit/38182647687148eb7c963dc57dc62456b12aa0ae, which was committed a little while after the currently packaged 0.0~git20210312.d90f377-1 version.
Bug#998231:
Unable to reproduce with an earlier, in-house build of smokeping_prober
0.3.1 (prior to first debian upload):
# HELP smokeping_response_duration_seconds A histogram of latencies for
ping responses.
# TYPE smokeping_response_duration_seconds histogram
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="5e-05"}
474
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0001"}
67789
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0002"}
72798
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0004"}
72861
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0008"}
72917
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0016"}
72938
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0032"}
72949
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0064"}
72966
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0128"}
72973
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0256"}
72978
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0512"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.1024"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.2048"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.4096"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.8192"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="1.6384"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="3.2768"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="6.5536"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="13.1072"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="26.2144"}
72979
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="+Inf"}
72979
smokeping_response_duration_seconds_sum{host="127.0.0.1",ip="127.0.0.1"}
6.126716514000115
smokeping_response_duration_seconds_count{host="127.0.0.1",ip="127.0.0.1"}
72979
According to the go.mod for smokeping_prober v0.3.1, it was presumably
built with github.com/sparrc/go-ping v0.0.0-20190613174326-4e5b6552494c
(which predates the go-ping project moving to a new organization in github).
So despite the fact that the currently open github issues suggest that the
bug is not yet resolved upstream, it is also beginning to smell like a
regression in go-ping, somewhere between v0.0.0-20190613174326-4e5b6552494c
and v0.0.0-20210312.d90f377.
Bug#998231:
Reproduced with prometheus-smokeping-prober 0.4.2-2, built with go-ping
0.0~git20210312.d90f377-1.
# HELP smokeping_response_duration_seconds A histogram of latencies for
ping responses.
# TYPE smokeping_response_duration_seconds histogram
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="5e-05"}
49514
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0001"}
65308
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0002"}
65498
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0004"}
65507
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0008"}
65530
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0016"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0032"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0064"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0128"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0256"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.0512"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.1024"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.2048"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.4096"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="0.8192"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="1.6384"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="3.2768"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="6.5536"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="13.1072"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="26.2144"}
65535
smokeping_response_duration_seconds_bucket{host="127.0.0.1",ip="127.0.0.1",le="+Inf"}
65535
smokeping_response_duration_seconds_sum{host="127.0.0.1",ip="127.0.0.1"}
3.102824054205
smokeping_response_duration_seconds_count{host="127.0.0.1",ip="127.0.0.1"}
65535
Bug#998231:
Hello Tim, I have just uploaded prometheus-smokeping-prober 0.4.2-1, however I have not marked this bug as solved, since the only difference between 0.4.1 and 0.4.2 is that the upstream developer bumped the go-ping build dependency git snapshot in go.mod to a slightly later version. As far as I can tell, the real bug (which is actually in go-ping) has not had a fix merged yet: see https://github.com/go-ping/ping/issues/142 I have older packaged versions of prometheus-smokeping-prober (0.3.0, 0.3.1) which were definitely built with much older versions of go-ping, yet they have bucket counts that are over 200K, so this is a little bit bewildering. Note that the Debian go-ping build-dep has been updated since the previous prometheus-smokeping-prober 0.4.1 package was built, however it is still not as new as the git snapshot referred to in smokeping_prober's go.mod Perhaps you could take the new 0.4.2-1 package for a test drive. Daniel Swarbrick
