Bug#318719: Patch - plays with sound now
Le vendredi 16 juin 2006 à 10:45 +0200, Sam Hocevar a écrit : This patch was in tecnoballz 0.91cvs20060501-1.3 but for some reason it disappeared from 0.91cvs20060612-1. This is my fault, I'm going to commit that patch upstream and then repackage tecnoballz with the reuslting new CVS snapshot. Thanks for the help. Regards, -- Alexis Sukrieh
Bug#318719: Patch - plays with sound now
On Thu, Jun 15, 2006, Alexis Sukrieh wrote:
Thanks a lot for the patch, I'm going to test it on a 32bit arch very
soon.
I do not like this patch because it assumes that long has the same
size as void *, which is true in practice but not guaranteed. A more
correct patch did this:
union { int i; void *p; } dummy;
memcpy(ptModAmiga, (Uint8 *)pMixmodule + sizeof(dummy), sizeof(void *));
It is not absolutely necessary to have the union, but it guarantees
that the code with also work on platforms where ints are bigger than
pointers (though I don't know any modern platform that does that).
This patch was in tecnoballz 0.91cvs20060501-1.3 but for some reason
it disappeared from 0.91cvs20060612-1.
--
Sam.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#318719: Patch - plays with sound now
tags 318719 + pending thanks Hi, I've just applied Sam's last patch (provided in debian package version 0.91cvs20060501-1.3) in the upstream CVS repository. I've packaged the resulting export as version 0.91cvs20060616-1. This bug will then be closed as soon as that package is uploaded to the Debian archive. I guess that now, for real, tecnoballz does run on AMD 64 archs ;-) Thanks for anyone who gave a hand for closing that issue. Best regards, -- Alexis Sukrieh -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Re: Bug#318719: Patch - plays with sound now
Processing commands for [EMAIL PROTECTED]: tags 318719 + pending Bug#318719: tecnoballz: Segfaults on startup on 64-bit machines Tags were: patch Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#318719: Patch - plays with sound now
On Fri, Jun 16, 2006 at 10:45:30AM +0200, Sam Hocevar wrote: On Thu, Jun 15, 2006, Alexis Sukrieh wrote: Thanks a lot for the patch, I'm going to test it on a 32bit arch very soon. I do not like this patch because it assumes that long has the same size as void *, which is true in practice but not guaranteed. A more correct patch did this: Yes, I never claimed the patch to be perfect, my intend was to help finding the problematic point (I am not really a fluent C programmer). And given that it worked afterwards, I was happy :-)) This patch was in tecnoballz 0.91cvs20060501-1.3 but for some reason it disappeared from 0.91cvs20060612-1. Ok, I did not try intermediate versions, sorry. Greetings Helge -- Dr. Helge Kreutzmann [EMAIL PROTECTED] Dipl.-Phys. http://www.helgefjell.de/debian.php 64bit GNU powered gpg signed mail preferred Help keep free software libre: http://www.ffii.de/ signature.asc Description: Digital signature
Bug#318719: Patch - plays with sound now
tags 318719 + patch
thanks robot
Looking at the sources and poking around a little. I can always
briefly here the sound, and then the crash (backtrace above) and the
bug is the same (no two bugs as outlined above), i.e., it crashes at
the same spot, same reason all the time. It works, if you apply the
attached patch (I played the first two levels with sound with no
previous config file in my home dirctory, i.e. it was created
automatically with sound). I derived the patch by finding this ugly
hack and knowing that assumptions about sizeof(int) are often
problems on 64bit architectures. So I don't know if this patch
actually is the right way to fix this; please check on a 32bit
architecture.
If you want me to test a better patch please tell me.
Greetings
Helge
--
Dr. Helge Kreutzmann [EMAIL PROTECTED]
Dipl.-Phys. http://www.helgefjell.de/debian.php
64bit GNU powered gpg signed mail preferred
Help keep free software libre: http://www.ffii.de/
--- audiomixer.cc.orig 2006-06-12 15:18:08.0 +0200
+++ audiomixer.cc 2006-06-15 18:19:25.309002840 +0200
@@ -350,7 +350,8 @@
return (erreur_num = E_SDLMIXER);
}
// Ugly way to access sdl-mixer's internal structures.
- memcpy(ptModAmiga, (Uint8 *)pMixmodule + sizeof(int), sizeof(void *));
+ // memcpy(ptModAmiga, (Uint8 *)pMixmodule + sizeof(int), sizeof(void
*));
+ memcpy(ptModAmiga, (Uint8 *)pMixmodule + sizeof(long), sizeof(void *));
//###
@@ -459,7 +460,7 @@
void audiomixer::mus_handle()
{
if (!ptModAmiga) return;
-
+
if(lastsngpos != ptModAmiga-sngpos)
lastsngpos = ptModAmiga-sngpos;
signature.asc
Description: Digital signature
Bug#318719: Patch - plays with sound now
Le jeudi 15 juin 2006 à 18:32 +0200, Helge Kreutzmann a écrit : tags 318719 + patch thanks robot Looking at the sources and poking around a little. I can always briefly here the sound, and then the crash (backtrace above) and the bug is the same (no two bugs as outlined above), i.e., it crashes at the same spot, same reason all the time. It works, if you apply the attached patch (I played the first two levels with sound with no previous config file in my home dirctory, i.e. it was created automatically with sound). I derived the patch by finding this ugly hack and knowing that assumptions about sizeof(int) are often problems on 64bit architectures. So I don't know if this patch actually is the right way to fix this; please check on a 32bit architecture. Thanks a lot for the patch, I'm going to test it on a 32bit arch very soon. Regards, -- Alexis Sukrieh
