Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
On 04/25/2011 02:35 AM, David Claughton wrote: On 24/04/11 23:45, Mehdi Dogguy wrote: On 04/25/2011 12:17 AM, David Claughton wrote: OK, I've applied the patch to the git repo - looks good. Thanks again to you both. Thanks. However, you might want to revert the other patch that turned pyversions -s into pyversions -r. The former allows us to update the package by a simple binNMU while the latter forces source changes in the source package. Regards, Hmm, I'm not sure I agree. As we have just seen, graphviz requires source changes anyway to support a new python version. Surely all pyversions -s does in this situation is guarantee that the binNMU will fail, just as it did this time? I left pyversions -r in as it seemed the better approach in this case. It should mean that transitions are smoother - an OCAML transition shouldn't come to a grinding halt because a new python version has been uploaded to the archive! It's up to you, anyway. Now, graphviz is the last package missing to complete the OCaml transition. Could you please upload the package? I can also make the upload if you provide me a .dsc. (or I can NMU, but I'd prefer to upload your .dsc since it's already fixed in Git). Cheers, -- Mehdi Dogguy مهدي الدڤي http://dogguy.org/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
On 23/04/11 23:32, David Claughton wrote: On 22/04/11 21:10, Mehdi Dogguy wrote: I've been able to build the package using Barry's patch, and successfully tested the python binary package produced. So, ok upstream's Graphviz doesn't have Python 2.7 support… but you can hack configure.ac a bit to get that working. Attached is a debdiff between sid's version and mine (well, with Barry's patch). Please consider applying it. Thanks, I'll take a look at it. OK, I've applied the patch to the git repo - looks good. Thanks again to you both. Christoph, please can you pull the new commit and include it in the release. Cheers, David. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
On 04/25/2011 12:17 AM, David Claughton wrote: OK, I've applied the patch to the git repo - looks good. Thanks again to you both. Thanks. However, you might want to revert the other patch that turned pyversions -s into pyversions -r. The former allows us to update the package by a simple binNMU while the latter forces source changes in the source package. Regards, -- Mehdi Dogguy مهدي الدڤي http://dogguy.org/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
On 24/04/11 23:45, Mehdi Dogguy wrote: On 04/25/2011 12:17 AM, David Claughton wrote: OK, I've applied the patch to the git repo - looks good. Thanks again to you both. Thanks. However, you might want to revert the other patch that turned pyversions -s into pyversions -r. The former allows us to update the package by a simple binNMU while the latter forces source changes in the source package. Regards, Hmm, I'm not sure I agree. As we have just seen, graphviz requires source changes anyway to support a new python version. Surely all pyversions -s does in this situation is guarantee that the binNMU will fail, just as it did this time? I left pyversions -r in as it seemed the better approach in this case. It should mean that transitions are smoother - an OCAML transition shouldn't come to a grinding halt because a new python version has been uploaded to the archive! Cheers, David. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
On 22/04/11 21:10, Mehdi Dogguy wrote: I'm sorry but 65883762c382d200cc5001433d060474045c7e30 looks wrong. If python 2.7 is set as default python interpreter, libgv-python will be useless, unless you install python2.6. I realise that this will probably happen at some point, but I didn't think this was going to be soon? I went with the quickest option to fix the FTBFS, so I wasn't holding up the transition, with a view that I could revisit the issue later if the new upstream release doesn't turn up soonish (which will support 2.7). Backporting python 2.7 support seemed over the top for a release that might only last a few days, however that was before ... Barry Warsaw kindly proposed a patch [1] in this bugreport, which was applied in Ubuntu. Did you test it? Did you have a look at it? ... Barry posted this. Since Barry's been kind enough to do all the hard work for me (thanks Barry!), that obviously changes things. I've been able to build the package using Barry's patch, and successfully tested the python binary package produced. So, ok upstream's Graphviz doesn't have Python 2.7 support… but you can hack configure.ac a bit to get that working. Attached is a debdiff between sid's version and mine (well, with Barry's patch). Please consider applying it. Thanks, I'll take a look at it. Cheers, David. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
Processing commands for cont...@bugs.debian.org: tags 623165 + patch Bug #623165 [src:graphviz] src:graphviz: FTBFS with Python 2.7 enabled Added tag(s) patch. thanks Stopping processing here. Please contact me if you need assistance. -- 623165: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=623165 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#623165: Updated graphviz to fix FTBFS caused by python 2.7
Hi Christoph, Hope you're having a happy Easter (you too Seb). I've just pushed some changes to the git repo to fix the recent FTBFS which was caused by the introduction of python 2.7 to the archive. I've thrown in a couple of other things including a patch for Hurd which was submitted - just so you know I have no way to test this so I'm just taking a flyer on it. Could you please take a look and (assuming it looks OK) upload it for me? Cheers, David. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
