Bug#688713: timidity-daemon: mishandles conffiles
On Thu, 11 Oct 2012, Sébastien Villemot wrote: Thanks for your reply. I have rescheduled the upload to DELAYED/5, so that you can make an upload of your own this weekend. I failed to do this because I got stuck figuring out what was up with the large number of Ubuntu bugs. I think we have more bugs in the maintainer scripts (many of them are undiagnosable because we ignore the return value from adduser)... I'll hopefully get time to do an upload soon, but in the meantime, thanks for the NMU, and Guo, thanks for the patch. -- Geoffrey Thomas http://ldpreload.com geo...@ldpreload.com
Bug#688713: timidity-daemon: mishandles conffiles
Guo Yixuan culu@gmail.com writes: On 10/12/2012 02:36 AM, Sébastien Villemot wrote: Guo: Thanks for your contribution. I did not directly upload your patch for two reasons. First it was buggy since it was removing the call to invoke-rc.d timidity stop in prerm remove, and this call has to stay there. OK, it indeed needs this. However, I found that dh_installinit already provided this by default in prerm: # Automatically added by dh_installinit if [ -x /etc/init.d/timidity ] [ $1 = remove ]; then invoke-rc.d timidity stop || exit $? fi # End automatically added section You are perfectly right. Thanks for clarifying this and sorry for my incorrect claims. -- .''`.Sébastien Villemot : :' :Debian Developer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594 pgp2zlGuM2DH1.pgp Description: PGP signature
Bug#688713: timidity-daemon: mishandles conffiles
Control: tags -1 + pending Dear Maintainers, Andreas Beckmann deb...@abeckmann.de writes: Package: timidity-daemon Version: 2.13.2-40 Severity: serious User: debian...@lists.debian.org Usertags: piuparts during a test with piuparts I noticed your package mishandles conffiles. This is violates the policy, see http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files I miserably failed to understand that the maintainer scripts were to do, the only thing I can say for sure is that the conffile /etc/init.d/timidity is removed during the remove step of the package (which is wrong, because configuration must be preserved after remove, and needs to be clened up during purge only. And that will fail in the following scenario: install timidity-daemon remove (don't purge!) timidity-daemon install timidity-daemon Now /etc/init.d/timidity is missing (as dpkg will not restore deleted configuration files as that is usually a user choice the should be preserved). I have uploaded to DELAYED/2 a NMU of timidity versioned 2.13.2-40.1 which fixes that bug. The debdiff is attached. Don't hesitate to tell me if I should delay the upload longer. Guo: Thanks for your contribution. I did not directly upload your patch for two reasons. First it was buggy since it was removing the call to invoke-rc.d timidity stop in prerm remove, and this call has to stay there. Second it was making unnecessary changes related to /etc/timidity/timidity.daemon, which is no longer shipped in the package (it seems to predate squeeze); NMUs have to change the minimal amount of code in order to fix the bug. But indeed, as Andreas has noted, a lot of obsolete stuff could probably be removed from the maintainer scripts. diff -Nru timidity-2.13.2/debian/changelog timidity-2.13.2/debian/changelog --- timidity-2.13.2/debian/changelog 2011-11-21 17:14:10.0 +0100 +++ timidity-2.13.2/debian/changelog 2012-10-11 20:11:33.0 +0200 @@ -1,3 +1,11 @@ +timidity (2.13.2-40.1) unstable; urgency=low + + * Non-maintainer upload. + * No longer remove /etc/init.d/timidity in timidity-daemon's prerm remove. +Thanks to Guo Yixuan for digging into this issue. (Closes: #688713) + + -- Sébastien Villemot sebast...@debian.org Thu, 11 Oct 2012 20:08:58 +0200 + timidity (2.13.2-40) unstable; urgency=low * New maintainer (Closes: #585039). diff -Nru timidity-2.13.2/debian/timidity-daemon.prerm timidity-2.13.2/debian/timidity-daemon.prerm --- timidity-2.13.2/debian/timidity-daemon.prerm 2009-09-11 12:44:23.0 +0200 +++ timidity-2.13.2/debian/timidity-daemon.prerm 2012-10-11 20:02:36.0 +0200 @@ -30,7 +30,6 @@ fi fi -rm_conffile timidity-daemon /etc/init.d/timidity rm_conffile timidity-daemon /etc/timidity/timidity.daemon ;; -- .''`.Sébastien Villemot : :' :Debian Developer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594 pgpNS5buQaa7Z.pgp Description: PGP signature
Processed: Re: Bug#688713: timidity-daemon: mishandles conffiles
Processing control commands: tags -1 + pending Bug #688713 [timidity-daemon] timidity-daemon: mishandles conffiles Added tag(s) pending. -- 688713: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688713 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#688713: timidity-daemon: mishandles conffiles
On Thu, 11 Oct 2012, Sébastien Villemot wrote: I have uploaded to DELAYED/2 a NMU of timidity versioned 2.13.2-40.1 which fixes that bug. The debdiff is attached. Don't hesitate to tell me if I should delay the upload longer. Thanks, but would you mind delaying until early next week? There are a couple of wrong patches in the current source package (see #649274), and I was hoping to ask for a single freeze exception to deal with that issue too and a couple of Ubuntu ones. I know I've been remiss about doing an upload, but if it's already past time that an NMU is reasonable, I will make a point of attempting to deal with it this weekend -- and if I don't, feel free to let the NMU proceed. -- Geoffrey Thomas http://ldpreload.com geo...@ldpreload.com
Bug#688713: timidity-daemon: mishandles conffiles
Geoffrey Thomas geo...@mit.edu writes: On Thu, 11 Oct 2012, Sébastien Villemot wrote: I have uploaded to DELAYED/2 a NMU of timidity versioned 2.13.2-40.1 which fixes that bug. The debdiff is attached. Don't hesitate to tell me if I should delay the upload longer. Thanks, but would you mind delaying until early next week? There are a couple of wrong patches in the current source package (see #649274), and I was hoping to ask for a single freeze exception to deal with that issue too and a couple of Ubuntu ones. I know I've been remiss about doing an upload, but if it's already past time that an NMU is reasonable, I will make a point of attempting to deal with it this weekend -- and if I don't, feel free to let the NMU proceed. Thanks for your reply. I have rescheduled the upload to DELAYED/5, so that you can make an upload of your own this weekend. -- .''`.Sébastien Villemot : :' :Debian Developer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594 pgpk2nmMTMRVu.pgp Description: PGP signature
Bug#688713: timidity-daemon: mishandles conffiles
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 10/12/2012 02:36 AM, Sébastien Villemot wrote: Control: tags -1 + pending Dear Maintainers, Andreas Beckmann deb...@abeckmann.de writes: Package: timidity-daemon Version: 2.13.2-40 Severity: serious User: debian...@lists.debian.org Usertags: piuparts during a test with piuparts I noticed your package mishandles conffiles. This is violates the policy, see http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files I miserably failed to understand that the maintainer scripts were to do, the only thing I can say for sure is that the conffile /etc/init.d/timidity is removed during the remove step of the package (which is wrong, because configuration must be preserved after remove, and needs to be clened up during purge only. And that will fail in the following scenario: install timidity-daemon remove (don't purge!) timidity-daemon install timidity-daemon Now /etc/init.d/timidity is missing (as dpkg will not restore deleted configuration files as that is usually a user choice the should be preserved). I have uploaded to DELAYED/2 a NMU of timidity versioned 2.13.2-40.1 which fixes that bug. The debdiff is attached. Don't hesitate to tell me if I should delay the upload longer. Thank you for uploading a NMU. Guo: Thanks for your contribution. I did not directly upload your patch for two reasons. First it was buggy since it was removing the call to invoke-rc.d timidity stop in prerm remove, and this call has to stay there. OK, it indeed needs this. However, I found that dh_installinit already provided this by default in prerm: # Automatically added by dh_installinit if [ -x /etc/init.d/timidity ] [ $1 = remove ]; then invoke-rc.d timidity stop || exit $? fi # End automatically added section Second it was making unnecessary changes related to /etc/timidity/timidity.daemon, which is no longer shipped in the package (it seems to predate squeeze); NMUs have to change the minimal amount of code in order to fix the bug. But indeed, as Andreas has noted, a lot of obsolete stuff could probably be removed from the maintainer scripts. I see that NMU prefer to be minimal. Maybe my patch will still be useful in case of a maintainer upload. Cheers, Guo Yixuan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCgAGBQJQd3upAAoJEN1xpgAgL7gzZ0sP/A6qJlvwDZuiT6VSiTuZIqZO m1eqRh3ZE1ZKP3oXElzHZqbr78YQ0inPVRl/rc5he2ev4bzXhD2oIwHTvF6JvGO2 H4rJCQ/UJBHdOSQbSD87Crm8zAdTxc+E7cM38/Ry7fj4EP1VZum9lnMOsR9adEL4 JG05mwEUQ/+F//ZKAVez+USQBvCskdAMXvobJvTJ63fnbcqvKUttni5SQcLgyqSE uXxmvwB8GPdflTwBNQGgO3Qak9zW6EClVeRf72JybOU38IEV0prMHGv/7L3WmwQQ UMbAu5YzUYdnbKBP7Cwe6j9J3xf7CYbdtxlk7+eNGICym5q4gtv2JAV3eQTtVDuo 4gsZzGT71Zn4qn46LsSlgTQHL3yux9kOVOnU3jka9kkRg8D4CNdvWC/Qt4x8YADD 3oFV0KGOaIQhYd5KbxIT4T7SAAh62S88/7wdcGLQJyVpJOjMCThhgXdaiiiUNYJ8 BLM5XjqSxDVpf0NUYz7QxDIwhnhiTQas8DFbKYxCHPSVA8vJ6e8s+6tlYZLBkXcN lhIoUnUhHEWM4V4PcEhQl5OC+5FbiL8huNMlz6sM2VBzhgn5NfvpNrqNrtNszBta S5UxPDpj77a2DlGuiUCM2MxoXHVYxKu0855WBYcOPsPfjixYmUnrmfKzeNxhz7CP MDjc7xZHS2e30rnOrlcD =p9pU -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#688713: timidity-daemon: mishandles conffiles
Package: timidity-daemon Version: 2.13.2-40 Severity: serious User: debian...@lists.debian.org Usertags: piuparts Hi, during a test with piuparts I noticed your package mishandles conffiles. This is violates the policy, see http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files I miserably failed to understand that the maintainer scripts were to do, the only thing I can say for sure is that the conffile /etc/init.d/timidity is removed during the remove step of the package (which is wrong, because configuration must be preserved after remove, and needs to be clened up during purge only. And that will fail in the following scenario: install timidity-daemon remove (don't purge!) timidity-daemon install timidity-daemon Now /etc/init.d/timidity is missing (as dpkg will not restore deleted configuration files as that is usually a user choice the should be preserved). But all the things the mainteiner scripts try to do seem to predate squeeze, so just removing the maintainer scripts might do the job properly. debsums reports modification of the following files, from the attached log (scroll to the bottom...): debsums: missing file /etc/init.d/timidity (from timidity-daemon package) cheers, Andreas timidity-daemon_2.13.2-40.log.gz Description: GNU Zip compressed data
