Bug#807351: python-debian: diff for NMU version 0.1.27+nmu1

[Stuart Prescott]

Hi Neil,

thanks for looking at python-debian for us

In discussing comment handling with the apt and python-apt maintainers, I had 
reached the conclusion that this test probably needed to be deleted entirely. 
It is testing to see if some undefined behaviour has a particular outcome as a 
canary to help guard against other bugs in comment-handling creeping back in. 
But looking at your suggested patch, given that python-apt now throws an error 
on this undefined behaviour, I think we've got a better result than checking 
for one particular mis-parse. This feels a lot safer for consumers of the API, 
so maybe it is best to test for the failure as you have done here. Thanks.

BTW There's a lot of detritus in the diff from python-
debian-0.1.27/lib/python_debian.egg-info -- I suspect that this comes from 
building it twice in a row in the same tree rather than it being build by 
sbuild or pbuilder. (This is clearly a bug in the build system; perhaps we 
should be caring more for these files anyway?)

cheers
Stuart

-- 
Stuart Prescotthttp://www.nanonanonano.net/   stu...@nanonanonano.net
Debian Developer   http://www.debian.org/ stu...@debian.org
GPG fingerprint90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7

signature.asc
Description: This is a digitally signed message part.

Bug#807351: python-debian: diff for NMU version 0.1.27+nmu1

[Neil Williams]

Control: tags 807351 + patch
Control: tags 807351 + pending

Dear maintainer,

I've prepared an NMU for python-debian (versioned as 0.1.27+nmu1) and
uploaded it to DELAYED/7. Please feel free to tell me if I
should delay it longer.

Regards.
diff -Nru python-debian-0.1.27/debian/changelog python-debian-0.1.27+nmu1/debian/changelog
--- python-debian-0.1.27/debian/changelog	2015-04-14 15:53:31.0 +0100
+++ python-debian-0.1.27+nmu1/debian/changelog	2016-02-20 14:56:01.0 +
@@ -1,3 +1,11 @@
+python-debian (0.1.27+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Updating the multiline comment test for more aggressive
+failure mode in apt_pkg. (Closes: #807351)
+
+ -- Neil Williams   Sat, 20 Feb 2016 14:55:59 +
+
 python-debian (0.1.27) unstable; urgency=medium
 
   * Tighten whitespace handling in GPG Armor Header lines, with thanks to
diff -Nru python-debian-0.1.27/lib/python_debian.egg-info/dependency_links.txt python-debian-0.1.27+nmu1/lib/python_debian.egg-info/dependency_links.txt
--- python-debian-0.1.27/lib/python_debian.egg-info/dependency_links.txt	1970-01-01 01:00:00.0 +0100
+++ python-debian-0.1.27+nmu1/lib/python_debian.egg-info/dependency_links.txt	2016-02-20 14:59:59.0 +
@@ -0,0 +1 @@
+
diff -Nru python-debian-0.1.27/lib/python_debian.egg-info/PKG-INFO python-debian-0.1.27+nmu1/lib/python_debian.egg-info/PKG-INFO
--- python-debian-0.1.27/lib/python_debian.egg-info/PKG-INFO	1970-01-01 01:00:00.0 +0100
+++ python-debian-0.1.27+nmu1/lib/python_debian.egg-info/PKG-INFO	2016-02-20 14:59:59.0 +
@@ -0,0 +1,10 @@
+Metadata-Version: 1.0
+Name: python-debian
+Version: 0.1.27
+Summary: Debian package related modules
+Home-page: http://packages.debian.org/sid/python-debian
+Author: Debian python-debian Maintainers
+Author-email: pkg-python-debian-ma...@lists.alioth.debian.org
+License: UNKNOWN
+Description: UNKNOWN
+Platform: UNKNOWN
diff -Nru python-debian-0.1.27/lib/python_debian.egg-info/requires.txt python-debian-0.1.27+nmu1/lib/python_debian.egg-info/requires.txt
--- python-debian-0.1.27/lib/python_debian.egg-info/requires.txt	1970-01-01 01:00:00.0 +0100
+++ python-debian-0.1.27+nmu1/lib/python_debian.egg-info/requires.txt	2016-02-20 14:59:59.0 +
@@ -0,0 +1 @@
+six
diff -Nru python-debian-0.1.27/lib/python_debian.egg-info/SOURCES.txt python-debian-0.1.27+nmu1/lib/python_debian.egg-info/SOURCES.txt
--- python-debian-0.1.27/lib/python_debian.egg-info/SOURCES.txt	1970-01-01 01:00:00.0 +0100
+++ python-debian-0.1.27+nmu1/lib/python_debian.egg-info/SOURCES.txt	2016-02-20 14:59:59.0 +
@@ -0,0 +1,18 @@
+README
+setup.py
+lib/deb822.py
+lib/debian/__init__.py
+lib/debian/arfile.py
+lib/debian/changelog.py
+lib/debian/copyright.py
+lib/debian/deb822.py
+lib/debian/debfile.py
+lib/debian/debian_support.py
+lib/debian/debtags.py
+lib/debian/deprecation.py
+lib/debian_bundle/__init__.py
+lib/python_debian.egg-info/PKG-INFO
+lib/python_debian.egg-info/SOURCES.txt
+lib/python_debian.egg-info/dependency_links.txt
+lib/python_debian.egg-info/requires.txt
+lib/python_debian.egg-info/top_level.txt
\ No newline at end of file
diff -Nru python-debian-0.1.27/lib/python_debian.egg-info/top_level.txt python-debian-0.1.27+nmu1/lib/python_debian.egg-info/top_level.txt
--- python-debian-0.1.27/lib/python_debian.egg-info/top_level.txt	1970-01-01 01:00:00.0 +0100
+++ python-debian-0.1.27+nmu1/lib/python_debian.egg-info/top_level.txt	2016-02-20 14:59:59.0 +
@@ -0,0 +1,3 @@
+deb822
+debian
+debian_bundle
diff -Nru python-debian-0.1.27/tests/test_deb822.py python-debian-0.1.27+nmu1/tests/test_deb822.py
--- python-debian-0.1.27/tests/test_deb822.py	2014-10-22 09:37:50.0 +0100
+++ python-debian-0.1.27+nmu1/tests/test_deb822.py	2016-02-20 15:05:20.0 +
@@ -920,7 +920,8 @@
 with open_utf8(filename) as fh:
 paragraphs = list(deb822.Deb822.iter_paragraphs(
 fh, use_apt_pkg=True))
-self.assertEqual(paragraphs[0]['Build-Depends'], 'debhelper,')
+except SystemError as exc:
+self.assertIn('E:Unable to parse package file', str(exc))
 finally:
 os.remove(filename)
 


signature.asc
Description: PGP signature