Bug#881053: ppp: fails to compile because of mistake in rules file
Package: ppp Version: 2.4.7-1+4 Severity: serious Tags: patch Justification: fails to build from source (but built successfully in the past) Dear Maintainer, the rules file contains a problem that keeps ppp from compiling. This patch fixes the problem. --- debian/rules.ORIG 2017-11-07 14:43:08.026945955 +0100 +++ debian/rules2017-11-07 14:43:20.174879455 +0100 @@ -156,7 +156,7 @@ # the build fails if there are any discrepancies in the symbols file in order # to catch ABI changes. override_dh_makeshlibs: - dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd -V + dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd --version dh_makeshlibs --no-package=ppp ## http://wiki.debian.org/onlyjob/get-orig-source -- System Information: Debian Release: 9.1 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.utf8, LC_CTYPE=de_DE@euro (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), LANGUAGE=en_GB.utf8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages ppp depends on: ii init-system-helpers 1.48 ii libc62.24-11+deb9u1 ii libpam-modules 1.1.8-3.6 ii libpam-runtime 1.1.8-3.6 ii libpam0g 1.1.8-3.6 ii libpcap0.8 1.8.1-3 ii lsb-base 9.20161125 ii procps 2:3.3.12-3 ppp recommends no packages. ppp suggests no packages. -- no debconf information --- debian/rules.ORIG 2017-11-07 14:43:08.026945955 +0100 +++ debian/rules2017-11-07 14:43:20.174879455 +0100 @@ -156,7 +156,7 @@ # the build fails if there are any discrepancies in the symbols file in order # to catch ABI changes. override_dh_makeshlibs: - dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd -V + dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd --version dh_makeshlibs --no-package=ppp ## http://wiki.debian.org/onlyjob/get-orig-source
Bug#881053: ppp: fails to compile because of mistake in rules file
On Tue, Nov 07, 2017 at 02:46:59PM +0100, Christian Blum wrote: > Package: ppp > Version: 2.4.7-1+4 > Severity: serious > Tags: patch > Justification: fails to build from source (but built successfully in the past) > > Dear Maintainer, > > the rules file contains a problem that keeps ppp from compiling. This patch > fixes the problem. > > > --- debian/rules.ORIG 2017-11-07 14:43:08.026945955 +0100 > +++ debian/rules 2017-11-07 14:43:20.174879455 +0100 > @@ -156,7 +156,7 @@ > # the build fails if there are any discrepancies in the symbols file in order > # to catch ABI changes. > override_dh_makeshlibs: > - dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd -V > + dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd --version > dh_makeshlibs --no-package=ppp >... -V looks correct, and it works everywhere else: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ppp.html What is the exact error message you get? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
Bug#881053: ppp: fails to compile because of mistake in rules file
On 07/11/17 14:48, Adrian Bunk wrote: > On Tue, Nov 07, 2017 at 02:46:59PM +0100, Christian Blum wrote: >> Package: ppp >> Version: 2.4.7-1+4 >> Severity: serious >> Tags: patch >> Justification: fails to build from source (but built successfully in the >> past) >> >> Dear Maintainer, >> >> the rules file contains a problem that keeps ppp from compiling. This patch >> fixes the problem. >> >> >> --- debian/rules.ORIG2017-11-07 14:43:08.026945955 +0100 >> +++ debian/rules 2017-11-07 14:43:20.174879455 +0100 >> @@ -156,7 +156,7 @@ >> # the build fails if there are any discrepancies in the symbols file in >> order >> # to catch ABI changes. >> override_dh_makeshlibs: >> -dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd -V >> +dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd --version >> dh_makeshlibs --no-package=ppp >> ... > > -V looks correct, and it works everywhere else: > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ppp.html > > What is the exact error message you get? Hi Christian, Adrian, The -V comes after the '--' separator and thus should be an argument to dpkg-gensymbols. Its meaning there is, according to the man page: "Enable verbose mode. The generated symbols file contains deprecated symbols as comments. Furthermore in template mode, pattern symbols are followed by comments listing real symbols that have matched the pattern." This is probably unnecessary for pppd in the general case but I don't think it should do any harm. Replacing this with --version is definitely not correct, however: that should make dpkg-gensymbols show its version number and exit without producing any output. That would cause the build to ignore changes in the symbols, which is exactly what this is there to protect against. Please let me know if this is causing unexpected build failures and I'll try to help. Best regards, Chris -- Chris Boot bo...@boo.tc
Bug#881053: ppp: fails to compile because of mistake in rules file
On 11/11/17 23:00, Adrian Bunk wrote: > On Sat, Nov 11, 2017 at 07:50:15PM +, Christian Blum wrote: >> Hi Adrian, > > Hi Christian, > >> I have looked a bit closer; the error only occurs if the original sources >> get modified in some way (in my case by a patch that introduces a symbol, >> "charshunt_hook"); it seems that only then the target is run that executes >> "pppd -V". It looks like this: >> >> dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd -V > > -c2 is passed to dpkg-gensymbols and means > Level 2 fails if some new symbols have been introduced > > The point of it is to error out when a new symbol is missing in the > symbols file, therefore the error you get after adding a symbol without > adding it to the symbols file is exactly what is supposed to happen. Hi Adrian, Christian, Adrian: I'm glad someone else appears to understand my intentions with this mechanism! I believe I have fully documented this in debian/README.source, but please do let me know if something is missing from there. Perhaps the debian/rules can more explicitly point at the README.source in case a build fails in this location? Cheers, Chris -- Chris Boot bo...@debian.org
Bug#881053: ppp: fails to compile because of mistake in rules file
On Sun, Nov 12, 2017 at 09:35:02AM +, Chris Boot wrote: >... > I believe I have fully documented this in debian/README.source, but > please do let me know if something is missing from there. Perhaps the > debian/rules can more explicitly point at the README.source in case a > build fails in this location? What should really be improved is what I just reported as #881488 against dpkg-dev: dpkg-gensymbols prints "warning:" for these fatal errors. > Cheers, > Chris cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
