Bug#897250: FTBFS with libonig 6.8.1-1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Moritz, first thanks for your work. Am Freitag, den 04.05.2018, 14:36 +0200 schrieb Moritz Muehlenhoff: > B0;115;0cOn Fri, May 04, 2018 at 02:21:41PM +0200, Moritz Muehlenhoff > wrote: > > On Wed, May 02, 2018 at 12:02:03PM +0200, Moritz Muehlenhoff wrote: > > > Hi Jörg, > > > > > > On Mon, Apr 30, 2018 at 09:59:11PM +0200, Jörg Frings-Fürst > > > wrote: > > > > > > > > for the liboinig transition I testing the build of hhvm again > > > > libonig 6.8.1-1. > > > > > > > > The build fails with > > > > > > > > [quote] > > > > In file included from /build/hhvm- > > > > 3.21.0+dfsg/hphp/runtime/base/program- > > > > functions.cpp:117:0: > > > > /usr/include/oniguruma.h:347:1: error: 'UChar' does not name a > > > > type; did you > > > > mean 'char'? > > > > UChar* onigenc_strdup P_((OnigEncoding enc, const UChar* s, > > > > const UChar* > > > > end)); > > > > ^ > > > > char > > > > > > But that's a problem in the lobonig headers? > > > hphp/runtime/base/program-functions.cpp:117 simply does a > > > > > > #include > > > > Actually this needs some changes on the HHVM end, found a fix. > > The patch for HHVM is still needed to fix that the regex struc was > moved to a > private header. > > It also adds a workaround to address a bug in Oniguruma, though: > HHVM uses ONIG_ESCAPE_UCHAR_COLLISION and that is broken in > 6.8.0/6.8.1 > (see the comment in https://github.com/facebook/hhvm/commit/0bbbf67ad > c2643d04353cf2bdda2e1aa7c92d36f) > I have test it with libonig 6.8.2. It looks good. I hope that my sponsor can upload the new release shortly. > Cheers, > Moritz CU Jörg - -- New: GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D GPG key (long) : 09F89F3C8CA1D25D GPG Key: 8CA1D25D CAcert Key S/N : 0E:D4:56 Old pgp Key: BE581B6E (revoked since 2014-12-31). Jörg Frings-Fürst D-54470 Lieser Threema: SYR8SJXB Wire: @joergfringsfuerst Skype:joergpenguin Ring: jff Telegram: @joergfringsfuerst IRC: j_...@freenode.net j_...@oftc.net My wish list: - Please send me a picture from the nature at your home. -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEY+AHX8jUOrs1qzDuCfifPIyh0l0FAlrsgpIACgkQCfifPIyh 0l19Kg/+Jaa9riAExzDEPQCdMYeFgZiF2UmgfW3ehDi916WvEeJb+WPajowU0bBh QBVSM2N+AH9RFbnbspI6Xqxxa9yRtDk9fYh6Qed2IoO7H9f+AKGVghwH5YnKGDcc f/ScTsynsVuFIylwNqymXqyimpLG8kGiR01pPDlUdgqRxuMTvxCyVYUqfWezK1Lr /eoVJlBZBP/WwjEjS3ma5VlVGjLPseKcXQ9XqQqKZPP1MdfcZ5tCj/xdR3y75kuv U0IUbMyd9MazZkXEYbTEgWr097eNvGdDX/kj53b2qwWuluWYSttWytXkPbU3iCFy b4tJVVOfQFzcGrdWKT6v+uqOkzcW8yUh08H1Lsfz2uGb/5AoPX/V0iSp//Oo4vY+ t6EPCW2Rse3LTkYoYJBTCYxg1pRvLoC2taguRROr7WfROBn0pxZbAMD5rBde2VVY lhQeqRFppWCuFtyqZb9bYv5kma4gKxu9gaQuNwa2N9S+zp/0RSPM8D9Cab6JeyT4 vTY9Z2abZ1zRwR3Bnupns+zhb/0BrZ8zQBvaYCpK3U/tyIIKngWGkO5LClqxNCxP 8mETHdhjLjoSN0nOoTRuP3O3pQSIAypBS1iQiMYiBYwqNdKQUpee6x0eW55yIIBo jTzHEktW5OdTAYjsy9prrW2+RMdZPgGZnESwVZVqf1VahS0ggXY= =NjlM -END PGP SIGNATURE-
Bug#897250: FTBFS with libonig 6.8.1-1
B0;115;0cOn Fri, May 04, 2018 at 02:21:41PM +0200, Moritz Muehlenhoff wrote: > On Wed, May 02, 2018 at 12:02:03PM +0200, Moritz Muehlenhoff wrote: > > Hi Jörg, > > > > On Mon, Apr 30, 2018 at 09:59:11PM +0200, Jörg Frings-Fürst wrote: > > > > > > for the liboinig transition I testing the build of hhvm again libonig > > > 6.8.1-1. > > > > > > The build fails with > > > > > > [quote] > > > In file included from /build/hhvm-3.21.0+dfsg/hphp/runtime/base/program- > > > functions.cpp:117:0: > > > /usr/include/oniguruma.h:347:1: error: 'UChar' does not name a type; did > > > you > > > mean 'char'? > > > UChar* onigenc_strdup P_((OnigEncoding enc, const UChar* s, const UChar* > > > end)); > > > ^ > > > char > > > > But that's a problem in the lobonig headers? > > hphp/runtime/base/program-functions.cpp:117 simply does a > > > > #include > > Actually this needs some changes on the HHVM end, found a fix. The patch for HHVM is still needed to fix that the regex struc was moved to a private header. It also adds a workaround to address a bug in Oniguruma, though: HHVM uses ONIG_ESCAPE_UCHAR_COLLISION and that is broken in 6.8.0/6.8.1 (see the comment in https://github.com/facebook/hhvm/commit/0bbbf67adc2643d04353cf2bdda2e1aa7c92d36f) Cheers, Moritz
Bug#897250: FTBFS with libonig 6.8.1-1
On Wed, May 02, 2018 at 12:02:03PM +0200, Moritz Muehlenhoff wrote: > Hi Jörg, > > On Mon, Apr 30, 2018 at 09:59:11PM +0200, Jörg Frings-Fürst wrote: > > > > for the liboinig transition I testing the build of hhvm again libonig > > 6.8.1-1. > > > > The build fails with > > > > [quote] > > In file included from /build/hhvm-3.21.0+dfsg/hphp/runtime/base/program- > > functions.cpp:117:0: > > /usr/include/oniguruma.h:347:1: error: 'UChar' does not name a type; did you > > mean 'char'? > > UChar* onigenc_strdup P_((OnigEncoding enc, const UChar* s, const UChar* > > end)); > > ^ > > char > > But that's a problem in the lobonig headers? > hphp/runtime/base/program-functions.cpp:117 simply does a > > #include Actually this needs some changes on the HHVM end, found a fix. Cheers, Moritz
Bug#897250: FTBFS with libonig 6.8.1-1
Hi Jörg, On Mon, Apr 30, 2018 at 09:59:11PM +0200, Jörg Frings-Fürst wrote: > > for the liboinig transition I testing the build of hhvm again libonig 6.8.1-1. > > The build fails with > > [quote] > In file included from /build/hhvm-3.21.0+dfsg/hphp/runtime/base/program- > functions.cpp:117:0: > /usr/include/oniguruma.h:347:1: error: 'UChar' does not name a type; did you > mean 'char'? > UChar* onigenc_strdup P_((OnigEncoding enc, const UChar* s, const UChar* > end)); > ^ > char But that's a problem in the lobonig headers? hphp/runtime/base/program-functions.cpp:117 simply does a #include Cheers, Moritz
Processed: Bug#897250: FTBFS with libonig 6.8.1-1
Processing commands for cont...@bugs.debian.org: > severity 897250 serious Bug #897250 [hhvm] FTBFS with libonig 6.8.1-1 Severity set to 'serious' from 'important' > thanks Stopping processing here. Please contact me if you need assistance. -- 897250: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897250 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
