Bug#952208: python-ftputil

2020-03-04 Thread eamanu
Hi


> was temporary, just referring what my patch impacts and will close this
> issue.
> 
> The skip you made in your patch does not fix all issues, only workaround
> them.
>  

Oh! I can see. I was looking on the last commit.


> 
> >
> > Will you push new patch release soon? Or should I do?
> 
> I'm DM and I will need sponsorhip.
> 
> 
> I am DD, so I can upload it if you think it is "over" for you.

It' will be  great! Thanks
>  

> I have updated debian/master branch accordingly
> I pushed my patch and disabled your patch to skip the tests from
> d/patches/series
> A gbp buildpackage works with all tests now.

Great. Please, when you have time, push to salsa to see it. :-)

And please, if you can upload will be great.

> 
> Maybe master branch should be removed to avoid this kind of confusion

Yes, could be. But I let it for history purpose. If you consider better
remove it, go ahead.

Cheers!

-- 
Emmanuel Arias
@eamanu
yaerobi.com


0xFA9DEC5DE11C63F1.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature


Bug#952208: python-ftputil

2020-03-04 Thread olivier sallou
Le mer. 4 mars 2020 à 16:38, eamanu  a écrit :

> Hi olivier,
>
> On 04/03/2020 12:13, olivier sallou wrote:
> > Hi,
> > I saw you started some work on python-ftputil to fix #952208.
> >
> > I just pushed to git repo a fix for that.
>
> I am a little confused, you just added description to the patch?
>

No, I added a patch "debian/patches/fix_tests_future.patch" as explained in
d/changelog


>
> Why do you  douplicate on d/changelog  the (Closes #bugnumber) sentence?
> [0]
>

was temporary, just referring what my patch impacts and will close this
issue.

The skip you made in your patch does not fix all issues, only workaround
them.


>
> >
> > Will you push new patch release soon? Or should I do?
>
> I'm DM and I will need sponsorhip.
>

I am DD, so I can upload it if you think it is "over" for you.


> >
> > I wonder however why you pushed a gbp.conf (not really expected usually)
> > setting branch as debian/master , which does not exists and default
> > being master.
>
> I push gbp.conf and set debian/master as default branch to be the
> repository according to the DPMT policy recommendation [1] and DEP-14 [2]
>

ooh ok, I see a "new" debian/master branch, which did not exists on my
local clone
So I pushed to master branch instead of debian/master. that's reason
why we do not "see" everything...

I have updated debian/master branch accordingly
I pushed my patch and disabled your patch to skip the tests from
d/patches/series
A gbp buildpackage works with all tests now.

Maybe master branch should be removed to avoid this kind of confusion


Olivier


> [0]
>
> https://salsa.debian.org/python-team/modules/python-ftputil/-/commit/a52fad2009b720882fed9bbed366b5e70e9154ae
> [1]
>
> https://salsa.debian.org/python-team/tools/python-modules/blob/master/policy.rst#branch-names
> [2] https://dep-team.pages.debian.net/deps/dep14/
>
> Cheers!
>
> --
> Emmanuel Arias
> @eamanu
> yaerobi.com
>


Bug#952208: python-ftputil

2020-03-04 Thread eamanu
Hi olivier,

On 04/03/2020 12:13, olivier sallou wrote:
> Hi,
> I saw you started some work on python-ftputil to fix #952208.
> 
> I just pushed to git repo a fix for that.

I am a little confused, you just added description to the patch?

Why do you  douplicate on d/changelog  the (Closes #bugnumber) sentence? [0]

> 
> Will you push new patch release soon? Or should I do?

I'm DM and I will need sponsorhip.
> 
> I wonder however why you pushed a gbp.conf (not really expected usually)
> setting branch as debian/master , which does not exists and default
> being master.

I push gbp.conf and set debian/master as default branch to be the
repository according to the DPMT policy recommendation [1] and DEP-14 [2]

[0]
https://salsa.debian.org/python-team/modules/python-ftputil/-/commit/a52fad2009b720882fed9bbed366b5e70e9154ae
[1]
https://salsa.debian.org/python-team/tools/python-modules/blob/master/policy.rst#branch-names
[2] https://dep-team.pages.debian.net/deps/dep14/

Cheers!

-- 
Emmanuel Arias
@eamanu
yaerobi.com


0xFA9DEC5DE11C63F1.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature


Bug#952208: python-ftputil

2020-03-04 Thread olivier sallou
Hi,
I saw you started some work on python-ftputil to fix #952208.

I just pushed to git repo a fix for that.

Will you push new patch release soon? Or should I do?

I wonder however why you pushed a gbp.conf (not really expected usually)
setting branch as debian/master , which does not exists and default being
master.

Olivier


Bug#952208: python-ftputil: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.8 3.7" returned exit code 13

2020-02-23 Thread Lucas Nussbaum
Source: python-ftputil
Version: 3.4-2
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200222 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
>  debian/rules build
> dh build --with python3 --buildsystem=pybuild
>dh_update_autotools_config -O--buildsystem=pybuild
>dh_auto_configure -O--buildsystem=pybuild
> I: pybuild base:217: python3.8 setup.py config 
> running config
> I: pybuild base:217: python3.7 setup.py config 
> running config
>dh_auto_build -O--buildsystem=pybuild
> I: pybuild base:217: /usr/bin/python3.8 setup.py build 
> running build
> running build_py
> creating /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/error.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/tool.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/__init__.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/sync.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/host.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/session.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/file.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/lrucache.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/compat.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/stat_cache.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/stat.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/version.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/path.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/file_transfer.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/socket_file_adapter.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> copying ftputil/session_adapter.py -> 
> /<>/.pybuild/cpython3_3.8_ftputil/build/ftputil
> I: pybuild base:217: /usr/bin/python3 setup.py build 
> running build
> running build_py
> creating /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/error.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/tool.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/__init__.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/sync.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/host.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/session.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/file.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/lrucache.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/compat.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/stat_cache.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/stat.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/version.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/path.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/file_transfer.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/socket_file_adapter.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
> copying ftputil/session_adapter.py -> 
> /<>/.pybuild/cpython3_3.7_ftputil/build/ftputil
>dh_auto_test -O--buildsystem=pybuild
> I: pybuild base:217: cd /<>/.pybuild/cpython3_3.8_ftputil/build; 
> python3.8 -m pytest test
> = test session starts 
> ==
> platform linux -- Python 3.8.2rc2, pytest-4.6.9, py-1.8.1, pluggy-0.13.0
> rootdir: /<>
> collected 129 items
> 
> test/test_error.py ..[  
> 4%]
> test/test_file.py .. [ 
> 18%]
> test/test_file_transfer.py   [ 
> 21%]
> test/test_host.py ...F.F [ 
> 48%]
> test/test_path.py    [ 
> 57%]
> test/test_session.py ..  [ 
> 62%]
> test/test_stat.py .. [ 
> 79%]
> test/test_stat_cache.py ..   [ 
> 86%]
> test/test_sync.py ...[ 
> 89%]
> test/test_tool.py    [ 
> 95%]
> test/test_with_statement.py ..   
> [100%]
> 
> === FAILURES 
> ===
>  TestUploadAndDownload.tes