Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Nilesh Patra, Dec 06, 2023 at 16:44: My understanding is that we can maybe ignore the CI here. Hey Nilesh, thanks for looking at this. Unless you see something wrong I think it is good for another attempt at NEW. Cheers!
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
On Tue, Dec 05, 2023 at 11:15:40PM +0100, Robin Jarry wrote: > Nilesh Patra, Dec 05, 2023 at 20:44: > > You should have the permissions now for this repo. LMK if there's still > > an issue. > > Thanks I managed to push everything needed. However, the CI fails for some > obscure reason now: > > https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap/-/jobs/5005483 > > $ GBP_CONF_FILES=:debian/gbp.conf gbp buildpackage > --git-no-pristine-tar --git-ignore-branch --git-ignore-new > --git-export-dir=/tmp/export --git-no-overlay > --git-tarball-dir=/nonexistent --git-cleaner=/bin/true > --git-builder='dpkg-buildpackage -S -d --no-sign' > gbp:info: Tarballs 'golang-sourcehut-rockorager-go-jmap_0.4.4.orig.tar.gz' > not found at '/nonexistent' > gbp:error: upstream is not a valid branch > > Do you have a clue? It seems related to my change in debian/gbp.conf I have a vague idea, and I'm not really keep to dig into it as this is not /really/ important. I am able to repro if I `git clone` the repository and try to run the command or try to run `gbp export-orig` | $ gbp export-orig | gbp:error: upstream is not a valid branch This is because a simple clone does not checkout the upstream branch. Once I checkout this, the error goes away. My hunch is that the CI is trying to do something like this, atleast as per the CI logs: | Fetching changes with git depth set to 20... | Reinitialized existing Git repository in /builds/go-team/packages/golang-sourcehut-rockorager-go-jmap/.git/ My understanding is that we can maybe ignore the CI here. Best, Nilesh signature.asc Description: PGP signature
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Nilesh Patra, Dec 05, 2023 at 20:44: You should have the permissions now for this repo. LMK if there's still an issue. Thanks I managed to push everything needed. However, the CI fails for some obscure reason now: https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap/-/jobs/5005483 $ GBP_CONF_FILES=:debian/gbp.conf gbp buildpackage --git-no-pristine-tar --git-ignore-branch --git-ignore-new --git-export-dir=/tmp/export --git-no-overlay --git-tarball-dir=/nonexistent --git-cleaner=/bin/true --git-builder='dpkg-buildpackage -S -d --no-sign' gbp:info: Tarballs 'golang-sourcehut-rockorager-go-jmap_0.4.4.orig.tar.gz' not found at '/nonexistent' gbp:error: upstream is not a valid branch Do you have a clue? It seems related to my change in debian/gbp.conf https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap/-/commit/b5e8586dbced8af76352917f9f2d1d4da0641b28 But I am not sure at all. I wanted to avoid importing the upstream source as a git archive of the tag and have gbp import-orig automatically pull the upstream source and rebase the upstream branch accordingly. Maybe I don't understand how to deal with this...
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
On Tue, Dec 05, 2023 at 02:30:42PM +0100, Robin Jarry wrote: > Hi Nilesh, > > I finally get time to work on this. I tried updating the repo but somehow I > messed up the upstream branch (updated it with gbp import-orig --uscan) last > time. > > https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap/ > > I'd like to follow the standard go team workflow which is to preserve all > history in the upstream branch. > > https://go-team.pages.debian.net/workflow-changes.html > > I tried renaming the branch to old/upstream and pushing a new one but I > don't have the permissions to do so: > > > remote: GitLab: You are not allowed to delete protected branches from > > this project. Only a project maintainer or owner can delete a protected > > branch. > > Can you help? You should have the permissions now for this repo. LMK if there's still an issue. Best, Nilesh signature.asc Description: PGP signature
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Hi Nilesh, I finally get time to work on this. I tried updating the repo but somehow I messed up the upstream branch (updated it with gbp import-orig --uscan) last time. https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap/ I'd like to follow the standard go team workflow which is to preserve all history in the upstream branch. https://go-team.pages.debian.net/workflow-changes.html I tried renaming the branch to old/upstream and pushing a new one but I don't have the permissions to do so: remote: GitLab: You are not allowed to delete protected branches from this project. Only a project maintainer or owner can delete a protected branch. Can you help? Thanks!
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Hi Nilesh, Nilesh Patra, Nov 22, 2023 at 21:03: I am pinging here to ask if you have a clue as to what could be done about it. As this is blocking aerc update, do you find it possible to use another golang library in place of rockorager-go-jmap that may offer similar functionality? Sorry, I got sidetracked on the matter. I have worked to remove the RFC text quotes from all the project: https://git.sr.ht/~rockorager/go-jmap/commit/a79dd619191ffcd97dab0d5be21c98ae70ff8a25 https://git.sr.ht/~rockorager/go-jmap/commit/bc07e105979181f8ec1b744982919e0e4d9d606c There was a new tagged release but I haven't taken the time to integrate it into the debian package. I'll try to do this before the end of the week. Thanks for caring :)
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Hi Robin, On Wed, Oct 18, 2023 at 01:54:31AM +0530, Nilesh Patra wrote: > On Fri, Oct 06, 2023 at 08:55:18AM +0200, Robin Jarry wrote: > > Nilesh Patra, Oct 05, 2023 at 23:52: > > > Uploaded to NEW -- I hope the copyright checks would be green! > > > > Thanks \o/ > > This got rejected due to license issues beyond my control. > If this can be replaced by something else, that could be an option. > > Otherwise LMK what you think can be done about this. I am pinging here to ask if you have a clue as to what could be done about it. As this is blocking aerc update, do you find it possible to use another golang library in place of rockorager-go-jmap that may offer similar functionality? Best, Nilesh signature.asc Description: PGP signature
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
On Fri, Oct 06, 2023 at 08:55:18AM +0200, Robin Jarry wrote: > Nilesh Patra, Oct 05, 2023 at 23:52: > > Uploaded to NEW -- I hope the copyright checks would be green! > > Thanks \o/ This got rejected due to license issues beyond my control. If this can be replaced by something else, that could be an option. Otherwise LMK what you think can be done about this. Best, Nilesh signature.asc Description: PGP signature
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Nilesh Patra, Oct 05, 2023 at 23:52: Uploaded to NEW -- I hope the copyright checks would be green! Thanks \o/
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
On Thu, Oct 05, 2023 at 08:28:32PM +0200, Robin Jarry wrote: > Nilesh Patra, Oct 02, 2023 at 00:08: > > When a file has multiple licenses, you can mention the license as > > "License: Expat and RFC-Reference" and add a > > comment section stating the doctrings are licensed under RFC license. > > > > I took a hint for how it's done in gnupg2 package[1]. You could do something > > similar here for the description of the RFC, hopefully this should work. > > > > I personally don't care too much about this being mentioned or not, but FTP > > master would likely reject the package if copyright is not perfect so here > > we are. > > > > [1]: > > https://salsa.debian.org/debian/gnupg2/-/blob/debian/unstable/debian/copyright#L123 > > Hi Nilesh, > > I have updated d/copyright and bumped the upstream version as well. It > should be good. > > Let me know if I need to change anything. Uploaded to NEW -- I hope the copyright checks would be green! Best, Nilesh signature.asc Description: PGP signature
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Nilesh Patra, Oct 02, 2023 at 00:08: When a file has multiple licenses, you can mention the license as "License: Expat and RFC-Reference" and add a comment section stating the doctrings are licensed under RFC license. I took a hint for how it's done in gnupg2 package[1]. You could do something similar here for the description of the RFC, hopefully this should work. I personally don't care too much about this being mentioned or not, but FTP master would likely reject the package if copyright is not perfect so here we are. [1]: https://salsa.debian.org/debian/gnupg2/-/blob/debian/unstable/debian/copyright#L123 Hi Nilesh, I have updated d/copyright and bumped the upstream version as well. It should be good. Let me know if I need to change anything. Thanks!
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
On Sun, Oct 01, 2023 at 11:41:51PM +0200, Robin Jarry wrote: > Nilesh Patra, Oct 01, 2023 at 12:28: > > The jmap.go file header says: > > > > """ > > // Package jmap implements JMAP Core protocol as defined in > > // draft-ietf-jmap-core-17 (published March 2019). > > // > > // Documentation strings for most of the protocol objects are taken from (or > > // based on) contents of draft-ietf-jmap-core-17 and is subject to the IETF > > // Trust Provisions. > > // See https://trustee.ietf.org/trust-legal-provisions.html for details. > > // See included draft-ietf-jmap-core-17.txt for related copyright notices. > > """ > > > > Seems like this has copyright of one more license. (There's no > > jmap-core-17 txt file in the package btw). Can you update d/copyright > > please? > > This comment was outdated. I sent a patch to fix it upstream. However, > I am not sure how to declare the copyright. > > Only the documentation (comments) are inspired or copied from the stated > RFCs. > > This page states that any IETF document is distributed under these > terms (very long text): > > https://trustee.ietf.org/documents/trust-legal-provisions/tlp-5/ > > It says that the "code components" (examples) are published under the > BSD revised (3-Clauses) license. I don't think any code excerpt was > taken from these RFCs, though. > > I can add this line in d/copyright: > > 2019 IETF Trust and the persons identified as authors of the code. > > But since the upstream project is licensed with MIT, I'm not sure if > this is correct. > > Thoughts? When a file has multiple licenses, you can mention the license as "License: Expat and RFC-Reference" and add a comment section stating the doctrings are licensed under RFC license. I took a hint for how it's done in gnupg2 package[1]. You could do something similar here for the description of the RFC, hopefully this should work. I personally don't care too much about this being mentioned or not, but FTP master would likely reject the package if copyright is not perfect so here we are. [1]: https://salsa.debian.org/debian/gnupg2/-/blob/debian/unstable/debian/copyright#L123 Best, Nilesh signature.asc Description: PGP signature
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Nilesh Patra, Oct 01, 2023 at 12:28: > The jmap.go file header says: > > """ > // Package jmap implements JMAP Core protocol as defined in > // draft-ietf-jmap-core-17 (published March 2019). > // > // Documentation strings for most of the protocol objects are taken from (or > // based on) contents of draft-ietf-jmap-core-17 and is subject to the IETF > // Trust Provisions. > // See https://trustee.ietf.org/trust-legal-provisions.html for details. > // See included draft-ietf-jmap-core-17.txt for related copyright notices. > """ > > Seems like this has copyright of one more license. (There's no > jmap-core-17 txt file in the package btw). Can you update d/copyright > please? > > Best, > Nilesh This comment was outdated. I sent a patch to fix it upstream. However, I am not sure how to declare the copyright. Only the documentation (comments) are inspired or copied from the stated RFCs. This page states that any IETF document is distributed under these terms (very long text): https://trustee.ietf.org/documents/trust-legal-provisions/tlp-5/ It says that the "code components" (examples) are published under the BSD revised (3-Clauses) license. I don't think any code excerpt was taken from these RFCs, though. I can add this line in d/copyright: 2019 IETF Trust and the persons identified as authors of the code. But since the upstream project is licensed with MIT, I'm not sure if this is correct. Thoughts?
Re: Sponsor upload request: golang-sourcehut-rockorager-go-jmap
On Fri, Sep 29, 2023 at 11:20:30PM +0200, Robin Jarry wrote: > https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap > > Could a kind soul please upload them to NEW on my behalf? The jmap.go file header says: """ // Package jmap implements JMAP Core protocol as defined in // draft-ietf-jmap-core-17 (published March 2019). // // Documentation strings for most of the protocol objects are taken from (or // based on) contents of draft-ietf-jmap-core-17 and is subject to the IETF // Trust Provisions. // See https://trustee.ietf.org/trust-legal-provisions.html for details. // See included draft-ietf-jmap-core-17.txt for related copyright notices. """ Seems like this has copyright of one more license. (There's no jmap-core-17 txt file in the package btw). Can you update d/copyright please? Best, Nilesh signature.asc Description: PGP signature
Sponsor upload request: golang-sourcehut-rockorager-go-jmap
Hi all, I am preparing for packaging the latest release of aerc: https://git.sr.ht/~rjarry/aerc/refs/0.16.0 It requires a new dependency which is not available in Debian yet: git.sr.ht/~rockorager/go-jmaphttps://bugs.debian.org/1053244 Using dh-make-golang, I have prepared the package on salsa: https://salsa.debian.org/go-team/packages/golang-sourcehut-rockorager-go-jmap Could a kind soul please upload them to NEW on my behalf? Thanks a bunch. -- Robin
