Bug#712115: marked as done (linux-source-3.2: Kernel from proposed-updates fails to build without removing [drivers/staging/rts5139/rts5139.ko] from configuration)
Your message dated Mon, 29 Sep 2014 07:52:25 +0200 with message-id 20140929075225.04fa5f52@s5.lokal and subject line close has caused the Debian Bug report #712115, regarding linux-source-3.2: Kernel from proposed-updates fails to build without removing [drivers/staging/rts5139/rts5139.ko] from configuration to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 712115: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=712115 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Package: linux-source-3.2 Version: 3.2.46-1 Severity: normal Dear Maintainer, *** Please consider answering these questions, where appropriate *** * What led up to the situation? * What exactly did you do (or not do) that was effective (or ineffective)? * What was the outcome of this action? * What outcome did you expect instead? *** End of the template - remove these lines *** I had to remove this: drivers/staging/rts5139 from my kernel-configuration in order to be able to build correctly, before that I saw this: . . .. CC [M] drivers/video/via/accel.o CC [M] drivers/video/via/via_utility.o CC [M] drivers/video/via/vt1636.o CC [M] drivers/video/via/global.o CC [M] drivers/usb/serial/ti_usb_3410_5052.o CC [M] drivers/video/via/tblDPASetting.o CC [M] drivers/video/via/viamode.o CC [M] drivers/video/via/via-core.o CC [M] drivers/video/via/via-gpio.o CC [M] drivers/video/via/via_modesetting.o CC [M] drivers/video/via/via_clock.o CC [M] drivers/usb/serial/visor.o CC [M] drivers/usb/serial/whiteheat.o LD [M] drivers/video/sis/sisfb.o CC [M] drivers/usb/serial/vivopay-serial.o LD [M] drivers/video/via/viafb.o CC [M] drivers/usb/serial/zio.o LD [M] drivers/usb/serial/usbserial.o Building modules, stage 2. MODPOST 2796 modules ERROR: __modver_version_show [drivers/staging/rts5139/rts5139.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make[1]: Leaving directory `/home/andreas/src/linux-source-3.2' make: *** [debian/stamp/build/kernel] Error 2 See my attached k-configuration. The second problem is, that the AMD-legacy blob failed to be rebuilt by dkms for the newly built kernel-image, when setting it up. I have no idea, wether this is the fault of the dkms-mechanism or if it is the blob's fault, but this used to work very well on Squeeze, now there was no hint at all about dkms, only update-grub was done when setting up the new kernel-package. So as it looks like now, I have to reinstall the blob manually every time a new kernel-version is installed. This is quite bad, another regression, that makes me want to buy new hardware. - -- System Information: Debian Release: 7.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.46cak (SMP w/3 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages linux-source-3.2 depends on: ii binutils 2.22-8 ii bzip2 1.0.6-4 Versions of packages linux-source-3.2 recommends: ii gcc 4:4.7.2-1 ii libc6-dev [libc-dev] 2.13-38 ii make 3.81-8.2 Versions of packages linux-source-3.2 suggests: pn libncurses-dev | ncurses-dev none pn libqt4-devnone ii pkg-config0.26-1 - -- no debconf information -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlG5YhAACgkQ5+rBHyUt5wvd9gCfTv/PhXbckX4tISN7OGpqZi1Y RZEAnAjXJMlB+YT9qZ4Yt0UvXILlPrcP =GKKx -END PGP SIGNATURE- config-3.2.46cak.bz2 Description: application/bzip ---End Message--- ---BeginMessage--- -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 No idea, why this episode has been left open. -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlQo85kACgkQ5+rBHyUt5wu/4QCeN3p/aAO93hs/MDzidURNpL1T bLcAoKD3FrLxyMIu3FAOVG9PdOth2zmz =ddLh -END PGP SIGNATURE- ---End Message---
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On 29 September 2014 00:21, Brian Norris computersforpe...@gmail.com wrote: + Rafal Rafal has been looking at the same area of code. I'd really like to get this patch into 3.18 if possible, so the more eyes the better. Thanks Brian. I took me a while to follow this issue, too bad I wasn't subscribed to the ML earlier. Let me try to sum it up. 1) The main urgent issue: broken auto-loading Tracked in the thread: http://www.spinics.net/lists/linux-spi/msg01726.html Problem: m25p80.c references spi_nor_ids (from external file) Short-term solution: duplicate IDs in the m25p80.c Ben: just like Brian, I think the patch like this one ( [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80 ) is the way to go. However few comments: a) I don't see why you modify m25p_probe in it. b) I don't think the described clean solution (you described it in the commit message): A clean solution to this will involve defining the list of device IDs in spi-nor.h and removing struct spi_device_id from the spi-nor API, but this is quite a large change. is the correct one. I think there should be a single string to trigger m25p80 load and the rest should be handled using JEDEC, with some workarounds for incompatible devices only. One thing I wonder about is sense of pushing this patch to the Linus's tree. Do you think we could prepare a real fix for Linus and leave this patch for stable@ only? I'm far from being an expert on such things, just asking. 2) On going cleanups It seems there are at least 2 ppl (me, Ben) working on some cleanups independently. a) There is (l2-mtd pushed) patch moving flash_platform_data into m25p80: https://patchwork.ozlabs.org/patch/394219/ b) Removing spi_nor::read_id https://patchwork.ozlabs.org/patch/389073/ Ben: I think this one has a NACK from me, because I'm going to use custom read_id in the bcm53xxspiflash driver. See following thread for bcm53xxspiflash description: http://comments.gmane.org/gmane.linux.drivers.mtd/54578 Initial commit (it uses read_id): https://patchwork.ozlabs.org/patch/381902/ c) Obsoleting spi_device_id It seems we both were working on the same thing, me slightly slower however ;) https://patchwork.ozlabs.org/patch/377917/ https://patchwork.ozlabs.org/patch/389074/ https://patchwork.ozlabs.org/patch/389075/ I still have to review calmly your changes, but they need to be rebased anyway. d) Cleaning m25p80 https://patchwork.ozlabs.org/patch/389076/ Ben: As said before, I think we should do smarter in the m25p80. We should get rid of all that duplicated strings. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CACna6rx=GyZ-4JpDix==wkszabseqxk6qcckfikcm9-wzbm...@mail.gmail.com
Bug#759323: linux-image-3.16-trunk-amd64 : Xorg freezes or the system reboots under glxgears
This bug is resolved with the package: linux-image-3.16-0.bpo.2-amd64. Thank you. -- Alain Rpnpif -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140929080107.7b5115a1...@chro.home
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On 29 September 2014 00:21, Brian Norris computersforpe...@gmail.com wrote: (Honestly, some of this name-matching / ID-matching stuff confuses me; there is at least one too many ways to choose a flash device for this driver.) It's not that complex once you track it. It's just ugly to tracks because of different structs, function calls and code locations. 1) All m25p80 users (arch code, SPI drivers, etc.) register struct spi_board_info that contains modalias. It it used to match a driver to load. In most (?) cases modalias is set to m25p80 2) Some m25p80 users decided to put a flash device name (e.g. at25fs010, mx25l2005a, m25p05, w25x10) as modalias of the struct spi_board_info. I think they are affected by the recent m25p80 change to use spi-not framework. 3) Other m25p80 users provide flash device name (e.g. at25fs010, mx25l2005a, m25p05, w25x10) using platform_data in the struct spi_board_info. It points to the struct flash_platform_data with name and type properties. It seems to me that name is never used. My idea for fixing this: 1) Always use m25p80 modalias (for m25p80 compatible hw). This will make m25p80 driver work without this huge id_table 2) Do not use name nor type in the struct flash_platform_data if the flash supports JEDEC 3) If the flash is m25p80 compatible, but doesn't support JEDEC, let's use type to let m25p80 work. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CACna6rwxK61zVPNf2ACYj_NfNtkq=fnqde4xjjnpb8tvp1h...@mail.gmail.com
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On 29 September 2014 08:36, Rafał Miłecki zaj...@gmail.com wrote: 1) The main urgent issue: broken auto-loading Tracked in the thread: http://www.spinics.net/lists/linux-spi/msg01726.html Problem: m25p80.c references spi_nor_ids (from external file) Short-term solution: duplicate IDs in the m25p80.c Ben: just like Brian, I think the patch like this one ( [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80 ) is the way to go. However few comments: I started wondering... would this be possible to fix all m25p80 users instead? Make them always specify modalias as m25p80 and then provide platform_data if needed? Has anyone checked in how many places we use wrong (or should I say weird) modaliases? I guess some would need to grep kernel for all possible names. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cacna6ry91b3wchsg4c-td+stpuiah7oaacqukikdhud+jct...@mail.gmail.com
Bug#763320: linux-image-3.16-2-amd64: intel_idle enabled for Intel Atom S1260, causes high CPU temperature when idle
Package: src:linux Version: 3.16.3-2 Severity: normal Dear Maintainer, with Kernel 3.16, intel_idle is enabled for the Intel Atom S1260 CPU (Centerton SoC). This leads to a +20°C temperature increase when the CPU is idle, exceeding the 100°C alarm threshold for passive cooled systems like the Supermicro X9SBAA-F. With 3.14, intel_idle was blacklisted for this CPU, which runs fine. If 3.16 is booted with intel_idle.max_cstate=0 processor.max_cstate=0, which disables the intel_idle, the CPU also stays cool. -- Package-specific info: ** Version: Linux version 3.16-2-amd64 (debian-kernel@lists.debian.org) (gcc version 4.8.3 (Debian 4.8.3-11) ) #1 SMP Debian 3.16.3-2 (2014-09-20) ** Command line: BOOT_IMAGE=/boot/vmlinuz-3.16-2-amd64 root=UUID=7b7b22dd-1baa-4772-a734-03ffc40db914 ro quiet console=ttyS1,115200n8 console=tty0 intel_idle.max_cstate=0 processor.max_cstate=0 ** Not tainted ** Kernel log: [2.983325] ata8.00: configured for UDMA/66 [2.983820] ata3.00: ATA-8: ST2000DL003-9VT166, CC3C, max UDMA/133 [2.983825] ata3.00: 3907029168 sectors, multi 0: LBA48 NCQ (depth 31/32) [2.984577] ata3.00: configured for UDMA/133 [3.011761] usb 1-4: New USB device found, idVendor=0557, idProduct=2221 [3.011767] usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [3.011771] usb 1-4: Product: Hermon USB hidmouse Device [3.011776] usb 1-4: Manufacturer: Winbond Electronics Corp [3.012035] usb 1-4: ep 0x82 - rounding interval to 64 microframes, ep desc says 80 microframes [3.012046] usb 1-4: ep 0x81 - rounding interval to 64 microframes, ep desc says 80 microframes [3.019168] hidraw: raw HID events driver (C) Jiri Kosina [3.030160] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300) [3.030313] ata1.00: ATA-7: MARVELL Raid VD, MV.R00-0, max UDMA7 [3.030321] ata1.00: 3906865280 sectors, multi 0: LBA48 NCQ (depth 31/32) [3.030471] ata1.00: configured for UDMA/133 [3.030722] scsi 0:0:0:0: Direct-Access ATA MARVELL Raid VD 00-0 PQ: 0 ANSI: 5 [3.031345] usbcore: registered new interface driver usbhid [3.031351] usbhid: USB HID core driver [3.031737] scsi 2:0:0:0: Direct-Access ATA ST2000DL003-9VT1 CC3C PQ: 0 ANSI: 5 [3.032928] scsi 7:0:0:0: Processor Marvell Console 1.01 PQ: 0 ANSI: 5 [3.033670] input: Winbond Electronics Corp Hermon USB hidmouse Device as /devices/pci:00/:00:02.0/:02:00.0/usb1/1-4/1-4:1.0/0003:0557:2221.0001/input/input0 [3.033959] hid-generic 0003:0557:2221.0001: input,hidraw0: USB HID v1.00 Mouse [Winbond Electronics Corp Hermon USB hidmouse Device] on usb-:02:00.0-4/input0 [3.034460] input: Winbond Electronics Corp Hermon USB hidmouse Device as /devices/pci:00/:00:02.0/:02:00.0/usb1/1-4/1-4:1.1/0003:0557:2221.0002/input/input1 [3.034625] hid-generic 0003:0557:2221.0002: input,hidraw1: USB HID v1.00 Keyboard [Winbond Electronics Corp Hermon USB hidmouse Device] on usb-:02:00.0-4/input1 [3.046153] ata8.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 [3.053518] ata8.00: irq_stat 0x4001 [3.057990] scsi 7:0:0:0: CDB: [3.057994] Inquiry: 12 01 00 00 ff 00 [3.058012] ata8.00: cmd a0/01:00:00:00:01/00:00:00:00:00/a0 tag 3 dma 16640 in [3.058012] res 00/00:00:00:00:00/00:00:00:00:00/00 Emask 0x3 (HSM violation) [3.075126] ata8: hard resetting link [3.401934] ata8: SATA link up 1.5 Gbps (SStatus 113 SControl 300) [3.402158] ata8.00: configured for UDMA/66 [3.402241] ata8: EH complete [3.410424] scsi 0:0:0:0: Attached scsi generic sg0 type 0 [3.410654] scsi 2:0:0:0: Attached scsi generic sg1 type 0 [3.410830] scsi 7:0:0:0: Attached scsi generic sg2 type 3 [3.415232] sd 0:0:0:0: [sda] 3906865280 512-byte logical blocks: (2.00 TB/1.81 TiB) [3.415438] sd 0:0:0:0: [sda] Write Protect is off [3.415446] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00 [3.415527] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA [3.415633] sd 2:0:0:0: [sdb] 3907029168 512-byte logical blocks: (2.00 TB/1.81 TiB) [3.415642] sd 2:0:0:0: [sdb] 4096-byte physical blocks [3.415805] sd 2:0:0:0: [sdb] Write Protect is off [3.415813] sd 2:0:0:0: [sdb] Mode Sense: 00 3a 00 00 [3.415884] sd 2:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA [3.460487] sdb: sdb1 sdb2 [3.461418] sd 2:0:0:0: [sdb] Attached SCSI disk [3.478857] sda: sda1 sda2 [3.479827] sd 0:0:0:0: [sda] Attached SCSI disk [3.726640] PM: Starting manual resume from disk [3.726652] PM: Hibernation image partition 8:17 present [3.726655] PM: Looking for hibernation image. [3.727413] PM: Image not found (code -22) [3.727417] PM: Hibernation image not present or could not be loaded. [3.838801] EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null) [4.548055]
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On 29 September 2014 11:53, Rafał Miłecki zaj...@gmail.com wrote: On 29 September 2014 08:36, Rafał Miłecki zaj...@gmail.com wrote: 1) The main urgent issue: broken auto-loading Tracked in the thread: http://www.spinics.net/lists/linux-spi/msg01726.html Problem: m25p80.c references spi_nor_ids (from external file) Short-term solution: duplicate IDs in the m25p80.c Ben: just like Brian, I think the patch like this one ( [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80 ) is the way to go. However few comments: I started wondering... would this be possible to fix all m25p80 users instead? Make them always specify modalias as m25p80 and then provide platform_data if needed? Has anyone checked in how many places we use wrong (or should I say weird) modaliases? I guess some would need to grep kernel for all possible names. I did some (e)grepping, it seems we have: 1) Only 6 references (modalias) in arch/mips/ath79/ 2) About 57 references (compatible) in arch/arm/boot/dts/ 3) About 32 references (compatible) in arch/powerpc/boot/dts/ However it seems there is no way to provide platform_data in Device Tree files. So we have to support compatible (modalias) for now I guess. The list (if someone would like to check) of used names in archs: m25p128 m25p16 m25p32 m25p40 m25p64 mx25l12805d mx25l1606e mx25l25635e mx25l4005a mx25l6405d mx66l51235l n25q128a11 n25q128a13 n25q512a s25fl008k s25fl256s1 s25fl512s s25sl064a s25sl12801 sst25vf016b sst25vf032b sst25vf040b sst25wf040 w25q128 w25q256 w25q32 w25q32dw w25q80bl w25x80 -- Rafał -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cacna6rwz6e0hc_ho+drbtzwnu6_j0xn9b_76fh0ywdosv-m...@mail.gmail.com
Bug#763325: linux-image-3.16-2-amd64: Kernel oops 3.16.2-amd64
Package: src:linux Version: 3.16.3-2 Severity: normal Noticed several oddities while booting this laptop after recent upgrade: Keyboard was flakey (the 1 did not work unless first on line), then ok. Fan running continuously which was not happening before. Of course, these things may have no connection with the oops, which I have only just noticed. The oops (shown again in context later): - Sep 29 11:08:39 shelf kernel: [ 262.924810] WARNING: CPU: 0 PID: 0 at /build/linux-P15SNz/linux-3.16.3/net/sched/sch_g eneric.c:264 dev_watchdog+0x236/0x240() Sep 29 11:08:39 shelf kernel: [ 262.924812] NETDEV WATCHDOG: eth0 (r8169): transmit queue 0 timed out Sep 29 11:08:39 shelf kernel: [ 262.924813] Modules linked in: bnep uvcvideo videobuf2_vmalloc ecb videobuf2_memops vi deobuf2_core v4l2_common btusb videodev media bluetooth 6lowpan_iphc snd_hrtimer snd_seq snd_seq_device snd_hda_codec_h dmi joydev nfsd auth_rpcgss oid_registry nfs_acl nfs lockd fscache sunrpc arc4 rtsx_pci_ms rtsx_pci_sdmmc iTCO_wdt mems tick iTCO_vendor_support mmc_core snd_hda_codec_realtek snd_hda_codec_generic x86_pkg_temp_thermal intel_powerclamp int el_rapl coretemp kvm_intel kvm crc32_pclmul iwlmvm crc32c_intel mac80211 ghash_clmulni_intel aesni_intel aes_x86_64 lrw gf128mul glue_helper ablk_helper cryptd evdev psmouse iwlwifi i915 serio_raw pcspkr snd_hda_intel cfg80211 i2c_i801 sn d_hda_controller sg r8169 sr_mod cdrom mii rfkill rtsx_pci wmi ehci_pci xhci_hcd snd_hda_codec snd_hwdep ehci_hcd drm_k ms_helper snd_pcm battery snd_timer drm tpm_infineon mei_me tpm_tis i2c_algo_bit tpm snd i2c_core soundcore lpc_ich usb core ac mei shpchp mfd_core video usb_common button processor fuse parport_pc ppdev lp parport autofs4 ext4 crc16 mbcac he jbd2 sd_mod crc_t10dif crct10dif_generic ahci libahci crct10dif_pclmul crct10dif_common libata scsi_mod thermal ther mal_sys Sep 29 11:08:39 shelf kernel: [ 262.924877] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16-2-amd64 #1 Debian 3.16.3-2 Sep 29 11:08:39 shelf kernel: [ 262.924878] Hardware name: Notebook W54_55SU1,SUW/W54_55SU1,SU W, BIOS 4.6.5 05/29/2014 Sep 29 11:08:39 shelf kernel: [ 262.924879] 0009 81506188 88041fa03e28 81065707 Sep 29 11:08:39 shelf kernel: [ 262.924881] 88041fa03e78 0001 Sep 29 11:08:39 shelf kernel: [ 262.924883] 88040b1b4000 8106576c 81775ca0 88040030 Sep 29 11:08:39 shelf kernel: [ 262.924886] Call Trace: Sep 29 11:08:39 shelf kernel: [ 262.924887] IRQ [81506188] ? dump_stack+0x41/0x51 Sep 29 11:08:39 shelf kernel: [ 262.924896] [81065707] ? warn_slowpath_common+0x77/0x90 Sep 29 11:08:39 shelf kernel: [ 262.924898] [8106576c] ? warn_slowpath_fmt+0x4c/0x50 Sep 29 11:08:39 shelf kernel: [ 262.924902] [81439af6] ? dev_watchdog+0x236/0x240 Sep 29 11:08:39 shelf kernel: [ 262.924904] [814398c0] ? dev_graft_qdisc+0x70/0x70 Sep 29 11:08:39 shelf kernel: [ 262.924908] [810709c1] ? call_timer_fn+0x31/0x100 Sep 29 11:08:39 shelf kernel: [ 262.924910] [814398c0] ? dev_graft_qdisc+0x70/0x70 Sep 29 11:08:39 shelf kernel: [ 262.924913] [81071ff9] ? run_timer_softirq+0x209/0x2f0 ep 29 11:08:39 shelf kernel: [ 262.924887] IRQ [81506188] ? dump_stack+0x41/0x51 Sep 29 11:08:39 shelf kernel: [ 262.924896] [81065707] ? warn_slowpath_common+0x77/0x90 Sep 29 11:08:39 shelf kernel: [ 262.924898] [8106576c] ? warn_slowpath_fmt+0x4c/0x50 Sep 29 11:08:39 shelf kernel: [ 262.924902] [81439af6] ? dev_watchdog+0x236/0x240 Sep 29 11:08:39 shelf kernel: [ 262.924904] [814398c0] ? dev_graft_qdisc+0x70/0x70 Sep 29 11:08:39 shelf kernel: [ 262.924908] [810709c1] ? call_timer_fn+0x31/0x100 Sep 29 11:08:39 shelf kernel: [ 262.924910] [814398c0] ? dev_graft_qdisc+0x70/0x70 Sep 29 11:08:39 shelf kernel: [ 262.924913] [81071ff9] ? run_timer_softirq+0x209/0x2f0 Sep 29 11:08:39 shelf kernel: [ 262.924916] [8106a5a1] ? __do_softirq+0xf1/0x290 Sep 29 11:08:39 shelf kernel: [ 262.924918] [8106a975] ? irq_exit+0x95/0xa0 Sep 29 11:08:39 shelf kernel: [ 262.924922] [8150f155] ? smp_apic_timer_interrupt+0x45/0x60 Sep 29 11:08:39 shelf kernel: [ 262.924924] [8150d25d] ? apic_timer_interrupt+0x6d/0x80 Sep 29 11:08:39 shelf kernel: [ 262.924925] EOI [81072906] ? get_next_timer_interrupt+0x1d6/0x250 Sep 29 11:08:39 shelf kernel: [ 262.924931] [813d96e2] ? cpuidle_enter_state+0x52/0xc0 Sep 29 11:08:39 shelf kernel: [ 262.924934] [813d96d8] ? cpuidle_enter_state+0x48/0xc0 Sep 29 11:08:39 shelf kernel: [ 262.924937] [810a5d28] ? cpu_startup_entry+0x2f8/0x400 Sep 29 11:08:39 shelf kernel: [ 262.924940] [8190305a] ?
Bug#763325: Solid
I just had a repeat of this dump with the same details and Call Trace. It seemed to happen when the machine was (probably) idle which I suppose fits with a watchdog bug. The other symptoms that I mentioned did not occur this time. ael -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140929133205.GA10203@shelf.conquest
Processed: severity of 763320 is important
Processing commands for cont...@bugs.debian.org: severity 763320 important Bug #763320 [src:linux] linux-image-3.16-2-amd64: intel_idle enabled for Intel Atom S1260, causes high CPU temperature when idle Severity set to 'important' from 'normal' thanks Stopping processing here. Please contact me if you need assistance. -- 763320: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763320 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141199826920082.transcr...@bugs.debian.org
Bug#759323: marked as done (linux-image-3.16-trunk-amd64 : Xorg freezes or the system reboots under glxgears)
Your message dated Mon, 29 Sep 2014 16:04:28 +0100 with message-id 1412003068.9388.43.ca...@decadent.org.uk and subject line Re: Bug#759323: linux-image-3.16-trunk-amd64 : Xorg freezes or the system reboots under glxgears has caused the Debian Bug report #759323, regarding linux-image-3.16-trunk-amd64 : Xorg freezes or the system reboots under glxgears to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 759323: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759323 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: src:linux Version: 3.16-1~exp1 Severity: normal Dear Maintainer, Booting with linux-image-3.16-trunk-amd64. In Xfce, run vblank_mode=1 glxgears. After some seconds, Xorg freezes or the system reboots. I will send you the config files. With the 3.16.1 kernel from upstream, no such issue. Rarely, one reboot after two weeks occurs. CPU : processor : 0 vendor_id : AuthenticAMD cpu family : 21 model : 16 model name : AMD A4-5300 APU with Radeon(tm) HD Graphics stepping: 1 microcode : 0x6001119 -- Package-specific info: ** Kernel log: boot messages should be attached ** Model information sys_vendor: MSI product_name: MS-7721 product_version: 6.0 chassis_vendor: MSI chassis_version: 6.0 bios_vendor: American Megatrends Inc. bios_version: V30.3 board_vendor: MSI board_name: A78M-E35 (MS-7721) board_version: 6.0 ** PCI devices: 00:00.0 Host bridge [0600]: Advanced Micro Devices [AMD] Family 15h (Models 10h-1fh) Processor Root Complex [1022:1410] Subsystem: Micro-Star International Co., Ltd. Device [1462:7721] Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium TAbort- TAbort- MAbort- SERR- PERR- INTx- Latency: 0 00:00.2 IOMMU [0806]: Advanced Micro Devices [AMD] Family 15h (Models 10h-1fh) I/O Memory Management Unit [1022:1419] Subsystem: Micro-Star International Co., Ltd. Device [1462:7721] Control: I/O- Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Latency: 0 Interrupt: pin A routed to IRQ 40 Capabilities: access denied 00:01.0 VGA compatible controller [0300]: Advanced Micro Devices [AMD] nee ATI Device [1002:9993] (prog-if 00 [VGA controller]) Subsystem: Micro-Star International Co., Ltd. Device [1462:7721] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 49 Region 0: Memory at c000 (32-bit, prefetchable) [size=256M] Region 1: I/O ports at f000 [size=256] Region 2: Memory at feb0 (32-bit, non-prefetchable) [size=256K] Expansion ROM at unassigned [disabled] Capabilities: access denied Kernel driver in use: radeon 00:01.1 Audio device [0403]: Advanced Micro Devices [AMD] nee ATI Trinity HDMI Audio Controller [1002:9902] Subsystem: Micro-Star International Co., Ltd. Device [1462:7721] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin B routed to IRQ 50 Region 0: Memory at feb44000 (32-bit, non-prefetchable) [size=16K] Capabilities: access denied Kernel driver in use: snd_hda_intel 00:04.0 PCI bridge [0604]: Advanced Micro Devices [AMD] Family 15h (Models 10h-1fh) Processor Root Port [1022:1414] (prog-if 00 [Normal decode]) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Bus: primary=00, secondary=01, subordinate=01, sec-latency=0 I/O behind bridge: e000-efff Memory behind bridge: fea0-feaf Prefetchable memory behind bridge: d000-d00f Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort+ SERR- PERR-
Bug#763354: Enable support for RTS5129 card reader
Package: src:linux Version: 3.16.3-2 Please enable support for the RTS5129 card reader. Bus 001 Device 005: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129 Card Reader Controller # journalctl 9月 30 00:04:35 jidanni5 systemd-udevd[168]: Network interface NamePolicy= disabled on kernel commandline, ignoring. 9月 30 00:04:35 jidanni5 kernel: mmc0: new high speed SD card at address 0007 9月 30 00:04:35 jidanni5 kernel: mmcblk0: mmc0:0007 SD02G 1.84 GiB 9月 30 00:04:35 jidanni5 kernel: mmcblk0: p1 http://thelastmaimou.wordpress.com/2013/05/16/the-card-reader-bluff-call-it/comment-page-1/ -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/87fvfajt44@jidanni.org
Bug#720735: initramfs-tools: mkinitramfs uses ldd, which is insecure and generates core dumps
Control: retitle -1 initramfs-tools: Use static check for library dependencies instead of ldd Control: severity -1 normal On Sun, 2013-08-25 at 14:38 +0200, Vincent Lefevre wrote: On 2013-08-25 09:53:07 +0100, Ben Hutchings wrote: No, this has a defined meaning in FHS: http://www.pathname.com/fhs/pub/fhs-2.3.html#LIBLTQUALGTALTERNATEFORMATESSENTIAL OK (both the French and English versions of the Wikipedia article didn't mention these directories... I've updated them now). I still think that ldd should be avoided, though. The core dump seems to have been due to a kernel bug, fixed in 3.14.15-1: * [amd64] Reject x32 executables if x32 ABI not supported Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part
Processed: tagging 760127, tagging 760127
Processing commands for cont...@bugs.debian.org: tags 760127 - moreinfo Bug #760127 [initramfs-tools] Cannot find root device if booted without initramfs; MODULES=dep fails Bug #760126 [initramfs-tools] Cannot find root device if booted without initramfs; MODULES=dep fails Removed tag(s) moreinfo. Removed tag(s) moreinfo. tags 760127 + patch Bug #760127 [initramfs-tools] Cannot find root device if booted without initramfs; MODULES=dep fails Bug #760126 [initramfs-tools] Cannot find root device if booted without initramfs; MODULES=dep fails Added tag(s) patch. Added tag(s) patch. thanks Stopping processing here. Please contact me if you need assistance. -- 760126: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760126 760127: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760127 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.14120094946592.transcr...@bugs.debian.org
Processed: Re: Bug#720735: initramfs-tools: mkinitramfs uses ldd, which is insecure and generates core dumps
Processing control commands: retitle -1 initramfs-tools: Use static check for library dependencies instead of ldd Bug #720735 [initramfs-tools] initramfs-tools: mkinitramfs uses ldd, which is insecure and generates core dumps Changed Bug title to 'initramfs-tools: Use static check for library dependencies instead of ldd' from 'initramfs-tools: mkinitramfs uses ldd, which is insecure and generates core dumps' severity -1 normal Bug #720735 [initramfs-tools] initramfs-tools: Use static check for library dependencies instead of ldd Severity set to 'normal' from 'important' -- 720735: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720735 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b720735.14120094225545.transcr...@bugs.debian.org
Bug#685659: marked as done (initramfs-tools: please use blkid to resolve LABEL= and UUID= )
Your message dated Mon, 29 Sep 2014 17:53:44 +0100 with message-id 1412009624.9388.50.ca...@decadent.org.uk and subject line Re: initramfs-tools: please use blkid to resolve LABEL= and UUID= has caused the Debian Bug report #685659, regarding initramfs-tools: please use blkid to resolve LABEL= and UUID= to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 685659: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685659 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: initramfs-tools Version: 0.107 Severity: wishlist Tags: patch It would be nice if the following chage (see attached patch) was made to /usr/share/initramfs-tools/init, which changes the script to uses blkid instead of /dev/disk/by-{label,uuid}. The reason why I consider this an improvement is that it allows df to show the actual device: Filesystem 1K-blocks Used Available Use% Mounted on rootfs 73759976 21773136 48240024 32% / udev102400 10240 0% /dev tmpfs 1610688 816 1609872 1% /run /dev/sdc173759976 21773136 48240024 32% / without this patch, you end up with a much uglier df output, which looks especially horrid for those of us who like 80 character terminals: Filesystem 1K-blocks Used Available Use% Mounted on rootfs 73759976 21773136 48240024 32% / udev 102400 10240 0% /dev tmpfs1610688 816 1609872 1% /run /dev/disk/by-uuid/a623d491-1394-41c9-a820-eedafb2981cf 73759976 21773136 48240024 32% / I've made this change locally, but I suspect other people would appreciate this and consider it an improvement. Thanks, regards, - Ted --- /usr/share/initramfs-tools/init.orig2012-07-09 13:03:57.0 -0400 +++ /usr/share/initramfs-tools/init 2012-08-22 21:18:21.028984845 -0400 @@ -95,10 +95,10 @@ ROOT=${newroot} fi esac - ROOT=/dev/disk/by-label/${ROOT} + ROOT=$(blkid -L ${ROOT}) ;; UUID=*) - ROOT=/dev/disk/by-uuid/${ROOT#UUID=} + ROOT=$(blkid -U ${ROOT#UUID=}) ;; /dev/nfs) [ -z ${BOOT} ] BOOT=nfs -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.5.0-00076-g0cf1598 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages initramfs-tools depends on: ii cpio 2.11-8 ii klibc-utils2.0.1-1 ii kmod 8-2 ii module-init-tools 8-2 ii udev 175-3.1 Versions of packages initramfs-tools recommends: pn busybox | busybox-initramfs | busybox-static none Versions of packages initramfs-tools suggests: ii bash-completion 1:2.0-1 -- no debconf information -- debsums errors found: debsums: changed file /usr/share/initramfs-tools/init (from initramfs-tools package) ---End Message--- ---BeginMessage--- Version: 0.117 Since version 0.117, init uses 'readlink -f' to canonicalise the device name. It does not use blkid but I think it solves the same problem. Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part ---End Message---
Processed: tagging 627547
Processing commands for cont...@bugs.debian.org: tags 627547 - pending Bug #627547 [initramfs-tools] /usr/sbin/update-initramfs: wrong arguments give misleading error message Removed tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. -- 627547: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=627547 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.14120097829520.transcr...@bugs.debian.org
Bug#751488: initramfs-tools: Shell spawned despite panic=0
This bug has not been properly fixed. The init script does not only run panic if it fails to run the real init, but in several earlier error cases. In that case, the 'return' will cause init to continue rather than dropping off the end. I think we must use 'exit' instead of 'return'. Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part
Processed: severity of 729800 is serious, tagging 729800
Processing commands for cont...@bugs.debian.org: severity 729800 serious Bug #729800 [initramfs-tools] Packages including /usr/sbin/update-initramfs must Provide and Conflict with linux-initramfs-tool Severity set to 'serious' from 'normal' tags 729800 + patch Bug #729800 [initramfs-tools] Packages including /usr/sbin/update-initramfs must Provide and Conflict with linux-initramfs-tool Added tag(s) patch. thanks Stopping processing here. Please contact me if you need assistance. -- 729800: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=729800 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141201049915240.transcr...@bugs.debian.org
Processed: forcibly merging 707286 720716
Processing commands for cont...@bugs.debian.org: forcemerge 707286 720716 Bug #707286 [initramfs-tools] linux-image-3.8-1-amd64: makes system unbootable Bug #616689 [initramfs-tools] Root-on-LVM setup fails often due to timing issues Bug #633024 [initramfs-tools] initramfs-tools: Race condition when root filesystem is on a LV and mdadm array Bug #678696 [initramfs-tools] Event based block device handling (fixes USB and nested devices problem) Bug #712984 [initramfs-tools] linux-image-3.9-1-amd64: Unable to find LVM volume system/root Bug #712999 [initramfs-tools] linux-image-3.9-1-amd64: Unable to find LVM volume Bug #718533 [initramfs-tools] linux-image-3.10-1-amd64 fails to boot with RAID5 Bug #742962 [initramfs-tools] fails to mount root when root is on lvm. Bug #752381 [initramfs-tools] initramfs-tools: does not activate logical volume before trying to mount root filesystem on LVM Bug #720716 [initramfs-tools] initramfs-tools: workaround in 707286 solves serious problem Severity set to 'serious' from 'normal' Marked as found in versions initramfs-tools/0.99, initramfs-tools/0.109.1, initramfs-tools/0.106, initramfs-tools/0.98.8, initramfs-tools/0.98.7, initramfs-tools/0.112, and initramfs-tools/0.115~bpo70+1. Bug #616689 [initramfs-tools] Root-on-LVM setup fails often due to timing issues Bug #633024 [initramfs-tools] initramfs-tools: Race condition when root filesystem is on a LV and mdadm array Bug #678696 [initramfs-tools] Event based block device handling (fixes USB and nested devices problem) Bug #712984 [initramfs-tools] linux-image-3.9-1-amd64: Unable to find LVM volume system/root Bug #712999 [initramfs-tools] linux-image-3.9-1-amd64: Unable to find LVM volume Bug #718533 [initramfs-tools] linux-image-3.10-1-amd64 fails to boot with RAID5 Bug #742962 [initramfs-tools] fails to mount root when root is on lvm. Bug #752381 [initramfs-tools] initramfs-tools: does not activate logical volume before trying to mount root filesystem on LVM Merged 616689 633024 678696 707286 712984 712999 718533 720716 742962 752381 thanks Stopping processing here. Please contact me if you need assistance. -- 616689: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616689 633024: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633024 678696: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678696 707286: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707286 712984: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=712984 712999: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=712999 718533: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718533 720716: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720716 742962: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742962 752381: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752381 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141201046415063.transcr...@bugs.debian.org
Processed (with 1 errors): reopening 751488, merging 751488 751640
Processing commands for cont...@bugs.debian.org: reopen 751488 Bug #751488 {Done: Michael Prokop m...@debian.org} [initramfs-tools] initramfs-tools: Shell spawned despite panic=0 'reopen' may be inappropriate when a bug has been closed with a version; all fixed versions will be cleared, and you may need to re-add them. Bug reopened No longer marked as fixed in versions initramfs-tools/0.116. merge 751488 751640 Bug #751488 [initramfs-tools] initramfs-tools: Shell spawned despite panic=0 Unable to merge bugs because: severity of #751640 is 'normal' not 'critical' Failed to merge 751488: Did not alter merged bugs thanks Stopping processing here. Please contact me if you need assistance. -- 751488: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751488 751640: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751640 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141201073117358.transcr...@bugs.debian.org
Processed: forcibly merging 751488 751640
Processing commands for cont...@bugs.debian.org: forcemerge 751488 751640 Bug #751488 [initramfs-tools] initramfs-tools: Shell spawned despite panic=0 Bug #751640 [initramfs-tools] initramfs-tools panic= may not always work Severity set to 'critical' from 'normal' Marked as found in versions initramfs-tools/0.115 and initramfs-tools/0.109.1. Added tag(s) patch. Merged 751488 751640 thanks Stopping processing here. Please contact me if you need assistance. -- 751488: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751488 751640: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751640 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141201074217406.transcr...@bugs.debian.org
Bug#763320: Supported SoC CPU states
The SoC is identified by cpu family: 6 model: 54 model name: Intel(R) Atom(TM) CPU S1260 @ 2.00GHz stepping: 9 microcode: 0x10d According to the data sheet at http://www.intel.de/content/dam/www/public/us/en/documents/datasheets/atom-processor-s1200-datasheet-vol-1.pdf the SoC supports the C1, C2, C4 and C6 CPU states. The previously mentioned kernel parameter switches to acpi_idle, but also limits to C0. Syslog states ACPI: processor limited to max C-state 0“. To get stable operation as with kernel 3.14, it is sufficient to switch to acpi_idle by appending intel_idle.max_cstate=0“ to the kernel parameters; processor.max_cstate=0“ is not necessary. There is no indication in the syslog that this limits also to C0, but powertop doesn’t provide any idle stats as with intel_idle. smime.p7s Description: S/MIME cryptographic signature
Bug#752789: initramfs-tools: mkinitramfs doesn't honor /usr/share/initramfs-tools/modules
On Thu, 2014-06-26 at 17:33 +0200, Lukas Anzinger wrote: Package: initramfs-tools Version: 0.115 Severity: normal Hi, mkinitramfs (the tool that is called from update-initramfs) doesn't honor /usr/share/initramfs-tools/modules, it only honors /etc/initramfs-tools/modules and /usr/share/initramfs-tools/modules.d. This is unfortunate because /usr/share/initramfs-tools/modules explicitly states that the modules listed in that file are included in the initramfs. The file /usr/share/initramfs-tools/modules should therefore be either added to the list of files that are processed or removed altogether. /usr/share/initramfs-tools/modules is the 'shipped' version of /etc/initramfs-tools/modules, and is copied to the latter file if it does not already exist. The comment is of course correct in the copy. And user-edittable configuration files are always installed in /etc, not /usr. Normally we would include /etc/initramfs-tools/modules in the package as a conffile, and then dpkg would take care of preserving any customised version. However, the installer may in some cases add modules to this file, which could result in dpkg later claiming that it's been edited by the user. I think the best way to deal with this would be to add a comment clarifying which file path is actually read. Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part
Bug#763305: linux-image-3.16-2-amd64: debian patch of linux kernel radeon driver erroneously prevents firmware loading
On Mon, 2014-09-29 at 00:24 -0400, Colin Worth wrote: Package: src:linux Version: 3.16.3-2 Severity: important Dear Maintainer, In order to use the radeon free driver with my HD6xxx series Radeon card on my EFI boot laptop, I downloaded a fresh kernel from kernel.org and built it with the following config, in order to add the required firmware for the Radeon card into the kernel, as required. CONFIG_FIRMWARE_IN_KERNEL=y CONFIG_EXTRA_FIRMWARE_DIR=/lib/firmware CONFIG_EXTRA_FIRMWARE=radeon/ARUBA_me.bin radeon/ARUBA_pfp.bin radeon/ARUBA_rlc.bin {} After this, the driver loaded successfully: Sep 28 22:28:30 worthlaptop kernel: [4.972516] [drm] radeon kernel modesetting enabled. Sep 28 22:28:30 worthlaptop kernel: [4.976621] [drm] initializing kernel modesetting (TURKS 0x1002:0x6741 0x106B:0x00E2) However, recently I decided to build the kernel the Debian way, to get the latest kernel patches. In particular, I got: https://github.com/BlankOn/linux-debian/blob/master/debian/patches/bugfix/all/radeon-firmware-is-required-for-drm-and-kms-on-r600-onward.patch After this patch was applied, I got this error when trying to boot: Sep 28 15:47:12 worthlaptop kernel: [2.668496] [drm] radeon kernel modesetting enabled. Sep 28 15:47:12 worthlaptop kernel: [2.668560] [drm:radeon_pci_probe] *ERROR* radeon kernel modesetting for R600 or later requires firmware-linux-nonfree. The purpose of the patch seems to have been to provide a quick fix to mitigate the number of bug reports related to missing firmware, by issuing a helpful message in the kernel log. Not just that - the driver tries to recover after finding that firmware is missing, but this code path is not well tested and didn't work on many systems. It is better to detect the error earlier and then the system can fall back to a generic framebuffer driver. But this didn't work - I have firmware in the correct location, and loaded into the kernel, but I still get the error messsage, and the driver fails to load, simply due to the patch. So the effect is to wrongly prevent the driver from loading. [...] Back to the kernel patch: the source of the problem is that the patch uses the call __ kern_path(/lib/firmware/radeon, LOOKUP_DIRECTORY) __ to try to check whether the user has firmware installed. I am not familiar with how the kern_path call works, but since I have this directory, and the call failed, it is definitely not checking the hard drive (probably obvious). Perhaps if I had set the kernel config CONFIG_EXTRA_FIRMWARE_DIR=/lib/firmware/radeon, it would work as intended? [...] I think the problem is that with the driver built-in this code runs before the hard drive has been mounted. I think I will revise the patch so the check only applies when the driver is built as a module. Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part
Bug#755518: marked as done (laptop-mode-tools: fails to boot when /usr is on LVM)
Your message dated Mon, 29 Sep 2014 18:55:31 +0100 with message-id 1412013331.9388.58.ca...@decadent.org.uk and subject line Re: laptop-mode-tools: fails to boot when /usr is on LVM has caused the Debian Bug report #755518, regarding laptop-mode-tools: fails to boot when /usr is on LVM to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 755518: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=755518 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: laptop-mode-tools Version: 1.65-2 Severity: serious Justification: Breaks normal system boot The lmt-udev script appears to be breaking systemd boot for me due to introducing a deadlock / dependency circle. Based on usage of debug-shell.service, it appears that systemd is waiting for udev to settle, which is needed for the lvm2 volumes to be present and active, which is needed for /usr to be mounted. However, the lmt-udev script is waiting for /usr to be mounted too, and this appears to be blocking the udev settle. The timeout for lmt-udev to wait for /usr is as long as the timeout for udevadm settle, and so eventually this times out and the system tries to limp along and finish booting, but many things are not started properly in this case. The lmt-udev script appears to be trying to run itself in the background, but this is not successful, as udev / systemd are clearly waiting on it. Based on the arguments to the script, it appears that this is related to usb autosuspend. Removing laptop-mode-tools causes my system to boot properly. -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.14-1-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages laptop-mode-tools depends on: ii lsb-base4.1+Debian13 ii psmisc 22.21-2 ii util-linux 2.20.1-5.8 Versions of packages laptop-mode-tools recommends: ii ethtool 1:3.13-1 ii hdparm 9.43-1.1 ii net-tools 1.60-26 ii python-qt4 4.11.1+dfsg-1 pn sdparm none ii udev208-6 ii wireless-tools 30~pre9-8 Versions of packages laptop-mode-tools suggests: ii acpid 1:2.0.22-3 pn hal none ii python 2.7.8-1 -- Configuration Files: /etc/laptop-mode/conf.d/cpufreq.conf changed: DEBUG=0 CONTROL_CPU_FREQUENCY=auto BATT_CPU_MAXFREQ=fastest BATT_CPU_MINFREQ=slowest BATT_CPU_GOVERNOR=powersave BATT_CPU_IGNORE_NICE_LOAD=1 LM_AC_CPU_MAXFREQ=fastest LM_AC_CPU_MINFREQ=slowest LM_AC_CPU_GOVERNOR=performance LM_AC_CPU_IGNORE_NICE_LOAD=0 NOLM_AC_CPU_MAXFREQ=fastest NOLM_AC_CPU_MINFREQ=slowest NOLM_AC_CPU_GOVERNOR=performance NOLM_AC_CPU_IGNORE_NICE_LOAD=0 CONTROL_CPU_THROTTLING=0 BATT_CPU_THROTTLING=medium LM_AC_CPU_THROTTLING=medium NOLM_AC_CPU_THROTTLING=minimum /etc/laptop-mode/conf.d/usb-autosuspend.conf changed: DEBUG=0 CONTROL_USB_AUTOSUSPEND=auto AUTOSUSPEND_USE_WHITELIST=0 AUTOSUSPEND_USBID_BLACKLIST=046d:c245 1c88:003f 1c88:0007 AUTOSUSPEND_USBTYPE_BLACKLIST= AUTOSUSPEND_USBID_WHITELIST= AUTOSUSPEND_USBTYPE_WHITELIST= BATT_SUSPEND_USB=1 LM_AC_SUSPEND_USB=0 NOLM_AC_SUSPEND_USB=0 AUTOSUSPEND_TIMEOUT=2 -- no debconf information ---End Message--- ---BeginMessage--- Version: 0.117 /usr is now mounted by the initramfs. We might have to disable this again if booting with sysvinit, but it will still be done if booting with systemd. Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part ---End Message---
Re: Uploading linux (3.2.63-1)
On Sun, 2014-09-28 at 18:42 +0100, Adam D. Barratt wrote: On Wed, 2014-09-24 at 03:54 +0100, Ben Hutchings wrote: I intend to upload linux version 3.2.63-1 to stable-proposed-updates later this week. This will include all the fixes that went into stable updates 3.2.61-63 inclusive, including fixes for these security issues: [...] Flagged for acceptance in to p-u; thanks. and built everywhere except s390{,x}, where it failed with an ABI change. Regards, Adam -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1412015358.25283.14.ca...@jacala.jungle.funky-badger.org
Bug#752789: initramfs-tools: mkinitramfs doesn't honor /usr/share/initramfs-tools/modules
On Mon, Sep 29, 2014 at 7:47 PM, Ben Hutchings b...@decadent.org.uk wrote: I think the best way to deal with this would be to add a comment clarifying which file path is actually read. Yes, that would be really helpful! -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CACB1Aevxtv8O1k=v2m9sqljx7fi5lww4q+q-buwc0x2cxlz...@mail.gmail.com
Bug#752789: initramfs-tools: mkinitramfs doesn't honor /usr/share/initramfs-tools/modules
On Mon, Sep 29, 2014 at 7:47 PM, Ben Hutchings b...@decadent.org.uk wrote: /usr/share/initramfs-tools/modules is the 'shipped' version of /etc/initramfs-tools/modules, and is copied to the latter file if it does not already exist. The comment is of course correct in the copy. And user-edittable configuration files are always installed in /etc, not /usr. Normally we would include /etc/initramfs-tools/modules in the package as a conffile, and then dpkg would take care of preserving any customised version. However, the installer may in some cases add modules to this file, which could result in dpkg later claiming that it's been edited by the user. I think the best way to deal with this would be to add a comment clarifying which file path is actually read. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CACB1AevZMOD7c0b+edrFt9gY9iNQO4gjK5Wcb7jk0=hnnmx...@mail.gmail.com
Bug#762812: Same on i386
Hi, I have the same issue since yesterday when debian testing updated to 3.16: Linux sirius 3.16-2-686-pae #1 SMP Debian 3.16.3-2 (2014-09-20) i686 GNU/Linux [55356.351794] unknown: hw csum failure [55356.351820] CPU: 0 PID: 3512 Comm: dnsmasq Not tainted 3.16-2-686-pae #1 Debian 3.16.3-2 [55356.351829] Hardware name:/CN700-8237, BIOS 6.00 PG 11/30/2007 [55356.351838] f4a73340 f3f3fbd0 c14747f8 f3f3fcf0 c1394419 f3f3fbc0 87e2 [55356.351861] 4a7fb580 f4a73340 f3ff4340 f3f3fdd8 f3f3fc10 c1445123 f3f3fbfc [55356.351883] f3f3fc00 f3ff45c4 f3ff4398 0053 0053 [55356.351904] Call Trace: [55356.351937] [c14747f8] ? dump_stack+0x3e/0x4e [55356.351958] [c1394419] ? skb_copy_and_csum_datagram_iovec+0xe9/0xf0 [55356.351981] [c1445123] ? udpv6_recvmsg+0x213/0x570 [55356.351999] [c140283f] ? inet_recvmsg+0x6f/0x90 [55356.352089] [c1386ef1] ? sock_recvmsg+0x81/0xa0 [55356.352110] [c117c470] ? poll_select_copy_remaining+0x100/0x100 [55356.352125] [c117c470] ? poll_select_copy_remaining+0x100/0x100 [55356.352139] [c1392f06] ? verify_iovec+0x46/0xc0 [55356.352153] [c1386e70] ? kernel_sendmsg+0x40/0x40 [55356.352167] [c138718b] ? ___sys_recvmsg.part.17+0xfb/0x1c0 [55356.352181] [c1386e70] ? kernel_sendmsg+0x40/0x40 [55356.352196] [c117c470] ? poll_select_copy_remaining+0x100/0x100 [55356.352216] [c13898d1] ? sock_init_data+0x91/0x200 [55356.352232] [c1388118] ? __sys_recvmsg+0x48/0x80 [55356.352248] [c1388b8d] ? SYSC_socketcall+0x85d/0xaa0 [55356.352264] [c117ecce] ? dput+0x1e/0x140 [55356.352278] [c117cf77] ? core_sys_select+0x1c7/0x260 [55356.352299] [c11759a5] ? filename_lookup+0x25/0xb0 [55356.352316] [c1253221] ? radix_tree_lookup+0x11/0x20 [55356.352334] [c118db26] ? __inode_wait_for_writeback+0x56/0x90 [55356.352349] [c147a885] ? do_IRQ+0x45/0xd0 [55356.352366] [c11824b1] ? destroy_inode+0x31/0x50 [55356.352382] [c11824b1] ? destroy_inode+0x31/0x50 [55356.352396] [c117ed45] ? dput+0x95/0x140 [55356.352410] [c117ed45] ? dput+0x95/0x140 [55356.352423] [c116c8c8] ? __fput+0x148/0x1b0 [55356.352437] [c117a733] ? do_fcntl+0x243/0x4e0 [55356.352451] [c117d0aa] ? SyS_select+0x9a/0xc0 [55356.352464] [c117ab18] ? SyS_fcntl64+0xa8/0xf0 [55356.352479] [c1388e93] ? SyS_socketcall+0x13/0x20 [55356.352498] [c147971f] ? sysenter_do_call+0x12/0x12 The stack trace is little different, also on different error occurences. The only static thing is the hw csum failure. It does not happen with earlier kernel. Dnsmasq did not crush and worked correctly. :-) Hardware: 00:00.0 Host bridge: VIA Technologies, Inc. CN700/VN800/P4M800CE/Pro Host Bridge 00:00.1 Host bridge: VIA Technologies, Inc. CN700/VN800/P4M800CE/Pro Host Bridge 00:00.2 Host bridge: VIA Technologies, Inc. CN700/VN800/P4M800CE/Pro Host Bridge 00:00.3 Host bridge: VIA Technologies, Inc. PT890 Host Bridge 00:00.4 Host bridge: VIA Technologies, Inc. CN700/VN800/P4M800CE/Pro Host Bridge 00:00.7 Host bridge: VIA Technologies, Inc. CN700/VN800/P4M800CE/Pro Host Bridge 00:01.0 PCI bridge: VIA Technologies, Inc. VT8237/VX700 PCI Bridge 00:0a.0 FireWire (IEEE 1394): VIA Technologies, Inc. VT6306/7/8 [Fire II(M)] IEEE 1394 OHCI Controller (rev 80) 00:0b.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8100/8101L/8139 PCI Fast Ethernet Adapter (rev 10) 00:0f.0 IDE interface: VIA Technologies, Inc. VIA VT6420 SATA RAID Controller (rev 80) 00:0f.1 IDE interface: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06) 00:10.0 USB controller: VIA Technologies, Inc. VT82x UHCI USB 1.1 Controller (rev 81) 00:10.1 USB controller: VIA Technologies, Inc. VT82x UHCI USB 1.1 Controller (rev 81) 00:10.2 USB controller: VIA Technologies, Inc. VT82x UHCI USB 1.1 Controller (rev 81) 00:10.3 USB controller: VIA Technologies, Inc. VT82x UHCI USB 1.1 Controller (rev 81) 00:10.4 USB controller: VIA Technologies, Inc. USB 2.0 (rev 86) 00:11.0 ISA bridge: VIA Technologies, Inc. VT8237 ISA bridge [KT600/K8T800/K8T890 South] 00:11.5 Multimedia audio controller: VIA Technologies, Inc. VT8233/A/8235/8237 AC97 Audio Controller (rev 60) 00:12.0 Ethernet controller: VIA Technologies, Inc. VT6102 [Rhine-II] (rev 78) 01:00.0 VGA compatible controller: VIA Technologies, Inc. CN700/P4M800 Pro/P4M800 CE/VN800 Graphics [S3 UniChrome Pro] (rev 01) - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/033601cfdc2d$6dd023f0$49706bd0$@thetaphi.de
Re: Uploading linux (3.2.63-1)
On Mon, 2014-09-29 at 19:29 +0100, Adam D. Barratt wrote: On Sun, 2014-09-28 at 18:42 +0100, Adam D. Barratt wrote: On Wed, 2014-09-24 at 03:54 +0100, Ben Hutchings wrote: I intend to upload linux version 3.2.63-1 to stable-proposed-updates later this week. This will include all the fixes that went into stable updates 3.2.61-63 inclusive, including fixes for these security issues: [...] Flagged for acceptance in to p-u; thanks. and built everywhere except s390{,x}, where it failed with an ABI change. We can ignore that change, but I forgot to do that. (We had the same build failure in 3.14.10-1.) Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part
[PATCH v2 1/2] [klibc] Implement realpath()
This is needed as the basis for the readlink -f option. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- v2: Don't implement the BSD/GNU extension of allowing a non-existent last part. Use open(O_PATH) and procfs to get resolved name from the kernel. --- a/usr/include/stdlib.h +++ b/usr/include/stdlib.h @@ -92,4 +92,6 @@ static __inline__ int grantpt(int __fd) return 0; /* devpts does this all for us! */ } +__extern char *realpath(const char *, char *); + #endif /* _STDLIB_H */ --- a/usr/klibc/Kbuild +++ b/usr/klibc/Kbuild @@ -60,7 +60,7 @@ klib-y += vsnprintf.o snprintf.o vsprint send.o recv.o \ access.o chmod.o chown.o dup2.o mknod.o poll.o rename.o stat.o \ lchown.o link.o rmdir.o unlink.o utimes.o lstat.o mkdir.o \ - readlink.o select.o symlink.o pipe.o \ + readlink.o realpath.o select.o symlink.o pipe.o \ ctype/isalnum.o ctype/isalpha.o ctype/isascii.o \ ctype/isblank.o ctype/iscntrl.o ctype/isdigit.o \ ctype/isgraph.o ctype/islower.o ctype/isprint.o \ --- /dev/null +++ b/usr/klibc/realpath.c @@ -0,0 +1,45 @@ +#include fcntl.h +#include limits.h +#include stdlib.h +#include sys/types.h +#include unistd.h + +/* + * Note that this requires name to refer to an existing file. This is + * correct according to POSIX. However, BSD and GNU implementations + * also allow name to refer to a non-existing file in an existing + * directory. + */ + +char *realpath(const char *name, char *resolved_name) +{ + static const char proc_fd_prefix[] = /proc/self/fd/; + char proc_fd_name[sizeof(proc_fd_prefix) + sizeof(int) * 3]; + int allocated = 0; + int fd; + ssize_t len; + + /* Open for path lookup only */ + fd = open(name, O_PATH); + if (fd 0) + return NULL; + + if (!resolved_name) { + resolved_name = malloc(PATH_MAX); + if (!resolved_name) + return NULL; + allocated = 1; + } + + /* Use procfs to read back the resolved name */ + sprintf(proc_fd_name, %s%d, proc_fd_prefix, fd); + len = readlink(proc_fd_name, resolved_name, PATH_MAX - 1); + if (len 0) { + if (allocated) + free(resolved_name); + return NULL; + } + + resolved_name[len] = 0; + return resolved_name; +} -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Re: Bug#763209: general: laptop panel no longer powers off
tags 763209 - moreinfo reassign 763209 src:linux found 763209 linux-image-3.14-2-amd64 thanks Hey, I'm reassigning your bug to Debian Kernel Team (src:linux). Just on a sidenote - yes, xserver-xorg-core was updated on 22 September but then it was updated again on 28 September :) A short summary of the original filling: Allan is running testing. Since he upgraded kernel to linux-image-3.14-2-amd64, DPMS can no longer power the monitor off. Running 'xset dpms force off' doesn't work either. There are no visible errors in his dmesg output. More information is available in his original filling at [1]. Regards, T. [1] https://bugs.debian.org/763209 signature.asc Description: OpenPGP digital signature
Bug#763320: linux-image-3.16-2-amd64: intel_idle enabled for Intel Atom S1260, causes high CPU temperature when idle
On Mon, 2014-09-29 at 11:57 +0200, Christophe Thil wrote: Package: src:linux Version: 3.16.3-2 Severity: normal Dear Maintainer, with Kernel 3.16, intel_idle is enabled for the Intel Atom S1260 CPU (Centerton SoC). This leads to a +20°C temperature increase when the CPU is idle, exceeding the 100°C alarm threshold for passive cooled systems like the Supermicro X9SBAA-F. With 3.14, intel_idle was blacklisted for this CPU, which runs fine. If 3.16 is booted with intel_idle.max_cstate=0 processor.max_cstate=0, which disables the intel_idle, the CPU also stays cool. [...] It looks like the relevant change is: commit acead1b0fac5b10d0ae3f1cc5f7820b9f9f924f5 Author: Jan Kiszka jan.kis...@siemens.com Date: Sat Jan 25 22:24:22 2014 +0100 intel_idle: Add CPU model 54 (Atom N2000 series) Add CPU ID for Atom N2600/N2800 processors. Datasheets indicate support for this, detailed information about potential quirks or limitations are missing, though. So we just reuse the definition for the previous ATOM series. [...] as those processors are part of the same Atom generation as Centerton. I think that more specific ID matching is required here. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Processing of linux_3.2.63-2_multi.changes
linux_3.2.63-2_multi.changes uploaded successfully to localhost along with the files: linux_3.2.63-2.dsc linux_3.2.63-2.debian.tar.xz linux-doc-3.2_3.2.63-2_all.deb linux-support-3.2.0-4_3.2.63-2_all.deb linux-manual-3.2_3.2.63-2_all.deb linux-source-3.2_3.2.63-2_all.deb Greetings, Your Debian queue daemon (running on host franck.debian.org) -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e1xyktk-0003qc...@franck.debian.org
linux_3.2.63-2_multi.changes ACCEPTED into proposed-updates-stable-new
Mapping wheezy to stable. Mapping stable to proposed-updates. Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Mon, 29 Sep 2014 22:35:33 +0100 Source: linux Binary: linux-source-3.2 linux-doc-3.2 linux-manual-3.2 linux-support-3.2.0-4 linux-libc-dev linux-headers-3.2.0-4-all linux-headers-3.2.0-4-all-alpha linux-headers-3.2.0-4-common linux-image-3.2.0-4-alpha-generic linux-headers-3.2.0-4-alpha-generic linux-image-3.2.0-4-alpha-smp linux-headers-3.2.0-4-alpha-smp linux-image-3.2.0-4-alpha-legacy linux-headers-3.2.0-4-alpha-legacy linux-headers-3.2.0-4-all-amd64 kernel-image-3.2.0-4-amd64-di nic-modules-3.2.0-4-amd64-di nic-extra-modules-3.2.0-4-amd64-di nic-wireless-modules-3.2.0-4-amd64-di nic-shared-modules-3.2.0-4-amd64-di serial-modules-3.2.0-4-amd64-di usb-serial-modules-3.2.0-4-amd64-di ppp-modules-3.2.0-4-amd64-di pata-modules-3.2.0-4-amd64-di cdrom-core-modules-3.2.0-4-amd64-di firewire-core-modules-3.2.0-4-amd64-di scsi-core-modules-3.2.0-4-amd64-di scsi-modules-3.2.0-4-amd64-di scsi-common-modules-3.2.0-4-amd64-di scsi-extra-modules-3.2.0-4-amd64-di plip-modules-3.2.0-4-amd64-di floppy-modules-3.2.0-4-amd64-di loop-modules-3.2.0-4-amd64-di btrfs-modules-3.2.0-4-amd64-di ext2-modules-3.2.0-4-amd64-di ext3-modules-3.2.0-4-amd64-di ext4-modules-3.2.0-4-amd64-di isofs-modules-3.2.0-4-amd64-di jfs-modules-3.2.0-4-amd64-di ntfs-modules-3.2.0-4-amd64-di reiserfs-modules-3.2.0-4-amd64-di xfs-modules-3.2.0-4-amd64-di fat-modules-3.2.0-4-amd64-di ufs-modules-3.2.0-4-amd64-di qnx4-modules-3.2.0-4-amd64-di md-modules-3.2.0-4-amd64-di multipath-modules-3.2.0-4-amd64-di usb-modules-3.2.0-4-amd64-di usb-storage-modules-3.2.0-4-amd64-di pcmcia-storage-modules-3.2.0-4-amd64-di fb-modules-3.2.0-4-amd64-di input-modules-3.2.0-4-amd64-di event-modules-3.2.0-4-amd64-di mouse-modules-3.2.0-4-amd64-di irda-modules-3.2.0-4-amd64-di parport-modules-3.2.0-4-amd64-di nic-pcmcia-modules-3.2.0-4-amd64-di pcmcia-modules-3.2.0-4-amd64-di nic-usb-modules-3.2.0-4-amd64-di sata-modules-3.2.0-4-amd64-di core-modules-3.2.0-4-amd64-di acpi-modules-3.2.0-4-amd64-di i2c-modules-3.2.0-4-amd64-di crc-modules-3.2.0-4-amd64-di crypto-modules-3.2.0-4-amd64-di crypto-dm-modules-3.2.0-4-amd64-di efi-modules-3.2.0-4-amd64-di ata-modules-3.2.0-4-amd64-di mmc-core-modules-3.2.0-4-amd64-di mmc-modules-3.2.0-4-amd64-di nbd-modules-3.2.0-4-amd64-di squashfs-modules-3.2.0-4-amd64-di speakup-modules-3.2.0-4-amd64-di virtio-modules-3.2.0-4-amd64-di uinput-modules-3.2.0-4-amd64-di sound-modules-3.2.0-4-amd64-di zlib-modules-3.2.0-4-amd64-di hyperv-modules-3.2.0-4-amd64-di udf-modules-3.2.0-4-amd64-di fuse-modules-3.2.0-4-amd64-di linux-image-3.2.0-4-amd64 linux-headers-3.2.0-4-amd64 linux-image-3.2.0-4-amd64-dbg xen-linux-system-3.2.0-4-amd64 linux-headers-3.2.0-4-common-rt linux-image-3.2.0-4-rt-amd64 linux-headers-3.2.0-4-rt-amd64 linux-image-3.2.0-4-rt-amd64-dbg linux-headers-3.2.0-4-all-armel kernel-image-3.2.0-4-iop32x-di nic-modules-3.2.0-4-iop32x-di nic-shared-modules-3.2.0-4-iop32x-di usb-serial-modules-3.2.0-4-iop32x-di ppp-modules-3.2.0-4-iop32x-di pata-modules-3.2.0-4-iop32x-di cdrom-core-modules-3.2.0-4-iop32x-di scsi-core-modules-3.2.0-4-iop32x-di loop-modules-3.2.0-4-iop32x-di ipv6-modules-3.2.0-4-iop32x-di btrfs-modules-3.2.0-4-iop32x-di ext2-modules-3.2.0-4-iop32x-di ext3-modules-3.2.0-4-iop32x-di ext4-modules-3.2.0-4-iop32x-di isofs-modules-3.2.0-4-iop32x-di jffs2-modules-3.2.0-4-iop32x-di jfs-modules-3.2.0-4-iop32x-di reiserfs-modules-3.2.0-4-iop32x-di fat-modules-3.2.0-4-iop32x-di md-modules-3.2.0-4-iop32x-di multipath-modules-3.2.0-4-iop32x-di usb-modules-3.2.0-4-iop32x-di usb-storage-modules-3.2.0-4-iop32x-di event-modules-3.2.0-4-iop32x-di nic-usb-modules-3.2.0-4-iop32x-di sata-modules-3.2.0-4-iop32x-di core-modules-3.2.0-4-iop32x-di crc-modules-3.2.0-4-iop32x-di crypto-modules-3.2.0-4-iop32x-di crypto-dm-modules-3.2.0-4-iop32x-di ata-modules-3.2.0-4-iop32x-di nbd-modules-3.2.0-4-iop32x-di squashfs-modules-3.2.0-4-iop32x-di zlib-modules-3.2.0-4-iop32x-di udf-modules-3.2.0-4-iop32x-di fuse-modules-3.2.0-4-iop32x-di kernel-image-3.2.0-4-kirkwood-di nic-modules-3.2.0-4-kirkwood-di nic-shared-modules-3.2.0-4-kirkwood-di usb-serial-modules-3.2.0-4-kirkwood-di ppp-modules-3.2.0-4-kirkwood-di cdrom-core-modules-3.2.0-4-kirkwood-di scsi-core-modules-3.2.0-4-kirkwood-di loop-modules-3.2.0-4-kirkwood-di ipv6-modules-3.2.0-4-kirkwood-di btrfs-modules-3.2.0-4-kirkwood-di ext2-modules-3.2.0-4-kirkwood-di ext3-modules-3.2.0-4-kirkwood-di ext4-modules-3.2.0-4-kirkwood-di isofs-modules-3.2.0-4-kirkwood-di jfs-modules-3.2.0-4-kirkwood-di reiserfs-modules-3.2.0-4-kirkwood-di fat-modules-3.2.0-4-kirkwood-di minix-modules-3.2.0-4-kirkwood-di md-modules-3.2.0-4-kirkwood-di multipath-modules-3.2.0-4-kirkwood-di usb-modules-3.2.0-4-kirkwood-di usb-storage-modules-3.2.0-4-kirkwood-di fb-modules-3.2.0-4-kirkwood-di input-modules-3.2.0-4-kirkwood-di
Processed: Re: Bug#763209: general: laptop panel no longer powers off
Processing commands for cont...@bugs.debian.org: tags 763209 - moreinfo Bug #763209 [general] general: laptop panel no longer powers off Removed tag(s) moreinfo. reassign 763209 src:linux Bug #763209 [general] general: laptop panel no longer powers off Bug reassigned from package 'general' to 'src:linux'. Ignoring request to alter found versions of bug #763209 to the same values previously set Ignoring request to alter fixed versions of bug #763209 to the same values previously set found 763209 linux-image-3.14-2-amd64 Bug #763209 [src:linux] general: laptop panel no longer powers off The source 'linux' and version 'linux-image-3.14-2-amd64' do not appear to match any binary packages Marked as found in versions linux/linux-image-3.14-2-amd64. thanks Stopping processing here. Please contact me if you need assistance. -- 763209: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763209 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141203565723554.transcr...@bugs.debian.org
Processing of firmware-nonfree_0.43~bpo70+1_multi.changes
firmware-nonfree_0.43~bpo70+1_multi.changes uploaded successfully to localhost along with the files: firmware-nonfree_0.43~bpo70+1.dsc firmware-nonfree_0.43~bpo70+1.tar.gz firmware-linux_0.43~bpo70+1_all.deb firmware-adi_0.43~bpo70+1_all.deb firmware-atheros_0.43~bpo70+1_all.deb firmware-bnx2_0.43~bpo70+1_all.deb firmware-bnx2x_0.43~bpo70+1_all.deb firmware-brcm80211_0.43~bpo70+1_all.deb firmware-intelwimax_0.43~bpo70+1_all.deb firmware-ipw2x00_0.43~bpo70+1_all.deb firmware-ivtv_0.43~bpo70+1_all.deb firmware-iwlwifi_0.43~bpo70+1_all.deb firmware-libertas_0.43~bpo70+1_all.deb firmware-linux-nonfree_0.43~bpo70+1_all.deb firmware-myricom_0.43~bpo70+1_all.deb firmware-netxen_0.43~bpo70+1_all.deb firmware-qlogic_0.43~bpo70+1_all.deb firmware-ralink_0.43~bpo70+1_all.deb firmware-realtek_0.43~bpo70+1_all.deb firmware-samsung_0.43~bpo70+1_all.deb firmware-ti-connectivity_0.43~bpo70+1_all.deb Greetings, Your Debian queue daemon (running on host franck.debian.org) -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e1xyl3u-0005in...@franck.debian.org
Processed: tagging 763320 ...
Processing commands for cont...@bugs.debian.org: tags 763320 + upstream Bug #763320 [src:linux] linux-image-3.16-2-amd64: intel_idle enabled for Intel Atom S1260, causes high CPU temperature when idle Added tag(s) upstream. forwarded 763320 http://mid.gmane.org/1412035987.9388.72.ca...@decadent.org.uk Bug #763320 [src:linux] linux-image-3.16-2-amd64: intel_idle enabled for Intel Atom S1260, causes high CPU temperature when idle Set Bug forwarded-to-address to 'http://mid.gmane.org/1412035987.9388.72.ca...@decadent.org.uk'. thanks Stopping processing here. Please contact me if you need assistance. -- 763320: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763320 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141203604825646.transcr...@bugs.debian.org
firmware-nonfree_0.43~bpo70+1_multi.changes is NEW
binary:firmware-samsung is NEW. Your package has been put into the NEW queue, which requires manual action from the ftpteam to process. The upload was otherwise valid (it had a good OpenPGP signature and file hashes are valid), so please be patient. Packages are routinely processed through to the archive, and do feel free to browse the NEW queue[1]. If there is an issue with the upload, you will recieve an email from a member of the ftpteam. If you have any questions, you may reply to this email. [1]: https://ftp-master.debian.org/new.html -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e1xyl9r-0006rs...@franck.debian.org
Re: [PATCH 0/5] m25p80,spi-nor: Fix module aliases for m25p80; clean up chip identification
On Sun, 2014-09-28 at 15:03 -0700, Brian Norris wrote: On Sun, Sep 14, 2014 at 06:13:15PM +0100, Ben Hutchings wrote: On Sun, 2014-09-14 at 18:10 +0100, Ben Hutchings wrote: The first patch in the series restores the module aliases to m25p80, but it does so by duplicating the list of names. This should be suitable for stable, but it isn't viable in the longer term. The following patches change the spi-nor interface so that this duplication is no longer necessary. This includes removing spi_nor::read_id, but it could be re-added after this with a different interface, e.g. returning a flash_info structure (which would need to be defined in spi_nor.h). Note that these patch are: - Based on your 'testing' branch Which testing branch? These two are the only official repos for MTD: git git://git.infradead.org/linux-mtd.git git git://git.infradead.org/l2-mtd.git You had a testing branch in git://git.infradead.org/users/norris/linux-mtd.git, and that included commit af249c3a0ca8 ('mtd: spi-nor: remove duplicated w25q128 entry') which this patch series depended on. Ben. - Untested by me, aside from compiling and checking that m25p80 has the expected module aliases Brian -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Re: [PATCH 5/5] m25p80,spi-nor: Share the list of supported chip type names again
On Wed, 2014-09-17 at 10:23 +0200, Geert Uytterhoeven wrote: Hi Ben, On Mon, Sep 15, 2014 at 5:07 PM, Ben Hutchings b...@decadent.org.uk wrote: +#define __SPI_NOR_ENUM_TYPES(c_id, str_and_c_id) \ + c_id(at25fs010) c_id(at25fs040) c_id(at25df041a) \ + c_id(at25df321a)c_id(at25df641) c_id(at26f004) \ Can't you just have the IDs in a header file only, and let the header file generate either a struct flash_info or a struct spi_device_id table, using a macro defined by the file that includes it? How would we match up the rest of the struct flash_info to the name? Ah, you use the enums to match the names to the rest of the flash_info. But you can do it in one-shot, can't you? [...] I know, but I didn't want to expose the data in a header file. As other people consider that a lesser evil than this rather complex approach, I'll do it the simple way. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On Mon, 2014-09-29 at 08:36 +0200, Rafał Miłecki wrote: On 29 September 2014 00:21, Brian Norris computersforpe...@gmail.com wrote: + Rafal Rafal has been looking at the same area of code. I'd really like to get this patch into 3.18 if possible, so the more eyes the better. Thanks Brian. I took me a while to follow this issue, too bad I wasn't subscribed to the ML earlier. Let me try to sum it up. 1) The main urgent issue: broken auto-loading Tracked in the thread: http://www.spinics.net/lists/linux-spi/msg01726.html Problem: m25p80.c references spi_nor_ids (from external file) Short-term solution: duplicate IDs in the m25p80.c Ben: just like Brian, I think the patch like this one ( [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80 ) is the way to go. However few comments: a) I don't see why you modify m25p_probe in it. Because spi_nor_scan() requires a struct spi_device_id with the driver_data field pointing to a struct flash_info. b) I don't think the described clean solution (you described it in the commit message): A clean solution to this will involve defining the list of device IDs in spi-nor.h and removing struct spi_device_id from the spi-nor API, but this is quite a large change. is the correct one. I think there should be a single string to trigger m25p80 load and the rest should be handled using JEDEC, with some workarounds for incompatible devices only. That certainly makes sense for Linux-specific platform data, but I don't think it works for Device Tree compatible strings (see http://mid.gmane.org/1410660009.3040.29.ca...@decadent.org.uk). [...] b) Removing spi_nor::read_id https://patchwork.ozlabs.org/patch/389073/ Ben: I think this one has a NACK from me, because I'm going to use custom read_id in the bcm53xxspiflash driver. See following thread for bcm53xxspiflash description: http://comments.gmane.org/gmane.linux.drivers.mtd/54578 Initial commit (it uses read_id): https://patchwork.ozlabs.org/patch/381902/ [...] But it has to use spi_nor_match_id() because of the driver_data requirement. This just illustrates that the read_id operation doesn't make sense as currently defined. I accept that there will be a need for a read_id operation, but I think it should fill in a struct flash_info rather than requiring every chip to be described and named in spi-nor.c. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
[PATCH v2 0/5] m25p80,spi-nor: Fix module aliases for m25p80; clean up chip identification
The first patch in the series restores the module aliases to m25p80, but it does so by duplicating the list of names. This should be suitable for stable, but it isn't viable in the longer term. The following patches change the spi-nor interface so that this duplication is no longer necessary. This includes removing spi_nor::read_id, but it could be re-added after this with a different interface, e.g. returning a flash_info structure (which would need to be defined in spi_nor.h). v2: Rebase onto l2-mtd/master. Put all the flash information into spi-nor.h rather than using an elaborate set of macros to validate names in spi-nor.c. These patches are still untested by me, aside from compiling and checking that m25p80 has the expected module aliases. Ben. Ben Hutchings (5): m25p80,spi-nor: Fix module aliases for m25p80 spi-nor: Remove spi_nor::read_id operation spi-nor: Make spi_nor_scan() take a chip type name, not an spi_device_id spi-nor: Replace struct spi_device_id with struct flash_info m25p80,spi-nor: Share the list of supported chip type names again drivers/mtd/devices/m25p80.c | 21 +++- drivers/mtd/spi-nor/fsl-quadspi.c | 7 +- drivers/mtd/spi-nor/spi-nor.c | 251 +++--- include/linux/mtd/spi-nor.h | 191 ++--- 4 files changed, 232 insertions(+), 238 deletions(-) -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
[PATCH v2 2/5] spi-nor: Remove spi_nor::read_id operation
There is currently no useful way to override the default implementation of this operation. The returned struct spi_device_id must have a pointer to struct flash_info in its private data, but this structure is defined inside spi-nor. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/mtd/spi-nor/spi-nor.c | 4 +--- include/linux/mtd/spi-nor.h | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 53783ed..c2f0573 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -902,8 +902,6 @@ static int spi_nor_check(struct spi_nor *nor) return -EINVAL; } - if (!nor-read_id) - nor-read_id = spi_nor_read_id; if (!nor-wait_till_ready) nor-wait_till_ready = spi_nor_wait_till_ready; @@ -929,7 +927,7 @@ int spi_nor_scan(struct spi_nor *nor, const struct spi_device_id *id, if (info-jedec_id) { const struct spi_device_id *jid; - jid = nor-read_id(nor); + jid = spi_nor_read_id(nor); if (IS_ERR(jid)) { return PTR_ERR(jid); } else if (jid != id) { diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h index 5ec84cc..66af67a 100644 --- a/include/linux/mtd/spi-nor.h +++ b/include/linux/mtd/spi-nor.h @@ -139,8 +139,6 @@ enum spi_nor_ops { * @write_xfer:[OPTIONAL] the writefundamental primitive * @read_reg: [DRIVER-SPECIFIC] read out the register * @write_reg: [DRIVER-SPECIFIC] write data to the register - * @read_id: [REPLACEABLE] read out the ID data, and find - * the proper spi_device_id * @wait_till_ready: [REPLACEABLE] wait till the NOR becomes ready * @read: [DRIVER-SPECIFIC] read data from the SPI NOR * @write: [DRIVER-SPECIFIC] write data to the SPI NOR @@ -172,7 +170,6 @@ struct spi_nor { int (*read_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len); int (*write_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len, int write_enable); - const struct spi_device_id *(*read_id)(struct spi_nor *nor); int (*wait_till_ready)(struct spi_nor *nor); int (*read)(struct spi_nor *nor, loff_t from, -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
[PATCH v2 1/5] m25p80,spi-nor: Fix module aliases for m25p80
m25p80's device ID table is now spi_nor_ids, defined in spi-nor. The MODULE_DEVICE_TABLE() macro doesn't work with extern definitions, but its use was also removed at the same time. Now if m25p80 is built as a module it doesn't get the necessary aliases to be loaded automatically. A clean solution to this will involve defining the list of device IDs in spi-nor.h and removing struct spi_device_id from the spi-nor API, but this is quite a large change. As a quick fix suitable for stable, copy the device IDs back into m25p80. Fixes: 03e296f613af (mtd: m25p80: use the SPI nor framework) Cc: stable sta...@vger.kernel.org # 3.16.x: 32f1b7c8352f: mtd: move support for struct flash_platform_data into m25p80 Cc: stable sta...@vger.kernel.org # 3.16.x Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/mtd/devices/m25p80.c | 59 --- drivers/mtd/spi-nor/spi-nor.c | 5 ++-- include/linux/mtd/spi-nor.h | 3 +-- 3 files changed, 59 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index dcda628..204bec1 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -239,8 +239,11 @@ static int m25p_probe(struct spi_device *spi) id = spi_nor_match_id(data-type); /* If we didn't get name from platform, simply use modalias. */ - if (!id) - id = spi_get_device_id(spi); + if (!id) { + id = spi_nor_match_id(spi_get_device_id(spi)-name); + if (WARN_ON(!id)) + return -ENODEV; + } ret = spi_nor_scan(nor, id, mode); if (ret) @@ -263,12 +266,62 @@ static int m25p_remove(struct spi_device *spi) } +/* + * XXX This needs to be kept in sync with spi_nor_ids. We can't share + * it with spi-nor, because if this is built as a module then modpost + * won't be able to read it and add appropriate aliases. + */ +static const struct spi_device_id m25p_ids[] = { + {at25fs010}, {at25fs040}, {at25df041a}, {at25df321a}, + {at25df641}, {at26f004}, {at26df081a}, {at26df161a}, + {at26df321}, {at45db081d}, + {en25f32},{en25p32},{en25q32b}, {en25p64}, + {en25q64},{en25qh128}, {en25qh256}, + {f25l32pa}, + {mr25h256}, {mr25h10}, + {gd25q32},{gd25q64}, + {160s33b},{320s33b},{640s33b}, + {mx25l2005a}, {mx25l4005a}, {mx25l8005}, {mx25l1606e}, + {mx25l3205d}, {mx25l3255e}, {mx25l6405d}, {mx25l12805d}, + {mx25l12855e},{mx25l25635e},{mx25l25655e},{mx66l51235l}, + {mx66l1g55g}, + {n25q064},{n25q128a11}, {n25q128a13}, {n25q256a}, + {n25q512a}, {n25q512ax3}, {n25q00}, + {pm25lv512}, {pm25lv010}, {pm25lq032}, + {s25sl032p}, {s25sl064p}, {s25fl256s0}, {s25fl256s1}, + {s25fl512s}, {s70fl01gs}, {s25sl12800}, {s25sl12801}, + {s25fl129p0}, {s25fl129p1}, {s25sl004a}, {s25sl008a}, + {s25sl016a}, {s25sl032a}, {s25sl064a}, {s25fl008k}, + {s25fl016k}, {s25fl064k}, + {sst25vf040b},{sst25vf080b},{sst25vf016b},{sst25vf032b}, + {sst25vf064c},{sst25wf512}, {sst25wf010}, {sst25wf020}, + {sst25wf040}, + {m25p05}, {m25p10}, {m25p20}, {m25p40}, + {m25p80}, {m25p16}, {m25p32}, {m25p64}, + {m25p128},{n25q032}, + {m25p05-nonjedec},{m25p10-nonjedec},{m25p20-nonjedec}, + {m25p40-nonjedec},{m25p80-nonjedec},{m25p16-nonjedec}, + {m25p32-nonjedec},{m25p64-nonjedec},{m25p128-nonjedec}, + {m45pe10},{m45pe80},{m45pe16}, + {m25pe20},{m25pe80},{m25pe16}, + {m25px16},{m25px32},{m25px32-s0}, {m25px32-s1}, + {m25px64}, + {w25x10}, {w25x20}, {w25x40}, {w25x80}, + {w25x16}, {w25x32}, {w25q32}, {w25q32dw}, + {w25x64}, {w25q64}, {w25q128},{w25q80}, + {w25q80bl}, {w25q128},{w25q256},{cat25c11}, + {cat25c03}, {cat25c09}, {cat25c17}, {cat25128}, + { }, +}; +MODULE_DEVICE_TABLE(spi, m25p_ids); + + static struct spi_driver m25p80_driver = { .driver = { .name = m25p80, .owner = THIS_MODULE, }, - .id_table = spi_nor_ids, + .id_table = m25p_ids, .probe = m25p_probe, .remove = m25p_remove, diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index ae16aa2..53783ed 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -473,7 +473,7 @@ struct flash_info { * more nor chips. This current list focusses on newer chips, which * have been converging on command sets which including JEDEC ID. */ -const struct spi_device_id spi_nor_ids[] = { +static const struct spi_device_id spi_nor_ids[] = { /* Atmel -- some are (confusingly) marketed as DataFlash */ { at25fs010, INFO(0x1f6601, 0,
[PATCH v2 3/5] spi-nor: Make spi_nor_scan() take a chip type name, not an spi_device_id
Drivers currently call spi_nor_match_id() and then spi_nor_scan(). This adds a dependency on struct spi_device_id which we want to avoid. Make spi_nor_scan() do it for them. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/mtd/devices/m25p80.c | 13 + drivers/mtd/spi-nor/fsl-quadspi.c | 7 +-- drivers/mtd/spi-nor/spi-nor.c | 13 + include/linux/mtd/spi-nor.h | 20 ++-- 4 files changed, 17 insertions(+), 36 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 204bec1..d9578b9 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -193,7 +193,7 @@ static int m25p_probe(struct spi_device *spi) { struct mtd_part_parser_data ppdata; struct flash_platform_data *data; - const struct spi_device_id *id = NULL; + const char *name = NULL; struct m25p *flash; struct spi_nor *nor; enum read_mode mode = SPI_NOR_NORMAL; @@ -236,16 +236,13 @@ static int m25p_probe(struct spi_device *spi) * If that's the case, respect type and ignore a name. */ if (data data-type) - id = spi_nor_match_id(data-type); + name = data-type; /* If we didn't get name from platform, simply use modalias. */ - if (!id) { - id = spi_nor_match_id(spi_get_device_id(spi)-name); - if (WARN_ON(!id)) - return -ENODEV; - } + if (!name) + name = spi_get_device_id(spi)-name; - ret = spi_nor_scan(nor, id, mode); + ret = spi_nor_scan(nor, name, mode); if (ret) return ret; diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index 8d659a2..d5269a2 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -881,7 +881,6 @@ static int fsl_qspi_probe(struct platform_device *pdev) /* iterate the subnodes. */ for_each_available_child_of_node(dev-of_node, np) { - const struct spi_device_id *id; char modalias[40]; /* skip the holes */ @@ -909,10 +908,6 @@ static int fsl_qspi_probe(struct platform_device *pdev) if (of_modalias_node(np, modalias, sizeof(modalias)) 0) goto map_failed; - id = spi_nor_match_id(modalias); - if (!id) - goto map_failed; - ret = of_property_read_u32(np, spi-max-frequency, q-clk_rate); if (ret 0) @@ -921,7 +916,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) /* set the chip address for READID */ fsl_qspi_set_base_addr(q, nor); - ret = spi_nor_scan(nor, id, SPI_NOR_QUAD); + ret = spi_nor_scan(nor, modalias, SPI_NOR_QUAD); if (ret) goto map_failed; diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index c2f0573..171c665 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -28,6 +28,8 @@ #define JEDEC_MFR(_jedec_id) ((_jedec_id) 16) +static const struct spi_device_id *spi_nor_match_id(const char *name); + /* * Read the status register, returning its value in the location * Return the status register value. @@ -908,9 +910,9 @@ static int spi_nor_check(struct spi_nor *nor) return 0; } -int spi_nor_scan(struct spi_nor *nor, const struct spi_device_id *id, - enum read_mode mode) +int spi_nor_scan(struct spi_nor *nor, const char *name, enum read_mode mode) { + const struct spi_device_id *id = NULL; struct flash_info *info; struct device *dev = nor-dev; struct mtd_info *mtd = nor-mtd; @@ -922,6 +924,10 @@ int spi_nor_scan(struct spi_nor *nor, const struct spi_device_id *id, if (ret) return ret; + id = spi_nor_match_id(name); + if (!id) + return -ENODEV; + info = (void *)id-driver_data; if (info-jedec_id) { @@ -1110,7 +1116,7 @@ int spi_nor_scan(struct spi_nor *nor, const struct spi_device_id *id, } EXPORT_SYMBOL_GPL(spi_nor_scan); -const struct spi_device_id *spi_nor_match_id(const char *name) +static const struct spi_device_id *spi_nor_match_id(const char *name) { const struct spi_device_id *id = spi_nor_ids; @@ -1121,7 +1127,6 @@ const struct spi_device_id *spi_nor_match_id(const char *name) } return NULL; } -EXPORT_SYMBOL_GPL(spi_nor_match_id); MODULE_LICENSE(GPL); MODULE_AUTHOR(Huang Shijie shij...@gmail.com); diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h index 66af67a..c48ad49 100644 --- a/include/linux/mtd/spi-nor.h +++ b/include/linux/mtd/spi-nor.h @@ -184,31 +184,15 @@ struct spi_nor {
[PATCH v2 4/5] spi-nor: Replace struct spi_device_id with struct flash_info
spi-nor does not depend on the SPI layer, so its use of struct spi_device_id adds an unnecessary indirection. Add the chip type name to struct flash_info and remove the wrapping struct spi_device_id. It also doesn't need a terminating zero entry in the array any more, so remove that. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/mtd/devices/m25p80.c | 2 +- drivers/mtd/spi-nor/spi-nor.c | 340 +- 2 files changed, 170 insertions(+), 172 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index d9578b9..79bc27a 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -264,7 +264,7 @@ static int m25p_remove(struct spi_device *spi) /* - * XXX This needs to be kept in sync with spi_nor_ids. We can't share + * XXX This needs to be kept in sync with spi_nor_info. We can't share * it with spi-nor, because if this is built as a module then modpost * won't be able to read it and add appropriate aliases. */ diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 171c665..2449ee5 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -28,8 +28,6 @@ #define JEDEC_MFR(_jedec_id) ((_jedec_id) 16) -static const struct spi_device_id *spi_nor_match_id(const char *name); - /* * Read the status register, returning its value in the location * Return the status register value. @@ -425,6 +423,8 @@ err: } struct flash_info { + const char name[SPI_NAME_SIZE]; + /* JEDEC id zero means no ID (most older chips); otherwise it has * a high byte of zero plus three data bytes: the manufacturer id, * then a two byte device id. @@ -452,201 +452,215 @@ struct flash_info { #defineUSE_FSR 0x80/* use flag status register */ }; -#define INFO(_jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \ - ((kernel_ulong_t)(struct flash_info) { \ +#define INFO(_name, _jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \ + { \ + .name = (_name),\ .jedec_id = (_jedec_id),\ .ext_id = (_ext_id),\ .sector_size = (_sector_size), \ .n_sectors = (_n_sectors), \ .page_size = 256, \ .flags = (_flags), \ - }) + } -#define CAT25_INFO(_sector_size, _n_sectors, _page_size, _addr_width, _flags) \ - ((kernel_ulong_t)(struct flash_info) { \ +#define CAT25_INFO(_name, _sector_size, _n_sectors, _page_size, \ + _addr_width, _flags) \ + { \ + .name = (_name),\ .sector_size = (_sector_size), \ .n_sectors = (_n_sectors), \ .page_size = (_page_size), \ .addr_width = (_addr_width),\ .flags = (_flags), \ - }) + } /* NOTE: double check command sets and memory organization when you add * more nor chips. This current list focusses on newer chips, which * have been converging on command sets which including JEDEC ID. */ -static const struct spi_device_id spi_nor_ids[] = { +static const struct flash_info spi_nor_info[] = { /* Atmel -- some are (confusingly) marketed as DataFlash */ - { at25fs010, INFO(0x1f6601, 0, 32 * 1024, 4, SECT_4K) }, - { at25fs040, INFO(0x1f6604, 0, 64 * 1024, 8, SECT_4K) }, + INFO(at25fs010, 0x1f6601, 0, 32 * 1024, 4, SECT_4K), + INFO(at25fs040, 0x1f6604, 0, 64 * 1024, 8, SECT_4K), - { at25df041a, INFO(0x1f4401, 0, 64 * 1024, 8, SECT_4K) }, - { at25df321a, INFO(0x1f4701, 0, 64 * 1024, 64, SECT_4K) }, - { at25df641, INFO(0x1f4800, 0, 64 * 1024, 128, SECT_4K) }, + INFO(at25df041a, 0x1f4401, 0, 64 * 1024, 8, SECT_4K), + INFO(at25df321a, 0x1f4701, 0, 64 * 1024, 64, SECT_4K), + INFO(at25df641, 0x1f4800, 0, 64 * 1024, 128, SECT_4K), - { at26f004, INFO(0x1f0400, 0, 64 * 1024, 8, SECT_4K) }, - { at26df081a, INFO(0x1f4501, 0, 64 * 1024, 16, SECT_4K) }, - { at26df161a, INFO(0x1f4601, 0, 64 * 1024, 32, SECT_4K) }, - { at26df321, INFO(0x1f4700, 0, 64 * 1024, 64, SECT_4K) }, + INFO(at26f004, 0x1f0400, 0, 64 * 1024, 8, SECT_4K), + INFO(at26df081a, 0x1f4501,
[PATCH v2 5/5] m25p80,spi-nor: Share the list of supported chip type names again
Move the list of chip type information to a macro in spi-nor.h, but leave the definitions of INFO and CAT25_INFO in spi-nor. In m25p80, define the INFO and CAT25_INFO macros to initialise a struct spi_device_id with the name, ignoring the remaining parameters. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/mtd/devices/m25p80.c | 47 +--- drivers/mtd/spi-nor/spi-nor.c | 165 +--- include/linux/mtd/spi-nor.h | 173 ++ 3 files changed, 177 insertions(+), 208 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 79bc27a..d13ac07 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -263,51 +263,10 @@ static int m25p_remove(struct spi_device *spi) } -/* - * XXX This needs to be kept in sync with spi_nor_info. We can't share - * it with spi-nor, because if this is built as a module then modpost - * won't be able to read it and add appropriate aliases. - */ static const struct spi_device_id m25p_ids[] = { - {at25fs010}, {at25fs040}, {at25df041a}, {at25df321a}, - {at25df641}, {at26f004}, {at26df081a}, {at26df161a}, - {at26df321}, {at45db081d}, - {en25f32},{en25p32},{en25q32b}, {en25p64}, - {en25q64},{en25qh128}, {en25qh256}, - {f25l32pa}, - {mr25h256}, {mr25h10}, - {gd25q32},{gd25q64}, - {160s33b},{320s33b},{640s33b}, - {mx25l2005a}, {mx25l4005a}, {mx25l8005}, {mx25l1606e}, - {mx25l3205d}, {mx25l3255e}, {mx25l6405d}, {mx25l12805d}, - {mx25l12855e},{mx25l25635e},{mx25l25655e},{mx66l51235l}, - {mx66l1g55g}, - {n25q064},{n25q128a11}, {n25q128a13}, {n25q256a}, - {n25q512a}, {n25q512ax3}, {n25q00}, - {pm25lv512}, {pm25lv010}, {pm25lq032}, - {s25sl032p}, {s25sl064p}, {s25fl256s0}, {s25fl256s1}, - {s25fl512s}, {s70fl01gs}, {s25sl12800}, {s25sl12801}, - {s25fl129p0}, {s25fl129p1}, {s25sl004a}, {s25sl008a}, - {s25sl016a}, {s25sl032a}, {s25sl064a}, {s25fl008k}, - {s25fl016k}, {s25fl064k}, - {sst25vf040b},{sst25vf080b},{sst25vf016b},{sst25vf032b}, - {sst25vf064c},{sst25wf512}, {sst25wf010}, {sst25wf020}, - {sst25wf040}, - {m25p05}, {m25p10}, {m25p20}, {m25p40}, - {m25p80}, {m25p16}, {m25p32}, {m25p64}, - {m25p128},{n25q032}, - {m25p05-nonjedec},{m25p10-nonjedec},{m25p20-nonjedec}, - {m25p40-nonjedec},{m25p80-nonjedec},{m25p16-nonjedec}, - {m25p32-nonjedec},{m25p64-nonjedec},{m25p128-nonjedec}, - {m45pe10},{m45pe80},{m45pe16}, - {m25pe20},{m25pe80},{m25pe16}, - {m25px16},{m25px32},{m25px32-s0}, {m25px32-s1}, - {m25px64}, - {w25x10}, {w25x20}, {w25x40}, {w25x80}, - {w25x16}, {w25x32}, {w25q32}, {w25q32dw}, - {w25x64}, {w25q64}, {w25q128},{w25q80}, - {w25q80bl}, {w25q128},{w25q256},{cat25c11}, - {cat25c03}, {cat25c09}, {cat25c17}, {cat25128}, +#define INFO(name, ...) { name } +#define CAT25_INFO(name, ...) { name } + SPI_NOR_INFO { }, }; MODULE_DEVICE_TABLE(spi, m25p_ids); diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 2449ee5..d98c6e0 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -474,171 +474,8 @@ struct flash_info { .flags = (_flags), \ } -/* NOTE: double check command sets and memory organization when you add - * more nor chips. This current list focusses on newer chips, which - * have been converging on command sets which including JEDEC ID. - */ static const struct flash_info spi_nor_info[] = { - /* Atmel -- some are (confusingly) marketed as DataFlash */ - INFO(at25fs010, 0x1f6601, 0, 32 * 1024, 4, SECT_4K), - INFO(at25fs040, 0x1f6604, 0, 64 * 1024, 8, SECT_4K), - - INFO(at25df041a, 0x1f4401, 0, 64 * 1024, 8, SECT_4K), - INFO(at25df321a, 0x1f4701, 0, 64 * 1024, 64, SECT_4K), - INFO(at25df641, 0x1f4800, 0, 64 * 1024, 128, SECT_4K), - - INFO(at26f004, 0x1f0400, 0, 64 * 1024, 8, SECT_4K), - INFO(at26df081a, 0x1f4501, 0, 64 * 1024, 16, SECT_4K), - INFO(at26df161a, 0x1f4601, 0, 64 * 1024, 32, SECT_4K), - INFO(at26df321, 0x1f4700, 0, 64 * 1024, 64, SECT_4K), - - INFO(at45db081d, 0x1f2500, 0, 64 * 1024, 16, SECT_4K), - - /* EON -- en25xxx */ - INFO(en25f32,0x1c3116, 0, 64 * 1024, 64, SECT_4K), - INFO(en25p32,0x1c2016, 0, 64 * 1024, 64, 0), - INFO(en25q32b, 0x1c3016, 0, 64 * 1024, 64, 0), - INFO(en25p64,0x1c2017, 0, 64 * 1024, 128, 0), - INFO(en25q64,0x1c3017, 0, 64 * 1024, 128, SECT_4K), - INFO(en25qh128, 0x1c7018, 0, 64 * 1024, 256, 0), -
Re: Firmware-nonfree in wheezy-backports
On Tue, 2014-08-19 at 11:20 +0300, Touko Korpela wrote: On Sat, Aug 02, 2014 at 09:11:02PM +0300, Touko Korpela wrote: Could you update wheezy backports version of firmware-nonfree too (now at version 0.41 while jessie/sid has 0.43)? bpo version is still 0.41 I uploaded a new version a few hours ago, but it is in the NEW queue as it adds a new binary package. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Bug#704836: efivars should be included in initramfs
Control: reassign -1 partman-md On Sat, 06 Apr 2013 16:06:04 +0100 Ben Hutchings b...@decadent.org.uk wrote: clone 704779 -1 retitle -1 efivars should be included in initramfs reassign -1 initramfs-tools 0.109 thanks Actually, I think it makes more sense to do this in partman-md (or possibly mdadm's initramfs hook) rather than always including efivars. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity. signature.asc Description: This is a digitally signed message part
Processed: Re: efivars should be included in initramfs
Processing control commands: reassign -1 partman-md Bug #704836 [initramfs-tools] efivars should be included in initramfs Bug reassigned from package 'initramfs-tools' to 'partman-md'. No longer marked as found in versions initramfs-tools/0.109. Ignoring request to alter fixed versions of bug #704836 to the same values previously set -- 704836: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704836 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b704836.14120450359305.transcr...@bugs.debian.org
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On Tue, Sep 30, 2014 at 03:07:38AM +0100, Ben Hutchings wrote: On Mon, 2014-09-29 at 08:36 +0200, Rafał Miłecki wrote: b) I don't think the described clean solution (you described it in the commit message): A clean solution to this will involve defining the list of device IDs in spi-nor.h and removing struct spi_device_id from the spi-nor API, but this is quite a large change. is the correct one. I think there should be a single string to trigger m25p80 load and the rest should be handled using JEDEC, with some workarounds for incompatible devices only. That certainly makes sense for Linux-specific platform data, but I don't think it works for Device Tree compatible strings (see http://mid.gmane.org/1410660009.3040.29.ca...@decadent.org.uk). I think it might work. Your quote from that thread: I think that a DT node is always supposed to include a compatible string for the specific device. It could also include a generic compatible string for SPI NOR chips, but the *only* thing a driver can do with that is to use the JEDEC ID command. It can't even generically read a single byte, since addresses may be either 3 or 4 bytes long! So I think that if a generic compatible string is defined, the DT binding must also define the properties that spi-nor currently reads out of its static table. For every current entry (except the *-nonjedec entries; I don't think we should be supporting any more entries like this, and I'd like to kill the existing ones if possible), we can do just that; read out the JEDEC ID and go from there. (Rafal is also looking at non-JEDEC RDID commands, but that would just require a different type of binding.) In fact, for most of these entries, we'll read out the ID and override the match provided by the driver anyway. See: int spi_nor_scan(...) { ... [Note: almost all 'info' entries provide a non-zero jedec_id field] if (info-jedec_id) { const struct spi_device_id *jid; jid = nor-read_id(nor); if (IS_ERR(jid)) { return PTR_ERR(jid); } else if (jid != id) { /* * JEDEC knows better, so overwrite platform ID. We * can't trust partitions any longer, but we'll let * mtd apply them anyway, since some partitions may be * marked read-only, and we don't want to lose that * information, even if it's not 100% accurate. */ dev_warn(dev, found %s, expected %s\n, jid-name, id-name); id = jid; info = (void *)jid-driver_data; } } ... } I think this chunk might be reworked (or at least, modify the comments) to note how we primarily expect to override the input ID. We might even drop the dev_warn() eventually, and make it more informative instead. [...] b) Removing spi_nor::read_id https://patchwork.ozlabs.org/patch/389073/ Ben: I think this one has a NACK from me, because I'm going to use custom read_id in the bcm53xxspiflash driver. See following thread for bcm53xxspiflash description: http://comments.gmane.org/gmane.linux.drivers.mtd/54578 Initial commit (it uses read_id): https://patchwork.ozlabs.org/patch/381902/ [...] But it has to use spi_nor_match_id() because of the driver_data requirement. This just illustrates that the read_id operation doesn't make sense as currently defined. Right. I think it may turn out better to drop it and force a redesign for the next user. I accept that there will be a need for a read_id operation, but I think it should fill in a struct flash_info rather than requiring every chip to be described and named in spi-nor.c. Maybe struct flash_info, but this still leaks more spi-nor.c internal info into drivers. Perhaps Rafal's use case could be served by a select-able 'READ ID' opcode, with his flash_info structs still stored in spi_nor_ids[] -- or possibly as a separate ID table within spi-nor.c. But either way, I agree the current read_id() hook is not satisfactory. Brian -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140930035558.GA8687@brian-ubuntu
Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
On 30 September 2014 04:07, Ben Hutchings b...@decadent.org.uk wrote: On Mon, 2014-09-29 at 08:36 +0200, Rafał Miłecki wrote: On 29 September 2014 00:21, Brian Norris computersforpe...@gmail.com wrote: + Rafal Rafal has been looking at the same area of code. I'd really like to get this patch into 3.18 if possible, so the more eyes the better. Thanks Brian. I took me a while to follow this issue, too bad I wasn't subscribed to the ML earlier. Let me try to sum it up. 1) The main urgent issue: broken auto-loading Tracked in the thread: http://www.spinics.net/lists/linux-spi/msg01726.html Problem: m25p80.c references spi_nor_ids (from external file) Short-term solution: duplicate IDs in the m25p80.c Ben: just like Brian, I think the patch like this one ( [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80 ) is the way to go. However few comments: a) I don't see why you modify m25p_probe in it. Because spi_nor_scan() requires a struct spi_device_id with the driver_data field pointing to a struct flash_info. More friendly explanation: because spi_get_device_id uses driver's id_table (that was now changes to pure strings). I see the point. b) I don't think the described clean solution (you described it in the commit message): A clean solution to this will involve defining the list of device IDs in spi-nor.h and removing struct spi_device_id from the spi-nor API, but this is quite a large change. is the correct one. I think there should be a single string to trigger m25p80 load and the rest should be handled using JEDEC, with some workarounds for incompatible devices only. That certainly makes sense for Linux-specific platform data, but I don't think it works for Device Tree compatible strings (see http://mid.gmane.org/1410660009.3040.29.ca...@decadent.org.uk). We could simply follow the way Linux-specific platform data works. We could always use compatible = m25p80; and then for some rare cases (where JEDEC fails) add something like model = at25df321a; b) Removing spi_nor::read_id https://patchwork.ozlabs.org/patch/389073/ Ben: I think this one has a NACK from me, because I'm going to use custom read_id in the bcm53xxspiflash driver. See following thread for bcm53xxspiflash description: http://comments.gmane.org/gmane.linux.drivers.mtd/54578 Initial commit (it uses read_id): https://patchwork.ozlabs.org/patch/381902/ [...] But it has to use spi_nor_match_id() because of the driver_data requirement. This just illustrates that the read_id operation doesn't make sense as currently defined. I agree, however there is already a patch in progress handling that: https://patchwork.ozlabs.org/patch/377917/ I accept that there will be a need for a read_id operation, but I think it should fill in a struct flash_info rather than requiring every chip to be described and named in spi-nor.c. Flashes not supporting JEDEC are usually some weird versions of normal flashes with JEDEC support. So I think we could still have them in the spi-nor database and let users provide the name instead of filling the whole struct flash_info. -- Rafał -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CACna6rxBFNvF5bouv9KkS-3=txcxvmrs30kmts0mcjdava4...@mail.gmail.com
Re: [PATCH v2 3/5] spi-nor: Make spi_nor_scan() take a chip type name, not an spi_device_id
On 30 September 2014 04:15, Ben Hutchings b...@decadent.org.uk wrote: @@ -236,16 +236,13 @@ static int m25p_probe(struct spi_device *spi) * If that's the case, respect type and ignore a name. */ if (data data-type) - id = spi_nor_match_id(data-type); + name = data-type; /* If we didn't get name from platform, simply use modalias. */ - if (!id) { - id = spi_nor_match_id(spi_get_device_id(spi)-name); - if (WARN_ON(!id)) - return -ENODEV; - } + if (!name) + name = spi_get_device_id(spi)-name; Huh? Iterating the whole id_table, checking the entries (looking for one with name equal to the spi-modalias) and then... getting that name? Did it hurt to use the patch I've sent mtd: m25p80: get rid of spi_get_device_id https://patchwork.ozlabs.org/patch/394328/ -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cacna6rynp7+4y7oss60atdzhuwfhiayv4oq5eli1gyen45z...@mail.gmail.com
Re: Uploading linux (3.2.63-1)
On Mon, 2014-09-29 at 23:24 +0100, Ben Hutchings wrote: On Mon, 2014-09-29 at 19:29 +0100, Adam D. Barratt wrote: On Sun, 2014-09-28 at 18:42 +0100, Adam D. Barratt wrote: On Wed, 2014-09-24 at 03:54 +0100, Ben Hutchings wrote: I intend to upload linux version 3.2.63-1 to stable-proposed-updates later this week. This will include all the fixes that went into stable updates 3.2.61-63 inclusive, including fixes for these security issues: [...] Flagged for acceptance in to p-u; thanks. and built everywhere except s390{,x}, where it failed with an ABI change. We can ignore that change, but I forgot to do that. (We had the same build failure in 3.14.10-1.) I've flagged 3.2.63-2, including the fix, for acceptance; thanks for the quick turn-around. Regards, Adam -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1412055407.25283.19.ca...@jacala.jungle.funky-badger.org